Hi Azuma-san, I'm very sorry I haven't had a chance to review your Perfmon/Cell patches previously. I've been pretty busy this summer with Cell SDK 3.0 work. But that has finished up this week, so I've had a chance to review these patches a bit.
I'll send comments on the patches in separate replies. On Thu August 30 2007 6:00 am, takaki.azuma wrote: > This patch directly accesses the MMIO registers and sets PM signal groups > for Cell platform. > > My previous patch was modified to correspond to git-tree. > In addition, I changed some coding style and error processing etc. > (no functional change) > > However, "PPE signal group" is included only this time. > > I posted the patch to cbe_regs.[ch] (as 3of3). > However, the patch is posted to PPC/Cell kernel now. I saw your posting on cbe-oss-dev, so I'll comment on that patch on that mailing list. Also, it looks different than the previous version you posted on this mailing list, so you'll probably want to send Stephane a copy (if you haven't already) so he has the correct version in his tree until it shows up in mainline. Thanks, -- Kevin Corry [EMAIL PROTECTED] http://www.ibm.com/linux/ _______________________________________________ perfmon mailing list [email protected] http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/
