Hi Azuma-san,

On Thu August 30 2007 9:17 am, Kevin Corry wrote:
> On Thu August 30 2007 6:21 am, takaki.azuma wrote:
> > It is a main body of pfm_cell_reset_signals() and
> > pfm_cell_activate_signals(). (in the new file: perfmon_cell_signals.c)
> > Moreover, this patch includes pfm_cell_pmc_check() too.
> >
> > -- Takaki Azuma
> >
> > Signed-off-by: Takaki Azuma <[EMAIL PROTECTED]>
> > Signed-off-by: Takayuki Uchikawa <[EMAIL PROTECTED]>
> >
> > Index: linux-2.6/arch/powerpc/perfmon/perfmon_cell_signals.c
> > ===================================================================
> > --- linux-2.6.git/arch/powerpc/perfmon/perfmon_cell_signals.c
> > +++ linux-2.6/arch/powerpc/perfmon/perfmon_cell_signals.c
> > @@ -0,0 +1,270 @@

> > +#define    HID1_RESET_MASK                 (~0x00000001fffffffful)
> > +#define    PPU_IU1_WORD0_HID1_EN_MASK      (~0x00000001f0c0802cul)
> > +#define    PPU_IU1_WORD0_HID1_EN_WORD      ( 0x00000001f0400000ul)
> > +#define    PPU_IU1_WORD1_HID1_EN_MASK      (~0x000000010fc08023ul)
> > +#define    PPU_IU1_WORD1_HID1_EN_WORD      ( 0x000000010f400001ul)
> > +#define    PPU_XU_WORD0_HID1_EN_MASK       (~0x00000001f038402cul)
> > +#define    PPU_XU_WORD0_HID1_EN_WORD       ( 0x00000001f0080008ul)
> > +#define    PPU_XU_WORD1_HID1_EN_MASK       (~0x000000010f074023ul)
> > +#define    PPU_XU_WORD1_HID1_EN_WORD       ( 0x000000010f030008ul)

While testing your patch, I noticed that this last #define is incorrect. The 
correct value for PPU_XU_WORD1_HID1_EN_WORD should be 0x000000010f030002ul 
(change the last 8 to a 2).

Thanks,
-- 
Kevin Corry
[EMAIL PROTECTED]
http://www.ibm.com/linux/
_______________________________________________
perfmon mailing list
[email protected]
http://www.hpl.hp.com/hosted/linux/mail-archives/perfmon/

Reply via email to