thanks! Do you want to work on a CL?
On 18 April 2018 at 00:10, tilman.dilo <[email protected]> wrote: > Sort of works, until it hangs forever while running genfileembed in > make.go:genEmbeds(). As parseGenEmbedOutputLines() was removed and > cmd.StderrPipe()'s return value is discarded, stderr of the genfileembed > process is not drained. Looks like no or little buffering takes place on > Windows, causing the process to hang and never return. > > According to https://golang.org/pkg/os/exec/#Cmd.StderrPipe it is incorrect > to call cmd.Wait() before reading all output. Removing the cmd.StderrPipe() > call and setting cmd.Stderr = os.Stderr is noisy but lets the build complete. > Maybe it would be best to do that and remove the "-output-files-stderr" flag > from genfileembed? > > I also ran devcam test for completeness but there were lots of errors > presumably not related to the recent changes (symlinks and such). Starting > devcam server worked. > > Tilman > > -- > You received this message because you are subscribed to the Google Groups > "Perkeep" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups "Perkeep" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
