On 31 Dec 2003, at 21:45, D.Kreft wrote:
On Wed, 31 Dec 2003, Chris Ridd did scribble:

There's at least one way where these methods return a non-object. Mostly
they call _error() to set an error code in a message object, but this isn't
always true - if $ldap->socket fails the integer LDAP_SERVER_DOWN is
returned (NB this is 81, so seems to be what you're getting)


This is probably not right, as it is inconsistent.

I would agree. The inconsistency is made even more odious by a lack of documentation indicating the potential for non-object return values.

Yes.


I suspect the socket failure case in _sendmesg() should be something like:

    my $socket = $ldap->socket
        or return _error($ldap, $mesg, LDAP_SERVER_DOWN, "$!");

*nod* Any chance someone can make this happen? :-)

It is in 0.31 just released to CPAN and sourceforge


Graham.



Reply via email to