-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Apr 8, 2008, at 7:32 PM, Phil Pennock wrote:
On 2008-04-08 at 09:46 -0500, Graham Barr wrote:
This patch no longer applies clean against the repository due to
ongoing
work.
The SVN repository can be found at
http://svn.goingon.net/repos/Authen-SASL/trunk
I was rather surprised to read this, since I'm not submitting a
feature
request; it's a security issue and normally, given a patch against the
latest released version, the people most familiar with the code should
port it forward, if going to merge security fixes with normal devel
work
instead of branching a pure security-fix.
My view is the opposite. the person most familiar with the fix is the
best person not to "break it", especially in the absence of test
Nonetheless, I set aside some time to redo the patch; first step,
build
the module before making any changes, to be sure that I have a clean
slate. Unfortunately, it fails to even configure for the platform.
Please first specify a required perl version, like this:
requires( perl => '5.005' );
Ack, another module caught by a change in Module::Install. I have
checked in a fix
Please also create a testcase which fails and shows the problem on
the
version you have so we can verify that new code has fixed it.
Attached, derived from existing DIGEST-MD5; my test user doesn't have
authorization rights and it'd be too much hassle to set up such a
privileged account, so this can just be a second t/ file. Test data
derived from Cyrus IMAP's MANAGESIEVE service (timsieved); server
behaviour confirmed against Isode's M-Box SIEVED server. Test program
used to obtain the data (with the help of a CNONCE hack) is
'sieve-connect', obtainable from:
http://people.spodhuis.org/phil.pennock/software/
Thanks, I added that to the repository too.
Graham.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
iD8DBQFH/BGSR0BL4gbYw3QRAnbvAJ9q8ALkbib59xP1dpBipjfd2awIlQCfTt+u
BrX0daJYtjGa7v97lHBctHE=
=uDJV
-----END PGP SIGNATURE-----
