Good to hear, and it is good a thing your patch finaly made it so we can smoke with MinGW-2.0 "out of the box" (I shall continue to do so). I am interested to see the results for BCC (Yves is now smoking MSVC7 I think, so Win32 should be pretty well covered)
After some tests with Borland:
An extra line in smoke.mk in CFG_VARS is created empty.
Something like:

CFG_VARS = \
~ \
osvers=4.0NTSP5 ~ \
config_args=-Dusedevel ~ \
....
Line with only "~ \" will later cause trouble when created config.h
(config.h created don't have:
#define USEPERLIO /**/
But
# USEPERLIO /**/
)

Then compiler will stop at first include of config.h with "bad macro".
Attached patch for correct this and smoke on borland.

Regards,
--
Alain BARBET
--- /usr/local/workplace/perl/Test-Smoke-1.16/mktest.pl Sun Sep 29 20:50:07 2002
+++ /home/alian/soft/mktest.pl  Thu Oct 24 19:20:54 2002
@@ -589,7 +589,9 @@
         if ( $donot_change ) {
             if (m/^\s*CFG_VARS\s*=/) {
                 my $extra_char = $win32_maker =~ /\bnmake\b/ ? "\t" : "~";
-                $_ .= join "", map "\t\t$_\t${extra_char}\t\\\n", @ARGV;
+                   my @l;
+                   foreach (@ARGV) { push(@l,$_) if ($_!~/^[\t\s]*$/); }
+                $_ .= join "", map "\t\t$_\t${extra_char}\t\\\n", @l;
             }
             print NEW $_;
             next;


Reply via email to