On 30/07/07, Robert May <[EMAIL PROTECTED]> wrote: > Attached is a patch to win32.c (against AS build 819). It implements > most of what I've talked about, plus a few other bits.
It fails 2 of the fork() tests on bleed, and one under AS build 819. > A lot of the complexity of the context passing could be removed if we > were to agree to take the hit of doing a dTHX; in > win32_process_message. We don't go in there very often (only for > alarms, kills and forks (and thread creation?). Perhaps the overhead > is worth the reduction in complexity? On investigation it turns out that the dTHX; I was doing in win32_create_message_window() gives the context of the "parent" thread when forking. There are 2 ways to solve this - always pass the context into win32_create_message_window(), or do a dTHX; in win32_process_message. I've opted for the latter, as it simplifies the code a lot. We can always change this later. I'll post another version as soon as I've shown that it tests clean (hopefully tomorrow). > Still TODO: > - I'd like to see us using registered messages rather than WM_USER_* > macros. This would avoid us ever clashing with someone else's message > numbers (this is only a potential problem for thread messages, not > when we have a message window) Regards, Rob. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Perl-Win32-GUI-Users mailing list Perl-Win32-GUI-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perl-win32-gui-users http://perl-win32-gui.sourceforge.net/
