On 31/07/07, Robert May <[EMAIL PROTECTED]> wrote: > I'll post another version as soon as I've shown that it tests clean > (hopefully tomorrow).
Attached patches implement the same functionality against AS build 819 and, probably more importantly, perl 9.5.9. Tests run without failures (well, the same failures as I get without the patch - see below). Jan - Would you like to comment on whether you think this is suitable? If so I'll take it to P5P, if not I'll only propose the simple change to the QS_ flags. I'd like to see something like this go in, as it'll make future development for Win32::GUI a whole load more robust. > > Still TODO/to think about: > > - I'd like to see us using registered messages rather than WM_USER_* > > macros. This would avoid us ever clashing with someone else's message > > numbers (this is only a potential problem for thread messages, not > > when we have a message window) Because we sometimes use thread messages, I think there should be better bounds checking within the handlers in win32_process_message(). For example we treat *any* message with value WM_USER_MESSAGE as ours, and blindly use the wParam value as an offset into the w32_pseudo_child_message_hwnds[] array. If someone else happened to pick this same message number for a thread message, and had a large number in wParam (a window handle for example), we'd end up trying to write beyond the end of the array. This might be the driver for me to implement the registered window messages, which would solve the problem. Regards, Rob. All test runs on win2000, showing results without and with the attached patches. (1) AS Build 819 Win2k: Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- ../ext/IO/t/io_dup.t 6 4 66.67% 2-5 comp/multiline.t 6 2 33.33% 5-6 io/dup.t 26 6 23.08% 2-7 51 tests and 315 subtests skipped. Failed 3/997 test scripts, 99.70% okay. 12/118111 subtests failed, 99.99% okay. (2) AS Build 819 Win2k with patched win32.c Failed Test Stat Wstat Total Fail Failed List of Failed ------------------------------------------------------------------------------- ../ext/IO/t/io_dup.t 6 4 66.67% 2-5 comp/multiline.t 6 2 33.33% 5-6 io/dup.t 26 6 23.08% 2-7 51 tests and 315 subtests skipped. Failed 3/997 test scripts, 99.70% okay. 12/118111 subtests failed, 99.99% okay. (3) 5.9.5 Win2k: Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- ../ext/IO/t/io_dup.t 6 4 2-5 ../lib/Archive/Extract/t/01_Archive-Extra 255 65280 39 2 37 39 comp/multiline.t 6 2 5-6 io/dup.t 29 6 2-7 (1 subtest UNEXPECTEDLY SUCCEEDED), 55 tests and 728 subtests skipped. Failed 4/1457 test scripts. 14/183750 subtests failed. Files=1457, Tests=183750, 1022 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU) Failed 4/1457 test programs. 14/183750 subtests failed. (4) 5.9.5 Win2k: Failed Test Stat Wstat Total Fail List of Failed ------------------------------------------------------------------------------- ../ext/IO/t/io_dup.t 6 4 2-5 ../lib/Archive/Extract/t/01_Archive-Extra 255 65280 39 2 37 39 comp/multiline.t 6 2 5-6 io/dup.t 29 6 2-7 (1 subtest UNEXPECTEDLY SUCCEEDED), 55 tests and 728 subtests skipped. Failed 4/1457 test scripts. 14/183750 subtests failed. Files=1457, Tests=183750, 987 wallclock secs ( 0.00 cusr + 0.00 csys = 0.00 CPU) Failed 4/1457 test programs. 14/183750 subtests failed.
win32.c.AP819.patch
Description: Binary data
win32.c.5.9.5.patch
Description: Binary data
------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________ Perl-Win32-GUI-Users mailing list Perl-Win32-GUI-Users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/perl-win32-gui-users http://perl-win32-gui.sourceforge.net/
