Change 17676 by [EMAIL PROTECTED] on 2002/08/04 15:14:09
Subject: Re: [PATCH] Re: taint news
From: Rick Delaney <[EMAIL PROTECTED]>
Date: 04 Aug 2002 00:28:58 EDT
Message-ID: <[EMAIL PROTECTED]>
Ref: 20020208.005
Affected files ...
.... //depot/perl/pp_sys.c#316 edit
Differences ...
==== //depot/perl/pp_sys.c#316 (text) ====
Index: perl/pp_sys.c
--- perl/pp_sys.c#315~17616~ Wed Jul 17 21:01:33 2002
+++ perl/pp_sys.c Sun Aug 4 08:14:09 2002
@@ -4048,24 +4048,14 @@
I32 did_pipes = 0;
if (PL_tainting) {
- int some_arg_tainted = 0;
TAINT_ENV();
while (++MARK <= SP) {
(void)SvPV_nolen(*MARK); /* stringify for taint check */
- if (PL_tainted) {
- some_arg_tainted = 1;
+ if (PL_tainted)
break;
- }
}
MARK = ORIGMARK;
- /* XXX Remove warning at end of deprecation cycle --RD 2002-02 */
- if (SP - MARK == 1) {
- TAINT_PROPER("system");
- }
- else if (some_arg_tainted && ckWARN2(WARN_TAINT, WARN_DEPRECATED)) {
- Perl_warner(aTHX_ packWARN2(WARN_TAINT, WARN_DEPRECATED),
- "Use of tainted arguments in %s is deprecated", "system");
- }
+ TAINT_PROPER("system");
}
PERL_FLUSHALL_FOR_CHILD;
#if (defined(HAS_FORK) || defined(AMIGAOS)) && !defined(VMS) && !defined(OS2) ||
defined(PERL_MICRO)
@@ -4186,24 +4176,14 @@
STRLEN n_a;
if (PL_tainting) {
- int some_arg_tainted = 0;
TAINT_ENV();
while (++MARK <= SP) {
(void)SvPV_nolen(*MARK); /* stringify for taint check */
- if (PL_tainted) {
- some_arg_tainted = 1;
+ if (PL_tainted)
break;
- }
}
MARK = ORIGMARK;
- /* XXX Remove warning at end of deprecation cycle --RD 2002-02 */
- if (SP - MARK == 1) {
- TAINT_PROPER("exec");
- }
- else if (some_arg_tainted && ckWARN2(WARN_TAINT, WARN_DEPRECATED)) {
- Perl_warner(aTHX_ packWARN2(WARN_TAINT, WARN_DEPRECATED),
- "Use of tainted arguments in %s is deprecated", "exec");
- }
+ TAINT_PROPER("exec");
}
PERL_FLUSHALL_FOR_CHILD;
if (PL_op->op_flags & OPf_STACKED) {
End of Patch.
