Well, looks like this wasn't right:
On Tue, Mar 11, 2008 at 01:00:13PM -0700, Nicholas Clark wrote:
> Change 33480 by [EMAIL PROTECTED] on 2008/03/11 19:45:55
>
> Subject: Re: Perl @ http://www.ccl4.org/~nick/P/perl-33444.tar.bz2
> From: Reini Urban <[EMAIL PROTECTED]>
> Message-ID: <[EMAIL PROTECTED]>
> Date: Sat, 08 Mar 2008 20:55:36 +0100
>
> CYG09 enhance GetCurrentThreadId test
>
> Affected files ...
>
> ... //depot/perl/ext/Win32/t/GetCurrentThreadId.t#2 edit
>
> Differences ...
>
> ==== //depot/perl/ext/Win32/t/GetCurrentThreadId.t#2 (text) ====
> Index: perl/ext/Win32/t/GetCurrentThreadId.t
> --- perl/ext/Win32/t/GetCurrentThreadId.t#1~31235~ 2007-05-18
> 03:46:57.000000000 -0700
> +++ perl/ext/Win32/t/GetCurrentThreadId.t 2008-03-11 12:45:55.000000000
> -0700
> @@ -3,11 +3,6 @@
> use Test;
> use Win32;
>
> -unless ($Config{ccflags} =~ /PERL_IMPLICIT_SYS/) {
> - print "1..0 # Skip: Test requires fork emulation\n";
> - exit 0;
> -}
> -
> plan tests => 1;
>
> if (my $pid = fork) {
> @@ -17,4 +12,9 @@
>
> # This test relies on the implementation detail that the fork() emulation
> # uses the negative value of the thread id as a pseudo process id.
> -ok(-$$, Win32::GetCurrentThreadId());
> +if ($Config{ccflags} =~ /PERL_IMPLICIT_SYS/) {
> + ok(-$$, Win32::GetCurrentThreadId());
> +} else {
> +# here we just want to see something.
> + ok(Win32::GetCurrentThreadId() > 0);
> +}
> End of Patch.
On Thu, Mar 13, 2008 at 03:47:00AM +0000, Steve Hay wrote:
> Automated smoke report for 5.11.0 patch 33500
> maldoror.bath.planit.group: Intel(R) Core(TM)2 CPU 6700 @ 2.66GHz(~2660 MHz)
> (x86/2 cpu)
> on MSWin32 - WinXP/.Net SP2
> using cl version 13.10.3077
> [default]
> [default] -DDEBUGGING
> [default] -Dusemymalloc
> [default] -DDEBUGGING -Dusemymalloc
> [default] -Duselargefiles
> [default] -DDEBUGGING -Duselargefiles
> [default] -Duselargefiles -Dusemymalloc
> [default] -DDEBUGGING -Duselargefiles -Dusemymalloc
> [default] -DDEBUGGING -Duseithreads -Uuseimpsys
> [default] -Duseithreads -Uuseimpsys -Dusemymalloc
> ../ext/Win32/t/GetCurrentThreadId.t.........................FAILED
> Bad plan. You planned 1 tests but ran 0.
>
> [default] -Duseithreads -Uuseimpsys
> [default] -DDEBUGGING -Duseithreads -Uuseimpsys -Dusemymalloc
> [default] -Duseithreads -Uuseimpsys -Duselargefiles
> [default] -DDEBUGGING -Duseithreads -Uuseimpsys -Duselargefiles
> [default] -Duseithreads -Uuseimpsys -Duselargefiles -Dusemymalloc
> [default] -DDEBUGGING -Duseithreads -Uuseimpsys -Duselargefiles -Dusemymalloc
> ../ext/threads/shared/t/stress.t............................FAILED
> ../ext/Win32/t/GetCurrentThreadId.t.........................FAILED
> Bad plan. You planned 1 tests but ran 0.
Which I infer is down to this:
if (my $pid = fork) {
waitpid($pid, 0);
exit 0;
}
Should that now be moved into the (new)
if ($Config{ccflags} =~ /PERL_IMPLICIT_SYS/) {
...
}
block?
Nicholas Clark
