In perl.git, the branch blead has been updated <http://perl5.git.perl.org/perl.git/commitdiff/ed5958d4d0be98bffc846ce92d77c382457feea0?hp=276c43f2d2142de2d4f48edf3eea35ea2ebfb749>
- Log ----------------------------------------------------------------- commit ed5958d4d0be98bffc846ce92d77c382457feea0 Author: Craig A. Berry <[email protected]> Date: Thu Apr 12 16:27:08 2012 -0500 Set *.pod permissions in installperl. installperl takes responsibility for explicitly setting the permissions on most of the files it installs, but had not been doing so on pods for some reason. This commit makes it do so. Not having world/other read access could not only defeat attempts to read documentation, but also cause C<use diagnostics;> to fail when it attempted to open perldiag.pod. M installperl commit c960cc81974e3ce509bf69f12382a9d1c60bc63b Author: Craig A. Berry <[email protected]> Date: Fri Apr 13 12:42:10 2012 -0500 Set *.html permissions in installhtml. Pod::Html::pod2html via the installhtml utility, which is invoked by the install.html make target, had not been explicitly setting permissions on the installed HTML files. Leaving the target permissions to chance meant that on some systems they were set appropriately and some not based on various site and platform defaults. "Appropriately" in this case means readable by world/other, so we now set that explicitly. M ext/Pod-Html/lib/Pod/Html.pm commit 53a8d1b8eb73ca45a9780f087010d37dca19fd16 Author: Ricardo Signes <[email protected]> Date: Thu Apr 19 22:25:34 2012 -0400 allow "." in directory name This qualifies as another of the "crude hack to keep Pod-Html more usable" hacks that are in place until the path handling is fixed more systematically. M ext/Pod-Html/lib/Pod/Html.pm ----------------------------------------------------------------------- Summary of changes: ext/Pod-Html/lib/Pod/Html.pm | 3 ++- installperl | 1 + 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/ext/Pod-Html/lib/Pod/Html.pm b/ext/Pod-Html/lib/Pod/Html.pm index f669873..9838ea4 100644 --- a/ext/Pod-Html/lib/Pod/Html.pm +++ b/ext/Pod-Html/lib/Pod/Html.pm @@ -332,7 +332,7 @@ sub pod2html { while($_dirlevel =~ /\.\./) { $_dirlevel =~ s/\.\.//; # Assume $Pages{$key} has '/' separators (html dir separators). - $Pages{$key} =~ s/^[\w\s\-]+\///; + $Pages{$key} =~ s/^[\w\s\-\.]+\///; } } print $cache "$key $Pages{$key}\n"; @@ -433,6 +433,7 @@ HTMLFOOT } print $fhout $output; close $fhout or die "Failed to close $Htmlfile: $!"; + chmod 0644, $Htmlfile unless $Htmlfile eq '-'; } ############################################################################## diff --git a/installperl b/installperl index 10a3781..8b22d72 100755 --- a/installperl +++ b/installperl @@ -558,6 +558,7 @@ if (!$nopods && (!$versiononly || ($installprivlib =~ m/\Q$vershort/))) { # $_ is a name like pod/perl.pod (my $base = $_) =~ s#.*/##; copy_if_diff($_, "${installprivlib}/$pod/${base}"); + chmod(0644, "${installprivlib}/$pod/${base}"); } } -- Perl5 Master Repository
