Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 9aa835c8dd6366d2c514188b780c81fcc32bc2f0
https://github.com/Perl/perl5/commit/9aa835c8dd6366d2c514188b780c81fcc32bc2f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 5362d9f20b9de2b3b30eddf188fc4941db3197a5
https://github.com/Perl/perl5/commit/5362d9f20b9de2b3b30eddf188fc4941db3197a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 6e11c945e5d2d10d9d7fd5b0a555acfa38a3123d
https://github.com/Perl/perl5/commit/6e11c945e5d2d10d9d7fd5b0a555acfa38a3123d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 377761e738bc57be00c85430f273488c7e591d23
https://github.com/Perl/perl5/commit/377761e738bc57be00c85430f273488c7e591d23
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 76af2e101fed4eb3a4566ccad29ff0c32ebd1794
https://github.com/Perl/perl5/commit/76af2e101fed4eb3a4566ccad29ff0c32ebd1794
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 0ebed4fd57df9a3cf7ec3be8a4049ea5c22d6ba8
https://github.com/Perl/perl5/commit/0ebed4fd57df9a3cf7ec3be8a4049ea5c22d6ba8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 8d2b4f589e2c7cc55714d5b2ab63445f146612b2
https://github.com/Perl/perl5/commit/8d2b4f589e2c7cc55714d5b2ab63445f146612b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: bfca1f969170fa0b02bc9a8c104a881d9b432101
https://github.com/Perl/perl5/commit/bfca1f969170fa0b02bc9a8c104a881d9b432101
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: a47d5a5762d1946e00d2dc6c17e1f29e44cebb5e
https://github.com/Perl/perl5/commit/a47d5a5762d1946e00d2dc6c17e1f29e44cebb5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 7c4dc99fcc5af7d6aa00266c4bb9a87d9f3df8f8
https://github.com/Perl/perl5/commit/7c4dc99fcc5af7d6aa00266c4bb9a87d9f3df8f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: ee418e22f6690f84b9e33ad9370608ad13a31e41
https://github.com/Perl/perl5/commit/ee418e22f6690f84b9e33ad9370608ad13a31e41
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: e9f25fa9f45441eaa968553c152af311ac884d50
https://github.com/Perl/perl5/commit/e9f25fa9f45441eaa968553c152af311ac884d50
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 9c58ed403ee498bc3f619de8ae6fc1b036b94dad
https://github.com/Perl/perl5/commit/9c58ed403ee498bc3f619de8ae6fc1b036b94dad
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 8c7289dbf777bbec9cba8e6827edeed403c4d022
https://github.com/Perl/perl5/commit/8c7289dbf777bbec9cba8e6827edeed403c4d022
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: cddf7dac0f03f0a1774e464790fca20014051705
https://github.com/Perl/perl5/commit/cddf7dac0f03f0a1774e464790fca20014051705
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: fac2f71ed8e817f399eeb1acbd98fe97478e685c
https://github.com/Perl/perl5/commit/fac2f71ed8e817f399eeb1acbd98fe97478e685c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: e1155591cecb1512e5a32d832680487f729697cf
https://github.com/Perl/perl5/commit/e1155591cecb1512e5a32d832680487f729697cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 27dc22e84edfdbf05f34c6a19f9a5301bbb0b054
https://github.com/Perl/perl5/commit/27dc22e84edfdbf05f34c6a19f9a5301bbb0b054
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: e640c6472cda45e25075ba5176ef050b618c1c09
https://github.com/Perl/perl5/commit/e640c6472cda45e25075ba5176ef050b618c1c09
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 0763835503f837e151960a405731164d3636e8a2
https://github.com/Perl/perl5/commit/0763835503f837e151960a405731164d3636e8a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 939a85de611a09cdc965542555f2c013f19e9fef
https://github.com/Perl/perl5/commit/939a85de611a09cdc965542555f2c013f19e9fef
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 70e9a045c1b8ff27f9b7b1d990c03a138d81802c
https://github.com/Perl/perl5/commit/70e9a045c1b8ff27f9b7b1d990c03a138d81802c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 8051ed06940c5f208b39e3beea16d0daca29dd4c
https://github.com/Perl/perl5/commit/8051ed06940c5f208b39e3beea16d0daca29dd4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 35edd08da4c60d0eba5f0a0eafe971f3f7d9b907
https://github.com/Perl/perl5/commit/35edd08da4c60d0eba5f0a0eafe971f3f7d9b907
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: bd69bcd85666e05a3e2ba6310d6ec6b9147f6f2a
https://github.com/Perl/perl5/commit/bd69bcd85666e05a3e2ba6310d6ec6b9147f6f2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 8e2638089973180f53b4865a11744e774356a62e
https://github.com/Perl/perl5/commit/8e2638089973180f53b4865a11744e774356a62e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 63bdebf05dcb3544eb104473b320b3c37d9b69a6
https://github.com/Perl/perl5/commit/63bdebf05dcb3544eb104473b320b3c37d9b69a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 15ac6a27d097d260bdea15e9c4dbd824be9b0599
https://github.com/Perl/perl5/commit/15ac6a27d097d260bdea15e9c4dbd824be9b0599
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 9dff897157ca1cc1d8c34f93575d0d0ee7368d9f
https://github.com/Perl/perl5/commit/9dff897157ca1cc1d8c34f93575d0d0ee7368d9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: b416b100305160a48581b803d9e0dcc5fee919c1
https://github.com/Perl/perl5/commit/b416b100305160a48581b803d9e0dcc5fee919c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 65c93e70a1671391a187acf442492bb906203c98
https://github.com/Perl/perl5/commit/65c93e70a1671391a187acf442492bb906203c98
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 93d53f04f2b76e5b15aef04699b082a54618e47c
https://github.com/Perl/perl5/commit/93d53f04f2b76e5b15aef04699b082a54618e47c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: c499f26129a88959354867c759700c9eb7e0747e
https://github.com/Perl/perl5/commit/c499f26129a88959354867c759700c9eb7e0747e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: db5604f9231e60aa7cf192bd555dc496844ea0c9
https://github.com/Perl/perl5/commit/db5604f9231e60aa7cf192bd555dc496844ea0c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: eb541439101694e460b0d218ac78fac7b1dae2af
https://github.com/Perl/perl5/commit/eb541439101694e460b0d218ac78fac7b1dae2af
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 91385c008b61a41fb1de7671b61bebf611c10ab2
https://github.com/Perl/perl5/commit/91385c008b61a41fb1de7671b61bebf611c10ab2
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 0b3ffdfd8a55b30533effbb42d3b41539c2aebb0
https://github.com/Perl/perl5/commit/0b3ffdfd8a55b30533effbb42d3b41539c2aebb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: e5ac47c3bbb7e77b9573f7e8290ee8037e81a33c
https://github.com/Perl/perl5/commit/e5ac47c3bbb7e77b9573f7e8290ee8037e81a33c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 907599d86ae21425484446581fc54f12bd484759
https://github.com/Perl/perl5/commit/907599d86ae21425484446581fc54f12bd484759
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: f9db46745b84b8f0489d946c5c3047284c405e3b
https://github.com/Perl/perl5/commit/f9db46745b84b8f0489d946c5c3047284c405e3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 5a56c8c81d252390261a33a9cc6c13e9ce9f1e5f
https://github.com/Perl/perl5/commit/5a56c8c81d252390261a33a9cc6c13e9ce9f1e5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 8600834679cd71a3220894572fd291236ef56e9c
https://github.com/Perl/perl5/commit/8600834679cd71a3220894572fd291236ef56e9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: c4681d94ead604a1f6007c8fe9d7501f1ca36d9d
https://github.com/Perl/perl5/commit/c4681d94ead604a1f6007c8fe9d7501f1ca36d9d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 0a2db3b0bc18815e5f25fde255b743c76035297d
https://github.com/Perl/perl5/commit/0a2db3b0bc18815e5f25fde255b743c76035297d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 8245ab9cf169771650ff2fba0fa9441a8d60161d
https://github.com/Perl/perl5/commit/8245ab9cf169771650ff2fba0fa9441a8d60161d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 1e946eeac66b7e0b2be2548e7723ebfc1d1e51e3
https://github.com/Perl/perl5/commit/1e946eeac66b7e0b2be2548e7723ebfc1d1e51e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: aac2279b04901a8b948f7ccca5c763ac37a9a8c8
https://github.com/Perl/perl5/commit/aac2279b04901a8b948f7ccca5c763ac37a9a8c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 9b0d25d39b14cc592ab32a83f17e146e4c853bd8
https://github.com/Perl/perl5/commit/9b0d25d39b14cc592ab32a83f17e146e4c853bd8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 2bed15e2d1c290c0285554222392e00a657d623a
https://github.com/Perl/perl5/commit/2bed15e2d1c290c0285554222392e00a657d623a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 1febb316c471c8e912a3ca011dbb4d9d1c426670
https://github.com/Perl/perl5/commit/1febb316c471c8e912a3ca011dbb4d9d1c426670
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 737fa918983af33096791336979a8948500a581d
https://github.com/Perl/perl5/commit/737fa918983af33096791336979a8948500a581d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 3f229020bf10bf0e0cc71210793fdff0179a8d2c
https://github.com/Perl/perl5/commit/3f229020bf10bf0e0cc71210793fdff0179a8d2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: ac621697d57ef465529f249a84714c2a7ad0a9c8
https://github.com/Perl/perl5/commit/ac621697d57ef465529f249a84714c2a7ad0a9c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 8e4c0966191fe90d79d71dd71c3bafc948d8fdce
https://github.com/Perl/perl5/commit/8e4c0966191fe90d79d71dd71c3bafc948d8fdce
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: d860de1d3e8488d6d070c6f01725540a9314cc6e
https://github.com/Perl/perl5/commit/d860de1d3e8488d6d070c6f01725540a9314cc6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 8c586e18ea5b4d31d9a522799ea6b1260690bfc7
https://github.com/Perl/perl5/commit/8c586e18ea5b4d31d9a522799ea6b1260690bfc7
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 7d6f4ef04c2818c0ce2dec100c7038a5b4ae7ddf
https://github.com/Perl/perl5/commit/7d6f4ef04c2818c0ce2dec100c7038a5b4ae7ddf
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: c414627fad02a47e1ed1cea69ecf21525b1256b9
https://github.com/Perl/perl5/commit/c414627fad02a47e1ed1cea69ecf21525b1256b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: c217aabf98aff5868056a8daed0f582f4d6ae23c
https://github.com/Perl/perl5/commit/c217aabf98aff5868056a8daed0f582f4d6ae23c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 5f555e83214454c95edeb9b11eb56f28801e0360
https://github.com/Perl/perl5/commit/5f555e83214454c95edeb9b11eb56f28801e0360
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: d4e2624a27da2425bf48db8ae0f1d7d492447a14
https://github.com/Perl/perl5/commit/d4e2624a27da2425bf48db8ae0f1d7d492447a14
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 2a2f80717ee8db5259f95db28967256781130bb8
https://github.com/Perl/perl5/commit/2a2f80717ee8db5259f95db28967256781130bb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 2e15b736022b7670af87e8faeaec7185d2923e36
https://github.com/Perl/perl5/commit/2e15b736022b7670af87e8faeaec7185d2923e36
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: cdaa183c289711976f0fbc67530cffa51797cc47
https://github.com/Perl/perl5/commit/cdaa183c289711976f0fbc67530cffa51797cc47
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 3a34730d3af82212901c4717fe7ae703c72bfa28
https://github.com/Perl/perl5/commit/3a34730d3af82212901c4717fe7ae703c72bfa28
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 712fdd2fc7c7401eda9fdd42ad3d4a61bf5c9ee4
https://github.com/Perl/perl5/commit/712fdd2fc7c7401eda9fdd42ad3d4a61bf5c9ee4
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: cbb62887991863d8be2d375e9c5ec73e4992e3a9
https://github.com/Perl/perl5/commit/cbb62887991863d8be2d375e9c5ec73e4992e3a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 6f01364847cce6c58056767a65a9af8bd95e87b5
https://github.com/Perl/perl5/commit/6f01364847cce6c58056767a65a9af8bd95e87b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 186b6fd222adf54b8f21a063cbefae4d24ce165a
https://github.com/Perl/perl5/commit/186b6fd222adf54b8f21a063cbefae4d24ce165a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: a9c536894de02f15b0a0e99b093d3d1f497699ce
https://github.com/Perl/perl5/commit/a9c536894de02f15b0a0e99b093d3d1f497699ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 8f2dcaf4beb189c8fd3f4b4c13cb919fc62c481b
https://github.com/Perl/perl5/commit/8f2dcaf4beb189c8fd3f4b4c13cb919fc62c481b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 4df03a3a688ed1a60adf34ae70379abe3898c163
https://github.com/Perl/perl5/commit/4df03a3a688ed1a60adf34ae70379abe3898c163
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 20880b6f70df7a150e787a818cb49564a3f4cbc8
https://github.com/Perl/perl5/commit/20880b6f70df7a150e787a818cb49564a3f4cbc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 3cb75ca6ae24ff4a3edc6affac7f30ae5de39d05
https://github.com/Perl/perl5/commit/3cb75ca6ae24ff4a3edc6affac7f30ae5de39d05
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: d4f9dc664b37ae0a2c7c5af93df07584efd7f338
https://github.com/Perl/perl5/commit/d4f9dc664b37ae0a2c7c5af93df07584efd7f338
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 7db32aa8a8e651d85e5a0f2957c9fe732f140701
https://github.com/Perl/perl5/commit/7db32aa8a8e651d85e5a0f2957c9fe732f140701
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 19f6ec71a29eafbb4220aacf12dd6c8e44f80e1d
https://github.com/Perl/perl5/commit/19f6ec71a29eafbb4220aacf12dd6c8e44f80e1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: e9c1a4b6e10d6293b9a37aec37570325bcd08605
https://github.com/Perl/perl5/commit/e9c1a4b6e10d6293b9a37aec37570325bcd08605
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 351fae1b14a3023b8ab471111a39796a7389f741
https://github.com/Perl/perl5/commit/351fae1b14a3023b8ab471111a39796a7389f741
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: a45a721151ff614599ebfc2e9dbf284aea42dbd9
https://github.com/Perl/perl5/commit/a45a721151ff614599ebfc2e9dbf284aea42dbd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 7716f24f759ed527a08c178a9ba412a80a4a234b
https://github.com/Perl/perl5/commit/7716f24f759ed527a08c178a9ba412a80a4a234b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 1e31449e7b228f9a391930269aea910a6f6bfa6b
https://github.com/Perl/perl5/commit/1e31449e7b228f9a391930269aea910a6f6bfa6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 4849802984c94fcdce1722ba118cc2945cd485c8
https://github.com/Perl/perl5/commit/4849802984c94fcdce1722ba118cc2945cd485c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: d355f4d02551f23246a5cbe96d4d54bb2dbe7c78
https://github.com/Perl/perl5/commit/d355f4d02551f23246a5cbe96d4d54bb2dbe7c78
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 5a86f233d5c24734b6c5741e8c3dd458f2598849
https://github.com/Perl/perl5/commit/5a86f233d5c24734b6c5741e8c3dd458f2598849
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: fbf5cf3b25bcaf3ee2789a7c2664e6fcac769d3d
https://github.com/Perl/perl5/commit/fbf5cf3b25bcaf3ee2789a7c2664e6fcac769d3d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 58c2250e4ff7fccb161efd08aa31f48de79f6d3b
https://github.com/Perl/perl5/commit/58c2250e4ff7fccb161efd08aa31f48de79f6d3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 8b7d154214d7e3b16fcf71e76bd9ca4a6b2c982b
https://github.com/Perl/perl5/commit/8b7d154214d7e3b16fcf71e76bd9ca4a6b2c982b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 15f1984c72621140f41c9d8b9f55cc2d229b53b3
https://github.com/Perl/perl5/commit/15f1984c72621140f41c9d8b9f55cc2d229b53b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: e62de66e77ea43a78c29a07d5ed641cf0ebc7366
https://github.com/Perl/perl5/commit/e62de66e77ea43a78c29a07d5ed641cf0ebc7366
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: ff7db3e75897e12bafc055f21faddfb07b330c8b
https://github.com/Perl/perl5/commit/ff7db3e75897e12bafc055f21faddfb07b330c8b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: cdf00b3557628fd07c7243915ad31c305e5b3827
https://github.com/Perl/perl5/commit/cdf00b3557628fd07c7243915ad31c305e5b3827
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 193a65cf8cc5159b821dae80fddc098ccc475255
https://github.com/Perl/perl5/commit/193a65cf8cc5159b821dae80fddc098ccc475255
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 7d47610ed6a3eff2e16c7ad33d4d7f7054710d2f
https://github.com/Perl/perl5/commit/7d47610ed6a3eff2e16c7ad33d4d7f7054710d2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: a7929bf5fd53db163ff93773928744954f3978d3
https://github.com/Perl/perl5/commit/a7929bf5fd53db163ff93773928744954f3978d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 012f51bd25fc1471d69deb8f18eed7b61067e7da
https://github.com/Perl/perl5/commit/012f51bd25fc1471d69deb8f18eed7b61067e7da
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: b164930c6e91422a1c452735255f299e240daa5c
https://github.com/Perl/perl5/commit/b164930c6e91422a1c452735255f299e240daa5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 0697352ef159b77e53bd48bf49c3f85b441f0943
https://github.com/Perl/perl5/commit/0697352ef159b77e53bd48bf49c3f85b441f0943
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 3fa751b488aa0fdad28e514a211319e98b5a60f3
https://github.com/Perl/perl5/commit/3fa751b488aa0fdad28e514a211319e98b5a60f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 7bfa76519920f7a957bc1cae1d28da1647180c01
https://github.com/Perl/perl5/commit/7bfa76519920f7a957bc1cae1d28da1647180c01
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 33d2a896212db1363c2485dce6f802180bce099c
https://github.com/Perl/perl5/commit/33d2a896212db1363c2485dce6f802180bce099c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 9baf585fa054cffa1a8083d97fe16f6eab7ccd57
https://github.com/Perl/perl5/commit/9baf585fa054cffa1a8083d97fe16f6eab7ccd57
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: c20e7dc7e516b21ba0dbf3703de744562af09840
https://github.com/Perl/perl5/commit/c20e7dc7e516b21ba0dbf3703de744562af09840
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: eace726910058059c3a5a498f4ae0c441733fd74
https://github.com/Perl/perl5/commit/eace726910058059c3a5a498f4ae0c441733fd74
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: bd7f0f1562918272fa851ddedc22adb44f1fc3ab
https://github.com/Perl/perl5/commit/bd7f0f1562918272fa851ddedc22adb44f1fc3ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: aaa2704843bb57ede7b6d3f4a1ec65007fa8d2e4
https://github.com/Perl/perl5/commit/aaa2704843bb57ede7b6d3f4a1ec65007fa8d2e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: f9f949512f0cc705f03542feadcadcc5cf74419e
https://github.com/Perl/perl5/commit/f9f949512f0cc705f03542feadcadcc5cf74419e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 4c52768151676dddd3267fe2145a4ba237273db1
https://github.com/Perl/perl5/commit/4c52768151676dddd3267fe2145a4ba237273db1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: a7c38bf07c3640152af803759c5bc0936d29cce1
https://github.com/Perl/perl5/commit/a7c38bf07c3640152af803759c5bc0936d29cce1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: c1de0703a47db41e0db37186e58ba205efaf22cf
https://github.com/Perl/perl5/commit/c1de0703a47db41e0db37186e58ba205efaf22cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: b634ce071b552e4d1259179b777cac0d9012cdda
https://github.com/Perl/perl5/commit/b634ce071b552e4d1259179b777cac0d9012cdda
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: b5355b6a34b2800f9acc1175804400022cdeed90
https://github.com/Perl/perl5/commit/b5355b6a34b2800f9acc1175804400022cdeed90
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 6f829d8bec105770a430bc5c4af81053ab3b9224
https://github.com/Perl/perl5/commit/6f829d8bec105770a430bc5c4af81053ab3b9224
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 59af473044ff36bdf409476b128739cffe7d3fb1
https://github.com/Perl/perl5/commit/59af473044ff36bdf409476b128739cffe7d3fb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: bba582ffa29a0b4fade9f3c43fb97d7c94cfa394
https://github.com/Perl/perl5/commit/bba582ffa29a0b4fade9f3c43fb97d7c94cfa394
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 60edb99122660fa2dc885fef7a22b0227dd92d58
https://github.com/Perl/perl5/commit/60edb99122660fa2dc885fef7a22b0227dd92d58
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 70ae47c583ac69adccd8bb795a7c4b14ed27e046
https://github.com/Perl/perl5/commit/70ae47c583ac69adccd8bb795a7c4b14ed27e046
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: be4877c5ed980342b1817e9841f1d79c4f158fdf
https://github.com/Perl/perl5/commit/be4877c5ed980342b1817e9841f1d79c4f158fdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 46c4f48a1dc2d0dd8770306ec628dd57de4ccc47
https://github.com/Perl/perl5/commit/46c4f48a1dc2d0dd8770306ec628dd57de4ccc47
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 32235dba52e2c4489884e8f2b2f94620e7d82667
https://github.com/Perl/perl5/commit/32235dba52e2c4489884e8f2b2f94620e7d82667
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 0dfb194980b1be1e1cc9910c3424d881a9c9ca5e
https://github.com/Perl/perl5/commit/0dfb194980b1be1e1cc9910c3424d881a9c9ca5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: c9b02637c4c47cf9e6a26ca78561099ff0848ee6
https://github.com/Perl/perl5/commit/c9b02637c4c47cf9e6a26ca78561099ff0848ee6
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 34408376897fdecb10d6c7e41d32ccc03b681e9c
https://github.com/Perl/perl5/commit/34408376897fdecb10d6c7e41d32ccc03b681e9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 9421fbfc0852ac60f8e3ba5ee3cc047fb8c38858
https://github.com/Perl/perl5/commit/9421fbfc0852ac60f8e3ba5ee3cc047fb8c38858
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 314cd3340979f67de2c5065e35543c56c320b66d
https://github.com/Perl/perl5/commit/314cd3340979f67de2c5065e35543c56c320b66d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 1c2ee4e482b095e66fd28a907e95b46ed5459712
https://github.com/Perl/perl5/commit/1c2ee4e482b095e66fd28a907e95b46ed5459712
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: e370398e0e01527e549e8fa168547e021a8660ea
https://github.com/Perl/perl5/commit/e370398e0e01527e549e8fa168547e021a8660ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 164558da7ed4f052886d11ad2b12118e28d75f9e
https://github.com/Perl/perl5/commit/164558da7ed4f052886d11ad2b12118e28d75f9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 5d4a65600f2378808176208edbc52e4b47e0ec55
https://github.com/Perl/perl5/commit/5d4a65600f2378808176208edbc52e4b47e0ec55
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 0be5b7e1228296bb7fee1e5537fd8bdd9287dcb9
https://github.com/Perl/perl5/commit/0be5b7e1228296bb7fee1e5537fd8bdd9287dcb9
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 2bdcb4377c67e68b78ad8538c19b9e6088b49853
https://github.com/Perl/perl5/commit/2bdcb4377c67e68b78ad8538c19b9e6088b49853
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 94072de1013e39af966bfd4ae08a2a6232937eb3
https://github.com/Perl/perl5/commit/94072de1013e39af966bfd4ae08a2a6232937eb3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: c52bf899b51aa77233744e6561c82b5802f66db5
https://github.com/Perl/perl5/commit/c52bf899b51aa77233744e6561c82b5802f66db5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 3ea57a345155dca9df81981401b91a08e9cc78d4
https://github.com/Perl/perl5/commit/3ea57a345155dca9df81981401b91a08e9cc78d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 94b72e22a3a5e719a7f3bd935b7e9208a7cfd199
https://github.com/Perl/perl5/commit/94b72e22a3a5e719a7f3bd935b7e9208a7cfd199
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 8e676f5dbc0266c17ca31f4051b754daf3411e54
https://github.com/Perl/perl5/commit/8e676f5dbc0266c17ca31f4051b754daf3411e54
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 38320d913e2589d4ec1f77c723c6a12b93798fb5
https://github.com/Perl/perl5/commit/38320d913e2589d4ec1f77c723c6a12b93798fb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: f351e2616db47bfe30c6d4b9a2f4764b87f642bb
https://github.com/Perl/perl5/commit/f351e2616db47bfe30c6d4b9a2f4764b87f642bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: adc521f262dfddd55e2d7eeb87dc9f20f9632229
https://github.com/Perl/perl5/commit/adc521f262dfddd55e2d7eeb87dc9f20f9632229
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 2a44199cfc28e029e153f2863ec3cb9f1c247a51
https://github.com/Perl/perl5/commit/2a44199cfc28e029e153f2863ec3cb9f1c247a51
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: fd109b42ca1847126bf44ba6f1c550c65c744a36
https://github.com/Perl/perl5/commit/fd109b42ca1847126bf44ba6f1c550c65c744a36
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 89e47088f1ab6d376f7c012356b0f615bdad265b
https://github.com/Perl/perl5/commit/89e47088f1ab6d376f7c012356b0f615bdad265b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: d1bd7a693b8b433b612fe01899fb4324c8ef2b34
https://github.com/Perl/perl5/commit/d1bd7a693b8b433b612fe01899fb4324c8ef2b34
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 8dfead9dca6e8eabde63ef49537af7f365cb7275
https://github.com/Perl/perl5/commit/8dfead9dca6e8eabde63ef49537af7f365cb7275
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 1e4ff0793250cebb585c8c4a66562060a1591d64
https://github.com/Perl/perl5/commit/1e4ff0793250cebb585c8c4a66562060a1591d64
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: bcb62dbb1afa591b510b06e803f59bbf56f1fc63
https://github.com/Perl/perl5/commit/bcb62dbb1afa591b510b06e803f59bbf56f1fc63
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: c735274af290a280439f6fa3c5f4a4fa2a68a905
https://github.com/Perl/perl5/commit/c735274af290a280439f6fa3c5f4a4fa2a68a905
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 0c4d46dd08b24ba8231681fd14f1fa02a618fb72
https://github.com/Perl/perl5/commit/0c4d46dd08b24ba8231681fd14f1fa02a618fb72
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: e1abe5d90c089593f1d1d4b6f81fdd70e4caf06d
https://github.com/Perl/perl5/commit/e1abe5d90c089593f1d1d4b6f81fdd70e4caf06d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 7e762e01265aa4d259b3651ad93d07f17e9273b8
https://github.com/Perl/perl5/commit/7e762e01265aa4d259b3651ad93d07f17e9273b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: b908ed74abecfd4b0fbefce826df9ff553fa2e15
https://github.com/Perl/perl5/commit/b908ed74abecfd4b0fbefce826df9ff553fa2e15
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: d3966ab25fdd5c2fcfe92fb390dd03f483f8849c
https://github.com/Perl/perl5/commit/d3966ab25fdd5c2fcfe92fb390dd03f483f8849c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 41b6bf54937f382b4a42a8f6ee0b154f65f92e6a
https://github.com/Perl/perl5/commit/41b6bf54937f382b4a42a8f6ee0b154f65f92e6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: a76a3f74fe1e05ff007eb654dd32c6186a26358f
https://github.com/Perl/perl5/commit/a76a3f74fe1e05ff007eb654dd32c6186a26358f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: ef59a0de1127de2244cee7c5d9776f11796703c7
https://github.com/Perl/perl5/commit/ef59a0de1127de2244cee7c5d9776f11796703c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: afc0df576df31ad535943cea850793193d2bc8e3
https://github.com/Perl/perl5/commit/afc0df576df31ad535943cea850793193d2bc8e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 73548a011aea5ce8b1b2e7b77db51387b79b479b
https://github.com/Perl/perl5/commit/73548a011aea5ce8b1b2e7b77db51387b79b479b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 9795b716a117650954430e3615b9dea17e5c2058
https://github.com/Perl/perl5/commit/9795b716a117650954430e3615b9dea17e5c2058
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 67754d8e2fdb12612bb4ed276f2805c072358186
https://github.com/Perl/perl5/commit/67754d8e2fdb12612bb4ed276f2805c072358186
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: e1e54153d2c1a171c427785fd2a04b0439df8586
https://github.com/Perl/perl5/commit/e1e54153d2c1a171c427785fd2a04b0439df8586
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 5493ed35b709111da5fb832dd374e4ef1c26dbd1
https://github.com/Perl/perl5/commit/5493ed35b709111da5fb832dd374e4ef1c26dbd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: f3a0700a07db9ba1f18bbebb08262929d9421ea3
https://github.com/Perl/perl5/commit/f3a0700a07db9ba1f18bbebb08262929d9421ea3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 8e716b2c44725eb5b80e9a9a589bdf6657bc0797
https://github.com/Perl/perl5/commit/8e716b2c44725eb5b80e9a9a589bdf6657bc0797
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: e97c451a107f38c5703d4e3c60892c95571ef92a
https://github.com/Perl/perl5/commit/e97c451a107f38c5703d4e3c60892c95571ef92a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: a3596c0d34f49497802ff6f3ad7d328eaa9bc3c8
https://github.com/Perl/perl5/commit/a3596c0d34f49497802ff6f3ad7d328eaa9bc3c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: bb5822d50c4094b92c4dd95fd9aa9cf4c1048c57
https://github.com/Perl/perl5/commit/bb5822d50c4094b92c4dd95fd9aa9cf4c1048c57
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: cec21f1d6ad8504ba1d1140b159cedcb577a6338
https://github.com/Perl/perl5/commit/cec21f1d6ad8504ba1d1140b159cedcb577a6338
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: e5b9242ea15413ffb226e6c5c76de88b16703783
https://github.com/Perl/perl5/commit/e5b9242ea15413ffb226e6c5c76de88b16703783
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 565be6ed29f7a81058dd09eb810c14da6f54209c
https://github.com/Perl/perl5/commit/565be6ed29f7a81058dd09eb810c14da6f54209c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: e91df0082459a165622c07ee77ec7f8e113585b4
https://github.com/Perl/perl5/commit/e91df0082459a165622c07ee77ec7f8e113585b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 3794bf2fd5836eeb7682e3e0e41b3a0b96147f58
https://github.com/Perl/perl5/commit/3794bf2fd5836eeb7682e3e0e41b3a0b96147f58
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 9aa9b82c13fa1d3ba29c22c7a12bedb79be521a0
https://github.com/Perl/perl5/commit/9aa9b82c13fa1d3ba29c22c7a12bedb79be521a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 622ff88177728427f3e4293f4a2f9f6c43019e3e
https://github.com/Perl/perl5/commit/622ff88177728427f3e4293f4a2f9f6c43019e3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 2661ed71ac1d975a91a6d129c110fb9e3c1160aa
https://github.com/Perl/perl5/commit/2661ed71ac1d975a91a6d129c110fb9e3c1160aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 33fc996c65e42614b0857899a89e46a28e881ba6
https://github.com/Perl/perl5/commit/33fc996c65e42614b0857899a89e46a28e881ba6
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 3a2c42fdf6082ba4d82f1c322fdfa86d1a477076
https://github.com/Perl/perl5/commit/3a2c42fdf6082ba4d82f1c322fdfa86d1a477076
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: cad08185cff30280d98664e02f86a0a9a7a1340f
https://github.com/Perl/perl5/commit/cad08185cff30280d98664e02f86a0a9a7a1340f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 256a33eded06eac95ce8ed78b618496bccbb945d
https://github.com/Perl/perl5/commit/256a33eded06eac95ce8ed78b618496bccbb945d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 3f7a9c6576d224ad96c91ad7903c2d6db096d8ab
https://github.com/Perl/perl5/commit/3f7a9c6576d224ad96c91ad7903c2d6db096d8ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: c6f3b3d47c72c8dbaad4a8b3d7a5ba78316b7feb
https://github.com/Perl/perl5/commit/c6f3b3d47c72c8dbaad4a8b3d7a5ba78316b7feb
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 324e2d0c35dea14322aea7924208b20689a7bbaa
https://github.com/Perl/perl5/commit/324e2d0c35dea14322aea7924208b20689a7bbaa
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: f76d94dfe685205ae4ba6486d15f56ff89c75e38
https://github.com/Perl/perl5/commit/f76d94dfe685205ae4ba6486d15f56ff89c75e38
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: da814cf5a396af25d564dbe6a4ab8c7f9b7d6f0e
https://github.com/Perl/perl5/commit/da814cf5a396af25d564dbe6a4ab8c7f9b7d6f0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 8c0b6c03faa9e8652b8385e77af962821f7edb99
https://github.com/Perl/perl5/commit/8c0b6c03faa9e8652b8385e77af962821f7edb99
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 91d6bcc53ed64b884e5854a04f7d5c565e68c798
https://github.com/Perl/perl5/commit/91d6bcc53ed64b884e5854a04f7d5c565e68c798
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 09dd419ff413173c113b8818783c563efb16e26e
https://github.com/Perl/perl5/commit/09dd419ff413173c113b8818783c563efb16e26e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: ecee7b5bd5c7df4c03692ce591e116dd5d13c94f
https://github.com/Perl/perl5/commit/ecee7b5bd5c7df4c03692ce591e116dd5d13c94f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: d341d67dcaba1241d9b71e55508f7dd1a75933ec
https://github.com/Perl/perl5/commit/d341d67dcaba1241d9b71e55508f7dd1a75933ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: acf244a75f454bb2c1772c7ec811bff3a4d97a78
https://github.com/Perl/perl5/commit/acf244a75f454bb2c1772c7ec811bff3a4d97a78
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 1334398aecce8fe31f51285f69b3b56eb11b2b93
https://github.com/Perl/perl5/commit/1334398aecce8fe31f51285f69b3b56eb11b2b93
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: c7b254dbddc759e76f8ee29c21b14a6db181abe8
https://github.com/Perl/perl5/commit/c7b254dbddc759e76f8ee29c21b14a6db181abe8
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: a2d73e25de0ac3e25092ea9f6be39ad54a371b84
https://github.com/Perl/perl5/commit/a2d73e25de0ac3e25092ea9f6be39ad54a371b84
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 76948f8a33ec3666612710d6899122f1b3daed96
https://github.com/Perl/perl5/commit/76948f8a33ec3666612710d6899122f1b3daed96
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 6d622b21d8a7e9c4132c81ae09aa7df85a7e6ed0
https://github.com/Perl/perl5/commit/6d622b21d8a7e9c4132c81ae09aa7df85a7e6ed0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: c38368431a853e6f50bc2bfae0e7d1e9e6e1d3c3
https://github.com/Perl/perl5/commit/c38368431a853e6f50bc2bfae0e7d1e9e6e1d3c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: db711d08b26fd5735fae9d656845035a341d867c
https://github.com/Perl/perl5/commit/db711d08b26fd5735fae9d656845035a341d867c
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 0509e342d37b4fa15be37477ae2e0dfdf650160b
https://github.com/Perl/perl5/commit/0509e342d37b4fa15be37477ae2e0dfdf650160b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 1dc0bd25cc1ade7be5afc294945bb112111df5e5
https://github.com/Perl/perl5/commit/1dc0bd25cc1ade7be5afc294945bb112111df5e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 0c7dac4ace7b4350a01498cdf827e909144c1dc4
https://github.com/Perl/perl5/commit/0c7dac4ace7b4350a01498cdf827e909144c1dc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 64a10fdc61f5ab8cdb198b8fa9283013a139041b
https://github.com/Perl/perl5/commit/64a10fdc61f5ab8cdb198b8fa9283013a139041b
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: cb186935e66e25050d984a2f548bce9b4a9ef7ec
https://github.com/Perl/perl5/commit/cb186935e66e25050d984a2f548bce9b4a9ef7ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 8af384f905da77ac448e929ca9c12fa84be844be
https://github.com/Perl/perl5/commit/8af384f905da77ac448e929ca9c12fa84be844be
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: f9e8ad89743c914b50d6ae33583e6f34a203897e
https://github.com/Perl/perl5/commit/f9e8ad89743c914b50d6ae33583e6f34a203897e
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: a3e90e64caef9a347ced38fd61a5aae3f3572146
https://github.com/Perl/perl5/commit/a3e90e64caef9a347ced38fd61a5aae3f3572146
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 9d3c219c9e36ff89f73842892658f47662256e8a
https://github.com/Perl/perl5/commit/9d3c219c9e36ff89f73842892658f47662256e8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_COLLATION handled the possibility of
being passed a NULL locale name. But we're not changing things unless
we have a new locale, and know its name.
Commit: 1c38201e0d429de8c90a997ba04d6df66845c6cd
https://github.com/Perl/perl5/commit/1c38201e0d429de8c90a997ba04d6df66845c6cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: ba13db34083db22feb9e1c5fff58079aea392195
https://github.com/Perl/perl5/commit/ba13db34083db22feb9e1c5fff58079aea392195
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: c379ef1c2bc18db7724a1a3b4b64ba3ae8af8dd0
https://github.com/Perl/perl5/commit/c379ef1c2bc18db7724a1a3b4b64ba3ae8af8dd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 07302762564b9f8839f99fea3b489deb71a19fc6
https://github.com/Perl/perl5/commit/07302762564b9f8839f99fea3b489deb71a19fc6
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
Log Message:
-----------
f
Commit: 3964154e103d4a479645b2ec3f9066163b890651
https://github.com/Perl/perl5/commit/3964154e103d4a479645b2ec3f9066163b890651
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Add missing SKIP: label
Commit: c2ad139ab4b07d7ee224ba49aceec02ce2bfab4d
https://github.com/Perl/perl5/commit/c2ad139ab4b07d7ee224ba49aceec02ce2bfab4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Fix tests
This was misleadingly outputting an undef value, instead of just saying
it's undef
Commit: 4225ee75a7a3d6dd9d45189aa1e3da7dfabd324f
https://github.com/Perl/perl5/commit/4225ee75a7a3d6dd9d45189aa1e3da7dfabd324f
Author: Karl Williamson <[email protected]>
Date: 2021-04-01 (Thu, 01 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M ext/XS-APItest/t/locale.t
M handy.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M proto.h
Log Message:
-----------
more4
Compare: https://github.com/Perl/perl5/compare/fd447e13a05b...4225ee75a7a3
