Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: d74a55d8c7c328b543200160cf1c4a6534f790bf
https://github.com/Perl/perl5/commit/d74a55d8c7c328b543200160cf1c4a6534f790bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: d9451b1dbbcfbabbaef9d0f332ded014c466933a
https://github.com/Perl/perl5/commit/d9451b1dbbcfbabbaef9d0f332ded014c466933a
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 1034598b2f9974d45b71445db9ec1972f6024d16
https://github.com/Perl/perl5/commit/1034598b2f9974d45b71445db9ec1972f6024d16
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: ece242d1e315d06e3a2efa1744d8eec067123b2b
https://github.com/Perl/perl5/commit/ece242d1e315d06e3a2efa1744d8eec067123b2b
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 27433c84603aa6ed3882f767e5c6c4e7701997aa
https://github.com/Perl/perl5/commit/27433c84603aa6ed3882f767e5c6c4e7701997aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 7a15913cb33ac1b1d99728f9b0fe584bf2e78608
https://github.com/Perl/perl5/commit/7a15913cb33ac1b1d99728f9b0fe584bf2e78608
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: ea6b59b52fa5b5928c6c76920cdba38e7c793889
https://github.com/Perl/perl5/commit/ea6b59b52fa5b5928c6c76920cdba38e7c793889
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 4455b1724ff48f871d727a32a4a71977a857e56f
https://github.com/Perl/perl5/commit/4455b1724ff48f871d727a32a4a71977a857e56f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 3aa6b77513a18f11a2e7c3e9465c6fa6ed929c65
https://github.com/Perl/perl5/commit/3aa6b77513a18f11a2e7c3e9465c6fa6ed929c65
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 46c5c47701dfb888960517c9343acfa57e5033a1
https://github.com/Perl/perl5/commit/46c5c47701dfb888960517c9343acfa57e5033a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 6ad37865a8320cb8090e034cadba60b26f74529d
https://github.com/Perl/perl5/commit/6ad37865a8320cb8090e034cadba60b26f74529d
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 72f2c9d9c9e2f071bae69f2882a4242b950f9f2c
https://github.com/Perl/perl5/commit/72f2c9d9c9e2f071bae69f2882a4242b950f9f2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 118564433d471fc219897dc935b9677f7e3a1ded
https://github.com/Perl/perl5/commit/118564433d471fc219897dc935b9677f7e3a1ded
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: f944d8c39c3b63977a17b38e55ead103c0a5d194
https://github.com/Perl/perl5/commit/f944d8c39c3b63977a17b38e55ead103c0a5d194
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: be773337b75c2e3ca14b8cbf99c9fb6fc64671a6
https://github.com/Perl/perl5/commit/be773337b75c2e3ca14b8cbf99c9fb6fc64671a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: e3b0af0ea2d0bd65ca82b5493999021d26f27184
https://github.com/Perl/perl5/commit/e3b0af0ea2d0bd65ca82b5493999021d26f27184
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: f687f69031e153672808bd39cb675d8a84d349ea
https://github.com/Perl/perl5/commit/f687f69031e153672808bd39cb675d8a84d349ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 0ff4bc660dda3ea553f067210038b1ff51bc1f35
https://github.com/Perl/perl5/commit/0ff4bc660dda3ea553f067210038b1ff51bc1f35
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: df7d163d5f6a647f3dea9d689b8c876137db1664
https://github.com/Perl/perl5/commit/df7d163d5f6a647f3dea9d689b8c876137db1664
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 5efa7ad039a06c3c63ce29fb37a3594e2040b4d8
https://github.com/Perl/perl5/commit/5efa7ad039a06c3c63ce29fb37a3594e2040b4d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: d7b3037b028ab4492927a44f13b66561d203aeda
https://github.com/Perl/perl5/commit/d7b3037b028ab4492927a44f13b66561d203aeda
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 8c43213d907f9119a041d7772f423927062b8d18
https://github.com/Perl/perl5/commit/8c43213d907f9119a041d7772f423927062b8d18
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: cd202f3bcd6d3ce463710aa0c477edf33bc5f78f
https://github.com/Perl/perl5/commit/cd202f3bcd6d3ce463710aa0c477edf33bc5f78f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 45e312cb1470d4e5f689d9a60ca2919872cfa45f
https://github.com/Perl/perl5/commit/45e312cb1470d4e5f689d9a60ca2919872cfa45f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: c5923d4a7a2fe6816e5a4d73c4c66ce6f4b752f9
https://github.com/Perl/perl5/commit/c5923d4a7a2fe6816e5a4d73c4c66ce6f4b752f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: be990c64652e2e3a9766a4023cf53a1aa4d78925
https://github.com/Perl/perl5/commit/be990c64652e2e3a9766a4023cf53a1aa4d78925
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 3db46c126b712520bd6ec4f554993b2eb1be6cb6
https://github.com/Perl/perl5/commit/3db46c126b712520bd6ec4f554993b2eb1be6cb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 1a82facb5f45a51364cb74693b10af70ba052efc
https://github.com/Perl/perl5/commit/1a82facb5f45a51364cb74693b10af70ba052efc
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: f31f7feacfc500292b859aeeacd9af293bf005fe
https://github.com/Perl/perl5/commit/f31f7feacfc500292b859aeeacd9af293bf005fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: e6264aca2f394a4a9aa4ce7f64b2388f601088e0
https://github.com/Perl/perl5/commit/e6264aca2f394a4a9aa4ce7f64b2388f601088e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: dc97117896afa067154557e2d5ac71dafbc53429
https://github.com/Perl/perl5/commit/dc97117896afa067154557e2d5ac71dafbc53429
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 13cb1de7fe4438b60b89c76000d202fbfaa21a80
https://github.com/Perl/perl5/commit/13cb1de7fe4438b60b89c76000d202fbfaa21a80
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 8e5225bf95106a75ef83f3cc72364199bd97469a
https://github.com/Perl/perl5/commit/8e5225bf95106a75ef83f3cc72364199bd97469a
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 2a7d15d2e441e97b7b757cf464cf15517c5bfee4
https://github.com/Perl/perl5/commit/2a7d15d2e441e97b7b757cf464cf15517c5bfee4
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 4c6d82b3b4c76807acd37358fd814acb3340ec97
https://github.com/Perl/perl5/commit/4c6d82b3b4c76807acd37358fd814acb3340ec97
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 8bb4fe8e494a9dda1abfdb82682e6f23e0378162
https://github.com/Perl/perl5/commit/8bb4fe8e494a9dda1abfdb82682e6f23e0378162
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: cbc8766348c3572321692c375771a360e85349e5
https://github.com/Perl/perl5/commit/cbc8766348c3572321692c375771a360e85349e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 195f5b369d51c875388e2310a6919badd86a9794
https://github.com/Perl/perl5/commit/195f5b369d51c875388e2310a6919badd86a9794
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: edb1238492278b71907f05f640a53b19f41539d9
https://github.com/Perl/perl5/commit/edb1238492278b71907f05f640a53b19f41539d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 274ab51c85381b561b49253591afb651bc1773ad
https://github.com/Perl/perl5/commit/274ab51c85381b561b49253591afb651bc1773ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: cb32358b56d87a53bf6053bd552dc819da491787
https://github.com/Perl/perl5/commit/cb32358b56d87a53bf6053bd552dc819da491787
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 5b9e6da67b940a6703303546a30c4e8964ac6659
https://github.com/Perl/perl5/commit/5b9e6da67b940a6703303546a30c4e8964ac6659
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 55b38d8f4a5cbc20a90451083b6d3945394358b9
https://github.com/Perl/perl5/commit/55b38d8f4a5cbc20a90451083b6d3945394358b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: de41b7a99c0791a1df4cc23a10f0a206224abf5c
https://github.com/Perl/perl5/commit/de41b7a99c0791a1df4cc23a10f0a206224abf5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: a5d1962c828e9762fc0b8d426c297fafd1105843
https://github.com/Perl/perl5/commit/a5d1962c828e9762fc0b8d426c297fafd1105843
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: dbc14d995f6609399f9865bb58004a2522b0403c
https://github.com/Perl/perl5/commit/dbc14d995f6609399f9865bb58004a2522b0403c
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 8cf13dc8c90f71c593078ae2cc3e890212ac20bf
https://github.com/Perl/perl5/commit/8cf13dc8c90f71c593078ae2cc3e890212ac20bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 79b306585b9bcafa876b7d944729003fd38f9c9e
https://github.com/Perl/perl5/commit/79b306585b9bcafa876b7d944729003fd38f9c9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: d3cb7bca483a5aca04bdc866152bdf0ecb034b16
https://github.com/Perl/perl5/commit/d3cb7bca483a5aca04bdc866152bdf0ecb034b16
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: cee77ea148f83e9b9a1adf8d565b1c801ed57ac4
https://github.com/Perl/perl5/commit/cee77ea148f83e9b9a1adf8d565b1c801ed57ac4
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 7bb779f844763a168175aa1d120de87968c3d205
https://github.com/Perl/perl5/commit/7bb779f844763a168175aa1d120de87968c3d205
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 174dcebeac777371b056d132212e114912dfae1d
https://github.com/Perl/perl5/commit/174dcebeac777371b056d132212e114912dfae1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: cc6f2c5c529952bee107955e6e5342fa7916d952
https://github.com/Perl/perl5/commit/cc6f2c5c529952bee107955e6e5342fa7916d952
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: b2e85146041dd730ac8151f61e49b545bea16eb9
https://github.com/Perl/perl5/commit/b2e85146041dd730ac8151f61e49b545bea16eb9
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 10db6b3a3297b40e86c300a4b8f9a3fc98239e82
https://github.com/Perl/perl5/commit/10db6b3a3297b40e86c300a4b8f9a3fc98239e82
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 8d3fda9691246013941c0dfa63585d847333c60f
https://github.com/Perl/perl5/commit/8d3fda9691246013941c0dfa63585d847333c60f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: ecac205c59a21682b951e74b7e9bdd144d6b8154
https://github.com/Perl/perl5/commit/ecac205c59a21682b951e74b7e9bdd144d6b8154
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 36cb92b603f6b72e6c312e9b6e527cce3620ab31
https://github.com/Perl/perl5/commit/36cb92b603f6b72e6c312e9b6e527cce3620ab31
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: bfda6d58ef14c07b48e11ada1d706c231e407399
https://github.com/Perl/perl5/commit/bfda6d58ef14c07b48e11ada1d706c231e407399
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 8ec58e69f5c1810218413fec4006e9dacb82dbab
https://github.com/Perl/perl5/commit/8ec58e69f5c1810218413fec4006e9dacb82dbab
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: 4a28c30ee0b192a8f1672a6069799123b833d1da
https://github.com/Perl/perl5/commit/4a28c30ee0b192a8f1672a6069799123b833d1da
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: cd29d0bb9e6b88db54f9cb35668de58a2a8a553b
https://github.com/Perl/perl5/commit/cd29d0bb9e6b88db54f9cb35668de58a2a8a553b
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 172a247523b1c5ac0fccf967476aef8c287f07d1
https://github.com/Perl/perl5/commit/172a247523b1c5ac0fccf967476aef8c287f07d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 9c46237cba31a636d2011ee3018e17c177a7ef92
https://github.com/Perl/perl5/commit/9c46237cba31a636d2011ee3018e17c177a7ef92
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: f5c1ebca81f0e3023df59bc63e52191a970455a1
https://github.com/Perl/perl5/commit/f5c1ebca81f0e3023df59bc63e52191a970455a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: bbef71da3201b8e79dbe92eaf0c2b4665805220b
https://github.com/Perl/perl5/commit/bbef71da3201b8e79dbe92eaf0c2b4665805220b
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 57fd442bc9d0baff358e9f5a40121d893da51575
https://github.com/Perl/perl5/commit/57fd442bc9d0baff358e9f5a40121d893da51575
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 8dda105149a633a4dda8e81eca41ac768ea21e49
https://github.com/Perl/perl5/commit/8dda105149a633a4dda8e81eca41ac768ea21e49
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 61fc0df03ca882e032e3ff2cad733fb1edb38586
https://github.com/Perl/perl5/commit/61fc0df03ca882e032e3ff2cad733fb1edb38586
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 02c809a31469eac44a22e52caabdbd3f4ec031e4
https://github.com/Perl/perl5/commit/02c809a31469eac44a22e52caabdbd3f4ec031e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: fd5486d300942601ee421bd0c12fc4b1fbb80d19
https://github.com/Perl/perl5/commit/fd5486d300942601ee421bd0c12fc4b1fbb80d19
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 8de2d391083e99f79d251e797323d692e3fd5fe9
https://github.com/Perl/perl5/commit/8de2d391083e99f79d251e797323d692e3fd5fe9
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: e3266790d76477bc24dfb5b3ebd1fae193bc4670
https://github.com/Perl/perl5/commit/e3266790d76477bc24dfb5b3ebd1fae193bc4670
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 0e55ca0734277cd73ae1fdf7fcd3ea5c3d6e75b7
https://github.com/Perl/perl5/commit/0e55ca0734277cd73ae1fdf7fcd3ea5c3d6e75b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: dd6c0b7b6ca3265c44f8653a1ea815bb1e58cc09
https://github.com/Perl/perl5/commit/dd6c0b7b6ca3265c44f8653a1ea815bb1e58cc09
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: f421de24c85b1326b7bb629756e8e491d268dbe0
https://github.com/Perl/perl5/commit/f421de24c85b1326b7bb629756e8e491d268dbe0
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 4e3cf31b7ab852a8121c4b916af1a0ed8be40822
https://github.com/Perl/perl5/commit/4e3cf31b7ab852a8121c4b916af1a0ed8be40822
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 841092b49a50c4bd10ed57b27dd220b40ba1df74
https://github.com/Perl/perl5/commit/841092b49a50c4bd10ed57b27dd220b40ba1df74
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: ad9706cac70e1542dc0a49200386adf620a8ee06
https://github.com/Perl/perl5/commit/ad9706cac70e1542dc0a49200386adf620a8ee06
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 26189a62c1ee1b67b5e0e837aef66173fdbe7128
https://github.com/Perl/perl5/commit/26189a62c1ee1b67b5e0e837aef66173fdbe7128
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 03e784c839360a610f33ad786610d23e4eeb2143
https://github.com/Perl/perl5/commit/03e784c839360a610f33ad786610d23e4eeb2143
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 7ad190ab5e433073dd0ece79dc21d1c30e90430c
https://github.com/Perl/perl5/commit/7ad190ab5e433073dd0ece79dc21d1c30e90430c
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: e25248aa027c0483fc80c56a07b22ae7c4f534e1
https://github.com/Perl/perl5/commit/e25248aa027c0483fc80c56a07b22ae7c4f534e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 5353c4400cb150981112898e8bc05f5296f44963
https://github.com/Perl/perl5/commit/5353c4400cb150981112898e8bc05f5296f44963
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 0ef5271c8af2b1ca3e81d1199b2121a6d0a22134
https://github.com/Perl/perl5/commit/0ef5271c8af2b1ca3e81d1199b2121a6d0a22134
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I now have seen evidence this guess was wrong, so give up
on it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: a83e1d4bda9badddb5117bbcb6ed05f993836c1f
https://github.com/Perl/perl5/commit/a83e1d4bda9badddb5117bbcb6ed05f993836c1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 5384937b35a0b814a7f4ef31634d309b4f605ec7
https://github.com/Perl/perl5/commit/5384937b35a0b814a7f4ef31634d309b4f605ec7
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: c5faba95ee0809230099f1ba292dddcd039958a4
https://github.com/Perl/perl5/commit/c5faba95ee0809230099f1ba292dddcd039958a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 71bea3b603ececb3aad81330ed6363b357e4d0cb
https://github.com/Perl/perl5/commit/71bea3b603ececb3aad81330ed6363b357e4d0cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: f1c33383995dcdcd298a378f936085032cf2763a
https://github.com/Perl/perl5/commit/f1c33383995dcdcd298a378f936085032cf2763a
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: e9012da8a1caaf2147d946aa297c96021d919df4
https://github.com/Perl/perl5/commit/e9012da8a1caaf2147d946aa297c96021d919df4
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 944ca9feb5dd58e5e98500b52c1277ab9631070b
https://github.com/Perl/perl5/commit/944ca9feb5dd58e5e98500b52c1277ab9631070b
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: c2bc04a68073d31565e40a6966a65b47b487f6c0
https://github.com/Perl/perl5/commit/c2bc04a68073d31565e40a6966a65b47b487f6c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 0cc2a2855062773af0848da8a18f6d2abf27ea69
https://github.com/Perl/perl5/commit/0cc2a2855062773af0848da8a18f6d2abf27ea69
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 0a5e0ae351dad07c0915d6b3aaea2de987a3b631
https://github.com/Perl/perl5/commit/0a5e0ae351dad07c0915d6b3aaea2de987a3b631
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: cfbdae743f84f23cbebaced7976dde7887d4e4a2
https://github.com/Perl/perl5/commit/cfbdae743f84f23cbebaced7976dde7887d4e4a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 5789443bcd2018ce0f627e026b502683564b0737
https://github.com/Perl/perl5/commit/5789443bcd2018ce0f627e026b502683564b0737
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 254f01a224700748709c62546c82df55383340ae
https://github.com/Perl/perl5/commit/254f01a224700748709c62546c82df55383340ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 656c69f074141a4b0d6472944942a67544ccb4cb
https://github.com/Perl/perl5/commit/656c69f074141a4b0d6472944942a67544ccb4cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 3d6e254beafaaf58397206eed987324bc0ba90d8
https://github.com/Perl/perl5/commit/3d6e254beafaaf58397206eed987324bc0ba90d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: c14928538e87d2f5005291bd70a26ca4e592ac78
https://github.com/Perl/perl5/commit/c14928538e87d2f5005291bd70a26ca4e592ac78
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 45a6b7fbd999a821118488581a1aa59e86178c6f
https://github.com/Perl/perl5/commit/45a6b7fbd999a821118488581a1aa59e86178c6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 9f497a20a0087693eb92fbb287b201bb5137cbc8
https://github.com/Perl/perl5/commit/9f497a20a0087693eb92fbb287b201bb5137cbc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 0ed6ffa3651a9fc0efb5580a29b74f947d7223ae
https://github.com/Perl/perl5/commit/0ed6ffa3651a9fc0efb5580a29b74f947d7223ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 6a9e040d1eebd1e04e8fb5312b7a37dd0c5e9d22
https://github.com/Perl/perl5/commit/6a9e040d1eebd1e04e8fb5312b7a37dd0c5e9d22
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 07544383e2797b405f00082e0192f50337b3aafd
https://github.com/Perl/perl5/commit/07544383e2797b405f00082e0192f50337b3aafd
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 6f0030a5e95ca814fba2d18bef31c9e0c7fb8bbb
https://github.com/Perl/perl5/commit/6f0030a5e95ca814fba2d18bef31c9e0c7fb8bbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 7edbdbbf9a61220631fb80e474125e00261e2684
https://github.com/Perl/perl5/commit/7edbdbbf9a61220631fb80e474125e00261e2684
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 785ca63f8587caa40dca61c4a58cd2d182b7192d
https://github.com/Perl/perl5/commit/785ca63f8587caa40dca61c4a58cd2d182b7192d
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 6253c778e02121e72b110ff3016a1353a4a5c4ad
https://github.com/Perl/perl5/commit/6253c778e02121e72b110ff3016a1353a4a5c4ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 251c8893d9237b49950dc4fca32f20fe037d8bb6
https://github.com/Perl/perl5/commit/251c8893d9237b49950dc4fca32f20fe037d8bb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 8224410ef4606cddd3fcbdd9e975d9943c9c9444
https://github.com/Perl/perl5/commit/8224410ef4606cddd3fcbdd9e975d9943c9c9444
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 42564ac68fd88e0b4db21bd068b2b7a1f12bc033
https://github.com/Perl/perl5/commit/42564ac68fd88e0b4db21bd068b2b7a1f12bc033
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: 7e23c592169d5516577b2ec2d578de80c81ae697
https://github.com/Perl/perl5/commit/7e23c592169d5516577b2ec2d578de80c81ae697
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: b7ac5c613895d31a06bf020df4ec7b67b33dbc7c
https://github.com/Perl/perl5/commit/b7ac5c613895d31a06bf020df4ec7b67b33dbc7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 4965eac1f38380301d2cf12e1145c3953446240f
https://github.com/Perl/perl5/commit/4965eac1f38380301d2cf12e1145c3953446240f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: e868316d5c18c7e67f301fa80b7d734017289627
https://github.com/Perl/perl5/commit/e868316d5c18c7e67f301fa80b7d734017289627
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 68cc96fc41b21e355f49166604730f2c4e641f1e
https://github.com/Perl/perl5/commit/68cc96fc41b21e355f49166604730f2c4e641f1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 745a190ed3115e45462617147b8235cba1adf8f2
https://github.com/Perl/perl5/commit/745a190ed3115e45462617147b8235cba1adf8f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 8a62b23137aad45ffcaafe2e3aa14511c017323e
https://github.com/Perl/perl5/commit/8a62b23137aad45ffcaafe2e3aa14511c017323e
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: db3e779c468fec3bf7b659d88f59b6d55efd9ce9
https://github.com/Perl/perl5/commit/db3e779c468fec3bf7b659d88f59b6d55efd9ce9
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: d70f42c3741f403f3cdf03033241c3c776298a6f
https://github.com/Perl/perl5/commit/d70f42c3741f403f3cdf03033241c3c776298a6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 2b331a7cb8504e7e21cc15ae92837228f9d25db3
https://github.com/Perl/perl5/commit/2b331a7cb8504e7e21cc15ae92837228f9d25db3
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 4d830e76244dfad155ee9ddca285984f9a697787
https://github.com/Perl/perl5/commit/4d830e76244dfad155ee9ddca285984f9a697787
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: e9b9ff623afd4ae4258508b219f35f8bbf4059cc
https://github.com/Perl/perl5/commit/e9b9ff623afd4ae4258508b219f35f8bbf4059cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 55d1ca27fe4cf58f8b59ca143b15f253283779a4
https://github.com/Perl/perl5/commit/55d1ca27fe4cf58f8b59ca143b15f253283779a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 5c2ea0e4085fcde6b7964c0376717842c2ac37a4
https://github.com/Perl/perl5/commit/5c2ea0e4085fcde6b7964c0376717842c2ac37a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: f2e71d72d5a923bf7dfce572ed0238d36c301400
https://github.com/Perl/perl5/commit/f2e71d72d5a923bf7dfce572ed0238d36c301400
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: caf00cb5921ad565fa429dcd7a8561053cb882f6
https://github.com/Perl/perl5/commit/caf00cb5921ad565fa429dcd7a8561053cb882f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 978ee52d6f77227ab6a59083077d586be8442838
https://github.com/Perl/perl5/commit/978ee52d6f77227ab6a59083077d586be8442838
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 52a246b68199ed669a563fab2b19b7e35a35f5e5
https://github.com/Perl/perl5/commit/52a246b68199ed669a563fab2b19b7e35a35f5e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 990e4e58e39105acf41e31366d524544c5184f77
https://github.com/Perl/perl5/commit/990e4e58e39105acf41e31366d524544c5184f77
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 69f072f7493964d0e5b283b7c1ec99da0694e18d
https://github.com/Perl/perl5/commit/69f072f7493964d0e5b283b7c1ec99da0694e18d
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 0e19d8c79d512334e81f9bed0d00cda9d00a4765
https://github.com/Perl/perl5/commit/0e19d8c79d512334e81f9bed0d00cda9d00a4765
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 66ca03888dde7caf927d1352da147d498e6d75a6
https://github.com/Perl/perl5/commit/66ca03888dde7caf927d1352da147d498e6d75a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: fb72b5752f9f28f055ddb306d9a67f2494f9a5e3
https://github.com/Perl/perl5/commit/fb72b5752f9f28f055ddb306d9a67f2494f9a5e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 39d178a50d1056a7f6c2a931defcf66a4ed6f1cf
https://github.com/Perl/perl5/commit/39d178a50d1056a7f6c2a931defcf66a4ed6f1cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 11d428234bb1836aa78b46da93fa980011cc6bbf
https://github.com/Perl/perl5/commit/11d428234bb1836aa78b46da93fa980011cc6bbf
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 1824537ca50d7c01154249b5991642d5e42f42c7
https://github.com/Perl/perl5/commit/1824537ca50d7c01154249b5991642d5e42f42c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: fc20a6e8ea925030c022a3366a966bd41efde23f
https://github.com/Perl/perl5/commit/fc20a6e8ea925030c022a3366a966bd41efde23f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: f1ba3457e534cdc1886f71f0b6385141a533c1dc
https://github.com/Perl/perl5/commit/f1ba3457e534cdc1886f71f0b6385141a533c1dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 06b3e3583f56393739aff8cb473c3f2a183dedc1
https://github.com/Perl/perl5/commit/06b3e3583f56393739aff8cb473c3f2a183dedc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 5cdee3cb0344d2003ec8a53d0a236a62575461e4
https://github.com/Perl/perl5/commit/5cdee3cb0344d2003ec8a53d0a236a62575461e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 6b3bc4c0ec84f56fd55fa4269706eb5390d81a73
https://github.com/Perl/perl5/commit/6b3bc4c0ec84f56fd55fa4269706eb5390d81a73
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 4512b7b18f69c58c86fbc22b9bdfa84106842f06
https://github.com/Perl/perl5/commit/4512b7b18f69c58c86fbc22b9bdfa84106842f06
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 6ac09aa3f2af42cf3c1159b16f03cbd105db4ab4
https://github.com/Perl/perl5/commit/6ac09aa3f2af42cf3c1159b16f03cbd105db4ab4
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: edac4cad585f084bbf865a008e0f9e2d0700e024
https://github.com/Perl/perl5/commit/edac4cad585f084bbf865a008e0f9e2d0700e024
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: bcd95f3bdbdb64d59f86698e7901767298fc592e
https://github.com/Perl/perl5/commit/bcd95f3bdbdb64d59f86698e7901767298fc592e
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: c2f77737a3882cac04c32afbb348ad38ce8a9761
https://github.com/Perl/perl5/commit/c2f77737a3882cac04c32afbb348ad38ce8a9761
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: d6174cb29632d1f8b05ace9bd1865d29d8408f71
https://github.com/Perl/perl5/commit/d6174cb29632d1f8b05ace9bd1865d29d8408f71
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: ca5014a4234e96fcf270b1feca6aae2402dd5cb6
https://github.com/Perl/perl5/commit/ca5014a4234e96fcf270b1feca6aae2402dd5cb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 06b6fb9d1424c87c72adf216126c2bdd01951cc8
https://github.com/Perl/perl5/commit/06b6fb9d1424c87c72adf216126c2bdd01951cc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 055bd2b437c8398118f4cc9c13da16c6e0c3932e
https://github.com/Perl/perl5/commit/055bd2b437c8398118f4cc9c13da16c6e0c3932e
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 81409557f779779d0c9b88daf8dd8eac0ae94643
https://github.com/Perl/perl5/commit/81409557f779779d0c9b88daf8dd8eac0ae94643
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 19d34baafd53ed2d434f3052e5ceb77996ae7dbf
https://github.com/Perl/perl5/commit/19d34baafd53ed2d434f3052e5ceb77996ae7dbf
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 4722a6551c0b233706083d4c8688c0d6a72d495c
https://github.com/Perl/perl5/commit/4722a6551c0b233706083d4c8688c0d6a72d495c
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 23dd177868d1a2b1afdef79da74d93d7bb7eb619
https://github.com/Perl/perl5/commit/23dd177868d1a2b1afdef79da74d93d7bb7eb619
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 6f4d4dde8906bfa4903c39b8c2c0fbef84583dad
https://github.com/Perl/perl5/commit/6f4d4dde8906bfa4903c39b8c2c0fbef84583dad
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 8ac36633b966f79d68d625fe95abcf13f7c92cda
https://github.com/Perl/perl5/commit/8ac36633b966f79d68d625fe95abcf13f7c92cda
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 4b18356cc9eb8c9bee6fe029b1f9f949cdad7541
https://github.com/Perl/perl5/commit/4b18356cc9eb8c9bee6fe029b1f9f949cdad7541
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: bd5686b9049d942f2e3ef22b45a319c8416eb1db
https://github.com/Perl/perl5/commit/bd5686b9049d942f2e3ef22b45a319c8416eb1db
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 079acff0deb0dc6cf43ae2b15ab7af466f87393f
https://github.com/Perl/perl5/commit/079acff0deb0dc6cf43ae2b15ab7af466f87393f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 5dd7c520f131724eda7198178e8fc5c0bf63e806
https://github.com/Perl/perl5/commit/5dd7c520f131724eda7198178e8fc5c0bf63e806
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: a6d4bba3ac14f3b0fd8fd9dcf5011fb9bc522997
https://github.com/Perl/perl5/commit/a6d4bba3ac14f3b0fd8fd9dcf5011fb9bc522997
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 8aa44d140f6ecac2ba8aa019404a575ac8b70426
https://github.com/Perl/perl5/commit/8aa44d140f6ecac2ba8aa019404a575ac8b70426
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: f21ac06b7c41f2025507a86a0e2b9f076fae1370
https://github.com/Perl/perl5/commit/f21ac06b7c41f2025507a86a0e2b9f076fae1370
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 0af2cb08a31cc8cc3d6db753fbc0efbbbe1e15ef
https://github.com/Perl/perl5/commit/0af2cb08a31cc8cc3d6db753fbc0efbbbe1e15ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 23d95b4a3c49c8b713c2161938a476da8356388c
https://github.com/Perl/perl5/commit/23d95b4a3c49c8b713c2161938a476da8356388c
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 095ca8807e01ceaf0eafdd92ef4b7b452c41c591
https://github.com/Perl/perl5/commit/095ca8807e01ceaf0eafdd92ef4b7b452c41c591
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: c752c725acfbf183128382c95bfa4d862bf142c2
https://github.com/Perl/perl5/commit/c752c725acfbf183128382c95bfa4d862bf142c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 1799e2152eafa8609ef852ff805877f51096eaad
https://github.com/Perl/perl5/commit/1799e2152eafa8609ef852ff805877f51096eaad
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 1d995566372364974f23f2c2e0f1ae212254296b
https://github.com/Perl/perl5/commit/1d995566372364974f23f2c2e0f1ae212254296b
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: bf4bb74e791a15e302872017ef13cc9f5cd0ed4c
https://github.com/Perl/perl5/commit/bf4bb74e791a15e302872017ef13cc9f5cd0ed4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: d6923739094c468dbd41e023a3e087d1caf7b250
https://github.com/Perl/perl5/commit/d6923739094c468dbd41e023a3e087d1caf7b250
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: e893928f1949889cdca658efa090f49679e57860
https://github.com/Perl/perl5/commit/e893928f1949889cdca658efa090f49679e57860
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 3444d1572dc64ee23d4e4b7f96ee259b861262cf
https://github.com/Perl/perl5/commit/3444d1572dc64ee23d4e4b7f96ee259b861262cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: ac94f9ad6a0b1dac728e723e292c2f9fe2e89f7a
https://github.com/Perl/perl5/commit/ac94f9ad6a0b1dac728e723e292c2f9fe2e89f7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 5ebbe09c783e7a12379fd177e7cc1c69ee78e4f0
https://github.com/Perl/perl5/commit/5ebbe09c783e7a12379fd177e7cc1c69ee78e4f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: ab39b6bbb71cde6f22ec1d9fe6cc4efd706e1b2e
https://github.com/Perl/perl5/commit/ab39b6bbb71cde6f22ec1d9fe6cc4efd706e1b2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 1d27192023f5fc692b7dc88e3a2281a78b9fd0b1
https://github.com/Perl/perl5/commit/1d27192023f5fc692b7dc88e3a2281a78b9fd0b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: daf7b7691e97ce441ad1232bd13a89cc72b9efe2
https://github.com/Perl/perl5/commit/daf7b7691e97ce441ad1232bd13a89cc72b9efe2
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: ad0699ef52cbba5b2b0cd278d845b676c82e534f
https://github.com/Perl/perl5/commit/ad0699ef52cbba5b2b0cd278d845b676c82e534f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 144417950d345b083e0edbc6a28e2db8999c12a6
https://github.com/Perl/perl5/commit/144417950d345b083e0edbc6a28e2db8999c12a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 3ffeae51c4b5fb5d277fc38f072a78c8af803e99
https://github.com/Perl/perl5/commit/3ffeae51c4b5fb5d277fc38f072a78c8af803e99
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 57cc4d2df61f681d1671651ce8c4b60646cfac6a
https://github.com/Perl/perl5/commit/57cc4d2df61f681d1671651ce8c4b60646cfac6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: e1839cfaea74bd2869de451a98158d3c822b16cb
https://github.com/Perl/perl5/commit/e1839cfaea74bd2869de451a98158d3c822b16cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 62aabd762182ca2207cf808f81a4db42788a08c3
https://github.com/Perl/perl5/commit/62aabd762182ca2207cf808f81a4db42788a08c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: fa99155ca687d100be95f14ee7ca06781de4b038
https://github.com/Perl/perl5/commit/fa99155ca687d100be95f14ee7ca06781de4b038
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: b446be9707a35a90282ff01d7a75a2fa61cb89e5
https://github.com/Perl/perl5/commit/b446be9707a35a90282ff01d7a75a2fa61cb89e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 1661bb9d964d3a6fb7174da053270a66f555b2a1
https://github.com/Perl/perl5/commit/1661bb9d964d3a6fb7174da053270a66f555b2a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 5f774729c0e4e226bea183c29e7230b757d04180
https://github.com/Perl/perl5/commit/5f774729c0e4e226bea183c29e7230b757d04180
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: b46eff0c510a84472c3567cb5b873e44fa5194d9
https://github.com/Perl/perl5/commit/b46eff0c510a84472c3567cb5b873e44fa5194d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 641f161dc8eb539d70eb88d9f429809455ccc0a8
https://github.com/Perl/perl5/commit/641f161dc8eb539d70eb88d9f429809455ccc0a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: c23807f8a4e9e1f026ae4ab3e04de41b01c4b9ee
https://github.com/Perl/perl5/commit/c23807f8a4e9e1f026ae4ab3e04de41b01c4b9ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 29a716f12a0a8114f20c943c2bf0278e2503c270
https://github.com/Perl/perl5/commit/29a716f12a0a8114f20c943c2bf0278e2503c270
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 73dfffcd88a79a41adc97e53d9625e021cc275b5
https://github.com/Perl/perl5/commit/73dfffcd88a79a41adc97e53d9625e021cc275b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: ef97d0de8e0c6465fa2cf85c1105b9e975735e4e
https://github.com/Perl/perl5/commit/ef97d0de8e0c6465fa2cf85c1105b9e975735e4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: e4cdc15443f15958f16b8ad21347b41fdcdd5f5d
https://github.com/Perl/perl5/commit/e4cdc15443f15958f16b8ad21347b41fdcdd5f5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 5d8ee5e0440616a606bf9f63f835a483d720090f
https://github.com/Perl/perl5/commit/5d8ee5e0440616a606bf9f63f835a483d720090f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: b58abd2dc537b9f896fc82e095762aad543180af
https://github.com/Perl/perl5/commit/b58abd2dc537b9f896fc82e095762aad543180af
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 622e75a22bb1c706ea3907be1289456d8b2e53ee
https://github.com/Perl/perl5/commit/622e75a22bb1c706ea3907be1289456d8b2e53ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 03e0397551bfa342e4c2fc9323bd02d16093e997
https://github.com/Perl/perl5/commit/03e0397551bfa342e4c2fc9323bd02d16093e997
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: f96cb30159a6c2fa1ecc0b2a3f89f572a7606c3d
https://github.com/Perl/perl5/commit/f96cb30159a6c2fa1ecc0b2a3f89f572a7606c3d
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: e7e98b6f3468fcfc615a2178950c5144eceeb41c
https://github.com/Perl/perl5/commit/e7e98b6f3468fcfc615a2178950c5144eceeb41c
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 3e27019c306a9f32f76c9bec4dcba5b40984197f
https://github.com/Perl/perl5/commit/3e27019c306a9f32f76c9bec4dcba5b40984197f
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_COLLATION handled the possibility of
being passed a NULL locale name. But we're not changing things unless
we have a new locale, and know its name.
Commit: 1fc64f364c0c104fc922f165551b0f9b6a5f6f6e
https://github.com/Perl/perl5/commit/1fc64f364c0c104fc922f165551b0f9b6a5f6f6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 1a69e0ea6fdfb5957637c51abb87d3788946148e
https://github.com/Perl/perl5/commit/1a69e0ea6fdfb5957637c51abb87d3788946148e
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: a0033812a9f4daf5556f7b4c5634dc776fc12273
https://github.com/Perl/perl5/commit/a0033812a9f4daf5556f7b4c5634dc776fc12273
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 8512385b85ede73261c50e5cfc9430f6ccb1d007
https://github.com/Perl/perl5/commit/8512385b85ede73261c50e5cfc9430f6ccb1d007
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
Log Message:
-----------
f
Commit: 5b354c5b1abd5a0f760361d915d0fc195a36f0cc
https://github.com/Perl/perl5/commit/5b354c5b1abd5a0f760361d915d0fc195a36f0cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Add missing SKIP: label
Commit: d66e20c9f108daf44da9687cd1c433450bcae9b3
https://github.com/Perl/perl5/commit/d66e20c9f108daf44da9687cd1c433450bcae9b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M ext/XS-APItest/t/locale.t
Log Message:
-----------
APItest/t/locale.t: Fix tests
This was misleadingly outputting an undef value, instead of just saying
it's undef
Commit: 09c640a11df0100802b38b55fdd84e183cf73361
https://github.com/Perl/perl5/commit/09c640a11df0100802b38b55fdd84e183cf73361
Author: Karl Williamson <[email protected]>
Date: 2021-04-02 (Fri, 02 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M ext/XS-APItest/t/locale.t
M handy.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M proto.h
Log Message:
-----------
more5
Compare: https://github.com/Perl/perl5/compare/4225ee75a7a3...09c640a11df0
