Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 9b778144e6bede591d64bf420db28e71f8c1a2c0
https://github.com/Perl/perl5/commit/9b778144e6bede591d64bf420db28e71f8c1a2c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 5cab0c0c0c0c2c2276378648347d87556836b284
https://github.com/Perl/perl5/commit/5cab0c0c0c0c2c2276378648347d87556836b284
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 542b39b06aaa7ae1ef40e947c6fe703cf453ba19
https://github.com/Perl/perl5/commit/542b39b06aaa7ae1ef40e947c6fe703cf453ba19
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 55251d3ff81a885ef63cad9980bef4317c191147
https://github.com/Perl/perl5/commit/55251d3ff81a885ef63cad9980bef4317c191147
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: a00078cbd16dd40325997b808e8b4644d6abddbd
https://github.com/Perl/perl5/commit/a00078cbd16dd40325997b808e8b4644d6abddbd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: cd1246c6d183b492dac35c6566c84adce3370810
https://github.com/Perl/perl5/commit/cd1246c6d183b492dac35c6566c84adce3370810
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 6d0e59caeefea473e87fc41c563dd8952bef0687
https://github.com/Perl/perl5/commit/6d0e59caeefea473e87fc41c563dd8952bef0687
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: a2565f1f7bcc8a58445447b6d4abc691f581dfeb
https://github.com/Perl/perl5/commit/a2565f1f7bcc8a58445447b6d4abc691f581dfeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 49c6a89a4ca292ac1eaee0b7d77be6ae41719333
https://github.com/Perl/perl5/commit/49c6a89a4ca292ac1eaee0b7d77be6ae41719333
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 07e8b39f102186109bbba53bcadcfceced1c9c9f
https://github.com/Perl/perl5/commit/07e8b39f102186109bbba53bcadcfceced1c9c9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: da60f4ef10c28b5a488161a3548f9b77d145c3c4
https://github.com/Perl/perl5/commit/da60f4ef10c28b5a488161a3548f9b77d145c3c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 1bb916d59e29a3f34b746183ed3ff558f03b54cf
https://github.com/Perl/perl5/commit/1bb916d59e29a3f34b746183ed3ff558f03b54cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: a01da81fc06befc1c3110046f660899eae41bbc3
https://github.com/Perl/perl5/commit/a01da81fc06befc1c3110046f660899eae41bbc3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 245828ac2f0655c901a560fa40bf6de79369a401
https://github.com/Perl/perl5/commit/245828ac2f0655c901a560fa40bf6de79369a401
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 22a0a6fefe824337ef081a9c4c63ffa149b9275e
https://github.com/Perl/perl5/commit/22a0a6fefe824337ef081a9c4c63ffa149b9275e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 9984c3236c62b1e665367bb89a98945d2e230855
https://github.com/Perl/perl5/commit/9984c3236c62b1e665367bb89a98945d2e230855
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 75d21e1c5bc90b2015aa6ac30aff60918b3a3e7a
https://github.com/Perl/perl5/commit/75d21e1c5bc90b2015aa6ac30aff60918b3a3e7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: c11c6815ed4247944ebcccc9b7ca0a51d22e6560
https://github.com/Perl/perl5/commit/c11c6815ed4247944ebcccc9b7ca0a51d22e6560
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: f3ca0eb51f0d177c09e919c7fefb91ae350f6519
https://github.com/Perl/perl5/commit/f3ca0eb51f0d177c09e919c7fefb91ae350f6519
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: aae397fded8645cb264816a01022798db54d44cd
https://github.com/Perl/perl5/commit/aae397fded8645cb264816a01022798db54d44cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: e77347649070fa44aa3beefe70a8ef73bf24b632
https://github.com/Perl/perl5/commit/e77347649070fa44aa3beefe70a8ef73bf24b632
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 8c4b4e739f27ac9f945921fcba3bf2d88dd8468c
https://github.com/Perl/perl5/commit/8c4b4e739f27ac9f945921fcba3bf2d88dd8468c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 6302a5035ce9b25f2ae30b3d77f346b066bb5f7b
https://github.com/Perl/perl5/commit/6302a5035ce9b25f2ae30b3d77f346b066bb5f7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 4397cff1a3e8db2ed2d6d63208c940e67b955fd9
https://github.com/Perl/perl5/commit/4397cff1a3e8db2ed2d6d63208c940e67b955fd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 95c4a81db7b6eb80f3bf3f48c85160fabb676d9b
https://github.com/Perl/perl5/commit/95c4a81db7b6eb80f3bf3f48c85160fabb676d9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 1f6f932c19ad61762797addebb199f3491da84c4
https://github.com/Perl/perl5/commit/1f6f932c19ad61762797addebb199f3491da84c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: a5f50efc264350740c1eebd6debeb8e402eb9cb1
https://github.com/Perl/perl5/commit/a5f50efc264350740c1eebd6debeb8e402eb9cb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 919d53e272ff7f7c8adc08b2514e5ca8b619c7c1
https://github.com/Perl/perl5/commit/919d53e272ff7f7c8adc08b2514e5ca8b619c7c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: abd8d438dd0d4d5bd8eafe9ddfd92b797cc77d86
https://github.com/Perl/perl5/commit/abd8d438dd0d4d5bd8eafe9ddfd92b797cc77d86
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: f67c646c8f0498d01750bc1b203b4e5584d1a951
https://github.com/Perl/perl5/commit/f67c646c8f0498d01750bc1b203b4e5584d1a951
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 56539933c7f9627798985f07195e9750c8c4008c
https://github.com/Perl/perl5/commit/56539933c7f9627798985f07195e9750c8c4008c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: a9f491af9699e20ad107e9795529fcc30f9f849f
https://github.com/Perl/perl5/commit/a9f491af9699e20ad107e9795529fcc30f9f849f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: ab7a3a6d67dcfab77804140e1f845721b94ca72f
https://github.com/Perl/perl5/commit/ab7a3a6d67dcfab77804140e1f845721b94ca72f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 97d951e9957ce70934742e2e8a8f60d84d0c362f
https://github.com/Perl/perl5/commit/97d951e9957ce70934742e2e8a8f60d84d0c362f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: d2ef431f5c79d8550c183e88b152156079483f64
https://github.com/Perl/perl5/commit/d2ef431f5c79d8550c183e88b152156079483f64
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 87d0e717d06f7173925d350f5cf118859b310efa
https://github.com/Perl/perl5/commit/87d0e717d06f7173925d350f5cf118859b310efa
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 91d824a7abcd2e6eb2bb0516f67f3900a30b05de
https://github.com/Perl/perl5/commit/91d824a7abcd2e6eb2bb0516f67f3900a30b05de
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 6e25687c65897d9f0b2e384f3830061fdf4ea185
https://github.com/Perl/perl5/commit/6e25687c65897d9f0b2e384f3830061fdf4ea185
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 2e426f006d7231d5745f9e60ead103e9a9c46e7c
https://github.com/Perl/perl5/commit/2e426f006d7231d5745f9e60ead103e9a9c46e7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 1d2b79b921a1531f01e0a55916c9ffc701573368
https://github.com/Perl/perl5/commit/1d2b79b921a1531f01e0a55916c9ffc701573368
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 77ff76f57d6965b4e5087dd26e9e7225b09c1574
https://github.com/Perl/perl5/commit/77ff76f57d6965b4e5087dd26e9e7225b09c1574
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 627525168078f37d12cdd7b713f3d3bef7c14ae5
https://github.com/Perl/perl5/commit/627525168078f37d12cdd7b713f3d3bef7c14ae5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 0c3c5ffd112d539bd0e31ba4191bd8323c3b7977
https://github.com/Perl/perl5/commit/0c3c5ffd112d539bd0e31ba4191bd8323c3b7977
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 3780376d1ca0edef5ded2bf22730dfd2faa55bd5
https://github.com/Perl/perl5/commit/3780376d1ca0edef5ded2bf22730dfd2faa55bd5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 225d340c58e09d232fefb69ec5d35cd60b5120ce
https://github.com/Perl/perl5/commit/225d340c58e09d232fefb69ec5d35cd60b5120ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 6be4203e1ee2425f6167e8a2004e5eff11463932
https://github.com/Perl/perl5/commit/6be4203e1ee2425f6167e8a2004e5eff11463932
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 2b32e57f77dd9f186466d7486fda150e667f3aa4
https://github.com/Perl/perl5/commit/2b32e57f77dd9f186466d7486fda150e667f3aa4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: a3f19c2f9648910ee2b8658d550530eceb5138e2
https://github.com/Perl/perl5/commit/a3f19c2f9648910ee2b8658d550530eceb5138e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 4ed5684b1bd25273491bc4a86dd0fce77dd0ff26
https://github.com/Perl/perl5/commit/4ed5684b1bd25273491bc4a86dd0fce77dd0ff26
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 0877c038e0264a7602116f5af44f9a830e70277b
https://github.com/Perl/perl5/commit/0877c038e0264a7602116f5af44f9a830e70277b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: b723ee1ddfabca9625dac989ee0f949c40e568bf
https://github.com/Perl/perl5/commit/b723ee1ddfabca9625dac989ee0f949c40e568bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 7e876aeb35c097ba17309024c3186554be0f1395
https://github.com/Perl/perl5/commit/7e876aeb35c097ba17309024c3186554be0f1395
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 6beaf03d19cae78be3968e62972ae9adb819a338
https://github.com/Perl/perl5/commit/6beaf03d19cae78be3968e62972ae9adb819a338
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 5591f999a67d53c2ee9d3ade2453c99b6ebff0be
https://github.com/Perl/perl5/commit/5591f999a67d53c2ee9d3ade2453c99b6ebff0be
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: e0464ca1c81d87976b8d1c06d5f04d656ccbab90
https://github.com/Perl/perl5/commit/e0464ca1c81d87976b8d1c06d5f04d656ccbab90
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 4ea335ea786ea4607c3a97ff7647a03342a397b2
https://github.com/Perl/perl5/commit/4ea335ea786ea4607c3a97ff7647a03342a397b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 0a21ed980ecc592265fadef7aecf857c242ea87a
https://github.com/Perl/perl5/commit/0a21ed980ecc592265fadef7aecf857c242ea87a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 4fafe4f201f903d9d81bbfb331d2f249677278cd
https://github.com/Perl/perl5/commit/4fafe4f201f903d9d81bbfb331d2f249677278cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: 50eb9bc4ebc69cc0471ee462849dfe02ed86bb6a
https://github.com/Perl/perl5/commit/50eb9bc4ebc69cc0471ee462849dfe02ed86bb6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 1442ca123283f9ad050542cad4192afe4cba7e38
https://github.com/Perl/perl5/commit/1442ca123283f9ad050542cad4192afe4cba7e38
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: f74d21cc12b0700ac3518502dc9b0f358f0991e5
https://github.com/Perl/perl5/commit/f74d21cc12b0700ac3518502dc9b0f358f0991e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 831e0abfc70427612ee2bb761df20f7d8ed775c8
https://github.com/Perl/perl5/commit/831e0abfc70427612ee2bb761df20f7d8ed775c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 1bf4165894d6f7b9791857c0a5474cc6f8c0fbc3
https://github.com/Perl/perl5/commit/1bf4165894d6f7b9791857c0a5474cc6f8c0fbc3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: ecdabc8dd22d4bfae3ae91da2fa965cf21f547a0
https://github.com/Perl/perl5/commit/ecdabc8dd22d4bfae3ae91da2fa965cf21f547a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 549762f4dcb3d31eb338adae84d50420e5657ac0
https://github.com/Perl/perl5/commit/549762f4dcb3d31eb338adae84d50420e5657ac0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: d4a718e527beb8af66e7bad37e73d9623f7aca5a
https://github.com/Perl/perl5/commit/d4a718e527beb8af66e7bad37e73d9623f7aca5a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: ce4b756543ab836b7b9b79df4181c30a7b5278ad
https://github.com/Perl/perl5/commit/ce4b756543ab836b7b9b79df4181c30a7b5278ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 053fce3e77c816062ffdce10f6c6e497531034ca
https://github.com/Perl/perl5/commit/053fce3e77c816062ffdce10f6c6e497531034ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: ad4d24939a8557aa8ddd742f15874328c51c4d58
https://github.com/Perl/perl5/commit/ad4d24939a8557aa8ddd742f15874328c51c4d58
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 94d008165efb0d2edf2cfbd31bdc6f3a4d6b2553
https://github.com/Perl/perl5/commit/94d008165efb0d2edf2cfbd31bdc6f3a4d6b2553
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 56f8064a46a75e00e6197a84c05a20ae43c88043
https://github.com/Perl/perl5/commit/56f8064a46a75e00e6197a84c05a20ae43c88043
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 766a99fae469200922b7942a3f4439f0768882e9
https://github.com/Perl/perl5/commit/766a99fae469200922b7942a3f4439f0768882e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 75a60912a286cc13b6ffca2b43b12c05d74dcc2f
https://github.com/Perl/perl5/commit/75a60912a286cc13b6ffca2b43b12c05d74dcc2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: f15617da57cbcf945c3c8ad9ff42dea2a05c984d
https://github.com/Perl/perl5/commit/f15617da57cbcf945c3c8ad9ff42dea2a05c984d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 24e9611b7ee4102a3120d7533709fb62456ad5c2
https://github.com/Perl/perl5/commit/24e9611b7ee4102a3120d7533709fb62456ad5c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 060837571973227258c6f6e306a72b8ffddc08e1
https://github.com/Perl/perl5/commit/060837571973227258c6f6e306a72b8ffddc08e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 1f7d10ef4ad7a80d35f3fb871858364169c095bc
https://github.com/Perl/perl5/commit/1f7d10ef4ad7a80d35f3fb871858364169c095bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: e96941452842768a08c81107a661f8a76a210fd1
https://github.com/Perl/perl5/commit/e96941452842768a08c81107a661f8a76a210fd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 9e02ca4743881dd214d24da652657c6096ca99b2
https://github.com/Perl/perl5/commit/9e02ca4743881dd214d24da652657c6096ca99b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 310ed558183d509dfd3fe87c51e8bab3c47b0ea1
https://github.com/Perl/perl5/commit/310ed558183d509dfd3fe87c51e8bab3c47b0ea1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: f7feee7c2066bcc6e293a7949dd9a9fb14924085
https://github.com/Perl/perl5/commit/f7feee7c2066bcc6e293a7949dd9a9fb14924085
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 51697d4f37ca7ef30a2f1916521280a68ba341c2
https://github.com/Perl/perl5/commit/51697d4f37ca7ef30a2f1916521280a68ba341c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 53346d9c4707ad5b12a6c66925e0eba93870c854
https://github.com/Perl/perl5/commit/53346d9c4707ad5b12a6c66925e0eba93870c854
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 8fb948233ffdc661773f1248c117582f49015224
https://github.com/Perl/perl5/commit/8fb948233ffdc661773f1248c117582f49015224
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: fdcf956cd9f410c19886cfe6f83ae033468f1e34
https://github.com/Perl/perl5/commit/fdcf956cd9f410c19886cfe6f83ae033468f1e34
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 1e82c726fff67e025ad382780ef5ab0494ce84a4
https://github.com/Perl/perl5/commit/1e82c726fff67e025ad382780ef5ab0494ce84a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 57989babd0689b45e6f909fd1a8545b1e7bedf9e
https://github.com/Perl/perl5/commit/57989babd0689b45e6f909fd1a8545b1e7bedf9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: f42188597116e96b8fdb9f98f05676fa2e69cb7d
https://github.com/Perl/perl5/commit/f42188597116e96b8fdb9f98f05676fa2e69cb7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 90d2c8ee3f77cac3f203c3b3053ed56c92f19881
https://github.com/Perl/perl5/commit/90d2c8ee3f77cac3f203c3b3053ed56c92f19881
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 6a5ddb3da939f556a97d6305aea03cdbaca09f30
https://github.com/Perl/perl5/commit/6a5ddb3da939f556a97d6305aea03cdbaca09f30
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 9039e57b654b77d90458a9b7456d339938e130ec
https://github.com/Perl/perl5/commit/9039e57b654b77d90458a9b7456d339938e130ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 66e94649776d95eb0f9387714b201ffdaa15f2b4
https://github.com/Perl/perl5/commit/66e94649776d95eb0f9387714b201ffdaa15f2b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: d888f3d91cabc0583c0209b34c26188a9bdb85f5
https://github.com/Perl/perl5/commit/d888f3d91cabc0583c0209b34c26188a9bdb85f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: cfdcfbae890d01150252e367fc13fece1f8c5958
https://github.com/Perl/perl5/commit/cfdcfbae890d01150252e367fc13fece1f8c5958
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 1d30290e865e3d5582e0d8abfd0315e067017ac6
https://github.com/Perl/perl5/commit/1d30290e865e3d5582e0d8abfd0315e067017ac6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 34444f512618b33b5c977b5c5e75b6eead3f9db1
https://github.com/Perl/perl5/commit/34444f512618b33b5c977b5c5e75b6eead3f9db1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: a369ad5f14b3363b8cda074ed91e0878a86a5bb4
https://github.com/Perl/perl5/commit/a369ad5f14b3363b8cda074ed91e0878a86a5bb4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: df799f91bac6625d37a8d22cf75ae6769216bd02
https://github.com/Perl/perl5/commit/df799f91bac6625d37a8d22cf75ae6769216bd02
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 510a46d8e00d5c2f48021ffdbda12f5978d6beb7
https://github.com/Perl/perl5/commit/510a46d8e00d5c2f48021ffdbda12f5978d6beb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: d3d373abd2c34c6b202ef7e9afb342b4d382f8b8
https://github.com/Perl/perl5/commit/d3d373abd2c34c6b202ef7e9afb342b4d382f8b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 7644aa6e497d400959f3586e77684798f1041b1c
https://github.com/Perl/perl5/commit/7644aa6e497d400959f3586e77684798f1041b1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 67d1914606c96e435091062407f5bc0d2b2824f2
https://github.com/Perl/perl5/commit/67d1914606c96e435091062407f5bc0d2b2824f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: c6f88bc432402481cd4956320d0fcd9cb50cd7b2
https://github.com/Perl/perl5/commit/c6f88bc432402481cd4956320d0fcd9cb50cd7b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 9cad6b4cd1785efd007dc811000d46851fcad1c9
https://github.com/Perl/perl5/commit/9cad6b4cd1785efd007dc811000d46851fcad1c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 3726bea20283b5d43241adc6ecfe6f5e1be548a0
https://github.com/Perl/perl5/commit/3726bea20283b5d43241adc6ecfe6f5e1be548a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 0917bff76bfcf0c9a831fceb5911d9305b0ea4d4
https://github.com/Perl/perl5/commit/0917bff76bfcf0c9a831fceb5911d9305b0ea4d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 9a76f25c4a76a46e28f72b268a59c5faf3366b78
https://github.com/Perl/perl5/commit/9a76f25c4a76a46e28f72b268a59c5faf3366b78
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: ea800541ba232c42d679b3237b2a2f49e3d35c08
https://github.com/Perl/perl5/commit/ea800541ba232c42d679b3237b2a2f49e3d35c08
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 08e49ae1c419253ae4fdf16685e8bd36856fdaab
https://github.com/Perl/perl5/commit/08e49ae1c419253ae4fdf16685e8bd36856fdaab
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: fa8a21623a68b7a45d5b486d5dfbcbab81a59c6f
https://github.com/Perl/perl5/commit/fa8a21623a68b7a45d5b486d5dfbcbab81a59c6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 766e2b907d1ecd2da1bad89d808efd221a15a71b
https://github.com/Perl/perl5/commit/766e2b907d1ecd2da1bad89d808efd221a15a71b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: a8c76fdd6c922e3b1c820fdf6bf6c6de0749fd4e
https://github.com/Perl/perl5/commit/a8c76fdd6c922e3b1c820fdf6bf6c6de0749fd4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 13ea1515a80e2d9c65bcbe2a7721e31c0c105812
https://github.com/Perl/perl5/commit/13ea1515a80e2d9c65bcbe2a7721e31c0c105812
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: bfbdc0446f82305690e0836feb2b2f97b070036a
https://github.com/Perl/perl5/commit/bfbdc0446f82305690e0836feb2b2f97b070036a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 10210201de4076831db9c6b871ca63bb83f12fdb
https://github.com/Perl/perl5/commit/10210201de4076831db9c6b871ca63bb83f12fdb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: b05fbde625d49e23edf8c68526745d0af7ed5c4c
https://github.com/Perl/perl5/commit/b05fbde625d49e23edf8c68526745d0af7ed5c4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: ba063963813f8cdbe647a450e88e670a3f8a0253
https://github.com/Perl/perl5/commit/ba063963813f8cdbe647a450e88e670a3f8a0253
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: f94f9e2e8fa78018d441f0f664b51aafbe41e69f
https://github.com/Perl/perl5/commit/f94f9e2e8fa78018d441f0f664b51aafbe41e69f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 581d8b04323d534d6214363621a1d996b6c7f671
https://github.com/Perl/perl5/commit/581d8b04323d534d6214363621a1d996b6c7f671
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 5416b03b62cd0a57b51aca170b9fac9f4db14b0a
https://github.com/Perl/perl5/commit/5416b03b62cd0a57b51aca170b9fac9f4db14b0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 1938da4eec012ded7eac57abf6aced83fd892029
https://github.com/Perl/perl5/commit/1938da4eec012ded7eac57abf6aced83fd892029
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 8ad88fab6e4a6907b9d477f11a617be91bf47706
https://github.com/Perl/perl5/commit/8ad88fab6e4a6907b9d477f11a617be91bf47706
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 4f1b8ffd8814c74ec9b9283fbc02b7d3f7bc41de
https://github.com/Perl/perl5/commit/4f1b8ffd8814c74ec9b9283fbc02b7d3f7bc41de
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 7c9508cee8dfb97350151c71b6f3d43dd58f1b49
https://github.com/Perl/perl5/commit/7c9508cee8dfb97350151c71b6f3d43dd58f1b49
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 0a2adc9e7f49c9c35034bd2c70ff5a37c55bdf19
https://github.com/Perl/perl5/commit/0a2adc9e7f49c9c35034bd2c70ff5a37c55bdf19
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 2ab41294082e57be5e571340de1e28e6a91536ac
https://github.com/Perl/perl5/commit/2ab41294082e57be5e571340de1e28e6a91536ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 20989624b710ce92e494b07e877c007516a5a111
https://github.com/Perl/perl5/commit/20989624b710ce92e494b07e877c007516a5a111
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 8a84412af97edec6f9943d73d5324fe424e3d5a6
https://github.com/Perl/perl5/commit/8a84412af97edec6f9943d73d5324fe424e3d5a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 86924a9a8b67d626ea8fc1af95656b85e250311d
https://github.com/Perl/perl5/commit/86924a9a8b67d626ea8fc1af95656b85e250311d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 33d0f5a5dcc1704694fa807070550b402a0f70a8
https://github.com/Perl/perl5/commit/33d0f5a5dcc1704694fa807070550b402a0f70a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: e0e6d567e80fba622256305760f0c961d58fcc0f
https://github.com/Perl/perl5/commit/e0e6d567e80fba622256305760f0c961d58fcc0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 2abfcd6b0dd5a588e1638691fcf7c0829002d490
https://github.com/Perl/perl5/commit/2abfcd6b0dd5a588e1638691fcf7c0829002d490
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 66473dfbbde4f4c5b24fca3e16fa0dcb0fe86b1b
https://github.com/Perl/perl5/commit/66473dfbbde4f4c5b24fca3e16fa0dcb0fe86b1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 8a5568d4d4cf23c19ee8ee589475eac19fa16eea
https://github.com/Perl/perl5/commit/8a5568d4d4cf23c19ee8ee589475eac19fa16eea
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 66140b053a8c1faac79c14186290bab12819befc
https://github.com/Perl/perl5/commit/66140b053a8c1faac79c14186290bab12819befc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 6d8bedeadfa3cc1ec7a15b72174358a9c69e4543
https://github.com/Perl/perl5/commit/6d8bedeadfa3cc1ec7a15b72174358a9c69e4543
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: a0c90b5aad7f85ef3282dfe861d5640f9377de8f
https://github.com/Perl/perl5/commit/a0c90b5aad7f85ef3282dfe861d5640f9377de8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 929da6b01b89f6ad6a36df1f5296bb98cc7fdf0e
https://github.com/Perl/perl5/commit/929da6b01b89f6ad6a36df1f5296bb98cc7fdf0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: b8c44545e0ae2b04055c263bf3577a4017decab7
https://github.com/Perl/perl5/commit/b8c44545e0ae2b04055c263bf3577a4017decab7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 0adae1170e2cfbe35a0015915f5d6c076b0d6e30
https://github.com/Perl/perl5/commit/0adae1170e2cfbe35a0015915f5d6c076b0d6e30
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 26475a99ced5d83b851e0a30a65ada05a0f1188b
https://github.com/Perl/perl5/commit/26475a99ced5d83b851e0a30a65ada05a0f1188b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 251bf75a0526edfc6a75738a88b48356d76afaae
https://github.com/Perl/perl5/commit/251bf75a0526edfc6a75738a88b48356d76afaae
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 06d89d110972a56ce31414870c9e4478101070c7
https://github.com/Perl/perl5/commit/06d89d110972a56ce31414870c9e4478101070c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: c1ca33dfff4b1ef31ecb113382729eef5260536d
https://github.com/Perl/perl5/commit/c1ca33dfff4b1ef31ecb113382729eef5260536d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: cbe1d2bbcbdebdc715f6adb599146f695da74f74
https://github.com/Perl/perl5/commit/cbe1d2bbcbdebdc715f6adb599146f695da74f74
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: a10c8e5a9e2eb47cf5fb046520f78b8c8f062d6f
https://github.com/Perl/perl5/commit/a10c8e5a9e2eb47cf5fb046520f78b8c8f062d6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 4d6f3d665a70a9e29afde4cadeb84a2a9801dff1
https://github.com/Perl/perl5/commit/4d6f3d665a70a9e29afde4cadeb84a2a9801dff1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 70ef11e7df781e4cfe03c9e3fd587a9d4b614eb9
https://github.com/Perl/perl5/commit/70ef11e7df781e4cfe03c9e3fd587a9d4b614eb9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 982d47a7254cf0cf8048b2be8b7eebaff47a14a2
https://github.com/Perl/perl5/commit/982d47a7254cf0cf8048b2be8b7eebaff47a14a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: acdeedb17f6dd5f08037cc33c5b326f50df05f1c
https://github.com/Perl/perl5/commit/acdeedb17f6dd5f08037cc33c5b326f50df05f1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 5cd3d13e1ceaf8951cc139385650bacbde72a3f7
https://github.com/Perl/perl5/commit/5cd3d13e1ceaf8951cc139385650bacbde72a3f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 944643dc79e5134932ffb4cc4f282220d46233f3
https://github.com/Perl/perl5/commit/944643dc79e5134932ffb4cc4f282220d46233f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: f03985ac9833e6644907304a38d74895807f5a56
https://github.com/Perl/perl5/commit/f03985ac9833e6644907304a38d74895807f5a56
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 43ede5a14b2d8c2650baaf18897d81f0fd3cb4df
https://github.com/Perl/perl5/commit/43ede5a14b2d8c2650baaf18897d81f0fd3cb4df
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 08a3c4ea559b29b67117fc69bde7b969919ab445
https://github.com/Perl/perl5/commit/08a3c4ea559b29b67117fc69bde7b969919ab445
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 4ccee8e9d241671c70d2cde0e9cda30e854ac657
https://github.com/Perl/perl5/commit/4ccee8e9d241671c70d2cde0e9cda30e854ac657
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 16040e3096baa74d99990889993960df239aff2a
https://github.com/Perl/perl5/commit/16040e3096baa74d99990889993960df239aff2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 23e859333a081df2d6859e79f3b6dcfec212192c
https://github.com/Perl/perl5/commit/23e859333a081df2d6859e79f3b6dcfec212192c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 7e50eb58488dfc9e585e65cd880024e3b18a0c3e
https://github.com/Perl/perl5/commit/7e50eb58488dfc9e585e65cd880024e3b18a0c3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: a3da15181af75b8774c14c074654bae7456f9003
https://github.com/Perl/perl5/commit/a3da15181af75b8774c14c074654bae7456f9003
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 40b227568416645f67206c521d81a3449448d6b1
https://github.com/Perl/perl5/commit/40b227568416645f67206c521d81a3449448d6b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 7c85ac4384c5f54251b3be57e5fef98caf7b0d1b
https://github.com/Perl/perl5/commit/7c85ac4384c5f54251b3be57e5fef98caf7b0d1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 526663749b624b7b2741c0337c81efceea30b025
https://github.com/Perl/perl5/commit/526663749b624b7b2741c0337c81efceea30b025
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 623a023d292128a5ef61a0f3e613d4a4b6c657ab
https://github.com/Perl/perl5/commit/623a023d292128a5ef61a0f3e613d4a4b6c657ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: e1913c5e8e1001eda8cc898c6df854674164fd96
https://github.com/Perl/perl5/commit/e1913c5e8e1001eda8cc898c6df854674164fd96
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: f3bd4fae3b83f526e544edf4595f810f793f1261
https://github.com/Perl/perl5/commit/f3bd4fae3b83f526e544edf4595f810f793f1261
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 1bdb4dcac837c497c175393187bd275f4b63a8f4
https://github.com/Perl/perl5/commit/1bdb4dcac837c497c175393187bd275f4b63a8f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 5f73bf858200c4b5a2d974f6f037b39d49b069be
https://github.com/Perl/perl5/commit/5f73bf858200c4b5a2d974f6f037b39d49b069be
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: aa1a63f7cf59beedc4811a5b1bc511c68dcdac3d
https://github.com/Perl/perl5/commit/aa1a63f7cf59beedc4811a5b1bc511c68dcdac3d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 73d5f58e4fa91ffc908899ede83f2c5ff34698a9
https://github.com/Perl/perl5/commit/73d5f58e4fa91ffc908899ede83f2c5ff34698a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: b3640271a041803d0d81c52994ceb061fc4ea595
https://github.com/Perl/perl5/commit/b3640271a041803d0d81c52994ceb061fc4ea595
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 09cadf1b053dab9e2f6205a6c03571d67e08dd83
https://github.com/Perl/perl5/commit/09cadf1b053dab9e2f6205a6c03571d67e08dd83
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 4fa78cfd7d1d58009fa283d44c42639da3efd7bb
https://github.com/Perl/perl5/commit/4fa78cfd7d1d58009fa283d44c42639da3efd7bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: cf61ec8d3418424537b66f8237c1d3cb29abedbf
https://github.com/Perl/perl5/commit/cf61ec8d3418424537b66f8237c1d3cb29abedbf
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: fabedf1feac08bcb189627cf7ee7d1b4004ec8ae
https://github.com/Perl/perl5/commit/fabedf1feac08bcb189627cf7ee7d1b4004ec8ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 4359bd441bca28548894562dab17efd72c8b1c54
https://github.com/Perl/perl5/commit/4359bd441bca28548894562dab17efd72c8b1c54
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5764a913563914ba1652d433810a927446dab68d
https://github.com/Perl/perl5/commit/5764a913563914ba1652d433810a927446dab68d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 7de16a278ff9dc8a35ece88764fa408903dc317f
https://github.com/Perl/perl5/commit/7de16a278ff9dc8a35ece88764fa408903dc317f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 13a0218f4172aa84869d049ad20912bf5162a4e6
https://github.com/Perl/perl5/commit/13a0218f4172aa84869d049ad20912bf5162a4e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 24ceb77b1478cadafb89c87a622893cf7f5b5ac0
https://github.com/Perl/perl5/commit/24ceb77b1478cadafb89c87a622893cf7f5b5ac0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 4664ae886a3c99d040ca749571f53a73356f06bb
https://github.com/Perl/perl5/commit/4664ae886a3c99d040ca749571f53a73356f06bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 49c1dd94efdedcf7699c89f8a8a793214e1cd578
https://github.com/Perl/perl5/commit/49c1dd94efdedcf7699c89f8a8a793214e1cd578
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 8cc54a4ea1baacac499ca2295bf05e7e29710b43
https://github.com/Perl/perl5/commit/8cc54a4ea1baacac499ca2295bf05e7e29710b43
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 60b46fefbcb7ea2aa8fe4a11815e7b3ac40c09af
https://github.com/Perl/perl5/commit/60b46fefbcb7ea2aa8fe4a11815e7b3ac40c09af
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: db2350e8e4a7a0775ca5fb9bfc7ddf7b59afdeb7
https://github.com/Perl/perl5/commit/db2350e8e4a7a0775ca5fb9bfc7ddf7b59afdeb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: a684d22b7be62422b1149f0edb8d18f62877db92
https://github.com/Perl/perl5/commit/a684d22b7be62422b1149f0edb8d18f62877db92
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: e90091597a39ff9ee284c4d0ddab029f80a876e8
https://github.com/Perl/perl5/commit/e90091597a39ff9ee284c4d0ddab029f80a876e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: e35fe5c19948ab8806f50e75a7ef5034149ce691
https://github.com/Perl/perl5/commit/e35fe5c19948ab8806f50e75a7ef5034149ce691
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 8a4914ecae4467950f52766c9c21c55405eb48fc
https://github.com/Perl/perl5/commit/8a4914ecae4467950f52766c9c21c55405eb48fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 9a011af995e1fbc0ffce2f5c2dcdd9f634c8a755
https://github.com/Perl/perl5/commit/9a011af995e1fbc0ffce2f5c2dcdd9f634c8a755
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 75d01f4747bfea7132982235518f136db2c0c65e
https://github.com/Perl/perl5/commit/75d01f4747bfea7132982235518f136db2c0c65e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 53c597ff98ec9f5711d28495987dce956bfd55fe
https://github.com/Perl/perl5/commit/53c597ff98ec9f5711d28495987dce956bfd55fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: d93cf61017481260c69c926756e2d75a67239cab
https://github.com/Perl/perl5/commit/d93cf61017481260c69c926756e2d75a67239cab
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: a7566082f194ef58c755adf5802525163bbff980
https://github.com/Perl/perl5/commit/a7566082f194ef58c755adf5802525163bbff980
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 42a0334bbeeff59be14bccef4b61b90e8cb84115
https://github.com/Perl/perl5/commit/42a0334bbeeff59be14bccef4b61b90e8cb84115
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 8e87ffcadaea056ad9e46a2348b340636e9d10b9
https://github.com/Perl/perl5/commit/8e87ffcadaea056ad9e46a2348b340636e9d10b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: d0ff92666500f7c8acdaa7e5961ccfbd79db7572
https://github.com/Perl/perl5/commit/d0ff92666500f7c8acdaa7e5961ccfbd79db7572
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: e9148c39e82a30ae548ca2ccf93c95cc3d94e463
https://github.com/Perl/perl5/commit/e9148c39e82a30ae548ca2ccf93c95cc3d94e463
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 5b1a9be669cc488d6896cd3fb8fa0c2e94c1564a
https://github.com/Perl/perl5/commit/5b1a9be669cc488d6896cd3fb8fa0c2e94c1564a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 9640ccb21a4366af07f11647c70b45bcd875298d
https://github.com/Perl/perl5/commit/9640ccb21a4366af07f11647c70b45bcd875298d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: af0027416d1feee89a64c7d1dc5969be7782a085
https://github.com/Perl/perl5/commit/af0027416d1feee89a64c7d1dc5969be7782a085
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 287a01fcf502c71183884ce28e470e16010bd589
https://github.com/Perl/perl5/commit/287a01fcf502c71183884ce28e470e16010bd589
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: d068b3043e88c8c4792fe44b760ea51687c8e23f
https://github.com/Perl/perl5/commit/d068b3043e88c8c4792fe44b760ea51687c8e23f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: b2ace9f8592c0f5a2ba0828220a0580ced6e17ab
https://github.com/Perl/perl5/commit/b2ace9f8592c0f5a2ba0828220a0580ced6e17ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 62ee1457dd44b377e3a91b96a5f41661e1fc1bb1
https://github.com/Perl/perl5/commit/62ee1457dd44b377e3a91b96a5f41661e1fc1bb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: acf68f76c13aad211ec7446e4e89c14574e57657
https://github.com/Perl/perl5/commit/acf68f76c13aad211ec7446e4e89c14574e57657
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: a58b141adca11506462480992ca1b6bf20bf1a06
https://github.com/Perl/perl5/commit/a58b141adca11506462480992ca1b6bf20bf1a06
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: cd389114da0e41baa634887e9a5f7a32f39af452
https://github.com/Perl/perl5/commit/cd389114da0e41baa634887e9a5f7a32f39af452
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: f3f20fbcceaecd5002401fc19a6ce81d4e6e7006
https://github.com/Perl/perl5/commit/f3f20fbcceaecd5002401fc19a6ce81d4e6e7006
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 71a270ddafdf626e0a1b3d3e3c5df027b8d5e4d5
https://github.com/Perl/perl5/commit/71a270ddafdf626e0a1b3d3e3c5df027b8d5e4d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 59c0e72cbd59844b43a58d1646afce00c664ba3a
https://github.com/Perl/perl5/commit/59c0e72cbd59844b43a58d1646afce00c664ba3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 3d8e25ae9ef7627ac10fb73834f5494d535bb919
https://github.com/Perl/perl5/commit/3d8e25ae9ef7627ac10fb73834f5494d535bb919
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 18b5ce371120b091e533c6e1dd8f66b2060f0966
https://github.com/Perl/perl5/commit/18b5ce371120b091e533c6e1dd8f66b2060f0966
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more20
Compare: https://github.com/Perl/perl5/compare/fdfff55a0cc0...18b5ce371120
