Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: f362f196c69e348df549fe6559bf43679aa2e922
https://github.com/Perl/perl5/commit/f362f196c69e348df549fe6559bf43679aa2e922
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 3dfae777003fe8597df83e8fbae57519619c8321
https://github.com/Perl/perl5/commit/3dfae777003fe8597df83e8fbae57519619c8321
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: d56255317d824cc92f17f8182b85e4976b8f04ac
https://github.com/Perl/perl5/commit/d56255317d824cc92f17f8182b85e4976b8f04ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: ab18f20b1422c3e1ca42d94f54691730106dd67f
https://github.com/Perl/perl5/commit/ab18f20b1422c3e1ca42d94f54691730106dd67f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 8db1bf5a9173a0c993600861d3734d92d3d0f172
https://github.com/Perl/perl5/commit/8db1bf5a9173a0c993600861d3734d92d3d0f172
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 5539545ea07ba7fa7578dfa74757f1ea20ea302e
https://github.com/Perl/perl5/commit/5539545ea07ba7fa7578dfa74757f1ea20ea302e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 064319af388fc3465eac2caf757d7080002b3926
https://github.com/Perl/perl5/commit/064319af388fc3465eac2caf757d7080002b3926
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 7de000ef65c1af6980509b626690de54233f8c3a
https://github.com/Perl/perl5/commit/7de000ef65c1af6980509b626690de54233f8c3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 457d33a078443d16e87a3b8e5b209a4b12698caf
https://github.com/Perl/perl5/commit/457d33a078443d16e87a3b8e5b209a4b12698caf
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 875d141b10634a48e39b33f93b88077fcac56792
https://github.com/Perl/perl5/commit/875d141b10634a48e39b33f93b88077fcac56792
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: e098201e32ef8aecb2d236e1d6e729465217847c
https://github.com/Perl/perl5/commit/e098201e32ef8aecb2d236e1d6e729465217847c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 5430da4eb3807a18e4026fc933b48d9995173790
https://github.com/Perl/perl5/commit/5430da4eb3807a18e4026fc933b48d9995173790
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: acadf9225606f36f9bd3f07cb17ebea2856db510
https://github.com/Perl/perl5/commit/acadf9225606f36f9bd3f07cb17ebea2856db510
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 9b306f4f35f1070f228da0ab5073be83ccfa33b9
https://github.com/Perl/perl5/commit/9b306f4f35f1070f228da0ab5073be83ccfa33b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 571e96d129c9b89ec470bfb9704732443d4b18ec
https://github.com/Perl/perl5/commit/571e96d129c9b89ec470bfb9704732443d4b18ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 9395cfae086e17a705da70e8694c034a68d113ab
https://github.com/Perl/perl5/commit/9395cfae086e17a705da70e8694c034a68d113ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: e1347579edd9bf66ce2b9ec7afc5d0d869929054
https://github.com/Perl/perl5/commit/e1347579edd9bf66ce2b9ec7afc5d0d869929054
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: a2ea2b12adc1f664d797c86d9196d554475efb84
https://github.com/Perl/perl5/commit/a2ea2b12adc1f664d797c86d9196d554475efb84
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: f13a3171f28655952326404b534a12fddd00e153
https://github.com/Perl/perl5/commit/f13a3171f28655952326404b534a12fddd00e153
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: fde950d1cb959f53cbe9e12502befb09e5d8b274
https://github.com/Perl/perl5/commit/fde950d1cb959f53cbe9e12502befb09e5d8b274
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: ee4e1a676df43153c31b038281d94147a0b58adb
https://github.com/Perl/perl5/commit/ee4e1a676df43153c31b038281d94147a0b58adb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: f87168227fbf46566588c8ffbe81f25336bb08a4
https://github.com/Perl/perl5/commit/f87168227fbf46566588c8ffbe81f25336bb08a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 23f845e65790a7a3aeafb748291819c06c49b56d
https://github.com/Perl/perl5/commit/23f845e65790a7a3aeafb748291819c06c49b56d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: eaa80b7563d55950ee1f281f57001f39556ffaf6
https://github.com/Perl/perl5/commit/eaa80b7563d55950ee1f281f57001f39556ffaf6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 6b33794ee3e2c233db9600145a83b2612b47d29d
https://github.com/Perl/perl5/commit/6b33794ee3e2c233db9600145a83b2612b47d29d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 76f97357e37f5718fc8bbb356374120f0f643e01
https://github.com/Perl/perl5/commit/76f97357e37f5718fc8bbb356374120f0f643e01
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 20d38d898eaa16fc507216d8dad9062158b11617
https://github.com/Perl/perl5/commit/20d38d898eaa16fc507216d8dad9062158b11617
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 44d3b86ea973ebfa9ac9ebb3954228f091239ca1
https://github.com/Perl/perl5/commit/44d3b86ea973ebfa9ac9ebb3954228f091239ca1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: b6f0af45a1ebe0589117286f0db3d8faf2a83679
https://github.com/Perl/perl5/commit/b6f0af45a1ebe0589117286f0db3d8faf2a83679
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 3dbeabbebc30e2a9fab7ecefae7f31e48d496e64
https://github.com/Perl/perl5/commit/3dbeabbebc30e2a9fab7ecefae7f31e48d496e64
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: e8c5861661c410d0356fa66b4e91b29a5ac57837
https://github.com/Perl/perl5/commit/e8c5861661c410d0356fa66b4e91b29a5ac57837
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 2418afcdd38c5e92554c31f6f47b39b875cbe6a7
https://github.com/Perl/perl5/commit/2418afcdd38c5e92554c31f6f47b39b875cbe6a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 6bdd5ca2df5b01bcd6aab5e083ede90257114f75
https://github.com/Perl/perl5/commit/6bdd5ca2df5b01bcd6aab5e083ede90257114f75
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 8844576be8eb5c33ce5ea8264431df9b01474d5b
https://github.com/Perl/perl5/commit/8844576be8eb5c33ce5ea8264431df9b01474d5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: ceedeafd68722ec4fd0e7d2ad698c899cfb17a0a
https://github.com/Perl/perl5/commit/ceedeafd68722ec4fd0e7d2ad698c899cfb17a0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 1607feed9130891fb5a78b215e2587d4bca40f05
https://github.com/Perl/perl5/commit/1607feed9130891fb5a78b215e2587d4bca40f05
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 3e2029f7879a8cf785b3af8b46eaa70be577dac0
https://github.com/Perl/perl5/commit/3e2029f7879a8cf785b3af8b46eaa70be577dac0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 49374854ecf32d03e20231b33a2f272550d2ee21
https://github.com/Perl/perl5/commit/49374854ecf32d03e20231b33a2f272550d2ee21
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: da66ffa682ae0a2ef3b2bc1040d3d730ae77970b
https://github.com/Perl/perl5/commit/da66ffa682ae0a2ef3b2bc1040d3d730ae77970b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 0e4a957add4b5b34635594261fd4a285321c3f03
https://github.com/Perl/perl5/commit/0e4a957add4b5b34635594261fd4a285321c3f03
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 5c222cad5887b207b76af6f48fc08cef47697710
https://github.com/Perl/perl5/commit/5c222cad5887b207b76af6f48fc08cef47697710
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: ab25307d069cbcff89d8b5ca3383bf19393c3a4f
https://github.com/Perl/perl5/commit/ab25307d069cbcff89d8b5ca3383bf19393c3a4f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 2bb85f77903fa0879d6c15445536de4aca89ca16
https://github.com/Perl/perl5/commit/2bb85f77903fa0879d6c15445536de4aca89ca16
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: fa48d04ef36cfa4c3238afd1d3b4a59b1f26947c
https://github.com/Perl/perl5/commit/fa48d04ef36cfa4c3238afd1d3b4a59b1f26947c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: b9672ea60898bc3f1b499e518686f1192b3f8de5
https://github.com/Perl/perl5/commit/b9672ea60898bc3f1b499e518686f1192b3f8de5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 5943b080d333ceaaa86a57f42764344a2687eeea
https://github.com/Perl/perl5/commit/5943b080d333ceaaa86a57f42764344a2687eeea
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: f19be2e4df7009d1f524546a175a0d7c22f5e0db
https://github.com/Perl/perl5/commit/f19be2e4df7009d1f524546a175a0d7c22f5e0db
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: a57273eb94eb8d71ef86336c4c6adbef5161f5c6
https://github.com/Perl/perl5/commit/a57273eb94eb8d71ef86336c4c6adbef5161f5c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 7f89652b5fd452177e12ea05f2f5ef1f89fd22b7
https://github.com/Perl/perl5/commit/7f89652b5fd452177e12ea05f2f5ef1f89fd22b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 3efd06c44a3aa596233e4dc6d552a0968fe11c8d
https://github.com/Perl/perl5/commit/3efd06c44a3aa596233e4dc6d552a0968fe11c8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: e3e77fde6cebee31809f0152d848d6aea86be9a8
https://github.com/Perl/perl5/commit/e3e77fde6cebee31809f0152d848d6aea86be9a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 639786d7edd9b43eee2ee54db235ee338116c5cf
https://github.com/Perl/perl5/commit/639786d7edd9b43eee2ee54db235ee338116c5cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: d73d7e345302bd0f66901e00ac2669e780a2fc50
https://github.com/Perl/perl5/commit/d73d7e345302bd0f66901e00ac2669e780a2fc50
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 5905241d8a7d214bfa7ceaa52b8c4cbe0649fe3a
https://github.com/Perl/perl5/commit/5905241d8a7d214bfa7ceaa52b8c4cbe0649fe3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 3eea78f63c82209a68817299ee27d099811bc0cb
https://github.com/Perl/perl5/commit/3eea78f63c82209a68817299ee27d099811bc0cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: f3f39fdc52969cdc5898583bd5609ca248864b45
https://github.com/Perl/perl5/commit/f3f39fdc52969cdc5898583bd5609ca248864b45
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: de3a71343a778af8e5f2e5064f547a1c439af985
https://github.com/Perl/perl5/commit/de3a71343a778af8e5f2e5064f547a1c439af985
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 749e0a2eb6184afa5bfe7d426709afc6e36b8daa
https://github.com/Perl/perl5/commit/749e0a2eb6184afa5bfe7d426709afc6e36b8daa
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Generalize stdsize_locale()
This function is rewritten to handle LC_ALL, and to handle certain buggy
Win32 locale names. This commit also calls it in appropriate places
where those buggy names could be returned.
setlocale() on Windows may return a locale that cannot be used as input
to a future setlocale(). This is contrary to the C89 standard, and
appears to have been an oversight corrected in the most recent Windows
version(s).
This commit solves the problem (as far as I know) by looking for the
problematic syntax and adjusting it.
I also rewrote the function to handle LC_ALL, which fixes that deficiency.
And, a change in that that I think is an improvement is that everything
starting with a \n is trimmed, instead of just a trailing \n being
chomped.
Commit: e8f4b33785aeb5ea8b636e146dda66eb4ead139a
https://github.com/Perl/perl5/commit/e8f4b33785aeb5ea8b636e146dda66eb4ead139a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 5d6ad0c01dfd77a8aebca75a29e71ac15881778b
https://github.com/Perl/perl5/commit/5d6ad0c01dfd77a8aebca75a29e71ac15881778b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX debug stdized
Commit: f204b2f8a7e14495757e0cd5e790351305f17037
https://github.com/Perl/perl5/commit/f204b2f8a7e14495757e0cd5e790351305f17037
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 4f5e25bfce2e636f08795fa8a7ed671295f286ca
https://github.com/Perl/perl5/commit/4f5e25bfce2e636f08795fa8a7ed671295f286ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 805cfa998ca139f7b69b6d6cfdb913920062a625
https://github.com/Perl/perl5/commit/805cfa998ca139f7b69b6d6cfdb913920062a625
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 26c6af14f9cdc99012d3d79c1aa110278cf10aaf
https://github.com/Perl/perl5/commit/26c6af14f9cdc99012d3d79c1aa110278cf10aaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: c5a1a1610e962f070c7b78d0b37b27b8139eafe8
https://github.com/Perl/perl5/commit/c5a1a1610e962f070c7b78d0b37b27b8139eafe8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: f885f8cbf2c9b04edecbb43614419e5d68387a52
https://github.com/Perl/perl5/commit/f885f8cbf2c9b04edecbb43614419e5d68387a52
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: ebb393599ec1a9e5a132c75c375e72b97e2855e3
https://github.com/Perl/perl5/commit/ebb393599ec1a9e5a132c75c375e72b97e2855e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 6a161037735c4b626fddceb9ef32f0a8d4e1e7f2
https://github.com/Perl/perl5/commit/6a161037735c4b626fddceb9ef32f0a8d4e1e7f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: ff6dd3c95d1d690c88e6260173c07274a99d8769
https://github.com/Perl/perl5/commit/ff6dd3c95d1d690c88e6260173c07274a99d8769
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 9c9bf5c3036d58c6b6bb2cd7ff3a6f9fa74e3b27
https://github.com/Perl/perl5/commit/9c9bf5c3036d58c6b6bb2cd7ff3a6f9fa74e3b27
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: e9622a9b2c986cf8db78e5c4eaf93317022e52e7
https://github.com/Perl/perl5/commit/e9622a9b2c986cf8db78e5c4eaf93317022e52e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 62fc4f49ca3e8a4d6f47e23e090e28266c468702
https://github.com/Perl/perl5/commit/62fc4f49ca3e8a4d6f47e23e090e28266c468702
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 2a33a277bbf44c573d78b62399f0a752e5ecade1
https://github.com/Perl/perl5/commit/2a33a277bbf44c573d78b62399f0a752e5ecade1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: d1d2f75fb1bd8630de63ff18c09930d50e1bfeb6
https://github.com/Perl/perl5/commit/d1d2f75fb1bd8630de63ff18c09930d50e1bfeb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: e081bafb9f5e248ce8596dc976b8a7388cc9dd24
https://github.com/Perl/perl5/commit/e081bafb9f5e248ce8596dc976b8a7388cc9dd24
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 9e17eccf5bde3ca07b63e26b4adf346ebec740a9
https://github.com/Perl/perl5/commit/9e17eccf5bde3ca07b63e26b4adf346ebec740a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: b4194b6843d14833c5293d5a6c507d2ac4f9a9ae
https://github.com/Perl/perl5/commit/b4194b6843d14833c5293d5a6c507d2ac4f9a9ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 5ae86b74b5ae8635ca7ad8b35370cb2f650304ea
https://github.com/Perl/perl5/commit/5ae86b74b5ae8635ca7ad8b35370cb2f650304ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 7bee8c905a550a5c137d6915e660716afa4c9dca
https://github.com/Perl/perl5/commit/7bee8c905a550a5c137d6915e660716afa4c9dca
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 1251224073a2a6e37451f6e1137a64e2b8da841a
https://github.com/Perl/perl5/commit/1251224073a2a6e37451f6e1137a64e2b8da841a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 311c4116c14515d909da8dee6a73f5a8be159bac
https://github.com/Perl/perl5/commit/311c4116c14515d909da8dee6a73f5a8be159bac
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 23b335c263790aa04b89ba3d1dd43e26a1611803
https://github.com/Perl/perl5/commit/23b335c263790aa04b89ba3d1dd43e26a1611803
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 474f32b6a04b1e4d0d61f90d50d28545eb264a81
https://github.com/Perl/perl5/commit/474f32b6a04b1e4d0d61f90d50d28545eb264a81
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 762d07f4c4f00aef1ed8d2d290752b725bdeda71
https://github.com/Perl/perl5/commit/762d07f4c4f00aef1ed8d2d290752b725bdeda71
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 8e54764c5b5813899b98a9daa66d72f9f3e14b32
https://github.com/Perl/perl5/commit/8e54764c5b5813899b98a9daa66d72f9f3e14b32
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 50d63c98bd38a9165badd1103c455ab2829a3633
https://github.com/Perl/perl5/commit/50d63c98bd38a9165badd1103c455ab2829a3633
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 4aac0a72c11b2285ce5408d8062063d13a4cbae7
https://github.com/Perl/perl5/commit/4aac0a72c11b2285ce5408d8062063d13a4cbae7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: a60e77c1f3c2de691ca569ea1780c8d314708e69
https://github.com/Perl/perl5/commit/a60e77c1f3c2de691ca569ea1780c8d314708e69
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: d58cb1bb03719be1ebb2037cea47fd6cd76c2034
https://github.com/Perl/perl5/commit/d58cb1bb03719be1ebb2037cea47fd6cd76c2034
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 82674a42ce79588a31effca2b9762556c660836d
https://github.com/Perl/perl5/commit/82674a42ce79588a31effca2b9762556c660836d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 31f1da20a5de42ca2ef4419b4051a3ee7ec8e0fc
https://github.com/Perl/perl5/commit/31f1da20a5de42ca2ef4419b4051a3ee7ec8e0fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 7609577023e0effa8fb528061bfa1bbd2adb9217
https://github.com/Perl/perl5/commit/7609577023e0effa8fb528061bfa1bbd2adb9217
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 7e1d09e3b4bd8d2db2ca5b5bfefc8bb7190c3183
https://github.com/Perl/perl5/commit/7e1d09e3b4bd8d2db2ca5b5bfefc8bb7190c3183
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 6df74a57774ed90dc9e0b17710c572947ce4e58c
https://github.com/Perl/perl5/commit/6df74a57774ed90dc9e0b17710c572947ce4e58c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 38fb99db8edad8222f85e9c644dcc8028ae1a863
https://github.com/Perl/perl5/commit/38fb99db8edad8222f85e9c644dcc8028ae1a863
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 9db80f0b327c432affcfecd3b06b48b00759147b
https://github.com/Perl/perl5/commit/9db80f0b327c432affcfecd3b06b48b00759147b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: a429a3c647aeaa69aa1bb0ee677cf972eb527f50
https://github.com/Perl/perl5/commit/a429a3c647aeaa69aa1bb0ee677cf972eb527f50
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 270a23ae442201729de8e2f6449c299ed823a8b1
https://github.com/Perl/perl5/commit/270a23ae442201729de8e2f6449c299ed823a8b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 283b48405959a847c3571fbd628bbc9b7bbf2cf2
https://github.com/Perl/perl5/commit/283b48405959a847c3571fbd628bbc9b7bbf2cf2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 71a3cf6d295feb7e5583eb29c3d48477eae484d7
https://github.com/Perl/perl5/commit/71a3cf6d295feb7e5583eb29c3d48477eae484d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: f53bf3cc478bc0e90c7b5d816ba2f3a92e764f5b
https://github.com/Perl/perl5/commit/f53bf3cc478bc0e90c7b5d816ba2f3a92e764f5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 86562484ddf65b3ac1842665c31d07ac84e7c4db
https://github.com/Perl/perl5/commit/86562484ddf65b3ac1842665c31d07ac84e7c4db
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 5061a56de7513a8e79f4e3f8f8e8abdc995d23af
https://github.com/Perl/perl5/commit/5061a56de7513a8e79f4e3f8f8e8abdc995d23af
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: cd41c8962b52a10f2f91660a3aa0a14598f6898c
https://github.com/Perl/perl5/commit/cd41c8962b52a10f2f91660a3aa0a14598f6898c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 6140eacbc2da2ca405f4120a2ea6aba39816abd5
https://github.com/Perl/perl5/commit/6140eacbc2da2ca405f4120a2ea6aba39816abd5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: d83440feae8f64522bdb773540bc353ae4daa61f
https://github.com/Perl/perl5/commit/d83440feae8f64522bdb773540bc353ae4daa61f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 08fb9f92c244d18833cb13c67f07378a4d9b76db
https://github.com/Perl/perl5/commit/08fb9f92c244d18833cb13c67f07378a4d9b76db
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 62df204762912a88dc7fbf67e85a56d6819d0b24
https://github.com/Perl/perl5/commit/62df204762912a88dc7fbf67e85a56d6819d0b24
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: c2b570c24e05c150c4478b8fc925c414c3d15292
https://github.com/Perl/perl5/commit/c2b570c24e05c150c4478b8fc925c414c3d15292
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: e7c4b857f5dddd047ec3e14470e494ef27f7fad4
https://github.com/Perl/perl5/commit/e7c4b857f5dddd047ec3e14470e494ef27f7fad4
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 0e9256cf47dc7c32f9fa9a58cd5c91a46473f180
https://github.com/Perl/perl5/commit/0e9256cf47dc7c32f9fa9a58cd5c91a46473f180
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 63bd0f607a7f621dc7165d4839685001ef3a8ecb
https://github.com/Perl/perl5/commit/63bd0f607a7f621dc7165d4839685001ef3a8ecb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 74534f918b56555d516a3a6ba1af1281585af8fd
https://github.com/Perl/perl5/commit/74534f918b56555d516a3a6ba1af1281585af8fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Revamp sync_locale()
This rarely used function was actually failing to do what it purported
in some Configurations.
Commit: bd5e0e604f4a2536a9af7036ca7205f470f91d5b
https://github.com/Perl/perl5/commit/bd5e0e604f4a2536a9af7036ca7205f470f91d5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 248303d87c3a61d3d66e3b95da858df69230bd82
https://github.com/Perl/perl5/commit/248303d87c3a61d3d66e3b95da858df69230bd82
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Revamp switch_to_global_locale()
Prior to this commit, the global locale was not always getting populated
with the values from the thread being switched.
Commit: 00e647e5e1dace287dcccd0d2aac7e4e19d9bf77
https://github.com/Perl/perl5/commit/00e647e5e1dace287dcccd0d2aac7e4e19d9bf77
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 6b1ae99acc5ed3efb71550e205f714f2912751e6
https://github.com/Perl/perl5/commit/6b1ae99acc5ed3efb71550e205f714f2912751e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
Commit: 539ea2ce4d5c4ef82814853c7de366e3e0cc9c8d
https://github.com/Perl/perl5/commit/539ea2ce4d5c4ef82814853c7de366e3e0cc9c8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 3df98657ff8d41fc2709aeed96fb77b5b4cdd694
https://github.com/Perl/perl5/commit/3df98657ff8d41fc2709aeed96fb77b5b4cdd694
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: f19a420d1900ff961abf447ae220beb7b1299ff0
https://github.com/Perl/perl5/commit/f19a420d1900ff961abf447ae220beb7b1299ff0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: bcdf324ed07553af9975841dcb7dc39c1a882db7
https://github.com/Perl/perl5/commit/bcdf324ed07553af9975841dcb7dc39c1a882db7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX PORCELAIN_SET not yet defined locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 27b90637e28dfde6e33bc8dd9499e454bb28a542
https://github.com/Perl/perl5/commit/27b90637e28dfde6e33bc8dd9499e454bb28a542
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: cc0f2198571bc476b9c5dc5b2b01e7effaf4572e
https://github.com/Perl/perl5/commit/cc0f2198571bc476b9c5dc5b2b01e7effaf4572e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: a594babc51cc2acf5806927954811d8281e1d4a9
https://github.com/Perl/perl5/commit/a594babc51cc2acf5806927954811d8281e1d4a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: f7d64abdf34e7f5d3f136734f9a5dd6087106c27
https://github.com/Perl/perl5/commit/f7d64abdf34e7f5d3f136734f9a5dd6087106c27
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 78b75f109e32d65d446b22f4083b6b25905fd69b
https://github.com/Perl/perl5/commit/78b75f109e32d65d446b22f4083b6b25905fd69b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 171b1dbf05f5e039b719d4d86b2d8f2de29b3c59
https://github.com/Perl/perl5/commit/171b1dbf05f5e039b719d4d86b2d8f2de29b3c59
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 1b97e4398af3acc67ef5828f026a22a056d456bb
https://github.com/Perl/perl5/commit/1b97e4398af3acc67ef5828f026a22a056d456bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: b8184a6ace0bcae1cb41d5646a75ee06b57cd21d
https://github.com/Perl/perl5/commit/b8184a6ace0bcae1cb41d5646a75ee06b57cd21d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: e5e95904294199d1ce93bd754016579721d9af9c
https://github.com/Perl/perl5/commit/e5e95904294199d1ce93bd754016579721d9af9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: c4ea9c92f0867f69122dd1706cb734ff5aaa5c4c
https://github.com/Perl/perl5/commit/c4ea9c92f0867f69122dd1706cb734ff5aaa5c4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 2009bdd990edd19b4f9987c92193566276be97f1
https://github.com/Perl/perl5/commit/2009bdd990edd19b4f9987c92193566276be97f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: Windows debug
Commit: 0199781fdaa5f2c6362c78b00a96753ba712ce7a
https://github.com/Perl/perl5/commit/0199781fdaa5f2c6362c78b00a96753ba712ce7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 62cdfb318dca7f69a47c39ef4719abf2fe3c6127
https://github.com/Perl/perl5/commit/62cdfb318dca7f69a47c39ef4719abf2fe3c6127
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: dbf14f9d9806b55195a8a26a66d166f7f17e260d
https://github.com/Perl/perl5/commit/dbf14f9d9806b55195a8a26a66d166f7f17e260d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 397f07c67a5ddc109ef6cb5ddcc237f22a78af3f
https://github.com/Perl/perl5/commit/397f07c67a5ddc109ef6cb5ddcc237f22a78af3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 7cea963710da6cd699e236385c878165a064519f
https://github.com/Perl/perl5/commit/7cea963710da6cd699e236385c878165a064519f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 9004d3edf434da57eb785a987be456e63b476626
https://github.com/Perl/perl5/commit/9004d3edf434da57eb785a987be456e63b476626
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 40f93d286d5b76dfde7ea6f447f36b1e1c4ea736
https://github.com/Perl/perl5/commit/40f93d286d5b76dfde7ea6f447f36b1e1c4ea736
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 1d64160c9617fab47ad4349e4e351ed125ce1b5a
https://github.com/Perl/perl5/commit/1d64160c9617fab47ad4349e4e351ed125ce1b5a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 40391c868a0769313fb16216b8c614ab732dabc5
https://github.com/Perl/perl5/commit/40391c868a0769313fb16216b8c614ab732dabc5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 07ef47648fb9e9d4a721b9b89cc96e9ed68489a2
https://github.com/Perl/perl5/commit/07ef47648fb9e9d4a721b9b89cc96e9ed68489a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: ae1b3864174976e804325844819a81ed1f892fe2
https://github.com/Perl/perl5/commit/ae1b3864174976e804325844819a81ed1f892fe2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 4ba7647f44fa684c6e4b5a6d0f38f56de940808f
https://github.com/Perl/perl5/commit/4ba7647f44fa684c6e4b5a6d0f38f56de940808f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 5dc23b85f89dbb125c88cbaccaac1c54a8c4d3f9
https://github.com/Perl/perl5/commit/5dc23b85f89dbb125c88cbaccaac1c54a8c4d3f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 011bc5ae8526ab2bbea027378844d28b70a20d71
https://github.com/Perl/perl5/commit/011bc5ae8526ab2bbea027378844d28b70a20d71
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 3bfc9f59bf9c0eb30cfe4478cf19bd523b32bc2f
https://github.com/Perl/perl5/commit/3bfc9f59bf9c0eb30cfe4478cf19bd523b32bc2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: fee60185618eed1a4313a03be26bbde5570c66bc
https://github.com/Perl/perl5/commit/fee60185618eed1a4313a03be26bbde5570c66bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: dfaeb6a915a8966f527fb6f07fd7083846f73362
https://github.com/Perl/perl5/commit/dfaeb6a915a8966f527fb6f07fd7083846f73362
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 6f25aed42fc894d12c64d29c634ccb119ef0547f
https://github.com/Perl/perl5/commit/6f25aed42fc894d12c64d29c634ccb119ef0547f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 4262f979391470aed820c469e06759e67c376cb7
https://github.com/Perl/perl5/commit/4262f979391470aed820c469e06759e67c376cb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 3b0979e01194c657fc620b0e49b9bd0e6996ece0
https://github.com/Perl/perl5/commit/3b0979e01194c657fc620b0e49b9bd0e6996ece0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: f0e10ee5f9109381a8e220ec26cacc5e3584a03e
https://github.com/Perl/perl5/commit/f0e10ee5f9109381a8e220ec26cacc5e3584a03e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 4e8990bb4d8935f93539fa52372789c90d1045aa
https://github.com/Perl/perl5/commit/4e8990bb4d8935f93539fa52372789c90d1045aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 1cb2749bdbb72be2f89e13ce11903b80996f29ee
https://github.com/Perl/perl5/commit/1cb2749bdbb72be2f89e13ce11903b80996f29ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: cc50c2d76044c0a3b0afeb3c3ef32ae1bee877bd
https://github.com/Perl/perl5/commit/cc50c2d76044c0a3b0afeb3c3ef32ae1bee877bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
XXX temp debug? locale.c, inline.h:foldEQ_locale
Commit: 24d60473a847e7f6606567ada10f4589beb85d30
https://github.com/Perl/perl5/commit/24d60473a847e7f6606567ada10f4589beb85d30
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: bea4b11c9ca0f36ebc716841b167c273e369a35f
https://github.com/Perl/perl5/commit/bea4b11c9ca0f36ebc716841b167c273e369a35f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 015dddb25d8bdb9420af808820efa6e14ef83528
https://github.com/Perl/perl5/commit/015dddb25d8bdb9420af808820efa6e14ef83528
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: ed9252731d22258f33471393ed01c41e785656f5
https://github.com/Perl/perl5/commit/ed9252731d22258f33471393ed01c41e785656f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: cbf854632f22d79f73ea0154b4402a9151569228
https://github.com/Perl/perl5/commit/cbf854632f22d79f73ea0154b4402a9151569228
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: e05486146b774eb9635be1b82d3b9c034be91f6b
https://github.com/Perl/perl5/commit/e05486146b774eb9635be1b82d3b9c034be91f6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: ed1b71426ce1b717595bacb98be28441a9848384
https://github.com/Perl/perl5/commit/ed1b71426ce1b717595bacb98be28441a9848384
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 6af494daa0016d41add90154800aa8972ea60341
https://github.com/Perl/perl5/commit/6af494daa0016d41add90154800aa8972ea60341
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: ac94389b8c82bb082f447a4cebd3dae8194df0a2
https://github.com/Perl/perl5/commit/ac94389b8c82bb082f447a4cebd3dae8194df0a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 359bb5235fd85013c227518546af958d4cac7c0d
https://github.com/Perl/perl5/commit/359bb5235fd85013c227518546af958d4cac7c0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 735c566204020f49633883d785132900a1ff2ffd
https://github.com/Perl/perl5/commit/735c566204020f49633883d785132900a1ff2ffd
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 71f56414a9480e2bfa04e5da5398219d811d873a
https://github.com/Perl/perl5/commit/71f56414a9480e2bfa04e5da5398219d811d873a
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 6d6f8dc1791780e781c2866b1c772cb2a5cab1f6
https://github.com/Perl/perl5/commit/6d6f8dc1791780e781c2866b1c772cb2a5cab1f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: e2671c7c7385d6808a6771e78d8360fd16da65dc
https://github.com/Perl/perl5/commit/e2671c7c7385d6808a6771e78d8360fd16da65dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: d278968f8d912ea4254074eab9c92124cae85859
https://github.com/Perl/perl5/commit/d278968f8d912ea4254074eab9c92124cae85859
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 511d968537c8eda9fec97c635744b30069dafe3e
https://github.com/Perl/perl5/commit/511d968537c8eda9fec97c635744b30069dafe3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: e140e3f75c8dc79d58a5e93175d47ef0a047ad5f
https://github.com/Perl/perl5/commit/e140e3f75c8dc79d58a5e93175d47ef0a047ad5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 3d7ceba7f31a54c5395f2f08f003318579a93c63
https://github.com/Perl/perl5/commit/3d7ceba7f31a54c5395f2f08f003318579a93c63
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 94a9ef986af5e1a3ed6166642a97d755eeb3929e
https://github.com/Perl/perl5/commit/94a9ef986af5e1a3ed6166642a97d755eeb3929e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: d3daa6fa8bda07ac2455985b3b611f6fd9f53845
https://github.com/Perl/perl5/commit/d3daa6fa8bda07ac2455985b3b611f6fd9f53845
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: cb535ac8d1427f4f5bf17492352733e3735bb86f
https://github.com/Perl/perl5/commit/cb535ac8d1427f4f5bf17492352733e3735bb86f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 153efe95b0e15413c85111d3946d5c879dfbe9d6
https://github.com/Perl/perl5/commit/153efe95b0e15413c85111d3946d5c879dfbe9d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: cd67099b04c182fcdf957276863fee1579252f4c
https://github.com/Perl/perl5/commit/cd67099b04c182fcdf957276863fee1579252f4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: e399e54eb273810c8dced4e30dd6d832ab30fb69
https://github.com/Perl/perl5/commit/e399e54eb273810c8dced4e30dd6d832ab30fb69
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 0b7f549fa1eba19dd6e56ce469e0f9e445714a14
https://github.com/Perl/perl5/commit/0b7f549fa1eba19dd6e56ce469e0f9e445714a14
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 3fbd5309c72998198aa3693405e0d76ab724d873
https://github.com/Perl/perl5/commit/3fbd5309c72998198aa3693405e0d76ab724d873
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 384aa3cf790f742040b383d7164a3f4ec1ac6875
https://github.com/Perl/perl5/commit/384aa3cf790f742040b383d7164a3f4ec1ac6875
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M handy.h
M iperlsys.h
M locale.c
M perl.h
M regen/reentr.pl
M regexec.c
M sv.c
M util.c
Log Message:
-----------
Notes
Commit: 6e2ac8ac942bc2768f1a706924995cddaf0f4423
https://github.com/Perl/perl5/commit/6e2ac8ac942bc2768f1a706924995cddaf0f4423
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 23fb4a8737843ed8ddfd5bf4f4d350f03ef196bc
https://github.com/Perl/perl5/commit/23fb4a8737843ed8ddfd5bf4f4d350f03ef196bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 2576be2521a0548b32c2dd0fe9b6b33dd7faeed0
https://github.com/Perl/perl5/commit/2576be2521a0548b32c2dd0fe9b6b33dd7faeed0
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 80ba3de80fd964f1c870a86d44f9b0cc68263916
https://github.com/Perl/perl5/commit/80ba3de80fd964f1c870a86d44f9b0cc68263916
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t
Commit: 0e467924f503a71265210258808dea58cc85fa9c
https://github.com/Perl/perl5/commit/0e467924f503a71265210258808dea58cc85fa9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 50aae42f684c1777f20393b904cd17d80e0e2dd9
https://github.com/Perl/perl5/commit/50aae42f684c1777f20393b904cd17d80e0e2dd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp win
Commit: 977abe32b57231d2f9f06636c1b4fbc5f22b6b71
https://github.com/Perl/perl5/commit/977abe32b57231d2f9f06636c1b4fbc5f22b6b71
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 7df6e4d1ede1345f6d50427a345276f410024496
https://github.com/Perl/perl5/commit/7df6e4d1ede1345f6d50427a345276f410024496
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 0a3bdb75146f1090ec4cd96284d424d962269940
https://github.com/Perl/perl5/commit/0a3bdb75146f1090ec4cd96284d424d962269940
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 231713fcc483e987125b2b6a697c88cf6c12ed13
https://github.com/Perl/perl5/commit/231713fcc483e987125b2b6a697c88cf6c12ed13
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX loc_tools: debug, white space
Commit: 4a249ed13c70e7a53889c7b7d91a1e2db5525304
https://github.com/Perl/perl5/commit/4a249ed13c70e7a53889c7b7d91a1e2db5525304
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 025a0d7d063649e907615885c56655236a9a569e
https://github.com/Perl/perl5/commit/025a0d7d063649e907615885c56655236a9a569e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: b496b07b18b5c457bf1c5ec2bbbee82b9cf4a0ef
https://github.com/Perl/perl5/commit/b496b07b18b5c457bf1c5ec2bbbee82b9cf4a0ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 4641884c0ed039f68d0b3314c6c2e0f3f1b47576
https://github.com/Perl/perl5/commit/4641884c0ed039f68d0b3314c6c2e0f3f1b47576
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: e2b315647993e12c61f4ff03bd39cf68259ac9b8
https://github.com/Perl/perl5/commit/e2b315647993e12c61f4ff03bd39cf68259ac9b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 4ae1ffb8ffd1d7ca9642c7ebc5127dbbff22954e
https://github.com/Perl/perl5/commit/4ae1ffb8ffd1d7ca9642c7ebc5127dbbff22954e
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: dd41ed59dbd710fd8bd46b9b874b7b9a5bec1271
https://github.com/Perl/perl5/commit/dd41ed59dbd710fd8bd46b9b874b7b9a5bec1271
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 4781ef8d633eadfd0415ba69dc7c13b45c966526
https://github.com/Perl/perl5/commit/4781ef8d633eadfd0415ba69dc7c13b45c966526
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 2b3df698224de442cebe8ea2c6547d4e281d76fc
https://github.com/Perl/perl5/commit/2b3df698224de442cebe8ea2c6547d4e281d76fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 9afbbbba79eaf5d8d9c25691dd534c2a892dfa00
https://github.com/Perl/perl5/commit/9afbbbba79eaf5d8d9c25691dd534c2a892dfa00
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 4049ac096d378b66acd9f05a67fe94984d8d1747
https://github.com/Perl/perl5/commit/4049ac096d378b66acd9f05a67fe94984d8d1747
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 4dd816e12ea157061586b57cddd65c20a2804259
https://github.com/Perl/perl5/commit/4dd816e12ea157061586b57cddd65c20a2804259
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: ce51883c1f98e5347047158c2423018045b276c9
https://github.com/Perl/perl5/commit/ce51883c1f98e5347047158c2423018045b276c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: a9f15d091d28cbc93d5974430163e2180bdb5c79
https://github.com/Perl/perl5/commit/a9f15d091d28cbc93d5974430163e2180bdb5c79
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 3c4da6fab25a40341fd310b560e12a11fa8d8129
https://github.com/Perl/perl5/commit/3c4da6fab25a40341fd310b560e12a11fa8d8129
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: b7b5f5de94aac77bd683669628e26517ec05a6ea
https://github.com/Perl/perl5/commit/b7b5f5de94aac77bd683669628e26517ec05a6ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 2e35e1ff2709db5bc6efcdffd1b20f5a40901369
https://github.com/Perl/perl5/commit/2e35e1ff2709db5bc6efcdffd1b20f5a40901369
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: eae29e5a875cee2c47a4cef732d31f11b119fb3f
https://github.com/Perl/perl5/commit/eae29e5a875cee2c47a4cef732d31f11b119fb3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: e8f944b19895188851bb050821e0fa598d4befb5
https://github.com/Perl/perl5/commit/e8f944b19895188851bb050821e0fa598d4befb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: f7e6507cd12dee14b3ee887159a0f5735e48aeb8
https://github.com/Perl/perl5/commit/f7e6507cd12dee14b3ee887159a0f5735e48aeb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-07 (Wed, 07 Apr 2021)
Changed paths:
M cygwin/cygwin.c
M embed.fnc
M embed.h
M ext/XS-APItest/t/locale.t
M handy.h
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M pod/perldiag.pod
M proto.h
M sv.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
more21
Compare: https://github.com/Perl/perl5/compare/18b5ce371120...f7e6507cd12d
