Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 9c0bebef4b1afcd6ad3fb8cbeb33a8f01378793c
https://github.com/Perl/perl5/commit/9c0bebef4b1afcd6ad3fb8cbeb33a8f01378793c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 95c4fd7319d63d7fba99f59bc5a4074597bf5c28
https://github.com/Perl/perl5/commit/95c4fd7319d63d7fba99f59bc5a4074597bf5c28
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 33031c9b470b73388610d08a3c671ec2f4e80c26
https://github.com/Perl/perl5/commit/33031c9b470b73388610d08a3c671ec2f4e80c26
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 570d7707cd635905bb1f8323ca15b177fb365500
https://github.com/Perl/perl5/commit/570d7707cd635905bb1f8323ca15b177fb365500
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 7bb70e86b1de4c4714e452960d234ed0b7cd524b
https://github.com/Perl/perl5/commit/7bb70e86b1de4c4714e452960d234ed0b7cd524b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: f188986dc8880916000721c0af153c80aacda644
https://github.com/Perl/perl5/commit/f188986dc8880916000721c0af153c80aacda644
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 80b92616931da66598adf2f9e95dcb7364649b55
https://github.com/Perl/perl5/commit/80b92616931da66598adf2f9e95dcb7364649b55
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 5b52c539042ffa519f266dc3f875a8ab70d037ed
https://github.com/Perl/perl5/commit/5b52c539042ffa519f266dc3f875a8ab70d037ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 31c7021cc9eca9a5dbc76d8c98d323384d285a3b
https://github.com/Perl/perl5/commit/31c7021cc9eca9a5dbc76d8c98d323384d285a3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 045024588871959daf00293daee44c8cb95ea880
https://github.com/Perl/perl5/commit/045024588871959daf00293daee44c8cb95ea880
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 45d67dfc090378ade1c3d8514b54d7335383897f
https://github.com/Perl/perl5/commit/45d67dfc090378ade1c3d8514b54d7335383897f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 5c26ff8c2d47b26eaa2d86dcf4ff4f6872fab60b
https://github.com/Perl/perl5/commit/5c26ff8c2d47b26eaa2d86dcf4ff4f6872fab60b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: e8bc0044d26dd34e104fd5d9fef18b3bc797519e
https://github.com/Perl/perl5/commit/e8bc0044d26dd34e104fd5d9fef18b3bc797519e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 27186ba5241612c8a74763a494237ff6cd799de6
https://github.com/Perl/perl5/commit/27186ba5241612c8a74763a494237ff6cd799de6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 974852f8a93b401a6d6351af5485b06412317d79
https://github.com/Perl/perl5/commit/974852f8a93b401a6d6351af5485b06412317d79
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: b48d3db8341150aec0c6f3284b75ae80c08c2c3e
https://github.com/Perl/perl5/commit/b48d3db8341150aec0c6f3284b75ae80c08c2c3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 361c6fb97431507b74678c4bbcf463219e0fd8bc
https://github.com/Perl/perl5/commit/361c6fb97431507b74678c4bbcf463219e0fd8bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 3a4b2a85e698fa25095622865315bccf38532c95
https://github.com/Perl/perl5/commit/3a4b2a85e698fa25095622865315bccf38532c95
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 388b59b2e94f995fa141cf128aa4edf05deb97ac
https://github.com/Perl/perl5/commit/388b59b2e94f995fa141cf128aa4edf05deb97ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 94ca7d5b89076d2d258f8e3878c96adb11313f39
https://github.com/Perl/perl5/commit/94ca7d5b89076d2d258f8e3878c96adb11313f39
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 1d8c3d43a123ec61d1205626a743514ed4c50280
https://github.com/Perl/perl5/commit/1d8c3d43a123ec61d1205626a743514ed4c50280
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 98262fa6bff418f01c1a6ce071c0d5342a322cba
https://github.com/Perl/perl5/commit/98262fa6bff418f01c1a6ce071c0d5342a322cba
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 12ac34b01879f805d6851efd66303a9e5292e25a
https://github.com/Perl/perl5/commit/12ac34b01879f805d6851efd66303a9e5292e25a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 9574b2c29c9212a127e97ae01ddeea226f18d41d
https://github.com/Perl/perl5/commit/9574b2c29c9212a127e97ae01ddeea226f18d41d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: ca01e6d5e88f30315bb56bbec4f8246735c56050
https://github.com/Perl/perl5/commit/ca01e6d5e88f30315bb56bbec4f8246735c56050
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 1ed22547ab17d45f11a0b425cfd395baa243ef0c
https://github.com/Perl/perl5/commit/1ed22547ab17d45f11a0b425cfd395baa243ef0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 3577808f0ce1c8d166e610edcf14a6399cf085b8
https://github.com/Perl/perl5/commit/3577808f0ce1c8d166e610edcf14a6399cf085b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: bd695508eaa930e4a8750ed1a87eb08847ba491c
https://github.com/Perl/perl5/commit/bd695508eaa930e4a8750ed1a87eb08847ba491c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 6bae5495fedb6d41ac0fcd92541bca361ebc73d4
https://github.com/Perl/perl5/commit/6bae5495fedb6d41ac0fcd92541bca361ebc73d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: fd2fb34e9ea02a2b94168be8fdd583eeab900801
https://github.com/Perl/perl5/commit/fd2fb34e9ea02a2b94168be8fdd583eeab900801
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: ecba931d0a5c1ec843187ba6e2254c95c89a1917
https://github.com/Perl/perl5/commit/ecba931d0a5c1ec843187ba6e2254c95c89a1917
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 8acf62ec9ce4ba58edb10470233c9ac34657487f
https://github.com/Perl/perl5/commit/8acf62ec9ce4ba58edb10470233c9ac34657487f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: cfd4e432a6f03c8ed3ed927f089990d1cdbc8a44
https://github.com/Perl/perl5/commit/cfd4e432a6f03c8ed3ed927f089990d1cdbc8a44
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: c64ec96244ab010640f4a220b67c590f416ce1d5
https://github.com/Perl/perl5/commit/c64ec96244ab010640f4a220b67c590f416ce1d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: b4ef84127a9e5e68fdd06327e996dc885db72dae
https://github.com/Perl/perl5/commit/b4ef84127a9e5e68fdd06327e996dc885db72dae
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 08322c87f3449f5f599ed7ea12af04c4f0f97b39
https://github.com/Perl/perl5/commit/08322c87f3449f5f599ed7ea12af04c4f0f97b39
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: e003762d22acbd17ea64851055644541b40d3d0b
https://github.com/Perl/perl5/commit/e003762d22acbd17ea64851055644541b40d3d0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 8c4636e12a73b77a5ed1e7b7a28333e268e2b827
https://github.com/Perl/perl5/commit/8c4636e12a73b77a5ed1e7b7a28333e268e2b827
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 1f072e5154127760269c508a9b42fb8826a89baa
https://github.com/Perl/perl5/commit/1f072e5154127760269c508a9b42fb8826a89baa
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: fd1cdda967760896a8f3e367a397da48190b23aa
https://github.com/Perl/perl5/commit/fd1cdda967760896a8f3e367a397da48190b23aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 2de8e7feb5c8c88486dee50fe1d02e164ecf2315
https://github.com/Perl/perl5/commit/2de8e7feb5c8c88486dee50fe1d02e164ecf2315
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 1f3734873e2e3a406957da4f12da76f3777d1354
https://github.com/Perl/perl5/commit/1f3734873e2e3a406957da4f12da76f3777d1354
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 0fffc658d5e63d9a11b879b518d98530abc1864f
https://github.com/Perl/perl5/commit/0fffc658d5e63d9a11b879b518d98530abc1864f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: acff41fbaf7e119cd75436196d26c94829e7a184
https://github.com/Perl/perl5/commit/acff41fbaf7e119cd75436196d26c94829e7a184
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: db8da11fd87dd8a7136c8a98d12e886c5768724b
https://github.com/Perl/perl5/commit/db8da11fd87dd8a7136c8a98d12e886c5768724b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: ad3addc109958b1a0fd1b85f9edfc929c21e1ae2
https://github.com/Perl/perl5/commit/ad3addc109958b1a0fd1b85f9edfc929c21e1ae2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 9bfb1914c64ded1b3a380fe72248b094bb5e5815
https://github.com/Perl/perl5/commit/9bfb1914c64ded1b3a380fe72248b094bb5e5815
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 56b81d9ce520ac4ce9a0ba84c15bdd4d42ab646f
https://github.com/Perl/perl5/commit/56b81d9ce520ac4ce9a0ba84c15bdd4d42ab646f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 9d61ecf73b1ca34b3a730740fcf99f5af2390b0e
https://github.com/Perl/perl5/commit/9d61ecf73b1ca34b3a730740fcf99f5af2390b0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 7156003c128a8adad34d45b71e6dbea3c8a8fd2c
https://github.com/Perl/perl5/commit/7156003c128a8adad34d45b71e6dbea3c8a8fd2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 7ce34ee6939cd373de732651406c6e3e54342280
https://github.com/Perl/perl5/commit/7ce34ee6939cd373de732651406c6e3e54342280
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: b79f2af3752224d70935eba00adb062cc8472c4c
https://github.com/Perl/perl5/commit/b79f2af3752224d70935eba00adb062cc8472c4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 082c6706325e306d1ea50f23b38c825a88db1f8f
https://github.com/Perl/perl5/commit/082c6706325e306d1ea50f23b38c825a88db1f8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 9c19ccc6fe68b4234ed3dc7ded319c7227e608ef
https://github.com/Perl/perl5/commit/9c19ccc6fe68b4234ed3dc7ded319c7227e608ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: e0271da34b3a1862fbef36f505cb46afb273e946
https://github.com/Perl/perl5/commit/e0271da34b3a1862fbef36f505cb46afb273e946
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 72508d995305cdbddb24e913dc06b415b5e318c6
https://github.com/Perl/perl5/commit/72508d995305cdbddb24e913dc06b415b5e318c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 574cb6e9cd540982578257c729f78d6912a35b23
https://github.com/Perl/perl5/commit/574cb6e9cd540982578257c729f78d6912a35b23
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: d9c5366fbabddc61e91e5595aeebf64be531ebb0
https://github.com/Perl/perl5/commit/d9c5366fbabddc61e91e5595aeebf64be531ebb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 5bae17c19b9ed88b6f9e6cbce6db7900b66ebfca
https://github.com/Perl/perl5/commit/5bae17c19b9ed88b6f9e6cbce6db7900b66ebfca
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: baa9ea4756c8a684d743bbfd8aa9afbb6d64febb
https://github.com/Perl/perl5/commit/baa9ea4756c8a684d743bbfd8aa9afbb6d64febb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: d3d2d56a06a174b6d05996af279f6329d8e0c29e
https://github.com/Perl/perl5/commit/d3d2d56a06a174b6d05996af279f6329d8e0c29e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 055c94ee07740f6e605ca6be38df241778158961
https://github.com/Perl/perl5/commit/055c94ee07740f6e605ca6be38df241778158961
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: ffdf6e6859efe74ca929755b518010300371e1f0
https://github.com/Perl/perl5/commit/ffdf6e6859efe74ca929755b518010300371e1f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: a8bcd3746398844c451bcfb0000e5017d6895c23
https://github.com/Perl/perl5/commit/a8bcd3746398844c451bcfb0000e5017d6895c23
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: ea8b1a47271526e6dca1b132fd9f863125364355
https://github.com/Perl/perl5/commit/ea8b1a47271526e6dca1b132fd9f863125364355
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 52f1eaa09b8944b071b62da05cb1331fca1a6560
https://github.com/Perl/perl5/commit/52f1eaa09b8944b071b62da05cb1331fca1a6560
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 5172932feaf4fee7a7ba4c8365e7377e0d4f6323
https://github.com/Perl/perl5/commit/5172932feaf4fee7a7ba4c8365e7377e0d4f6323
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 2614483743a1c4e9eb3d0bc1da297fd4d16b7416
https://github.com/Perl/perl5/commit/2614483743a1c4e9eb3d0bc1da297fd4d16b7416
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: c0ddfcb2484648c60103375874b5314849b2053a
https://github.com/Perl/perl5/commit/c0ddfcb2484648c60103375874b5314849b2053a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: eb791eeab6b7bc914add16e24d5f7202e0f287aa
https://github.com/Perl/perl5/commit/eb791eeab6b7bc914add16e24d5f7202e0f287aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 9686b38df74287b8ee27ea24d0d96da6cf534c23
https://github.com/Perl/perl5/commit/9686b38df74287b8ee27ea24d0d96da6cf534c23
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 98df2a15a030d0aebb15168e45633f6a7ad6d3b6
https://github.com/Perl/perl5/commit/98df2a15a030d0aebb15168e45633f6a7ad6d3b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 3f5773879ef09e7f14050e3485c5fc0f87011ef1
https://github.com/Perl/perl5/commit/3f5773879ef09e7f14050e3485c5fc0f87011ef1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 6e706e0a0dce4ac08026bb46710835511f27e0a0
https://github.com/Perl/perl5/commit/6e706e0a0dce4ac08026bb46710835511f27e0a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 1765ff25aad85ebe3b67c5f86e8b6e23dae153bc
https://github.com/Perl/perl5/commit/1765ff25aad85ebe3b67c5f86e8b6e23dae153bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: feaf86dbcdbc6fc3a30cd8b46cdf4e83d776f1dc
https://github.com/Perl/perl5/commit/feaf86dbcdbc6fc3a30cd8b46cdf4e83d776f1dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 6acc9039fdca845c7742f618d21521d610a54d38
https://github.com/Perl/perl5/commit/6acc9039fdca845c7742f618d21521d610a54d38
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 175a74565bd6119529719decbac4d124ce69c0f4
https://github.com/Perl/perl5/commit/175a74565bd6119529719decbac4d124ce69c0f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: c6a2d4a9fc197e024c0430b77c111227ea8ffea2
https://github.com/Perl/perl5/commit/c6a2d4a9fc197e024c0430b77c111227ea8ffea2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: e7d27579fe98c6a438d563682552802ae4e96599
https://github.com/Perl/perl5/commit/e7d27579fe98c6a438d563682552802ae4e96599
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 228fabc53cfb167b956dfbd176c12485a0e3e2fd
https://github.com/Perl/perl5/commit/228fabc53cfb167b956dfbd176c12485a0e3e2fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: b41cd08eeecf71f34897fed89eb5d4e77506d176
https://github.com/Perl/perl5/commit/b41cd08eeecf71f34897fed89eb5d4e77506d176
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 8fba90fc3b9bf489ee9e2bff4a1ae6aa8d35347a
https://github.com/Perl/perl5/commit/8fba90fc3b9bf489ee9e2bff4a1ae6aa8d35347a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: d9f79d26da5d2047ed347b019903b4912d35e521
https://github.com/Perl/perl5/commit/d9f79d26da5d2047ed347b019903b4912d35e521
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 5a1f65f906d29128e61814bc55d2d8f8d606bf41
https://github.com/Perl/perl5/commit/5a1f65f906d29128e61814bc55d2d8f8d606bf41
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 8b4dc410d87f014331299fafdc075ac2bfd9f80c
https://github.com/Perl/perl5/commit/8b4dc410d87f014331299fafdc075ac2bfd9f80c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: f032c24fadee67e2a29b0341c44db9625ca2205a
https://github.com/Perl/perl5/commit/f032c24fadee67e2a29b0341c44db9625ca2205a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 58272a5e8a83cf098ded57ff79eaa561d1023af2
https://github.com/Perl/perl5/commit/58272a5e8a83cf098ded57ff79eaa561d1023af2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 623d0a1038991e82ba68b2848182a05ec3d7a416
https://github.com/Perl/perl5/commit/623d0a1038991e82ba68b2848182a05ec3d7a416
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: d59e8d516e2de6b4d4db8a80a0ab0c27c60f9648
https://github.com/Perl/perl5/commit/d59e8d516e2de6b4d4db8a80a0ab0c27c60f9648
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: c89ac587cc8167903c65c7c4ea96d69bce3679d0
https://github.com/Perl/perl5/commit/c89ac587cc8167903c65c7c4ea96d69bce3679d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: b05a70e6ed3f0e68ab91c2a94a924d0c56aa927a
https://github.com/Perl/perl5/commit/b05a70e6ed3f0e68ab91c2a94a924d0c56aa927a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: ed25930e14a75dcb98413420b9d4a314de5ff1b9
https://github.com/Perl/perl5/commit/ed25930e14a75dcb98413420b9d4a314de5ff1b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: c9e0ea97eece953d011ec171c718ac1a6eeabd90
https://github.com/Perl/perl5/commit/c9e0ea97eece953d011ec171c718ac1a6eeabd90
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 5386e6b49999477a9798f17ce87cb4c2937708a6
https://github.com/Perl/perl5/commit/5386e6b49999477a9798f17ce87cb4c2937708a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 16068809fe6a610e4a7ccf975cb10405dd365c71
https://github.com/Perl/perl5/commit/16068809fe6a610e4a7ccf975cb10405dd365c71
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: e82839d514a22415051b698b127056cc6b38a0ac
https://github.com/Perl/perl5/commit/e82839d514a22415051b698b127056cc6b38a0ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: d70d18b763a6318628b29f5bba0c8f4aa4784299
https://github.com/Perl/perl5/commit/d70d18b763a6318628b29f5bba0c8f4aa4784299
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 30d0d476968670052fa35a60ee9b9932a3e7a14c
https://github.com/Perl/perl5/commit/30d0d476968670052fa35a60ee9b9932a3e7a14c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 1eb935b1748196aedb5ad34ff00f6cf536c5dfc1
https://github.com/Perl/perl5/commit/1eb935b1748196aedb5ad34ff00f6cf536c5dfc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: b3864d3bade3dacb059bedf5020918910a97f445
https://github.com/Perl/perl5/commit/b3864d3bade3dacb059bedf5020918910a97f445
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 33f630089ff81a2942f16bbc8796a99c21b47ce4
https://github.com/Perl/perl5/commit/33f630089ff81a2942f16bbc8796a99c21b47ce4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 5320c1b12ade72ed616ccd733fee7e582c5b93ea
https://github.com/Perl/perl5/commit/5320c1b12ade72ed616ccd733fee7e582c5b93ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 5dfb3702b4af4ac352bcaa8e9099697d45bf7955
https://github.com/Perl/perl5/commit/5dfb3702b4af4ac352bcaa8e9099697d45bf7955
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 776a993dfe686dc716362f3aa4717a060aea77be
https://github.com/Perl/perl5/commit/776a993dfe686dc716362f3aa4717a060aea77be
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 42ee05c722a252aba6dd9958db8308c57593a479
https://github.com/Perl/perl5/commit/42ee05c722a252aba6dd9958db8308c57593a479
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 30df72ac31af39e3b280a70f54109cd86b1b1f00
https://github.com/Perl/perl5/commit/30df72ac31af39e3b280a70f54109cd86b1b1f00
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: a26cbd2fdaa2656c1bec24cabde56003cbcc26c3
https://github.com/Perl/perl5/commit/a26cbd2fdaa2656c1bec24cabde56003cbcc26c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: d5602788f9b28c59b9835c9c1d732380c5f822c8
https://github.com/Perl/perl5/commit/d5602788f9b28c59b9835c9c1d732380c5f822c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 9ea859ab5022109177b433aa3f7c13466a0b781a
https://github.com/Perl/perl5/commit/9ea859ab5022109177b433aa3f7c13466a0b781a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: c7f4f31eb4f7de8d05c504a63b31aceb40bcd269
https://github.com/Perl/perl5/commit/c7f4f31eb4f7de8d05c504a63b31aceb40bcd269
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 07a7bc71452d8f79e401965afa083135a208b971
https://github.com/Perl/perl5/commit/07a7bc71452d8f79e401965afa083135a208b971
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 9ab3862aac401e92c84ba4289418b98b3095797b
https://github.com/Perl/perl5/commit/9ab3862aac401e92c84ba4289418b98b3095797b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: ebef9ff540cfa36dfc5c82fe72b2eaf11810d7b5
https://github.com/Perl/perl5/commit/ebef9ff540cfa36dfc5c82fe72b2eaf11810d7b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 94671070b16a790d8dcfcfa3a92651defd03cedc
https://github.com/Perl/perl5/commit/94671070b16a790d8dcfcfa3a92651defd03cedc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 7f952340575493da6351a9672782b273392bade6
https://github.com/Perl/perl5/commit/7f952340575493da6351a9672782b273392bade6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 600cf7187421f5c429df2cd485bb2d2892fe19c4
https://github.com/Perl/perl5/commit/600cf7187421f5c429df2cd485bb2d2892fe19c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: b1ac28b2ee173650836d8d06b132fa91897f0d32
https://github.com/Perl/perl5/commit/b1ac28b2ee173650836d8d06b132fa91897f0d32
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 88d0f5ff320fa4d16555f24f401ccbeb27683f09
https://github.com/Perl/perl5/commit/88d0f5ff320fa4d16555f24f401ccbeb27683f09
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: d6dac3a3d372280ffa4dd9b78cc380011ff9a7ef
https://github.com/Perl/perl5/commit/d6dac3a3d372280ffa4dd9b78cc380011ff9a7ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 46911b9e4d27d741ff3d90d5d45972471fc84d8a
https://github.com/Perl/perl5/commit/46911b9e4d27d741ff3d90d5d45972471fc84d8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 03a363f496f6b142bec4221bd405fede8ab1eb42
https://github.com/Perl/perl5/commit/03a363f496f6b142bec4221bd405fede8ab1eb42
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: d33bc2cafc596ee7286c3aefc1b1c5993c2f581b
https://github.com/Perl/perl5/commit/d33bc2cafc596ee7286c3aefc1b1c5993c2f581b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 364c3cd752a38cc2facede83fd05bf5c39097699
https://github.com/Perl/perl5/commit/364c3cd752a38cc2facede83fd05bf5c39097699
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: bf7dd8458913c5dfed4bac6768ab3009ea10e955
https://github.com/Perl/perl5/commit/bf7dd8458913c5dfed4bac6768ab3009ea10e955
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 5a0088d636781905d17bc7735a7a8848dc1621ac
https://github.com/Perl/perl5/commit/5a0088d636781905d17bc7735a7a8848dc1621ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: d32a79877a731298163493bc3b05edb2f7bc1beb
https://github.com/Perl/perl5/commit/d32a79877a731298163493bc3b05edb2f7bc1beb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: de42614235e088e915fd545c87613752cd53567c
https://github.com/Perl/perl5/commit/de42614235e088e915fd545c87613752cd53567c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 613eb10ed7708de291cb26fb8970c6e15e613ae6
https://github.com/Perl/perl5/commit/613eb10ed7708de291cb26fb8970c6e15e613ae6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 14f9bfbd93e9f2eea0f464d74c849a0828e78348
https://github.com/Perl/perl5/commit/14f9bfbd93e9f2eea0f464d74c849a0828e78348
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: 23f4935402393fc9cfdfd7b2fb45c25978de86b8
https://github.com/Perl/perl5/commit/23f4935402393fc9cfdfd7b2fb45c25978de86b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: f1cb3a34bf4f9af8e850568768b53b1a41666a2b
https://github.com/Perl/perl5/commit/f1cb3a34bf4f9af8e850568768b53b1a41666a2b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 69fa241d7a178c925a13216f9c54799d872713fe
https://github.com/Perl/perl5/commit/69fa241d7a178c925a13216f9c54799d872713fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 6fb322fe1168170dd801f2526f5c7fec9aca7257
https://github.com/Perl/perl5/commit/6fb322fe1168170dd801f2526f5c7fec9aca7257
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: ba35fe1a8d642b58e105b4d971e6e1e127f8cbd3
https://github.com/Perl/perl5/commit/ba35fe1a8d642b58e105b4d971e6e1e127f8cbd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: c5805ddaaa261293e735bbfba796c20d5eec3235
https://github.com/Perl/perl5/commit/c5805ddaaa261293e735bbfba796c20d5eec3235
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: aa6c61c24c85b352ead0cae493826814cdc07377
https://github.com/Perl/perl5/commit/aa6c61c24c85b352ead0cae493826814cdc07377
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 36d217bb0781db8779b803964fdabc65431bd0c9
https://github.com/Perl/perl5/commit/36d217bb0781db8779b803964fdabc65431bd0c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 887ebc077afd6a251e7131b8acb8eb9b8333ba31
https://github.com/Perl/perl5/commit/887ebc077afd6a251e7131b8acb8eb9b8333ba31
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 56a9c291164a4ca876f3eab08bc154ebc98046d4
https://github.com/Perl/perl5/commit/56a9c291164a4ca876f3eab08bc154ebc98046d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 4dd85edf1724d07e6f12939f3b0e6a6ff380c12b
https://github.com/Perl/perl5/commit/4dd85edf1724d07e6f12939f3b0e6a6ff380c12b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 46f647feffacdb480089e90339b678f5db1b7b8f
https://github.com/Perl/perl5/commit/46f647feffacdb480089e90339b678f5db1b7b8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 8b77c311548b2df330669306c243f562160bc2e1
https://github.com/Perl/perl5/commit/8b77c311548b2df330669306c243f562160bc2e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 922f30dbf4cdc6d8be1b2a45126b2fefc7cb06f9
https://github.com/Perl/perl5/commit/922f30dbf4cdc6d8be1b2a45126b2fefc7cb06f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 58f6b0e9d8feb40b6cfda611bd6651ca70e8ef86
https://github.com/Perl/perl5/commit/58f6b0e9d8feb40b6cfda611bd6651ca70e8ef86
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 27995ae9eb0deebe20f55dbbf31d9bc5572f6ff0
https://github.com/Perl/perl5/commit/27995ae9eb0deebe20f55dbbf31d9bc5572f6ff0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: e6191e262dfdc866a5c15a870e61ece11c88a8fd
https://github.com/Perl/perl5/commit/e6191e262dfdc866a5c15a870e61ece11c88a8fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 4a3c8338c3b06535d7501d1252e97e1f9c06065a
https://github.com/Perl/perl5/commit/4a3c8338c3b06535d7501d1252e97e1f9c06065a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 3466f27eb5bf0d4d4d3430d3fa76a59fb20ecfda
https://github.com/Perl/perl5/commit/3466f27eb5bf0d4d4d3430d3fa76a59fb20ecfda
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 89bd61fa74cf0bf673ec1aee2fabf132f925e4a3
https://github.com/Perl/perl5/commit/89bd61fa74cf0bf673ec1aee2fabf132f925e4a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 6953d9b03b9f4491830c76d3260e4b7819b9de0b
https://github.com/Perl/perl5/commit/6953d9b03b9f4491830c76d3260e4b7819b9de0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 6a246f95d545e8ebe9dbd7a787fabb233142409f
https://github.com/Perl/perl5/commit/6a246f95d545e8ebe9dbd7a787fabb233142409f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 0b94c3b3ab75af13a4f6dc86b0887c98324b4567
https://github.com/Perl/perl5/commit/0b94c3b3ab75af13a4f6dc86b0887c98324b4567
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 5c56276285972b5cd948f41d80a0ba6f710fa6a2
https://github.com/Perl/perl5/commit/5c56276285972b5cd948f41d80a0ba6f710fa6a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 8cae35c0af4a4faee18189650c1c6dbc2ac19d8f
https://github.com/Perl/perl5/commit/8cae35c0af4a4faee18189650c1c6dbc2ac19d8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: f42cbc9298bc776eeaf8831b61ad293801f0f63a
https://github.com/Perl/perl5/commit/f42cbc9298bc776eeaf8831b61ad293801f0f63a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 500a5df436683f64c2644e14365944db6d37717a
https://github.com/Perl/perl5/commit/500a5df436683f64c2644e14365944db6d37717a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: e9dfa5f5a8d55096a17092e69b666c1d0136bef6
https://github.com/Perl/perl5/commit/e9dfa5f5a8d55096a17092e69b666c1d0136bef6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 33aca0e49a6c3a010c8e606a0a27f741d94bc33c
https://github.com/Perl/perl5/commit/33aca0e49a6c3a010c8e606a0a27f741d94bc33c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: f174ded0f24b7ceba9d1af547bc0b5528f9890e1
https://github.com/Perl/perl5/commit/f174ded0f24b7ceba9d1af547bc0b5528f9890e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 228bebd09cf2a4dde86eb7b5b562cc853d2e699c
https://github.com/Perl/perl5/commit/228bebd09cf2a4dde86eb7b5b562cc853d2e699c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: f7e5c44b254f3f25f77cd0d4b6424dd821b38f28
https://github.com/Perl/perl5/commit/f7e5c44b254f3f25f77cd0d4b6424dd821b38f28
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: d9b1d0695cc47b21bad099db758d1f84071445ad
https://github.com/Perl/perl5/commit/d9b1d0695cc47b21bad099db758d1f84071445ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: fff181437d88a0d8907cbfdc98b6248aba223afb
https://github.com/Perl/perl5/commit/fff181437d88a0d8907cbfdc98b6248aba223afb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 462ab908a80af327c4eb90e3012be4a673c628b6
https://github.com/Perl/perl5/commit/462ab908a80af327c4eb90e3012be4a673c628b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 07041ecb43bbf348ad035c625a7384feea94787f
https://github.com/Perl/perl5/commit/07041ecb43bbf348ad035c625a7384feea94787f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: dc3c4cee09cc3ef6612944838a348083f54861e8
https://github.com/Perl/perl5/commit/dc3c4cee09cc3ef6612944838a348083f54861e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: c7f9b847597f85cb9d4b90eafbb3164c36773a35
https://github.com/Perl/perl5/commit/c7f9b847597f85cb9d4b90eafbb3164c36773a35
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: b2f105bb2c839d72e9f87d04d1cbd90779b1ab96
https://github.com/Perl/perl5/commit/b2f105bb2c839d72e9f87d04d1cbd90779b1ab96
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 0bc86e23bbaca629a008ffd4596d5a04ad51b3ff
https://github.com/Perl/perl5/commit/0bc86e23bbaca629a008ffd4596d5a04ad51b3ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 673d66ba3c2344798d3d44a1cb8276cb15779f34
https://github.com/Perl/perl5/commit/673d66ba3c2344798d3d44a1cb8276cb15779f34
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 046cc5f84697e83278ad1f2aa1d306dda1feca1d
https://github.com/Perl/perl5/commit/046cc5f84697e83278ad1f2aa1d306dda1feca1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: d7c4fe475d50c07b0b3752b5110ae6d257c81400
https://github.com/Perl/perl5/commit/d7c4fe475d50c07b0b3752b5110ae6d257c81400
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: a08dc82642574615831a8f5ba345915052b68b6a
https://github.com/Perl/perl5/commit/a08dc82642574615831a8f5ba345915052b68b6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 37180568bf36b32a1b370404644314daa665954d
https://github.com/Perl/perl5/commit/37180568bf36b32a1b370404644314daa665954d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 87b48dd34c6232b352db3dfaf26a75d2b0752a0c
https://github.com/Perl/perl5/commit/87b48dd34c6232b352db3dfaf26a75d2b0752a0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 7030ae7af2ea6c6fe9ecd8a00fdde6eaa9848cf9
https://github.com/Perl/perl5/commit/7030ae7af2ea6c6fe9ecd8a00fdde6eaa9848cf9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: c9efd8970e30cb9bcc6a0dc758cbd9293d75a4bc
https://github.com/Perl/perl5/commit/c9efd8970e30cb9bcc6a0dc758cbd9293d75a4bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 8261729a0047dc225a292a39af1c8c3aab2a6467
https://github.com/Perl/perl5/commit/8261729a0047dc225a292a39af1c8c3aab2a6467
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 0341c9babe450ae7f7b0f84802c79c637fa04c00
https://github.com/Perl/perl5/commit/0341c9babe450ae7f7b0f84802c79c637fa04c00
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 22753016e43edb4ec8b1c8729cb5fc67ba26441c
https://github.com/Perl/perl5/commit/22753016e43edb4ec8b1c8729cb5fc67ba26441c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: fcfadb1b0d22aac12f2c31e1b44ad7ebc10fe3d2
https://github.com/Perl/perl5/commit/fcfadb1b0d22aac12f2c31e1b44ad7ebc10fe3d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: dd10f82e25b6e18cc8ef0c211e6ab1e836a07e64
https://github.com/Perl/perl5/commit/dd10f82e25b6e18cc8ef0c211e6ab1e836a07e64
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 221a899e20daaf2d115bea3950f5ddf2c3ced4f9
https://github.com/Perl/perl5/commit/221a899e20daaf2d115bea3950f5ddf2c3ced4f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: a75c151a2c2ed5240a3f47e69ee14b39e7665d20
https://github.com/Perl/perl5/commit/a75c151a2c2ed5240a3f47e69ee14b39e7665d20
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 65f857ab18b7b2ff5b858d875dbd7e57584dca8c
https://github.com/Perl/perl5/commit/65f857ab18b7b2ff5b858d875dbd7e57584dca8c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: af28f817f14e7836e32ac65ca3df17ceca95c1a4
https://github.com/Perl/perl5/commit/af28f817f14e7836e32ac65ca3df17ceca95c1a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 990a39399ea549b57c838ac643ab03b8b297e65d
https://github.com/Perl/perl5/commit/990a39399ea549b57c838ac643ab03b8b297e65d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 0270107a3a5ace044d5900c948ba7fc6be30b7af
https://github.com/Perl/perl5/commit/0270107a3a5ace044d5900c948ba7fc6be30b7af
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 646af23d716dcdeae8358716d5669988c2f57f7a
https://github.com/Perl/perl5/commit/646af23d716dcdeae8358716d5669988c2f57f7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 7d1f2d8a009526ad79e2d97971dfceda9bafe2d9
https://github.com/Perl/perl5/commit/7d1f2d8a009526ad79e2d97971dfceda9bafe2d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 42733d9ee3142e570bdbad54230daab850113067
https://github.com/Perl/perl5/commit/42733d9ee3142e570bdbad54230daab850113067
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: a5ab0b4d8fbe42b56529376780211532a1f49bb6
https://github.com/Perl/perl5/commit/a5ab0b4d8fbe42b56529376780211532a1f49bb6
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 65c096a82bcfbd1001f91b23e18e191865d05c08
https://github.com/Perl/perl5/commit/65c096a82bcfbd1001f91b23e18e191865d05c08
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 1d01fd2bd830703d1ab956bf8b31b7febd42e1f8
https://github.com/Perl/perl5/commit/1d01fd2bd830703d1ab956bf8b31b7febd42e1f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: bceed4b7fb37693a287af2b11fcc7a3ff890481b
https://github.com/Perl/perl5/commit/bceed4b7fb37693a287af2b11fcc7a3ff890481b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 22cf9c31503cfa17da2a036874978a306eae96ae
https://github.com/Perl/perl5/commit/22cf9c31503cfa17da2a036874978a306eae96ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: b56ea6b7882c3cc50887d6c94a952dc648236dea
https://github.com/Perl/perl5/commit/b56ea6b7882c3cc50887d6c94a952dc648236dea
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: d8746fc5c624623a39ec6a72633fdc81f6e44d07
https://github.com/Perl/perl5/commit/d8746fc5c624623a39ec6a72633fdc81f6e44d07
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 94b31938ad27fd122e8b925827733729ceda84b9
https://github.com/Perl/perl5/commit/94b31938ad27fd122e8b925827733729ceda84b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: a6f7c5d6dcce4fb5875d305f3ee683c205688c10
https://github.com/Perl/perl5/commit/a6f7c5d6dcce4fb5875d305f3ee683c205688c10
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 06409ff5ee4165f013649824449ba60897d626c1
https://github.com/Perl/perl5/commit/06409ff5ee4165f013649824449ba60897d626c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 63a0c7799282f3eb5ffe16cf324a44ce52e92c7b
https://github.com/Perl/perl5/commit/63a0c7799282f3eb5ffe16cf324a44ce52e92c7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 2ae9fefc051634da6c6864c9c245a1e696fa87ba
https://github.com/Perl/perl5/commit/2ae9fefc051634da6c6864c9c245a1e696fa87ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: d982a5d34e5d5cb4db627d22b816c614b803b00f
https://github.com/Perl/perl5/commit/d982a5d34e5d5cb4db627d22b816c614b803b00f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 62254caf0a25cfcb9ba26332dcf0aa2dabf6f61b
https://github.com/Perl/perl5/commit/62254caf0a25cfcb9ba26332dcf0aa2dabf6f61b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 71cc948077301cc113ab05e8de06007f6690f29b
https://github.com/Perl/perl5/commit/71cc948077301cc113ab05e8de06007f6690f29b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: a39e91da03606ae4e948991be1ef8cd68f1ec0ce
https://github.com/Perl/perl5/commit/a39e91da03606ae4e948991be1ef8cd68f1ec0ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 36ed3223b99792c1a7c6168c7061758862598ac2
https://github.com/Perl/perl5/commit/36ed3223b99792c1a7c6168c7061758862598ac2
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: ca27125533d6c5028fb552c0553259ceb0b12703
https://github.com/Perl/perl5/commit/ca27125533d6c5028fb552c0553259ceb0b12703
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 20f79418c9936f0637c7743dd9b6b66729e1e064
https://github.com/Perl/perl5/commit/20f79418c9936f0637c7743dd9b6b66729e1e064
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 9620f3bf099c3fc4490cbd94a4d8d2f6be8827fb
https://github.com/Perl/perl5/commit/9620f3bf099c3fc4490cbd94a4d8d2f6be8827fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 39a93aba1816c4cda2784db1e2bf4cf00342cea9
https://github.com/Perl/perl5/commit/39a93aba1816c4cda2784db1e2bf4cf00342cea9
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 89415557f51267c3c4c3fbfc1d0571736b83cf3f
https://github.com/Perl/perl5/commit/89415557f51267c3c4c3fbfc1d0571736b83cf3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 39a1490ed10f6bfb2d0c8c514226de0159dfb999
https://github.com/Perl/perl5/commit/39a1490ed10f6bfb2d0c8c514226de0159dfb999
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 0e4554cd10600d656eddffb34dbddea2f9c9e881
https://github.com/Perl/perl5/commit/0e4554cd10600d656eddffb34dbddea2f9c9e881
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 19e1ecb54b795c4825263fc6fda74e7e26bce6e4
https://github.com/Perl/perl5/commit/19e1ecb54b795c4825263fc6fda74e7e26bce6e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: b84ce7916d29d28eaaffd12a7081163b2ba71cfa
https://github.com/Perl/perl5/commit/b84ce7916d29d28eaaffd12a7081163b2ba71cfa
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 51be6413b2d245c58f6899b75a42d015e15dc347
https://github.com/Perl/perl5/commit/51be6413b2d245c58f6899b75a42d015e15dc347
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: e796050052a2ecec041e2bc19f71600fcffedaa4
https://github.com/Perl/perl5/commit/e796050052a2ecec041e2bc19f71600fcffedaa4
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 8e65b9feabca27f885e04ab7b78ddfda23534327
https://github.com/Perl/perl5/commit/8e65b9feabca27f885e04ab7b78ddfda23534327
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 254d1026beea47d111fe18c9b60726f75e3daa28
https://github.com/Perl/perl5/commit/254d1026beea47d111fe18c9b60726f75e3daa28
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 9047d26c56cc9e234f7aa0288d3c866c534ab888
https://github.com/Perl/perl5/commit/9047d26c56cc9e234f7aa0288d3c866c534ab888
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 6e184c0335b06aa189ff2797498e822d9a609faa
https://github.com/Perl/perl5/commit/6e184c0335b06aa189ff2797498e822d9a609faa
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: b068ebf590c5e7f9906f8fb2fc7be1e5b96bf38f
https://github.com/Perl/perl5/commit/b068ebf590c5e7f9906f8fb2fc7be1e5b96bf38f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 5f8b282eb7f3d75d2b821756d79e25e8d3212ec7
https://github.com/Perl/perl5/commit/5f8b282eb7f3d75d2b821756d79e25e8d3212ec7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 51d42dc20295d60181c49b452720c917c851647c
https://github.com/Perl/perl5/commit/51d42dc20295d60181c49b452720c917c851647c
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 2bbee236f0d3ea731fb0f45b3e25c64038226cdc
https://github.com/Perl/perl5/commit/2bbee236f0d3ea731fb0f45b3e25c64038226cdc
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 589843541fd1d78c727cf18d1d2c938617f98b29
https://github.com/Perl/perl5/commit/589843541fd1d78c727cf18d1d2c938617f98b29
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 59e583a2941740140cdfee08d89d195ebf29a3cd
https://github.com/Perl/perl5/commit/59e583a2941740140cdfee08d89d195ebf29a3cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: c1c4e8fd023d56483358993896f60bb3c3967863
https://github.com/Perl/perl5/commit/c1c4e8fd023d56483358993896f60bb3c3967863
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 911c2ed6d16cda668a78457244bf287765794161
https://github.com/Perl/perl5/commit/911c2ed6d16cda668a78457244bf287765794161
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: ceef585f70d95c5b7437172efb912d74e694c31b
https://github.com/Perl/perl5/commit/ceef585f70d95c5b7437172efb912d74e694c31b
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 1364974c565c00e1aeed48bfba2a460360403bb7
https://github.com/Perl/perl5/commit/1364974c565c00e1aeed48bfba2a460360403bb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: fff115a18adda0db9fbe0652cbb2580b636ebc5d
https://github.com/Perl/perl5/commit/fff115a18adda0db9fbe0652cbb2580b636ebc5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: e0ef0259a72a76659d7219a4b968e2ade104a472
https://github.com/Perl/perl5/commit/e0ef0259a72a76659d7219a4b968e2ade104a472
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: c24e211f78f88c9e3e4228e8b9e14115d20aa6aa
https://github.com/Perl/perl5/commit/c24e211f78f88c9e3e4228e8b9e14115d20aa6aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: bb34f3226ab6b93e42fa86b280a43fd88715ef86
https://github.com/Perl/perl5/commit/bb34f3226ab6b93e42fa86b280a43fd88715ef86
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: f64fe803a9e032c1db583dc63a5e78a490fc9087
https://github.com/Perl/perl5/commit/f64fe803a9e032c1db583dc63a5e78a490fc9087
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 58cb7929e1381cd5b1f0d11c9d800e82c772bcf0
https://github.com/Perl/perl5/commit/58cb7929e1381cd5b1f0d11c9d800e82c772bcf0
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 28f5ae6c75d6111a6f9dc9b9fe1f8f603958939e
https://github.com/Perl/perl5/commit/28f5ae6c75d6111a6f9dc9b9fe1f8f603958939e
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 1fb970389775eceaf667bce0ff16b4c67c2c944f
https://github.com/Perl/perl5/commit/1fb970389775eceaf667bce0ff16b4c67c2c944f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: d74612a14e78096197415ac3501807caec57722d
https://github.com/Perl/perl5/commit/d74612a14e78096197415ac3501807caec57722d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 755773eeaa0f18c7f5a361da2848a23e60f9a388
https://github.com/Perl/perl5/commit/755773eeaa0f18c7f5a361da2848a23e60f9a388
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: f100f145481af173bc29079667053acb9cf2b89f
https://github.com/Perl/perl5/commit/f100f145481af173bc29079667053acb9cf2b89f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 369f99bcfb5e8ca91553dd51ec407368c7806c69
https://github.com/Perl/perl5/commit/369f99bcfb5e8ca91553dd51ec407368c7806c69
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 3dae185e06a0850633b0752a38fce0763b6c729a
https://github.com/Perl/perl5/commit/3dae185e06a0850633b0752a38fce0763b6c729a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 485f6951c848b21efa564d60f71f9a9cec794055
https://github.com/Perl/perl5/commit/485f6951c848b21efa564d60f71f9a9cec794055
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 80d6daa86ec75e0cb9e54004f22875562e6094ab
https://github.com/Perl/perl5/commit/80d6daa86ec75e0cb9e54004f22875562e6094ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 925b34da39a01bc4b0ede8c2a4f0de235b1b7399
https://github.com/Perl/perl5/commit/925b34da39a01bc4b0ede8c2a4f0de235b1b7399
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 3efa35bac46d844e7dc50f18e2cfb7840408b5e8
https://github.com/Perl/perl5/commit/3efa35bac46d844e7dc50f18e2cfb7840408b5e8
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: f76392d68e1c40c521a7e076c51e1b1687238e2f
https://github.com/Perl/perl5/commit/f76392d68e1c40c521a7e076c51e1b1687238e2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 0577cbbeaebf8c94ec26e033061a25619cc82877
https://github.com/Perl/perl5/commit/0577cbbeaebf8c94ec26e033061a25619cc82877
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: bdb0792df2498963b57e05db0bf0400d6017d700
https://github.com/Perl/perl5/commit/bdb0792df2498963b57e05db0bf0400d6017d700
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: a0ab487e9f4ce61f13df9657bd6b8fdbbeab8f3a
https://github.com/Perl/perl5/commit/a0ab487e9f4ce61f13df9657bd6b8fdbbeab8f3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: f4458429e11a13e7d39ef6a40129cad75733bf31
https://github.com/Perl/perl5/commit/f4458429e11a13e7d39ef6a40129cad75733bf31
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 39e2f5258523aebb68631908a9cc09af76b42f5f
https://github.com/Perl/perl5/commit/39e2f5258523aebb68631908a9cc09af76b42f5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
30
Commit: b4b0f3637f02096d2acbaaa2412088052974c73d
https://github.com/Perl/perl5/commit/b4b0f3637f02096d2acbaaa2412088052974c73d
Author: Karl Williamson <[email protected]>
Date: 2021-04-16 (Fri, 16 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M lib/locale.t
M lib/locale_threads.t
M t/loc_tools.pl
Log Message:
-----------
31
Compare: https://github.com/Perl/perl5/compare/a4d9a52013b5...b4b0f3637f02
