Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 1dfcf420fb3fbb5b80ca3d3a18dbe2b02f8629fb
https://github.com/Perl/perl5/commit/1dfcf420fb3fbb5b80ca3d3a18dbe2b02f8629fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 143e525e6deb603fcd85bc4aa9e209d9c14c1cd9
https://github.com/Perl/perl5/commit/143e525e6deb603fcd85bc4aa9e209d9c14c1cd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: e12b0e525a69a3a750dcd46fd017ca6410e562b1
https://github.com/Perl/perl5/commit/e12b0e525a69a3a750dcd46fd017ca6410e562b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: b0a662bd37cc77b9ede8c1a7a81491558a6e069d
https://github.com/Perl/perl5/commit/b0a662bd37cc77b9ede8c1a7a81491558a6e069d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 02660172e8b3d15c9859f1236aa7674f3faedb67
https://github.com/Perl/perl5/commit/02660172e8b3d15c9859f1236aa7674f3faedb67
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 1200ae569344fdfb05cad658e03bc3d86f3bf51d
https://github.com/Perl/perl5/commit/1200ae569344fdfb05cad658e03bc3d86f3bf51d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: ebc5873f313d30fd6117c27be88ac294ed2c0754
https://github.com/Perl/perl5/commit/ebc5873f313d30fd6117c27be88ac294ed2c0754
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 53bb25c09a73928dbfa32919c617f78cf0131826
https://github.com/Perl/perl5/commit/53bb25c09a73928dbfa32919c617f78cf0131826
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 8db19033b8e1f6b9a336149d9f2720b76fc370a1
https://github.com/Perl/perl5/commit/8db19033b8e1f6b9a336149d9f2720b76fc370a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 97f9034a4451d36842c2d7ac3abd8746751e8578
https://github.com/Perl/perl5/commit/97f9034a4451d36842c2d7ac3abd8746751e8578
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 5653130d81780090cd81c042d62be44c81ec5384
https://github.com/Perl/perl5/commit/5653130d81780090cd81c042d62be44c81ec5384
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: a1a575f8eedaa5191723a33b673483b8a3b5933f
https://github.com/Perl/perl5/commit/a1a575f8eedaa5191723a33b673483b8a3b5933f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: f491c3fc7ded683cb28596fd0b38d98c2f77e59b
https://github.com/Perl/perl5/commit/f491c3fc7ded683cb28596fd0b38d98c2f77e59b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: f96c029601bebdd0c1abef623777d46993a895dc
https://github.com/Perl/perl5/commit/f96c029601bebdd0c1abef623777d46993a895dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 270a9379ca548751065115cf0a774558ac68ac2f
https://github.com/Perl/perl5/commit/270a9379ca548751065115cf0a774558ac68ac2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: c008d6f26f591bb5cc66fda360183255e468dd31
https://github.com/Perl/perl5/commit/c008d6f26f591bb5cc66fda360183255e468dd31
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 544ea0b282239889ca751b2e7fc5acd4178497e2
https://github.com/Perl/perl5/commit/544ea0b282239889ca751b2e7fc5acd4178497e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 0e83a19e6def4835e2daf5c11feb81069df6952a
https://github.com/Perl/perl5/commit/0e83a19e6def4835e2daf5c11feb81069df6952a
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 47afa48156e986ad835081c7ac1afd8fca0ecd99
https://github.com/Perl/perl5/commit/47afa48156e986ad835081c7ac1afd8fca0ecd99
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 0b3fc3fc46c42e0ec20b03017946b7c1a6fddb05
https://github.com/Perl/perl5/commit/0b3fc3fc46c42e0ec20b03017946b7c1a6fddb05
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: dcf7817cdb834609c5c694809abfbaa4f1943055
https://github.com/Perl/perl5/commit/dcf7817cdb834609c5c694809abfbaa4f1943055
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 6ad1cf56e216c09dc5f0b8b1f153c991486fd838
https://github.com/Perl/perl5/commit/6ad1cf56e216c09dc5f0b8b1f153c991486fd838
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 80903843ced78d44aac3a87b08ec39ead82bf47a
https://github.com/Perl/perl5/commit/80903843ced78d44aac3a87b08ec39ead82bf47a
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 43b82d1554e292ed015b235128dd5dfeaa84b26f
https://github.com/Perl/perl5/commit/43b82d1554e292ed015b235128dd5dfeaa84b26f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 7dba72e2faeee23f16788f8e04febdaa10e1c18b
https://github.com/Perl/perl5/commit/7dba72e2faeee23f16788f8e04febdaa10e1c18b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 4b7bc4a668d3fa6e4f36bec7440b0f9be699947d
https://github.com/Perl/perl5/commit/4b7bc4a668d3fa6e4f36bec7440b0f9be699947d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 203385211d27507fc7a3ad8d48ca06e96b5b314b
https://github.com/Perl/perl5/commit/203385211d27507fc7a3ad8d48ca06e96b5b314b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 2828e1bf25b8f636b21a94fed0c054c226e8050c
https://github.com/Perl/perl5/commit/2828e1bf25b8f636b21a94fed0c054c226e8050c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: cdae1352ff174981e27aa0bba2394b9fed057083
https://github.com/Perl/perl5/commit/cdae1352ff174981e27aa0bba2394b9fed057083
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: c503fe74b862f768dacdc770c8014869ea72ab9e
https://github.com/Perl/perl5/commit/c503fe74b862f768dacdc770c8014869ea72ab9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 7d95f291f44cb970fcaec65eaaa630e1e9d2500e
https://github.com/Perl/perl5/commit/7d95f291f44cb970fcaec65eaaa630e1e9d2500e
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 771af2572fa840ae71c0d112594be7915942d4ad
https://github.com/Perl/perl5/commit/771af2572fa840ae71c0d112594be7915942d4ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 7892cad91928a771a584962ffdadec1c1eea9b43
https://github.com/Perl/perl5/commit/7892cad91928a771a584962ffdadec1c1eea9b43
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: c44be8ea6d4ebe049140536e8e9c91a7e9734d07
https://github.com/Perl/perl5/commit/c44be8ea6d4ebe049140536e8e9c91a7e9734d07
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 35d712a60c43fedbeb6205ed2287c7896bc2d481
https://github.com/Perl/perl5/commit/35d712a60c43fedbeb6205ed2287c7896bc2d481
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 2c53ae9251f44a10f75e91c5f55b61739b2a641c
https://github.com/Perl/perl5/commit/2c53ae9251f44a10f75e91c5f55b61739b2a641c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: e23265a0ad6abb7645c57edbe92c502b3c67a0b0
https://github.com/Perl/perl5/commit/e23265a0ad6abb7645c57edbe92c502b3c67a0b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 582210e8d678af5ebcee6ed217cea61da8510902
https://github.com/Perl/perl5/commit/582210e8d678af5ebcee6ed217cea61da8510902
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 123c88014f5a6fa917129b54752ce3a10e559f59
https://github.com/Perl/perl5/commit/123c88014f5a6fa917129b54752ce3a10e559f59
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 4c6985ee31b74af65fbc2af15125f8868476a564
https://github.com/Perl/perl5/commit/4c6985ee31b74af65fbc2af15125f8868476a564
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: c946b2eda7a50dbb256a8758e420f18b384f3c80
https://github.com/Perl/perl5/commit/c946b2eda7a50dbb256a8758e420f18b384f3c80
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 789438b9693e3f18192d69bf1179034b7a0b63d8
https://github.com/Perl/perl5/commit/789438b9693e3f18192d69bf1179034b7a0b63d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 84f6494f88b52962ce27788d767badb0eba7a0f8
https://github.com/Perl/perl5/commit/84f6494f88b52962ce27788d767badb0eba7a0f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 35d8bd0c89ac7434f0c265a78b94bcb40c35b75c
https://github.com/Perl/perl5/commit/35d8bd0c89ac7434f0c265a78b94bcb40c35b75c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 19eb2aeafec627d5692656e966a1457aeb00f421
https://github.com/Perl/perl5/commit/19eb2aeafec627d5692656e966a1457aeb00f421
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 31d2759fd99475522517154e198bcabe243b7e8d
https://github.com/Perl/perl5/commit/31d2759fd99475522517154e198bcabe243b7e8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 0e0a16f0e7548c0de2615ca5be34548c785b2b1f
https://github.com/Perl/perl5/commit/0e0a16f0e7548c0de2615ca5be34548c785b2b1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 048053ee8a68ed8a34bcbc2b6e70e5cc71751c56
https://github.com/Perl/perl5/commit/048053ee8a68ed8a34bcbc2b6e70e5cc71751c56
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 373bbe9e8c217b7467af4a121a0ef27dec1d9492
https://github.com/Perl/perl5/commit/373bbe9e8c217b7467af4a121a0ef27dec1d9492
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 13fefc6a1cc75fc6e91075cb864d2592165062b5
https://github.com/Perl/perl5/commit/13fefc6a1cc75fc6e91075cb864d2592165062b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 0fe41f27adf18abc7db6193f0902776e26356280
https://github.com/Perl/perl5/commit/0fe41f27adf18abc7db6193f0902776e26356280
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 172cfefd6bfb057990b0aa924e4c5383fa33eb5d
https://github.com/Perl/perl5/commit/172cfefd6bfb057990b0aa924e4c5383fa33eb5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: d0ff0693da664d597b8f1b7d173ef8716d7ceeaa
https://github.com/Perl/perl5/commit/d0ff0693da664d597b8f1b7d173ef8716d7ceeaa
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 3fb6827b6e1b96a10d1d1263b8644ddb1ab63006
https://github.com/Perl/perl5/commit/3fb6827b6e1b96a10d1d1263b8644ddb1ab63006
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 9ab4a30f0cfe09736296aef681510f6ba447add6
https://github.com/Perl/perl5/commit/9ab4a30f0cfe09736296aef681510f6ba447add6
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: a79e57b5397eff371df2398d76f49bf15fae9441
https://github.com/Perl/perl5/commit/a79e57b5397eff371df2398d76f49bf15fae9441
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 29b40e9c6a193aac323ab4f6001dfc1ea1fa2e0f
https://github.com/Perl/perl5/commit/29b40e9c6a193aac323ab4f6001dfc1ea1fa2e0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: cb4372986b77511471c3aab7c7d0cd61694a0639
https://github.com/Perl/perl5/commit/cb4372986b77511471c3aab7c7d0cd61694a0639
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: f9dd36bcf9d77bb368b52baacb0ad420ff586591
https://github.com/Perl/perl5/commit/f9dd36bcf9d77bb368b52baacb0ad420ff586591
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: d151dfda16d72cf84dbb3d6ea6b7f257a04c8c4b
https://github.com/Perl/perl5/commit/d151dfda16d72cf84dbb3d6ea6b7f257a04c8c4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 0bd4332bbaa4ce7ea5f4f345a153319629984a16
https://github.com/Perl/perl5/commit/0bd4332bbaa4ce7ea5f4f345a153319629984a16
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 1b194a641b213d8d338a7cee62d86a78a9a47043
https://github.com/Perl/perl5/commit/1b194a641b213d8d338a7cee62d86a78a9a47043
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: b8510a591e745297a365c052db5c486624e9a653
https://github.com/Perl/perl5/commit/b8510a591e745297a365c052db5c486624e9a653
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 34aa8068815ef465a74d79fa29fd44d51911b147
https://github.com/Perl/perl5/commit/34aa8068815ef465a74d79fa29fd44d51911b147
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: bd8aa1f9c6550c53888ef8ca71df440140509349
https://github.com/Perl/perl5/commit/bd8aa1f9c6550c53888ef8ca71df440140509349
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: e9d63f355c115b9966d34244d4a1c67b529c78a0
https://github.com/Perl/perl5/commit/e9d63f355c115b9966d34244d4a1c67b529c78a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: a086aec2d99b833cd8e89b5a6774b36bfed4d8d1
https://github.com/Perl/perl5/commit/a086aec2d99b833cd8e89b5a6774b36bfed4d8d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 59609496d7c37b796eb4d24c319fcfd1bfe7dd63
https://github.com/Perl/perl5/commit/59609496d7c37b796eb4d24c319fcfd1bfe7dd63
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: dacd6e569254acc829f26e9a9b21bb320e01a6e1
https://github.com/Perl/perl5/commit/dacd6e569254acc829f26e9a9b21bb320e01a6e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 41e058c99ba74ee5a519076574ecd01c7a3182b0
https://github.com/Perl/perl5/commit/41e058c99ba74ee5a519076574ecd01c7a3182b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 4837b8cd848904b5ce1882b3377cd035be0dc2b3
https://github.com/Perl/perl5/commit/4837b8cd848904b5ce1882b3377cd035be0dc2b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 93ab30391b40db35f3467614bf50a0119472553c
https://github.com/Perl/perl5/commit/93ab30391b40db35f3467614bf50a0119472553c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: d1d3521750973795075591da65a155036a277e63
https://github.com/Perl/perl5/commit/d1d3521750973795075591da65a155036a277e63
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: e6cc989aa01b68caa1b5648221318cffb3e53178
https://github.com/Perl/perl5/commit/e6cc989aa01b68caa1b5648221318cffb3e53178
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: ef8cf95fae9f81b88212fea9cd27430f89d32c99
https://github.com/Perl/perl5/commit/ef8cf95fae9f81b88212fea9cd27430f89d32c99
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: dcb88ae30771637dd1f45aa207fa6cc8959ac58b
https://github.com/Perl/perl5/commit/dcb88ae30771637dd1f45aa207fa6cc8959ac58b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 5a6b954941d42831a393a10ec77dcff20afa0f7f
https://github.com/Perl/perl5/commit/5a6b954941d42831a393a10ec77dcff20afa0f7f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: ac4587659e9b129f6827e853ef88fa9189d4b83c
https://github.com/Perl/perl5/commit/ac4587659e9b129f6827e853ef88fa9189d4b83c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 8c52cc6af9ad9670a2f8c6f35a427dcf534f1641
https://github.com/Perl/perl5/commit/8c52cc6af9ad9670a2f8c6f35a427dcf534f1641
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 0281c724a1596d76202b5fca3321266e8005d844
https://github.com/Perl/perl5/commit/0281c724a1596d76202b5fca3321266e8005d844
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: c0dd5c408d60d325eb5c7ed401b6b81b734ac00f
https://github.com/Perl/perl5/commit/c0dd5c408d60d325eb5c7ed401b6b81b734ac00f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 378e2c34c5d14b6c8deb57bf59b02d565d16bc02
https://github.com/Perl/perl5/commit/378e2c34c5d14b6c8deb57bf59b02d565d16bc02
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 69a6d24d0a22dc1a181eb3ecd76d48829093c1fd
https://github.com/Perl/perl5/commit/69a6d24d0a22dc1a181eb3ecd76d48829093c1fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: b0853ab35b18f844c28206d95fada61a2113829b
https://github.com/Perl/perl5/commit/b0853ab35b18f844c28206d95fada61a2113829b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 35b4ff5ac56eaba592dc56122e55941e6a7993a1
https://github.com/Perl/perl5/commit/35b4ff5ac56eaba592dc56122e55941e6a7993a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 4262ac44576b7e60915342d9598dedfbc04f09c6
https://github.com/Perl/perl5/commit/4262ac44576b7e60915342d9598dedfbc04f09c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 808c88dec6978edcebe1865596b617f77b8ff416
https://github.com/Perl/perl5/commit/808c88dec6978edcebe1865596b617f77b8ff416
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 87f686952441b9c3027fc94d517fff90f370fd14
https://github.com/Perl/perl5/commit/87f686952441b9c3027fc94d517fff90f370fd14
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: ed91ea241d5f9ada60b946a8990819e5411333ed
https://github.com/Perl/perl5/commit/ed91ea241d5f9ada60b946a8990819e5411333ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: b31e6dd3019cf62c5f6e775c1cf69057fd245af3
https://github.com/Perl/perl5/commit/b31e6dd3019cf62c5f6e775c1cf69057fd245af3
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: b976bb9fa3bcb4bda27f89e769f229c8e83d12c2
https://github.com/Perl/perl5/commit/b976bb9fa3bcb4bda27f89e769f229c8e83d12c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 50890da0a42b495b57e6800e181f7812f8272c34
https://github.com/Perl/perl5/commit/50890da0a42b495b57e6800e181f7812f8272c34
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 0450d8728a22ee320d6557377dc86b54313a8d48
https://github.com/Perl/perl5/commit/0450d8728a22ee320d6557377dc86b54313a8d48
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 8a7096de842ddc290a3f6f377543129830f68b46
https://github.com/Perl/perl5/commit/8a7096de842ddc290a3f6f377543129830f68b46
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: fc8768215c9e68eda29c8c65521486b01d36d689
https://github.com/Perl/perl5/commit/fc8768215c9e68eda29c8c65521486b01d36d689
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: cff0c4e673afe62b1cc73b195536c959ecddf473
https://github.com/Perl/perl5/commit/cff0c4e673afe62b1cc73b195536c959ecddf473
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 53e7e5391b636c8cf9602a65f3b29b606d6a12a3
https://github.com/Perl/perl5/commit/53e7e5391b636c8cf9602a65f3b29b606d6a12a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 92ce6d820b53f62453ed9f1c2f739b4207bc4792
https://github.com/Perl/perl5/commit/92ce6d820b53f62453ed9f1c2f739b4207bc4792
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 57ea07da5bd18d557049970342028545d74efabf
https://github.com/Perl/perl5/commit/57ea07da5bd18d557049970342028545d74efabf
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 23f6d054fcc811117a8cfe7a33bb182854d6eb8e
https://github.com/Perl/perl5/commit/23f6d054fcc811117a8cfe7a33bb182854d6eb8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: d98949ec0af4221ffb4998394ca07f6c41940850
https://github.com/Perl/perl5/commit/d98949ec0af4221ffb4998394ca07f6c41940850
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 3a2f9add9f197df13bc822b7a1707a9234d6f584
https://github.com/Perl/perl5/commit/3a2f9add9f197df13bc822b7a1707a9234d6f584
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 30a7e29e1517cd8df9c7cd817461c1871018b46c
https://github.com/Perl/perl5/commit/30a7e29e1517cd8df9c7cd817461c1871018b46c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 3f974f2de0debc53ee6e238313189b0ded7529d8
https://github.com/Perl/perl5/commit/3f974f2de0debc53ee6e238313189b0ded7529d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: e185923443992c6ffc60efcca823d213f14b4e07
https://github.com/Perl/perl5/commit/e185923443992c6ffc60efcca823d213f14b4e07
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 289eefb7c6ef0450d41c9be2d3692139b441ee29
https://github.com/Perl/perl5/commit/289eefb7c6ef0450d41c9be2d3692139b441ee29
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: e25327e9a019e081159f31596fd6bb75a0e8dbeb
https://github.com/Perl/perl5/commit/e25327e9a019e081159f31596fd6bb75a0e8dbeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: dfa0fc0c865bd7a90c982afcbc2191846a131e50
https://github.com/Perl/perl5/commit/dfa0fc0c865bd7a90c982afcbc2191846a131e50
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: ed707ab3798597118c370ae57112864edcea7e4b
https://github.com/Perl/perl5/commit/ed707ab3798597118c370ae57112864edcea7e4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 9de1f738828e458a23920c78dfb74ba048cc6612
https://github.com/Perl/perl5/commit/9de1f738828e458a23920c78dfb74ba048cc6612
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 0771cb6f5dea00fa3beeabee5a816335c22770cf
https://github.com/Perl/perl5/commit/0771cb6f5dea00fa3beeabee5a816335c22770cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 68ee3efcec3598284358e472144a1fdc0459e02f
https://github.com/Perl/perl5/commit/68ee3efcec3598284358e472144a1fdc0459e02f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: b963f69983029fa863be6ac420283c224c2d0876
https://github.com/Perl/perl5/commit/b963f69983029fa863be6ac420283c224c2d0876
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: e3369b1fcb3592f4d8cd1c18b3a545f42ce401e0
https://github.com/Perl/perl5/commit/e3369b1fcb3592f4d8cd1c18b3a545f42ce401e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: a3a0f6f11742ea0b1a7e89306c37851db973fb76
https://github.com/Perl/perl5/commit/a3a0f6f11742ea0b1a7e89306c37851db973fb76
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: d5a35bcd0b6af02b5235e45fd380ff710c612ab2
https://github.com/Perl/perl5/commit/d5a35bcd0b6af02b5235e45fd380ff710c612ab2
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: e36687000830fee020482ea1366391fa4ce7f357
https://github.com/Perl/perl5/commit/e36687000830fee020482ea1366391fa4ce7f357
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 4b5fcb5f02c90289cfc55a5048e0d00aa15e1bf7
https://github.com/Perl/perl5/commit/4b5fcb5f02c90289cfc55a5048e0d00aa15e1bf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 4e39a7270893105ebbcdf6d95227c83d8cef9c48
https://github.com/Perl/perl5/commit/4e39a7270893105ebbcdf6d95227c83d8cef9c48
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 5bbf9e5e5db76b44e86bb56a415cd98efaf57b1d
https://github.com/Perl/perl5/commit/5bbf9e5e5db76b44e86bb56a415cd98efaf57b1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 1ede1bae4177e2802fcfdae21be674ff5e47fb76
https://github.com/Perl/perl5/commit/1ede1bae4177e2802fcfdae21be674ff5e47fb76
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 4741a7e24c5f641afb8fae387b567383fc45483b
https://github.com/Perl/perl5/commit/4741a7e24c5f641afb8fae387b567383fc45483b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 8a395dd46b91abf782f2593865fc90d8dd31c6bc
https://github.com/Perl/perl5/commit/8a395dd46b91abf782f2593865fc90d8dd31c6bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 9da44844a892901255479e1e569aaaec31e53045
https://github.com/Perl/perl5/commit/9da44844a892901255479e1e569aaaec31e53045
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: f0da20bcdfe2d88c56e956c5ad4065c8b7806179
https://github.com/Perl/perl5/commit/f0da20bcdfe2d88c56e956c5ad4065c8b7806179
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: be3737cef62b3f01a135fc4c3273631b60ac1514
https://github.com/Perl/perl5/commit/be3737cef62b3f01a135fc4c3273631b60ac1514
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 7964d3f1611ad20326f445506f44b7911cda44bf
https://github.com/Perl/perl5/commit/7964d3f1611ad20326f445506f44b7911cda44bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 96e3e08ad078bf7fd1ccc3d5b8a843764fa0b283
https://github.com/Perl/perl5/commit/96e3e08ad078bf7fd1ccc3d5b8a843764fa0b283
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 5588bdbfe8cb581402a71816be7bc34ed0ff4155
https://github.com/Perl/perl5/commit/5588bdbfe8cb581402a71816be7bc34ed0ff4155
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 14802fd85ca01b70d82836cf5e6eb8e5c4ef257e
https://github.com/Perl/perl5/commit/14802fd85ca01b70d82836cf5e6eb8e5c4ef257e
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: a7b7b2b8ad47cdbb185c1c00342bd6d4bc29bc31
https://github.com/Perl/perl5/commit/a7b7b2b8ad47cdbb185c1c00342bd6d4bc29bc31
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: c826e14c2231706d33f6c880dd1769afe96f0157
https://github.com/Perl/perl5/commit/c826e14c2231706d33f6c880dd1769afe96f0157
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 45fedda87b7a181c8479d979dcfeb0f69dd184cd
https://github.com/Perl/perl5/commit/45fedda87b7a181c8479d979dcfeb0f69dd184cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: efae6fe17b186e8bf656e008b688bec37d84bbfb
https://github.com/Perl/perl5/commit/efae6fe17b186e8bf656e008b688bec37d84bbfb
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: ffbdf1ba33ff52fcb8d620501aacce006d469c20
https://github.com/Perl/perl5/commit/ffbdf1ba33ff52fcb8d620501aacce006d469c20
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: bd96c93d5bd0447534ed14781ea7e19d97cb0aa9
https://github.com/Perl/perl5/commit/bd96c93d5bd0447534ed14781ea7e19d97cb0aa9
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: d40c9570c7ff24c24bb6aa09d56b966e4c5a1f6b
https://github.com/Perl/perl5/commit/d40c9570c7ff24c24bb6aa09d56b966e4c5a1f6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 1aa84b51636d423ef21c9f23742b4b7ed9b3d775
https://github.com/Perl/perl5/commit/1aa84b51636d423ef21c9f23742b4b7ed9b3d775
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: da867666be49f06a9523eb1ba8e4fd8c0ead3792
https://github.com/Perl/perl5/commit/da867666be49f06a9523eb1ba8e4fd8c0ead3792
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 356d6d699b05705db2abc56ac4fda64cd5e5a727
https://github.com/Perl/perl5/commit/356d6d699b05705db2abc56ac4fda64cd5e5a727
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 268db11b6cbaf2aed7d9d7498febf4ab6297b4e0
https://github.com/Perl/perl5/commit/268db11b6cbaf2aed7d9d7498febf4ab6297b4e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 3a708da1a24722485a7e9faab68ffc3ca230459e
https://github.com/Perl/perl5/commit/3a708da1a24722485a7e9faab68ffc3ca230459e
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 88690d77018748069de03602c3edadf3e2f9a620
https://github.com/Perl/perl5/commit/88690d77018748069de03602c3edadf3e2f9a620
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 45213bbbce1f525f2318815fda6ccafbfc72e75c
https://github.com/Perl/perl5/commit/45213bbbce1f525f2318815fda6ccafbfc72e75c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: a02d03f044b8eff633f6b4c02cd3cca48785f251
https://github.com/Perl/perl5/commit/a02d03f044b8eff633f6b4c02cd3cca48785f251
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 940c1d30d7b640e1c995fadf076e0676f2e5000d
https://github.com/Perl/perl5/commit/940c1d30d7b640e1c995fadf076e0676f2e5000d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 0055f6fede103bc24baf91155854f30e3dc01cf4
https://github.com/Perl/perl5/commit/0055f6fede103bc24baf91155854f30e3dc01cf4
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 596dbf8d1298096a10c5b91be130bb160461a54c
https://github.com/Perl/perl5/commit/596dbf8d1298096a10c5b91be130bb160461a54c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 6ab592289c1885c08684d58d9d306a4bfd50c8ff
https://github.com/Perl/perl5/commit/6ab592289c1885c08684d58d9d306a4bfd50c8ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: d35c234d90470eb1c0dfbf6968ed89b43d2423d8
https://github.com/Perl/perl5/commit/d35c234d90470eb1c0dfbf6968ed89b43d2423d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: d579ee4c9fd5e19b1af7c27fe141cd40ebed8cc2
https://github.com/Perl/perl5/commit/d579ee4c9fd5e19b1af7c27fe141cd40ebed8cc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 129234d5eafa0eca4f4bb3e29f359459fad2d41c
https://github.com/Perl/perl5/commit/129234d5eafa0eca4f4bb3e29f359459fad2d41c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 77b2b0555bfe9df40d7ac0957ddba3f7c3239469
https://github.com/Perl/perl5/commit/77b2b0555bfe9df40d7ac0957ddba3f7c3239469
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 1befe39fc3e7d2d0dc45e6e01677677542324451
https://github.com/Perl/perl5/commit/1befe39fc3e7d2d0dc45e6e01677677542324451
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 4a6c3320672ca03576443be993524cd64d79b4a6
https://github.com/Perl/perl5/commit/4a6c3320672ca03576443be993524cd64d79b4a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: ec1129983d2bbb3450cb7432696c728bbad2f02c
https://github.com/Perl/perl5/commit/ec1129983d2bbb3450cb7432696c728bbad2f02c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: f08a512d4931ca8c30dce97d0f35c2203a0bf79f
https://github.com/Perl/perl5/commit/f08a512d4931ca8c30dce97d0f35c2203a0bf79f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: a438cb529df1af90df8a3c5b7c95af2c017b71d0
https://github.com/Perl/perl5/commit/a438cb529df1af90df8a3c5b7c95af2c017b71d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: aa2a7da0f6fb5c10652d771dd3e3c593c35f26aa
https://github.com/Perl/perl5/commit/aa2a7da0f6fb5c10652d771dd3e3c593c35f26aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 1130af9a2d6b07bc5665e4cf0b6ff8af035caf64
https://github.com/Perl/perl5/commit/1130af9a2d6b07bc5665e4cf0b6ff8af035caf64
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: ed8c003c890b908eeaf0b797dc6318db62d8ed39
https://github.com/Perl/perl5/commit/ed8c003c890b908eeaf0b797dc6318db62d8ed39
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: fb80e0e5c668101349629c389f78397f28bbdb93
https://github.com/Perl/perl5/commit/fb80e0e5c668101349629c389f78397f28bbdb93
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 5bba24d1939baa27ea0bc540af825ec432e903d5
https://github.com/Perl/perl5/commit/5bba24d1939baa27ea0bc540af825ec432e903d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: eaad07682b6c8d2b3a6a67f822b42005770abf79
https://github.com/Perl/perl5/commit/eaad07682b6c8d2b3a6a67f822b42005770abf79
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: a82ed72d5077f0b6dd4c662e59a6f5c3dd7db020
https://github.com/Perl/perl5/commit/a82ed72d5077f0b6dd4c662e59a6f5c3dd7db020
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 1dc36e4392866dc735b67cb1afc84bc8fa2f5b11
https://github.com/Perl/perl5/commit/1dc36e4392866dc735b67cb1afc84bc8fa2f5b11
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 1cb41627595677a913af712079250b2378c4c1d2
https://github.com/Perl/perl5/commit/1cb41627595677a913af712079250b2378c4c1d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 0c26130e5fb0e1cda0567235cfb331edb696a64e
https://github.com/Perl/perl5/commit/0c26130e5fb0e1cda0567235cfb331edb696a64e
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 11bb44ecf0f461082c46328f02536a802509064a
https://github.com/Perl/perl5/commit/11bb44ecf0f461082c46328f02536a802509064a
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 8aa09623d72798971400670d49d21e8b8796b911
https://github.com/Perl/perl5/commit/8aa09623d72798971400670d49d21e8b8796b911
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 9f2dd9e1527be389d05339f335cad5ab25f9794c
https://github.com/Perl/perl5/commit/9f2dd9e1527be389d05339f335cad5ab25f9794c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 85f34e58374918efb0f358eeb893537b5eb645cc
https://github.com/Perl/perl5/commit/85f34e58374918efb0f358eeb893537b5eb645cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 7f1fbfb63d50728d8f8d7a2b95d63070838b0eb5
https://github.com/Perl/perl5/commit/7f1fbfb63d50728d8f8d7a2b95d63070838b0eb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 0c9cffa28c2a7b1a01a5ba03a7685d0ec652781e
https://github.com/Perl/perl5/commit/0c9cffa28c2a7b1a01a5ba03a7685d0ec652781e
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 0fa37cd158f049f19008fa132bc0ff063670fe7a
https://github.com/Perl/perl5/commit/0fa37cd158f049f19008fa132bc0ff063670fe7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 6c2ad3c5a511a7203c2918429f64a5d3a2c39973
https://github.com/Perl/perl5/commit/6c2ad3c5a511a7203c2918429f64a5d3a2c39973
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: a7c572b6d8969467699d7fc01f58e009327b96b4
https://github.com/Perl/perl5/commit/a7c572b6d8969467699d7fc01f58e009327b96b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 7db67ba57c580dde109d4366c0d0198d501e9194
https://github.com/Perl/perl5/commit/7db67ba57c580dde109d4366c0d0198d501e9194
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 3440bfb1b4e91ad7d6c9a1cb55636836aeeb991f
https://github.com/Perl/perl5/commit/3440bfb1b4e91ad7d6c9a1cb55636836aeeb991f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 8eb84ccdd60f7e250decaf0b9051b47f377104f3
https://github.com/Perl/perl5/commit/8eb84ccdd60f7e250decaf0b9051b47f377104f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: c515eeea822fdc9af7eef1ef6a5719ebe14db75b
https://github.com/Perl/perl5/commit/c515eeea822fdc9af7eef1ef6a5719ebe14db75b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 368ba619521df3ae674d1c6925b3b381b05e5f0d
https://github.com/Perl/perl5/commit/368ba619521df3ae674d1c6925b3b381b05e5f0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: e612975fd482f092693785a9a985ce15db2cc9b0
https://github.com/Perl/perl5/commit/e612975fd482f092693785a9a985ce15db2cc9b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 3bf40c558acd1e8b18711bd7832204b647dbaa32
https://github.com/Perl/perl5/commit/3bf40c558acd1e8b18711bd7832204b647dbaa32
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: e539f05f593fdba40faf4cb50a554f7de182bd72
https://github.com/Perl/perl5/commit/e539f05f593fdba40faf4cb50a554f7de182bd72
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 23506663a4d9b4c6e359a70ccc3c98942cab1720
https://github.com/Perl/perl5/commit/23506663a4d9b4c6e359a70ccc3c98942cab1720
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: cec164f0d280215ecd400c8e1688b305f24ba380
https://github.com/Perl/perl5/commit/cec164f0d280215ecd400c8e1688b305f24ba380
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: e7c9c851b159be22c3c4fb77bb466493c6c43bd0
https://github.com/Perl/perl5/commit/e7c9c851b159be22c3c4fb77bb466493c6c43bd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 1cceb6565595da124d497bcae2a8dce58ac4e7b6
https://github.com/Perl/perl5/commit/1cceb6565595da124d497bcae2a8dce58ac4e7b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 723c146ab2ccd6fd2defd58ea2f1855d628ee0e7
https://github.com/Perl/perl5/commit/723c146ab2ccd6fd2defd58ea2f1855d628ee0e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: efa4710f158a7e308341dd5320aee436357a51fa
https://github.com/Perl/perl5/commit/efa4710f158a7e308341dd5320aee436357a51fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 73e1c68f44378ece50ac0a6edccd05c2d3db4a94
https://github.com/Perl/perl5/commit/73e1c68f44378ece50ac0a6edccd05c2d3db4a94
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 5b662db12c81c147d589012c9c8af01891d72808
https://github.com/Perl/perl5/commit/5b662db12c81c147d589012c9c8af01891d72808
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 82008877b40c5ea20caf5cfb5e7e4859791b61e6
https://github.com/Perl/perl5/commit/82008877b40c5ea20caf5cfb5e7e4859791b61e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: f34c1bca4ec05243d268010f6d369acf43c56686
https://github.com/Perl/perl5/commit/f34c1bca4ec05243d268010f6d369acf43c56686
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 95d3ade1e39f470d41eb0846e1054f139fc092d3
https://github.com/Perl/perl5/commit/95d3ade1e39f470d41eb0846e1054f139fc092d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 6d49d8c2b97614cebceb1608f61b743ee0a35e5e
https://github.com/Perl/perl5/commit/6d49d8c2b97614cebceb1608f61b743ee0a35e5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 76562eb4153f561a89e5dc17e7ba844ed39daf9b
https://github.com/Perl/perl5/commit/76562eb4153f561a89e5dc17e7ba844ed39daf9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 37f4eb782b343916a1c0f21551a5792b25ffcd84
https://github.com/Perl/perl5/commit/37f4eb782b343916a1c0f21551a5792b25ffcd84
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 85bd596d8d52f3af32a87215628cffd7b1de5984
https://github.com/Perl/perl5/commit/85bd596d8d52f3af32a87215628cffd7b1de5984
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: f63ce418c6f30e018619f64653728ba6e939f829
https://github.com/Perl/perl5/commit/f63ce418c6f30e018619f64653728ba6e939f829
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: a5aeff3b73b1461ca117570c7f8d75ffa59bdbf2
https://github.com/Perl/perl5/commit/a5aeff3b73b1461ca117570c7f8d75ffa59bdbf2
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: cdcbc3d1f952b636b620457c109574bb2fc9e995
https://github.com/Perl/perl5/commit/cdcbc3d1f952b636b620457c109574bb2fc9e995
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 6bd556f2e4c9b52d28be041b367a35ff0e073bb5
https://github.com/Perl/perl5/commit/6bd556f2e4c9b52d28be041b367a35ff0e073bb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: c111c9cb3237ef8d05f11e352698e500a4c1f6ed
https://github.com/Perl/perl5/commit/c111c9cb3237ef8d05f11e352698e500a4c1f6ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: c3f828460213bcf4a7c504b02143beff8171ddaa
https://github.com/Perl/perl5/commit/c3f828460213bcf4a7c504b02143beff8171ddaa
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 7906a4233e9ba140f16668f0ba2e6a7cec44765c
https://github.com/Perl/perl5/commit/7906a4233e9ba140f16668f0ba2e6a7cec44765c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: d39998d6d8967968276bc551d119c471bd009fe6
https://github.com/Perl/perl5/commit/d39998d6d8967968276bc551d119c471bd009fe6
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 489af988537f4f26c139e837f25f499ff32c49a0
https://github.com/Perl/perl5/commit/489af988537f4f26c139e837f25f499ff32c49a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 64e08255aac9ec12429ee3c194288efa3b796cf0
https://github.com/Perl/perl5/commit/64e08255aac9ec12429ee3c194288efa3b796cf0
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 1ceb1400e8f15461ce103b67c0b8512b32eef94f
https://github.com/Perl/perl5/commit/1ceb1400e8f15461ce103b67c0b8512b32eef94f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: f90109df680e6d95093686228bb31804612dc15c
https://github.com/Perl/perl5/commit/f90109df680e6d95093686228bb31804612dc15c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 1e0ab4c0ef27a6fa6ec8b7f80a737d6ae48c8524
https://github.com/Perl/perl5/commit/1e0ab4c0ef27a6fa6ec8b7f80a737d6ae48c8524
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 12f46f95906b204ea2556da985bc643b3df51692
https://github.com/Perl/perl5/commit/12f46f95906b204ea2556da985bc643b3df51692
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 25afa26dc95809bc114013244640627a104b6d02
https://github.com/Perl/perl5/commit/25afa26dc95809bc114013244640627a104b6d02
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 4c0d532c720830de7533bcede36dc430d3eaf19f
https://github.com/Perl/perl5/commit/4c0d532c720830de7533bcede36dc430d3eaf19f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: dd51d4844b9d4d012a95da7a83fe8bdbcb613f87
https://github.com/Perl/perl5/commit/dd51d4844b9d4d012a95da7a83fe8bdbcb613f87
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: cd848bb0bdb6dea3f49451870a69376a43bf6250
https://github.com/Perl/perl5/commit/cd848bb0bdb6dea3f49451870a69376a43bf6250
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: fc1ed6b36f7e7b2e004d3658e3291bfa27d5f9f9
https://github.com/Perl/perl5/commit/fc1ed6b36f7e7b2e004d3658e3291bfa27d5f9f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 6acd1b290fbd1df4a658ca8186a5a246b956853c
https://github.com/Perl/perl5/commit/6acd1b290fbd1df4a658ca8186a5a246b956853c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: c9dd529b087af7eb486256fd4a48251a80fdead3
https://github.com/Perl/perl5/commit/c9dd529b087af7eb486256fd4a48251a80fdead3
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 2f5e4de0125ffb5eeee6d6efd6c304e5b84936f3
https://github.com/Perl/perl5/commit/2f5e4de0125ffb5eeee6d6efd6c304e5b84936f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: b892b2ac4e9931f953f7bd9425c257a1c824871f
https://github.com/Perl/perl5/commit/b892b2ac4e9931f953f7bd9425c257a1c824871f
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 793f03c731797dd4467b52693ea9358a64ac66f7
https://github.com/Perl/perl5/commit/793f03c731797dd4467b52693ea9358a64ac66f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: 650fcd57e06c6908ee93e0ce2a2671bb8300754b
https://github.com/Perl/perl5/commit/650fcd57e06c6908ee93e0ce2a2671bb8300754b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 44dbd2c30a1b959748bb20b2f0c8bb6a4e63746a
https://github.com/Perl/perl5/commit/44dbd2c30a1b959748bb20b2f0c8bb6a4e63746a
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 31a5abeff1ec918323608a9fe4b4de0f1c0ca473
https://github.com/Perl/perl5/commit/31a5abeff1ec918323608a9fe4b4de0f1c0ca473
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 1276e0f4f5b73c7cb4cadccc674fdc6b8c37f5e4
https://github.com/Perl/perl5/commit/1276e0f4f5b73c7cb4cadccc674fdc6b8c37f5e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 6039c263939c10c0a305e72134c2b4713846734a
https://github.com/Perl/perl5/commit/6039c263939c10c0a305e72134c2b4713846734a
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 8c8b2706ae00b5cd8c374afea1a2df568b24ae16
https://github.com/Perl/perl5/commit/8c8b2706ae00b5cd8c374afea1a2df568b24ae16
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: d92a2d23d43e890615670172a038c5292169af04
https://github.com/Perl/perl5/commit/d92a2d23d43e890615670172a038c5292169af04
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 1643cfafcdb741b6e265c66b23bc33b1703ddac4
https://github.com/Perl/perl5/commit/1643cfafcdb741b6e265c66b23bc33b1703ddac4
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 49324d999c2fd48175f94e98fe04b9f37fcf3975
https://github.com/Perl/perl5/commit/49324d999c2fd48175f94e98fe04b9f37fcf3975
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 586b5fa1671cd1f909c203445a62a5b87bdc6e80
https://github.com/Perl/perl5/commit/586b5fa1671cd1f909c203445a62a5b87bdc6e80
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 43ba552de6bcf942b0afc37395548b3943b942f2
https://github.com/Perl/perl5/commit/43ba552de6bcf942b0afc37395548b3943b942f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: c24e67cdbe9cae8a6274a49f3ba76fa80cd647db
https://github.com/Perl/perl5/commit/c24e67cdbe9cae8a6274a49f3ba76fa80cd647db
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 3aa8408a03eee604192690e99c1f8e898ea49cae
https://github.com/Perl/perl5/commit/3aa8408a03eee604192690e99c1f8e898ea49cae
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: a5d5178865df07a8be557604d5dd2852ece30b17
https://github.com/Perl/perl5/commit/a5d5178865df07a8be557604d5dd2852ece30b17
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: e9b3bc152c0c61f6a0da85bb94716eeb2f9bb3a3
https://github.com/Perl/perl5/commit/e9b3bc152c0c61f6a0da85bb94716eeb2f9bb3a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: f0f04612ffe16b60c9cb6dabeeb65f8cf248be47
https://github.com/Perl/perl5/commit/f0f04612ffe16b60c9cb6dabeeb65f8cf248be47
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 3905e149afd81ed025469d4dce445fcbd26829e1
https://github.com/Perl/perl5/commit/3905e149afd81ed025469d4dce445fcbd26829e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: c5c7da5e8a086d39aaeb0a00fe29e449b4b77977
https://github.com/Perl/perl5/commit/c5c7da5e8a086d39aaeb0a00fe29e449b4b77977
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 7cd2e14ee7a43003fd45bd6a0659209e5b14a164
https://github.com/Perl/perl5/commit/7cd2e14ee7a43003fd45bd6a0659209e5b14a164
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 392ba6b4658b0b73c3938884762d6d7cbb23c6b2
https://github.com/Perl/perl5/commit/392ba6b4658b0b73c3938884762d6d7cbb23c6b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: aa46e4f2e1e5ca0d47742a4358f9004f9bdf5b8c
https://github.com/Perl/perl5/commit/aa46e4f2e1e5ca0d47742a4358f9004f9bdf5b8c
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: fe4775d993a2957767f102e73b3032ee73b88e1d
https://github.com/Perl/perl5/commit/fe4775d993a2957767f102e73b3032ee73b88e1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: c6f2ed8a79efe189d3796bfa4b0adc02b50d8ec7
https://github.com/Perl/perl5/commit/c6f2ed8a79efe189d3796bfa4b0adc02b50d8ec7
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 6b6befc13718084e888ad5d3fd5d6ec6303a99a2
https://github.com/Perl/perl5/commit/6b6befc13718084e888ad5d3fd5d6ec6303a99a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: a63f8507be9b62616320316af833e6d474e63a68
https://github.com/Perl/perl5/commit/a63f8507be9b62616320316af833e6d474e63a68
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 7f7a7bb8623bc5a886c716b150e318a4ac0cb097
https://github.com/Perl/perl5/commit/7f7a7bb8623bc5a886c716b150e318a4ac0cb097
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: d6d21eed1d2ec26e9a9bb74a2268b0c00dc859ee
https://github.com/Perl/perl5/commit/d6d21eed1d2ec26e9a9bb74a2268b0c00dc859ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: f02b1578211683a091f4ced81350052e6b9140c5
https://github.com/Perl/perl5/commit/f02b1578211683a091f4ced81350052e6b9140c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 5c4967e92ceab981986922e861350a712a69acbd
https://github.com/Perl/perl5/commit/5c4967e92ceab981986922e861350a712a69acbd
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: fb9291d4e2591a7155c6c4d7cc75f59ebffcb435
https://github.com/Perl/perl5/commit/fb9291d4e2591a7155c6c4d7cc75f59ebffcb435
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: ef4d94372f357c795a4f09b0fc4a23dc1c667735
https://github.com/Perl/perl5/commit/ef4d94372f357c795a4f09b0fc4a23dc1c667735
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: e30785fb1497abb7d7dd87c43ca9fc52cbf2470d
https://github.com/Perl/perl5/commit/e30785fb1497abb7d7dd87c43ca9fc52cbf2470d
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 29d9c901ffd9aa66ac89e120ff460e97aca3c827
https://github.com/Perl/perl5/commit/29d9c901ffd9aa66ac89e120ff460e97aca3c827
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
30
Commit: 77bf2eebcd45313cb74e2372ab343f639f5fba1b
https://github.com/Perl/perl5/commit/77bf2eebcd45313cb74e2372ab343f639f5fba1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-17 (Sat, 17 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M lib/locale.t
M lib/locale_threads.t
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
32
Compare: https://github.com/Perl/perl5/compare/b4b0f3637f02...77bf2eebcd45
