Branch: refs/heads/smoke-me/khw-env
Home: https://github.com/Perl/perl5
Commit: bd83362f6162de83866a8079f0f408b714f9c45b
https://github.com/Perl/perl5/commit/bd83362f6162de83866a8079f0f408b714f9c45b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: e781cd6c8e9cc57c0002aad864d29c75f2053fb7
https://github.com/Perl/perl5/commit/e781cd6c8e9cc57c0002aad864d29c75f2053fb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 08b0af183f499dd7b00305a137de590f17d50c83
https://github.com/Perl/perl5/commit/08b0af183f499dd7b00305a137de590f17d50c83
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 810a173ef9d0cbfa18c352289d017e007eb6fb0f
https://github.com/Perl/perl5/commit/810a173ef9d0cbfa18c352289d017e007eb6fb0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 37d727315c5407d4c8148e83ee89c227693b20ad
https://github.com/Perl/perl5/commit/37d727315c5407d4c8148e83ee89c227693b20ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 85382bf15bfe5ea80e081754b8d42bbde9212a15
https://github.com/Perl/perl5/commit/85382bf15bfe5ea80e081754b8d42bbde9212a15
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 81ecb65a4d6ff91e7ecc75698772ee28f4329ddb
https://github.com/Perl/perl5/commit/81ecb65a4d6ff91e7ecc75698772ee28f4329ddb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 68e4e039335ed7d46c635243130902c8f6bf487e
https://github.com/Perl/perl5/commit/68e4e039335ed7d46c635243130902c8f6bf487e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: a954e817d490da363a21200227aaf6398068dc4a
https://github.com/Perl/perl5/commit/a954e817d490da363a21200227aaf6398068dc4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: f9cb5b17b171d804d46a71017f4dcb7f66d51d81
https://github.com/Perl/perl5/commit/f9cb5b17b171d804d46a71017f4dcb7f66d51d81
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: b2415e4274f94149a7241f1e2a40769aa30cec41
https://github.com/Perl/perl5/commit/b2415e4274f94149a7241f1e2a40769aa30cec41
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 4cdf39d99135aca238a0da055b4f9339966ef05a
https://github.com/Perl/perl5/commit/4cdf39d99135aca238a0da055b4f9339966ef05a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: e8aef14cfdb4705aace139c593fea9bb7052c0de
https://github.com/Perl/perl5/commit/e8aef14cfdb4705aace139c593fea9bb7052c0de
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 1ac8148c1e9924347806a88d0425018f4e9fe0d6
https://github.com/Perl/perl5/commit/1ac8148c1e9924347806a88d0425018f4e9fe0d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: ae6ed1f15ba05f24b0c91ccb1078faeb5475705f
https://github.com/Perl/perl5/commit/ae6ed1f15ba05f24b0c91ccb1078faeb5475705f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: da0fbc391506e2522f03e8352321aebf7c47ad7c
https://github.com/Perl/perl5/commit/da0fbc391506e2522f03e8352321aebf7c47ad7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: dea9358dea70cdb0232a1fceecff31e88853db4b
https://github.com/Perl/perl5/commit/dea9358dea70cdb0232a1fceecff31e88853db4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 4becb686df6ef0b97cd756b349fdb09a41a693dd
https://github.com/Perl/perl5/commit/4becb686df6ef0b97cd756b349fdb09a41a693dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: bab000a0a21478081a0f99e049221c842d49a7ee
https://github.com/Perl/perl5/commit/bab000a0a21478081a0f99e049221c842d49a7ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 1c48212fd9e0d0f43ba8d8033b9a6148d60babd7
https://github.com/Perl/perl5/commit/1c48212fd9e0d0f43ba8d8033b9a6148d60babd7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: ad6e1be4eaa178e6abeb232c93dc9e4f0d880743
https://github.com/Perl/perl5/commit/ad6e1be4eaa178e6abeb232c93dc9e4f0d880743
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: eb3d32cc508ec0affd2fe69e83711be073e98843
https://github.com/Perl/perl5/commit/eb3d32cc508ec0affd2fe69e83711be073e98843
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 1a1d96d6f8c60fab92edbe13a94ab68f800f7a31
https://github.com/Perl/perl5/commit/1a1d96d6f8c60fab92edbe13a94ab68f800f7a31
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 428fea9e6faed50de2921b96470abc3512ba6a68
https://github.com/Perl/perl5/commit/428fea9e6faed50de2921b96470abc3512ba6a68
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 71ff041069489f8e47b14ebb2a1c4e71ec834cd7
https://github.com/Perl/perl5/commit/71ff041069489f8e47b14ebb2a1c4e71ec834cd7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 7b494f6c175a0a41d88c24f4eb3ddf192dcdf472
https://github.com/Perl/perl5/commit/7b494f6c175a0a41d88c24f4eb3ddf192dcdf472
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 2b95bc19c87e99b9a091f66b8ecba44b382ca74f
https://github.com/Perl/perl5/commit/2b95bc19c87e99b9a091f66b8ecba44b382ca74f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: d48c3a5d1205a3c58c0dff5fb09b51dd69beff51
https://github.com/Perl/perl5/commit/d48c3a5d1205a3c58c0dff5fb09b51dd69beff51
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 7dde83c9f956535745c6aa1fa1b9ac4e3c308dc1
https://github.com/Perl/perl5/commit/7dde83c9f956535745c6aa1fa1b9ac4e3c308dc1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 27fe61e055021b8fea39ec3959c45236dcedc98a
https://github.com/Perl/perl5/commit/27fe61e055021b8fea39ec3959c45236dcedc98a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 7e9c813d8da5105779cc7dc3c0faf6e5180a50b2
https://github.com/Perl/perl5/commit/7e9c813d8da5105779cc7dc3c0faf6e5180a50b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 63dd7bb25eac2f9475467d30881c9c71947ea755
https://github.com/Perl/perl5/commit/63dd7bb25eac2f9475467d30881c9c71947ea755
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 9cd53c3605c8ede5365ef7be883239901c8ba2a2
https://github.com/Perl/perl5/commit/9cd53c3605c8ede5365ef7be883239901c8ba2a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 08368e977d0738b4b5269851fe03a2db8ec45c79
https://github.com/Perl/perl5/commit/08368e977d0738b4b5269851fe03a2db8ec45c79
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: b1b3adbac60193dd0f7d7c1cc7736c7d3d0018ce
https://github.com/Perl/perl5/commit/b1b3adbac60193dd0f7d7c1cc7736c7d3d0018ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: e5dbeab5894dee4711cb147e41f55b70b3f9446d
https://github.com/Perl/perl5/commit/e5dbeab5894dee4711cb147e41f55b70b3f9446d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 27167cde5835d875c24e515c489ae8987730eb97
https://github.com/Perl/perl5/commit/27167cde5835d875c24e515c489ae8987730eb97
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 19e6040a53b689595390f27fffc7d0912e1a6ac2
https://github.com/Perl/perl5/commit/19e6040a53b689595390f27fffc7d0912e1a6ac2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: f84700258b64172bdfa8d79427e03c0f593e1b66
https://github.com/Perl/perl5/commit/f84700258b64172bdfa8d79427e03c0f593e1b66
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 6eaf7adf0d151a2bebab34b70627a5205fa79573
https://github.com/Perl/perl5/commit/6eaf7adf0d151a2bebab34b70627a5205fa79573
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 9644625e2fab44820703ec879ba79b2f9c383e72
https://github.com/Perl/perl5/commit/9644625e2fab44820703ec879ba79b2f9c383e72
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 53874cf7f0e4ff75544b272c14e45a1d94854519
https://github.com/Perl/perl5/commit/53874cf7f0e4ff75544b272c14e45a1d94854519
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 2f007dd6ce0ddbeae0938ab26abc5efeafff984f
https://github.com/Perl/perl5/commit/2f007dd6ce0ddbeae0938ab26abc5efeafff984f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 572fcada141f93bfb94e0fdcf70677e126ed3dd5
https://github.com/Perl/perl5/commit/572fcada141f93bfb94e0fdcf70677e126ed3dd5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: ff75ca93a662ba5de6433d1c162a770eaf186a1c
https://github.com/Perl/perl5/commit/ff75ca93a662ba5de6433d1c162a770eaf186a1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 279bb72758cb6092d9f176d7067dc2a15761a25e
https://github.com/Perl/perl5/commit/279bb72758cb6092d9f176d7067dc2a15761a25e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: be1c96c6a76fe49dd0530766fa648f14c9eaf293
https://github.com/Perl/perl5/commit/be1c96c6a76fe49dd0530766fa648f14c9eaf293
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 0ed2fcfc798c3506044cd982f51d263177df56f0
https://github.com/Perl/perl5/commit/0ed2fcfc798c3506044cd982f51d263177df56f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: edfb8fdb7bfe4c64c4d8bbfb78e7e6fa0524678f
https://github.com/Perl/perl5/commit/edfb8fdb7bfe4c64c4d8bbfb78e7e6fa0524678f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 0e0e25533b0fd994a7752f9705267e9d6f6417c3
https://github.com/Perl/perl5/commit/0e0e25533b0fd994a7752f9705267e9d6f6417c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 9836f6f83a7de76f6f098c52f1fe05334aabc356
https://github.com/Perl/perl5/commit/9836f6f83a7de76f6f098c52f1fe05334aabc356
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 23043dcc5e47c0256a02f919810d82c1bdd23ba1
https://github.com/Perl/perl5/commit/23043dcc5e47c0256a02f919810d82c1bdd23ba1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 001697b7ecf15a46239b0dbde7fe276545a066bf
https://github.com/Perl/perl5/commit/001697b7ecf15a46239b0dbde7fe276545a066bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 38bcee4d1ec720d4af747fa9ce16a30083f27915
https://github.com/Perl/perl5/commit/38bcee4d1ec720d4af747fa9ce16a30083f27915
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: cb694de9b7df7a73f85de7a0d2bc5384077141e2
https://github.com/Perl/perl5/commit/cb694de9b7df7a73f85de7a0d2bc5384077141e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: e8e36853e6e4a41a105a6919cf05d85273c82f54
https://github.com/Perl/perl5/commit/e8e36853e6e4a41a105a6919cf05d85273c82f54
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: e2244fe569e5fbfe735b38f724c81f31a7eb4a95
https://github.com/Perl/perl5/commit/e2244fe569e5fbfe735b38f724c81f31a7eb4a95
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: 3cebe52e9b35337aa495b78fa09ae89d8dde262b
https://github.com/Perl/perl5/commit/3cebe52e9b35337aa495b78fa09ae89d8dde262b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: e5f9136e8b3801ed0634f7a11410725ccc259a84
https://github.com/Perl/perl5/commit/e5f9136e8b3801ed0634f7a11410725ccc259a84
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: c896dce4894dc7d817987fc268406ca5f0a06dcd
https://github.com/Perl/perl5/commit/c896dce4894dc7d817987fc268406ca5f0a06dcd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 0bab92ebc5ca6f36151309a37c597eb9fb3b717c
https://github.com/Perl/perl5/commit/0bab92ebc5ca6f36151309a37c597eb9fb3b717c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 81e0347d7846b720f237b3611f448678fc74ea55
https://github.com/Perl/perl5/commit/81e0347d7846b720f237b3611f448678fc74ea55
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: ceea389a1e9783d542c62ed934660997988797ce
https://github.com/Perl/perl5/commit/ceea389a1e9783d542c62ed934660997988797ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 65d9baa5d79c7bf70936649af6528c903e379e18
https://github.com/Perl/perl5/commit/65d9baa5d79c7bf70936649af6528c903e379e18
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 73d53c83cd65bba283b69bb54751a8aea41f7a80
https://github.com/Perl/perl5/commit/73d53c83cd65bba283b69bb54751a8aea41f7a80
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: bc5aef03368943fcd863d09289f15692a9321c6d
https://github.com/Perl/perl5/commit/bc5aef03368943fcd863d09289f15692a9321c6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 36d5eff7bb99529da6c3b5047e8be4914d3bf521
https://github.com/Perl/perl5/commit/36d5eff7bb99529da6c3b5047e8be4914d3bf521
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: ddf6a1157945611b2ffc690d86ab688ad32145fc
https://github.com/Perl/perl5/commit/ddf6a1157945611b2ffc690d86ab688ad32145fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: f5c53afc124d1e86684d75dd43201306e6d5206b
https://github.com/Perl/perl5/commit/f5c53afc124d1e86684d75dd43201306e6d5206b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: dac28932033f8ac5a9577c46fbd47070166526a0
https://github.com/Perl/perl5/commit/dac28932033f8ac5a9577c46fbd47070166526a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: c60c89ba38f018aa252c30b4c445e76ba9b41f5c
https://github.com/Perl/perl5/commit/c60c89ba38f018aa252c30b4c445e76ba9b41f5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 10a74e9221b9246af28f985cb1d975137edd71a3
https://github.com/Perl/perl5/commit/10a74e9221b9246af28f985cb1d975137edd71a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 455840642a54538be73a7c68afc29b5390b28128
https://github.com/Perl/perl5/commit/455840642a54538be73a7c68afc29b5390b28128
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: dcd30229722e5b0756c5afb692f4e1c0917df4c3
https://github.com/Perl/perl5/commit/dcd30229722e5b0756c5afb692f4e1c0917df4c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: bdd11c0388c948cae2f4b2e5eb73cd4457f67f88
https://github.com/Perl/perl5/commit/bdd11c0388c948cae2f4b2e5eb73cd4457f67f88
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 6ff02a175df3614279702b7d084a3fad0f240bb1
https://github.com/Perl/perl5/commit/6ff02a175df3614279702b7d084a3fad0f240bb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 41d8d7026a5494ac14819d3ee9a9e89fa8106024
https://github.com/Perl/perl5/commit/41d8d7026a5494ac14819d3ee9a9e89fa8106024
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 221d99cbd497e4416bf6c028dc9c7224c901067d
https://github.com/Perl/perl5/commit/221d99cbd497e4416bf6c028dc9c7224c901067d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: b124799f4b618098e7cec6674cbee27ed2d4026d
https://github.com/Perl/perl5/commit/b124799f4b618098e7cec6674cbee27ed2d4026d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 6bb176d25bcd0f9f37944e2223a8798f7f1a9514
https://github.com/Perl/perl5/commit/6bb176d25bcd0f9f37944e2223a8798f7f1a9514
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 0a814144b7938eb968f31cc66caedeca1df5f45f
https://github.com/Perl/perl5/commit/0a814144b7938eb968f31cc66caedeca1df5f45f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 39846e185d5a730d67b50d5fefcd42d83d38d2f8
https://github.com/Perl/perl5/commit/39846e185d5a730d67b50d5fefcd42d83d38d2f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: b905ee78c8e15c2ef4ad5e75293a20d70902559e
https://github.com/Perl/perl5/commit/b905ee78c8e15c2ef4ad5e75293a20d70902559e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 9199c98b22d90a155b2b13868c18fe975b5149ec
https://github.com/Perl/perl5/commit/9199c98b22d90a155b2b13868c18fe975b5149ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 43bc1ae6e2947373af0332c198aabeb116cb3a08
https://github.com/Perl/perl5/commit/43bc1ae6e2947373af0332c198aabeb116cb3a08
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 1103f1153f8229ec4c53d44add4d0ab7d51416fe
https://github.com/Perl/perl5/commit/1103f1153f8229ec4c53d44add4d0ab7d51416fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 398c255695a68d9e1609fa491b4e8a35e5983d09
https://github.com/Perl/perl5/commit/398c255695a68d9e1609fa491b4e8a35e5983d09
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 3efd703a2702b1ee2f8b585fb3015e304b70982e
https://github.com/Perl/perl5/commit/3efd703a2702b1ee2f8b585fb3015e304b70982e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: d02ebe7e4aee844d35ffe99a72b35927da71eb9e
https://github.com/Perl/perl5/commit/d02ebe7e4aee844d35ffe99a72b35927da71eb9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: c3b787be7263f4ae4db6259edb7e6af066501c24
https://github.com/Perl/perl5/commit/c3b787be7263f4ae4db6259edb7e6af066501c24
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: ab536574ca63cf4ba58ba7f08af823ffe9ba90dd
https://github.com/Perl/perl5/commit/ab536574ca63cf4ba58ba7f08af823ffe9ba90dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 6e678196b3ae85be982922cf664b2699591c4daa
https://github.com/Perl/perl5/commit/6e678196b3ae85be982922cf664b2699591c4daa
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 1cf2d1b5b7858f50343baeed5cc35f67c0aa5dcc
https://github.com/Perl/perl5/commit/1cf2d1b5b7858f50343baeed5cc35f67c0aa5dcc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: a516bf5cf8a3ccc8af926300811bee6c312d46c3
https://github.com/Perl/perl5/commit/a516bf5cf8a3ccc8af926300811bee6c312d46c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 2b33f9a945996cd62ca84848e8c7b20b74cf7b02
https://github.com/Perl/perl5/commit/2b33f9a945996cd62ca84848e8c7b20b74cf7b02
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 1321a796356f4b58bfd6f6db333f41ada8bc6a67
https://github.com/Perl/perl5/commit/1321a796356f4b58bfd6f6db333f41ada8bc6a67
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: f3898e075b84bff13237fc5dab5ccabc24066935
https://github.com/Perl/perl5/commit/f3898e075b84bff13237fc5dab5ccabc24066935
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 1306f8ddd4d608cd59498b7c1de57beb84a53946
https://github.com/Perl/perl5/commit/1306f8ddd4d608cd59498b7c1de57beb84a53946
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: e180025497d96e191398ae10dbac4ad47f5c0a5e
https://github.com/Perl/perl5/commit/e180025497d96e191398ae10dbac4ad47f5c0a5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 12c557b756526b4f9c3f15fc070a14b52100a6ab
https://github.com/Perl/perl5/commit/12c557b756526b4f9c3f15fc070a14b52100a6ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: eece4b2efd34297ab6d5bbcfdedd80fdb4b31fc8
https://github.com/Perl/perl5/commit/eece4b2efd34297ab6d5bbcfdedd80fdb4b31fc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 5df3f4d54e09e22c296751c51f49b10ad07fc2e9
https://github.com/Perl/perl5/commit/5df3f4d54e09e22c296751c51f49b10ad07fc2e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 4c060120e062eec2b31a8e37ad196d252d9b9368
https://github.com/Perl/perl5/commit/4c060120e062eec2b31a8e37ad196d252d9b9368
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 3e6f5a0edde5f01318863408789411e117eb61f8
https://github.com/Perl/perl5/commit/3e6f5a0edde5f01318863408789411e117eb61f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: fbbf5b62a6c3a78b784ddb9adbfb29cd96da0216
https://github.com/Perl/perl5/commit/fbbf5b62a6c3a78b784ddb9adbfb29cd96da0216
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 49c7c915ff96ec7e0987066201866f5b48623911
https://github.com/Perl/perl5/commit/49c7c915ff96ec7e0987066201866f5b48623911
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 624e6f850e54286b1b579e208c44bb9f7b115861
https://github.com/Perl/perl5/commit/624e6f850e54286b1b579e208c44bb9f7b115861
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: e6d0d294bc4ff1c5c4fc7ce7b912c11098773cf6
https://github.com/Perl/perl5/commit/e6d0d294bc4ff1c5c4fc7ce7b912c11098773cf6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: a640b7bdb4940810163424b3732b051324b226e0
https://github.com/Perl/perl5/commit/a640b7bdb4940810163424b3732b051324b226e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 7f972c5b7986897574a9f3389549512474ba3518
https://github.com/Perl/perl5/commit/7f972c5b7986897574a9f3389549512474ba3518
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 9a1ef8431b354e45b8d4b4a202d251e600a58910
https://github.com/Perl/perl5/commit/9a1ef8431b354e45b8d4b4a202d251e600a58910
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 47db08de6aa292f888e36983e4694ac716c2c049
https://github.com/Perl/perl5/commit/47db08de6aa292f888e36983e4694ac716c2c049
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 74612746487b2c03da542022719a893ba555be46
https://github.com/Perl/perl5/commit/74612746487b2c03da542022719a893ba555be46
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: b302261f9b1b4d258ac01114c6e938bef4f3a457
https://github.com/Perl/perl5/commit/b302261f9b1b4d258ac01114c6e938bef4f3a457
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: ccf3d5ea92286ba3f96c990d7f83fb7f2aa0607f
https://github.com/Perl/perl5/commit/ccf3d5ea92286ba3f96c990d7f83fb7f2aa0607f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 4125ce1b03d18b7049e9a1a54714b7c96ce3456f
https://github.com/Perl/perl5/commit/4125ce1b03d18b7049e9a1a54714b7c96ce3456f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: da19593c8507249bb3a60cd5a5c76972a0cf2ebf
https://github.com/Perl/perl5/commit/da19593c8507249bb3a60cd5a5c76972a0cf2ebf
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 2c0ff4cb581c770739b3bcfee66c8335e73bff35
https://github.com/Perl/perl5/commit/2c0ff4cb581c770739b3bcfee66c8335e73bff35
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 6196d72c8651ebdef7e5bdc4c0362d2e8660a218
https://github.com/Perl/perl5/commit/6196d72c8651ebdef7e5bdc4c0362d2e8660a218
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 34e57216cf7b88dcfcdace67082406b551097ce5
https://github.com/Perl/perl5/commit/34e57216cf7b88dcfcdace67082406b551097ce5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: e05a27c08b99689664570cd444baf7e6087a6068
https://github.com/Perl/perl5/commit/e05a27c08b99689664570cd444baf7e6087a6068
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 70dd98e7e9863300801ea80db07b280082b01018
https://github.com/Perl/perl5/commit/70dd98e7e9863300801ea80db07b280082b01018
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 08b650ddcd731eb484292ce497173a9a74e1a0a2
https://github.com/Perl/perl5/commit/08b650ddcd731eb484292ce497173a9a74e1a0a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 6fe459fd6955d466083e1a7593d19f8ec8adcb19
https://github.com/Perl/perl5/commit/6fe459fd6955d466083e1a7593d19f8ec8adcb19
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: f27c62f32787f32b007321877a70bf9c43d2944e
https://github.com/Perl/perl5/commit/f27c62f32787f32b007321877a70bf9c43d2944e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 538b911fe4d8cbe76a965942345ba9c1d03387e2
https://github.com/Perl/perl5/commit/538b911fe4d8cbe76a965942345ba9c1d03387e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: babf3a09030e2766df9f490c87fc500aa62ea303
https://github.com/Perl/perl5/commit/babf3a09030e2766df9f490c87fc500aa62ea303
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: d3a8531568cf41f984ca0f89b3bd80db8660c392
https://github.com/Perl/perl5/commit/d3a8531568cf41f984ca0f89b3bd80db8660c392
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 6fac1e8ec241f364f175ffad3b49e33a08dfa014
https://github.com/Perl/perl5/commit/6fac1e8ec241f364f175ffad3b49e33a08dfa014
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 8af753cc48daf6ef846c0e6eba7294174a2bb667
https://github.com/Perl/perl5/commit/8af753cc48daf6ef846c0e6eba7294174a2bb667
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: af932c9d4af3e049c2eb404e6d2e20cc2de10cef
https://github.com/Perl/perl5/commit/af932c9d4af3e049c2eb404e6d2e20cc2de10cef
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 6fd7196fe03c2dcc082a992daa3523b97c165f14
https://github.com/Perl/perl5/commit/6fd7196fe03c2dcc082a992daa3523b97c165f14
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 4a0c3ff5d86890f3e61ae4d7cb4e9228e283ba37
https://github.com/Perl/perl5/commit/4a0c3ff5d86890f3e61ae4d7cb4e9228e283ba37
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 0214560bd94c2da89fb41a2d3fb0d717e45a446a
https://github.com/Perl/perl5/commit/0214560bd94c2da89fb41a2d3fb0d717e45a446a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: e37a3d92e2e39fea9806550e43706f79ad60edf7
https://github.com/Perl/perl5/commit/e37a3d92e2e39fea9806550e43706f79ad60edf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 807faa02359952bb1c03af5e7d5d951b81c734fb
https://github.com/Perl/perl5/commit/807faa02359952bb1c03af5e7d5d951b81c734fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 1c8d2cf3094bba1ae69dfc067a31f06204dd0271
https://github.com/Perl/perl5/commit/1c8d2cf3094bba1ae69dfc067a31f06204dd0271
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 64dde12834fa2ddd5b42758a996da5281d2a3032
https://github.com/Perl/perl5/commit/64dde12834fa2ddd5b42758a996da5281d2a3032
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 0195fec45e84a97d8018cfb26cc4c512b55a323a
https://github.com/Perl/perl5/commit/0195fec45e84a97d8018cfb26cc4c512b55a323a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 5a1e8e37fb2f5f8f66e31e3b6be21ccc44e58767
https://github.com/Perl/perl5/commit/5a1e8e37fb2f5f8f66e31e3b6be21ccc44e58767
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 096b832056ec77eba3bfbfe6285033bd9e5f69fd
https://github.com/Perl/perl5/commit/096b832056ec77eba3bfbfe6285033bd9e5f69fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 7bdf4322fb1626069d150338c4c413acc767fa4c
https://github.com/Perl/perl5/commit/7bdf4322fb1626069d150338c4c413acc767fa4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 88be5cfae24d83557bdaceed698163d181b0a305
https://github.com/Perl/perl5/commit/88be5cfae24d83557bdaceed698163d181b0a305
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: f6d887e8133dca2abbd1aa5167dff3c0920555f3
https://github.com/Perl/perl5/commit/f6d887e8133dca2abbd1aa5167dff3c0920555f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: cd2b472600a61a7a6fc92b3adf403c1e6cd61832
https://github.com/Perl/perl5/commit/cd2b472600a61a7a6fc92b3adf403c1e6cd61832
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: f21a4fc87c7c41fb18b774bd70dc6a1c6f872ee6
https://github.com/Perl/perl5/commit/f21a4fc87c7c41fb18b774bd70dc6a1c6f872ee6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: bc8859cd2d2488f6c1a9d4a09d65dbcff9202fdc
https://github.com/Perl/perl5/commit/bc8859cd2d2488f6c1a9d4a09d65dbcff9202fdc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 6c5a3c2d1a6faf86a2946936291bb149a64e1f14
https://github.com/Perl/perl5/commit/6c5a3c2d1a6faf86a2946936291bb149a64e1f14
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 2481a8b01bca36701402e3b52d36f898d443aa78
https://github.com/Perl/perl5/commit/2481a8b01bca36701402e3b52d36f898d443aa78
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 5c194e3910d043966d5c737ad56e445e0cfd2d1d
https://github.com/Perl/perl5/commit/5c194e3910d043966d5c737ad56e445e0cfd2d1d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 26f88cdf55babe45d414c63fd03a29be6e1056ce
https://github.com/Perl/perl5/commit/26f88cdf55babe45d414c63fd03a29be6e1056ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 8b7abb78d43f97afd2ed10b62aecffa7a1c85911
https://github.com/Perl/perl5/commit/8b7abb78d43f97afd2ed10b62aecffa7a1c85911
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 9074ff9b0828b1592dc514f069d2cc8a40846cfc
https://github.com/Perl/perl5/commit/9074ff9b0828b1592dc514f069d2cc8a40846cfc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 5f4744f1262e311643cd5a6b8788bebc7b324140
https://github.com/Perl/perl5/commit/5f4744f1262e311643cd5a6b8788bebc7b324140
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: e077759d01b470acf7fd44f1a659970a97d918b3
https://github.com/Perl/perl5/commit/e077759d01b470acf7fd44f1a659970a97d918b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: c52b983471383b00a339d462d05c99fb21b4e3fe
https://github.com/Perl/perl5/commit/c52b983471383b00a339d462d05c99fb21b4e3fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 7b84bcfb94f01e143defabb13b7859027963ac0f
https://github.com/Perl/perl5/commit/7b84bcfb94f01e143defabb13b7859027963ac0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 633555be02563b07e4cc89db586461e17c438522
https://github.com/Perl/perl5/commit/633555be02563b07e4cc89db586461e17c438522
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 0eb49c5b6cb5afe0056557b08711611bb1f0528a
https://github.com/Perl/perl5/commit/0eb49c5b6cb5afe0056557b08711611bb1f0528a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: fb82170f3a14aa66a6eac8fd8eacc8cc0c90a145
https://github.com/Perl/perl5/commit/fb82170f3a14aa66a6eac8fd8eacc8cc0c90a145
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: a555ad271f02098e70cd05b8cd4872131efd4d62
https://github.com/Perl/perl5/commit/a555ad271f02098e70cd05b8cd4872131efd4d62
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 86db3746f0e8da8ab95a4539ed031b8e1afbfcdb
https://github.com/Perl/perl5/commit/86db3746f0e8da8ab95a4539ed031b8e1afbfcdb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 22ea49c3826291b552f88d3f821c18625c7a58f4
https://github.com/Perl/perl5/commit/22ea49c3826291b552f88d3f821c18625c7a58f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: bb8ba4a9c27c6c9b7318a5843f64e7b891514e40
https://github.com/Perl/perl5/commit/bb8ba4a9c27c6c9b7318a5843f64e7b891514e40
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: cd88bb903ab988ae6f2dc747ec7134477926528e
https://github.com/Perl/perl5/commit/cd88bb903ab988ae6f2dc747ec7134477926528e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: eca44aa9f23161df18585aa03d66101f14edb675
https://github.com/Perl/perl5/commit/eca44aa9f23161df18585aa03d66101f14edb675
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: dc98882309a1691c61d62659b3b6413929405fa3
https://github.com/Perl/perl5/commit/dc98882309a1691c61d62659b3b6413929405fa3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 4372b488dc5a068a5ba62d2c8a1737f8c9deac61
https://github.com/Perl/perl5/commit/4372b488dc5a068a5ba62d2c8a1737f8c9deac61
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 40920067f0b6f85adc7f5ce6e5943d892905c8c6
https://github.com/Perl/perl5/commit/40920067f0b6f85adc7f5ce6e5943d892905c8c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 2c5afe3cc40913077124497a248ed1093995ec4a
https://github.com/Perl/perl5/commit/2c5afe3cc40913077124497a248ed1093995ec4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 3aa9a5c93caea17f51053edfad4637dd04d80e36
https://github.com/Perl/perl5/commit/3aa9a5c93caea17f51053edfad4637dd04d80e36
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 2f1cf3e41ee945c9afad0b9b0983f2c058758115
https://github.com/Perl/perl5/commit/2f1cf3e41ee945c9afad0b9b0983f2c058758115
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: e04eeb56921ae2f127b63c9eda871d7fece8c20a
https://github.com/Perl/perl5/commit/e04eeb56921ae2f127b63c9eda871d7fece8c20a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 891ee5f6b41a3f5aad508f80fac934cf77870e5b
https://github.com/Perl/perl5/commit/891ee5f6b41a3f5aad508f80fac934cf77870e5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 0f5b371459ed85d6542da9f21bbe0f7547433372
https://github.com/Perl/perl5/commit/0f5b371459ed85d6542da9f21bbe0f7547433372
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: eb308bf3ce4e36a943dfa87a75f70f92271a4e85
https://github.com/Perl/perl5/commit/eb308bf3ce4e36a943dfa87a75f70f92271a4e85
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 65d5038fe756d535f9488a28df8cb1ad219d8d58
https://github.com/Perl/perl5/commit/65d5038fe756d535f9488a28df8cb1ad219d8d58
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: cd4944c64981ea76f54e2ff4b51397f32870870f
https://github.com/Perl/perl5/commit/cd4944c64981ea76f54e2ff4b51397f32870870f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 59e5fd0567e003af5e80bab8581ec9efbd12eb7b
https://github.com/Perl/perl5/commit/59e5fd0567e003af5e80bab8581ec9efbd12eb7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 0cc82c4b5f653046acb2c4a995da680c7f74053d
https://github.com/Perl/perl5/commit/0cc82c4b5f653046acb2c4a995da680c7f74053d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: e2772f2809e850649d71cad2cbee3255bc73221e
https://github.com/Perl/perl5/commit/e2772f2809e850649d71cad2cbee3255bc73221e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 532c3328681d8ad936225e53769fa4bdf2d59d24
https://github.com/Perl/perl5/commit/532c3328681d8ad936225e53769fa4bdf2d59d24
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: df6b0eb8e9555d1d093b0d56759745dbe1de41f6
https://github.com/Perl/perl5/commit/df6b0eb8e9555d1d093b0d56759745dbe1de41f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 2898986727a35d0928cd1d1a17cdbc958b71e795
https://github.com/Perl/perl5/commit/2898986727a35d0928cd1d1a17cdbc958b71e795
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: c06edcf1bc00401066675677eee6cbb8d17f58e7
https://github.com/Perl/perl5/commit/c06edcf1bc00401066675677eee6cbb8d17f58e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5e5fd2d8ca202f6aa4fda69227438879a8f6fb7a
https://github.com/Perl/perl5/commit/5e5fd2d8ca202f6aa4fda69227438879a8f6fb7a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: b2f374730199ad3087206b25ade98b50cc4f7235
https://github.com/Perl/perl5/commit/b2f374730199ad3087206b25ade98b50cc4f7235
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: d07595cdb0f4fd669692a381c9e9633be2bb45bf
https://github.com/Perl/perl5/commit/d07595cdb0f4fd669692a381c9e9633be2bb45bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 9b49000f1cb9693e6974935a58ac0e4a473ff745
https://github.com/Perl/perl5/commit/9b49000f1cb9693e6974935a58ac0e4a473ff745
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: d7360a1a4826b7e2dcae4e9799a22e8eb520e4ee
https://github.com/Perl/perl5/commit/d7360a1a4826b7e2dcae4e9799a22e8eb520e4ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: de5da6a92274ac97f8474a047d201c9db6e557d2
https://github.com/Perl/perl5/commit/de5da6a92274ac97f8474a047d201c9db6e557d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: f1ecd829e0e171a9a8668d1e0569e2abc2bb9559
https://github.com/Perl/perl5/commit/f1ecd829e0e171a9a8668d1e0569e2abc2bb9559
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: c47351cbaf076a32b2999303c6c2d5fa5a0d3489
https://github.com/Perl/perl5/commit/c47351cbaf076a32b2999303c6c2d5fa5a0d3489
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 0541330cac808b62b5b1e225740a88f56cb5c92b
https://github.com/Perl/perl5/commit/0541330cac808b62b5b1e225740a88f56cb5c92b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: f60fd8851112c90d4750e28c8f024dcc8fa66dab
https://github.com/Perl/perl5/commit/f60fd8851112c90d4750e28c8f024dcc8fa66dab
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 613595a2efcdc42aff8c7198358bed49b2d51ca5
https://github.com/Perl/perl5/commit/613595a2efcdc42aff8c7198358bed49b2d51ca5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: ad86d6d83745bea46a032001612fd47f4451c2c0
https://github.com/Perl/perl5/commit/ad86d6d83745bea46a032001612fd47f4451c2c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 9475560b53a783548bcdfe7db85cb59b5339c39b
https://github.com/Perl/perl5/commit/9475560b53a783548bcdfe7db85cb59b5339c39b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 0cc4c4ef81925ab2b77428e277c02f973d7310ca
https://github.com/Perl/perl5/commit/0cc4c4ef81925ab2b77428e277c02f973d7310ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 5ca357fc4a4ea4ee5425763a58babc2cfb1df3fd
https://github.com/Perl/perl5/commit/5ca357fc4a4ea4ee5425763a58babc2cfb1df3fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 27adb862daeade6e2d4efebcf83d4020418e1fab
https://github.com/Perl/perl5/commit/27adb862daeade6e2d4efebcf83d4020418e1fab
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 6c11efdb27613850e6f4db71d4d29c2b459d339d
https://github.com/Perl/perl5/commit/6c11efdb27613850e6f4db71d4d29c2b459d339d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 16d1c795254cb237d45b0257a9eecec5676117e7
https://github.com/Perl/perl5/commit/16d1c795254cb237d45b0257a9eecec5676117e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: a9fc3c02b2668c1354a73c62e9ea09a72b26a4c4
https://github.com/Perl/perl5/commit/a9fc3c02b2668c1354a73c62e9ea09a72b26a4c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 41424787ae98fb29885ae71f7267854210824cd9
https://github.com/Perl/perl5/commit/41424787ae98fb29885ae71f7267854210824cd9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 32b7514511d658d6ada83db5bbfbb3131de2a90c
https://github.com/Perl/perl5/commit/32b7514511d658d6ada83db5bbfbb3131de2a90c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 9cba0378f1fd936b05a25439c5f3fe48d39e736f
https://github.com/Perl/perl5/commit/9cba0378f1fd936b05a25439c5f3fe48d39e736f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 19cf6ec6eb324c735c467530d02e5491a68cbb32
https://github.com/Perl/perl5/commit/19cf6ec6eb324c735c467530d02e5491a68cbb32
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 87707aaf7da325be9133a5e1ab1577736b518cce
https://github.com/Perl/perl5/commit/87707aaf7da325be9133a5e1ab1577736b518cce
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: b3d135b51e430be1a6a5890d9b4945f5dbf39926
https://github.com/Perl/perl5/commit/b3d135b51e430be1a6a5890d9b4945f5dbf39926
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: ce320adb72627bcbe8efbbdeb58996a99f4e1d35
https://github.com/Perl/perl5/commit/ce320adb72627bcbe8efbbdeb58996a99f4e1d35
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 0b1e93ef93abdb7e422ae735810d12ff85d0fe3b
https://github.com/Perl/perl5/commit/0b1e93ef93abdb7e422ae735810d12ff85d0fe3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 4dd00052e733bca9d48cb5bd79e7c1d077ab499e
https://github.com/Perl/perl5/commit/4dd00052e733bca9d48cb5bd79e7c1d077ab499e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: aca79cf073254c3525181b1d6570c9b2fff96026
https://github.com/Perl/perl5/commit/aca79cf073254c3525181b1d6570c9b2fff96026
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: d49c863133c6ea91ba209dd72ed8a9e816c29062
https://github.com/Perl/perl5/commit/d49c863133c6ea91ba209dd72ed8a9e816c29062
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 6ae817d8f14326d6d9b3633c6a8180464c01a0cc
https://github.com/Perl/perl5/commit/6ae817d8f14326d6d9b3633c6a8180464c01a0cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 44905f0ffd84d098a061f6e1d61158af910d6d44
https://github.com/Perl/perl5/commit/44905f0ffd84d098a061f6e1d61158af910d6d44
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: a9635f672d3e85c6ec6be77821f39f351ef499a5
https://github.com/Perl/perl5/commit/a9635f672d3e85c6ec6be77821f39f351ef499a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 73a5066952155f8a74d380fa4dc0a86ed10a0056
https://github.com/Perl/perl5/commit/73a5066952155f8a74d380fa4dc0a86ed10a0056
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: d8d941f89545b244b01ed104bac70e9bdd7d4866
https://github.com/Perl/perl5/commit/d8d941f89545b244b01ed104bac70e9bdd7d4866
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 67b5889bc2d52bc1ea612e3a004548abd80bf455
https://github.com/Perl/perl5/commit/67b5889bc2d52bc1ea612e3a004548abd80bf455
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 7fffefd6baba3476bb22864a3abce2d88d73beec
https://github.com/Perl/perl5/commit/7fffefd6baba3476bb22864a3abce2d88d73beec
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 47ed3cd9d65c4d60deb44d0f54a287296c6d34cd
https://github.com/Perl/perl5/commit/47ed3cd9d65c4d60deb44d0f54a287296c6d34cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 88a45fe915126e6a514b1bebb8aa856e552cc136
https://github.com/Perl/perl5/commit/88a45fe915126e6a514b1bebb8aa856e552cc136
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: 3cf9878d9996d580de79782ad008d06acba22a65
https://github.com/Perl/perl5/commit/3cf9878d9996d580de79782ad008d06acba22a65
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 7eb694337ff2f174984d7b302f582e4ca1d69e87
https://github.com/Perl/perl5/commit/7eb694337ff2f174984d7b302f582e4ca1d69e87
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: dc5e15eb0d0b5901c622c944e3c67d1d8372f54f
https://github.com/Perl/perl5/commit/dc5e15eb0d0b5901c622c944e3c67d1d8372f54f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 3da082b65315c7c0192376b1fa50a5f1e2593269
https://github.com/Perl/perl5/commit/3da082b65315c7c0192376b1fa50a5f1e2593269
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: c3caa24fb29afe129833d3ec0889f03875ae4e5c
https://github.com/Perl/perl5/commit/c3caa24fb29afe129833d3ec0889f03875ae4e5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: e04998f62d87c53ce1c6b5a7e657760f3f38dca9
https://github.com/Perl/perl5/commit/e04998f62d87c53ce1c6b5a7e657760f3f38dca9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: ab9817c4e73ef172a9fdf0ee6794cf9d8673fd16
https://github.com/Perl/perl5/commit/ab9817c4e73ef172a9fdf0ee6794cf9d8673fd16
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 165f244089aedf2287208b2575e47cce1377dc5d
https://github.com/Perl/perl5/commit/165f244089aedf2287208b2575e47cce1377dc5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: b800d732bf64744e8c2e141111652011f88d6b5e
https://github.com/Perl/perl5/commit/b800d732bf64744e8c2e141111652011f88d6b5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 408322d159631c226c4a645e986738ccb6744bef
https://github.com/Perl/perl5/commit/408322d159631c226c4a645e986738ccb6744bef
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 37f7a1b5c781e89e37d38714c9fca7614e8a21a6
https://github.com/Perl/perl5/commit/37f7a1b5c781e89e37d38714c9fca7614e8a21a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 46c3a8424709ea88fe1e1f638df8d83b52540e51
https://github.com/Perl/perl5/commit/46c3a8424709ea88fe1e1f638df8d83b52540e51
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: dc5a4bb799fad9739d9b0a049c3af4deb17eb12b
https://github.com/Perl/perl5/commit/dc5a4bb799fad9739d9b0a049c3af4deb17eb12b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: eebcc2ebd3b0ad68967ed45fbf4cc444e2d07ff9
https://github.com/Perl/perl5/commit/eebcc2ebd3b0ad68967ed45fbf4cc444e2d07ff9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: b7078d202439f382cce8deb172093248e703d100
https://github.com/Perl/perl5/commit/b7078d202439f382cce8deb172093248e703d100
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 7519c2931de5ddd298fff901b530c8927a3881de
https://github.com/Perl/perl5/commit/7519c2931de5ddd298fff901b530c8927a3881de
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 1e24ceb743ea45e4da67e55facbf128a8a249d46
https://github.com/Perl/perl5/commit/1e24ceb743ea45e4da67e55facbf128a8a249d46
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: d61b5d847d2ce1579b520360350775b5007c5dc2
https://github.com/Perl/perl5/commit/d61b5d847d2ce1579b520360350775b5007c5dc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: c066b184881425769d7bc6acc7eb9a69410bc983
https://github.com/Perl/perl5/commit/c066b184881425769d7bc6acc7eb9a69410bc983
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 3a4dfa9db375541b1de36b61f1f6a451e4f4fd77
https://github.com/Perl/perl5/commit/3a4dfa9db375541b1de36b61f1f6a451e4f4fd77
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: e1b68899227b9b5cf4fdbdd3a08fe1678c4e82fe
https://github.com/Perl/perl5/commit/e1b68899227b9b5cf4fdbdd3a08fe1678c4e82fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 048e8d23fdf6c3db0a598f15f21cee37ea6a2944
https://github.com/Perl/perl5/commit/048e8d23fdf6c3db0a598f15f21cee37ea6a2944
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 86dd7c4f769d448343015b30080a79b1c8aea99f
https://github.com/Perl/perl5/commit/86dd7c4f769d448343015b30080a79b1c8aea99f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 22936a5a7c505be11db6148b12d4d1493364eb6b
https://github.com/Perl/perl5/commit/22936a5a7c505be11db6148b12d4d1493364eb6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 547b1e0d30847e71781745b3516361a296a11255
https://github.com/Perl/perl5/commit/547b1e0d30847e71781745b3516361a296a11255
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 52cbc6273051a5658b32247d21f69129c21c9e73
https://github.com/Perl/perl5/commit/52cbc6273051a5658b32247d21f69129c21c9e73
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 08fccffbb907cff51691ad2ebb86fdb942425a4b
https://github.com/Perl/perl5/commit/08fccffbb907cff51691ad2ebb86fdb942425a4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: febf551349324983fa4fa6ab048adbf640e17c22
https://github.com/Perl/perl5/commit/febf551349324983fa4fa6ab048adbf640e17c22
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 08d7a38471ff686b8c4d59c8fb44f3a1ce89d939
https://github.com/Perl/perl5/commit/08d7a38471ff686b8c4d59c8fb44f3a1ce89d939
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 9990c0bee2f55b0cc3f497a622a3f239695f1a52
https://github.com/Perl/perl5/commit/9990c0bee2f55b0cc3f497a622a3f239695f1a52
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 85cff8e375294ab9539bc626ab71717d58ccc03f
https://github.com/Perl/perl5/commit/85cff8e375294ab9539bc626ab71717d58ccc03f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 2462345bf0198c695ba1086f6d9bc7c3eda989db
https://github.com/Perl/perl5/commit/2462345bf0198c695ba1086f6d9bc7c3eda989db
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: fd77db5a470678cc8e99d58a2af562114dc2ef95
https://github.com/Perl/perl5/commit/fd77db5a470678cc8e99d58a2af562114dc2ef95
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
38
Compare: https://github.com/Perl/perl5/compare/b8433b9e0f92...fd77db5a4706
