Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 2d7d127eb9d9d4d683b06d62bbcd10a471f1a40c
https://github.com/Perl/perl5/commit/2d7d127eb9d9d4d683b06d62bbcd10a471f1a40c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: a9bbd880c2ad194e4e557a36bcf06ddb9892aaff
https://github.com/Perl/perl5/commit/a9bbd880c2ad194e4e557a36bcf06ddb9892aaff
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 12b3ae67e81951fb89491dc1e79e0af1a02a3fdb
https://github.com/Perl/perl5/commit/12b3ae67e81951fb89491dc1e79e0af1a02a3fdb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: f2830683b1b092e158e556e5345242196539e358
https://github.com/Perl/perl5/commit/f2830683b1b092e158e556e5345242196539e358
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 5868966e4b930552e15ebf9921647897fc80723e
https://github.com/Perl/perl5/commit/5868966e4b930552e15ebf9921647897fc80723e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: c70967820993e4fb324e5c20498ffd3177303bc0
https://github.com/Perl/perl5/commit/c70967820993e4fb324e5c20498ffd3177303bc0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: ebe5029636ce2b51b581840e8d2b51b019f3918f
https://github.com/Perl/perl5/commit/ebe5029636ce2b51b581840e8d2b51b019f3918f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 7f1522eadfeca74f4574f6fdd24a34d6a0d30a30
https://github.com/Perl/perl5/commit/7f1522eadfeca74f4574f6fdd24a34d6a0d30a30
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: a895027c3617f887e6850875d90cbcbb3a5d3564
https://github.com/Perl/perl5/commit/a895027c3617f887e6850875d90cbcbb3a5d3564
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 1f0fddeeff5c77b817ee62ae371d7d82cc16eee1
https://github.com/Perl/perl5/commit/1f0fddeeff5c77b817ee62ae371d7d82cc16eee1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 9aab7b0636c82deda7218cad8ffb085ef530df8d
https://github.com/Perl/perl5/commit/9aab7b0636c82deda7218cad8ffb085ef530df8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: d3cad59145d847f1533135ecaab8785f214834c0
https://github.com/Perl/perl5/commit/d3cad59145d847f1533135ecaab8785f214834c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 9117f61b9f753bfd8580b1614c117a3fd13e189c
https://github.com/Perl/perl5/commit/9117f61b9f753bfd8580b1614c117a3fd13e189c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 0c37d52e06e6bcb86410fcfe7f58a39b8526b125
https://github.com/Perl/perl5/commit/0c37d52e06e6bcb86410fcfe7f58a39b8526b125
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: bec23eb06f28add1b29c1ca865abd770e382ad6e
https://github.com/Perl/perl5/commit/bec23eb06f28add1b29c1ca865abd770e382ad6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: a0204a107a90b97814215caaa671c191e698932b
https://github.com/Perl/perl5/commit/a0204a107a90b97814215caaa671c191e698932b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 1ec847281d04f38559e703d116aaaebf97037141
https://github.com/Perl/perl5/commit/1ec847281d04f38559e703d116aaaebf97037141
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: ff390386dc85fe09e2f9e4fbfe6b8e847e887736
https://github.com/Perl/perl5/commit/ff390386dc85fe09e2f9e4fbfe6b8e847e887736
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 3776c24aac65b6aebded7fd32bd70f47d2f3b9e7
https://github.com/Perl/perl5/commit/3776c24aac65b6aebded7fd32bd70f47d2f3b9e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: b6d3c08ffd8025ddc91aa70b3540544795665701
https://github.com/Perl/perl5/commit/b6d3c08ffd8025ddc91aa70b3540544795665701
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 5d5764e9f89952d7db0d0d87745903e33b11ac10
https://github.com/Perl/perl5/commit/5d5764e9f89952d7db0d0d87745903e33b11ac10
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 4827fac3c0d3c4ed2575c15c8732451232d9aa57
https://github.com/Perl/perl5/commit/4827fac3c0d3c4ed2575c15c8732451232d9aa57
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: e0cf37ff52255b0892a1d11cf927f69e8cc4077c
https://github.com/Perl/perl5/commit/e0cf37ff52255b0892a1d11cf927f69e8cc4077c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: b9044978ec61084728741d618faea1d85e773c0b
https://github.com/Perl/perl5/commit/b9044978ec61084728741d618faea1d85e773c0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 17ee8bab7abe16024b6a42f12ad54713fb947e1e
https://github.com/Perl/perl5/commit/17ee8bab7abe16024b6a42f12ad54713fb947e1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 9bb7ec1a88a415091c8cd5a104508da16de3275b
https://github.com/Perl/perl5/commit/9bb7ec1a88a415091c8cd5a104508da16de3275b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 9eeb3d8fd09296dffd888f5f1ac20bb4efcf1941
https://github.com/Perl/perl5/commit/9eeb3d8fd09296dffd888f5f1ac20bb4efcf1941
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: f871b3ec0088a565487c2dccad64a244fb3b7464
https://github.com/Perl/perl5/commit/f871b3ec0088a565487c2dccad64a244fb3b7464
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 6fd8f161f27c2595faab933ca7c9cb3e5f1fb72e
https://github.com/Perl/perl5/commit/6fd8f161f27c2595faab933ca7c9cb3e5f1fb72e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 5319de7fb445d2ead92eeb19216bae70e950a167
https://github.com/Perl/perl5/commit/5319de7fb445d2ead92eeb19216bae70e950a167
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 8af087553fc9ef8084e1181678984d4e501ba6f9
https://github.com/Perl/perl5/commit/8af087553fc9ef8084e1181678984d4e501ba6f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 01f7d2e9912017e4ebf12e829fd5840ec1ae4b71
https://github.com/Perl/perl5/commit/01f7d2e9912017e4ebf12e829fd5840ec1ae4b71
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: acce74ec5864a7306c0fd6943c7cdc3cf141147c
https://github.com/Perl/perl5/commit/acce74ec5864a7306c0fd6943c7cdc3cf141147c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: df0b9d46b836025286842050a1b687d1fb9f48a0
https://github.com/Perl/perl5/commit/df0b9d46b836025286842050a1b687d1fb9f48a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: c396aa890fe479e799e6899954b99ed5413e4c5d
https://github.com/Perl/perl5/commit/c396aa890fe479e799e6899954b99ed5413e4c5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 6412cc403a60c0998575a898607b1624b54ff505
https://github.com/Perl/perl5/commit/6412cc403a60c0998575a898607b1624b54ff505
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 01a41fee11907c5efc22fb21885a0de6bd993141
https://github.com/Perl/perl5/commit/01a41fee11907c5efc22fb21885a0de6bd993141
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 0e70a8befd5747d6df50b7729a53d7fc6e7b0d32
https://github.com/Perl/perl5/commit/0e70a8befd5747d6df50b7729a53d7fc6e7b0d32
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 3e77d184f27fd07bb22d6441674c49fb87980647
https://github.com/Perl/perl5/commit/3e77d184f27fd07bb22d6441674c49fb87980647
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 1c467cd5a854143d5654f69d8c2fcd36783da19d
https://github.com/Perl/perl5/commit/1c467cd5a854143d5654f69d8c2fcd36783da19d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 3eae0db8b8cde9512d151554eb9b1ab058b8c03e
https://github.com/Perl/perl5/commit/3eae0db8b8cde9512d151554eb9b1ab058b8c03e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: fd2d84a83aaa4e77f8d61aafcfd86c7989480565
https://github.com/Perl/perl5/commit/fd2d84a83aaa4e77f8d61aafcfd86c7989480565
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: e46d7faf51b8a6b321b081f8109f1f2c6368407a
https://github.com/Perl/perl5/commit/e46d7faf51b8a6b321b081f8109f1f2c6368407a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 33645a17fe336ededfd19b7982688da32bed6aba
https://github.com/Perl/perl5/commit/33645a17fe336ededfd19b7982688da32bed6aba
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: fa875194cc9fb954e1572183263ea9a3a68d606f
https://github.com/Perl/perl5/commit/fa875194cc9fb954e1572183263ea9a3a68d606f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: afedad54afc9e60e6c258eeee1436107a47882e7
https://github.com/Perl/perl5/commit/afedad54afc9e60e6c258eeee1436107a47882e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 87d22b559a679299863ab0d8dda4af271d524181
https://github.com/Perl/perl5/commit/87d22b559a679299863ab0d8dda4af271d524181
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: ea5476ba4764350aa14c4f913579e82e4e628f30
https://github.com/Perl/perl5/commit/ea5476ba4764350aa14c4f913579e82e4e628f30
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: d7ddc85f413ac0cb37147fecb4a60fb959d5beab
https://github.com/Perl/perl5/commit/d7ddc85f413ac0cb37147fecb4a60fb959d5beab
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 0828b015743a18f45d77fe6a1724310795950288
https://github.com/Perl/perl5/commit/0828b015743a18f45d77fe6a1724310795950288
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 56c4b16d354de404042d3aede38abf8d581db03d
https://github.com/Perl/perl5/commit/56c4b16d354de404042d3aede38abf8d581db03d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 62e80254702df95d52338ce6f171f74e9ebd5f2a
https://github.com/Perl/perl5/commit/62e80254702df95d52338ce6f171f74e9ebd5f2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: f4b9d3bd22020415b7c646f2cc8e96ff550e09fa
https://github.com/Perl/perl5/commit/f4b9d3bd22020415b7c646f2cc8e96ff550e09fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 75c13c4e00b8cc46d78fd39411d2413709cd124c
https://github.com/Perl/perl5/commit/75c13c4e00b8cc46d78fd39411d2413709cd124c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 6ce26802e28c916488d18cb45be631689845a0f1
https://github.com/Perl/perl5/commit/6ce26802e28c916488d18cb45be631689845a0f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: d2c24a8ee4e455a911b3ba8320bdc95869637ce8
https://github.com/Perl/perl5/commit/d2c24a8ee4e455a911b3ba8320bdc95869637ce8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 5b7eccb5aaecee77adaa7caf7a15470e119b5cf7
https://github.com/Perl/perl5/commit/5b7eccb5aaecee77adaa7caf7a15470e119b5cf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: 03312f827076a81c6838bfa5aff51f476f33db4d
https://github.com/Perl/perl5/commit/03312f827076a81c6838bfa5aff51f476f33db4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 0077c629328a771629fb11aae73661ff5574d383
https://github.com/Perl/perl5/commit/0077c629328a771629fb11aae73661ff5574d383
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: a312c3a9fd0cf486dafe1515b262b1eb30f2d6bc
https://github.com/Perl/perl5/commit/a312c3a9fd0cf486dafe1515b262b1eb30f2d6bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: b48b5dd0cc4e539a1d4f7da317122618d0f8ecba
https://github.com/Perl/perl5/commit/b48b5dd0cc4e539a1d4f7da317122618d0f8ecba
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 75dfd36ac25801146866cc43dafad4c2699a574b
https://github.com/Perl/perl5/commit/75dfd36ac25801146866cc43dafad4c2699a574b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: f9d4ba7e78f2a3f28e55b5f9f7a4c56c98f58913
https://github.com/Perl/perl5/commit/f9d4ba7e78f2a3f28e55b5f9f7a4c56c98f58913
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 01fe3ff6c00d910b007d366f59fd7f51895d7098
https://github.com/Perl/perl5/commit/01fe3ff6c00d910b007d366f59fd7f51895d7098
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: a2b14bc42c3fabbb93cf737d87786f2086ccf18b
https://github.com/Perl/perl5/commit/a2b14bc42c3fabbb93cf737d87786f2086ccf18b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 46eebf9746e1318f9547185beebdd85a0893b873
https://github.com/Perl/perl5/commit/46eebf9746e1318f9547185beebdd85a0893b873
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 97d532196a759b2b3d5dce69f95f7cfd912415ee
https://github.com/Perl/perl5/commit/97d532196a759b2b3d5dce69f95f7cfd912415ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 416f06bf6c6e383543d1029b2c04a2ba7582fcff
https://github.com/Perl/perl5/commit/416f06bf6c6e383543d1029b2c04a2ba7582fcff
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: b895183c07817f3e8fa59100997f45fe8e5e5883
https://github.com/Perl/perl5/commit/b895183c07817f3e8fa59100997f45fe8e5e5883
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 42976935b92baa246b63f373a9f4f15f29bdb501
https://github.com/Perl/perl5/commit/42976935b92baa246b63f373a9f4f15f29bdb501
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 1bff34e45e98fbd0ad23b3fa2eeca1a62c4866de
https://github.com/Perl/perl5/commit/1bff34e45e98fbd0ad23b3fa2eeca1a62c4866de
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 281c45cfac0893d6e2a021623522dd0c71abc1b8
https://github.com/Perl/perl5/commit/281c45cfac0893d6e2a021623522dd0c71abc1b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 4206d50e1ef41f4e406835dd6b9df147595ba230
https://github.com/Perl/perl5/commit/4206d50e1ef41f4e406835dd6b9df147595ba230
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 2202b70c62b2e26263b7cbe6ca8299c011d18078
https://github.com/Perl/perl5/commit/2202b70c62b2e26263b7cbe6ca8299c011d18078
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: df701018278ee2c7a84a48e4759aeeb36f7499a4
https://github.com/Perl/perl5/commit/df701018278ee2c7a84a48e4759aeeb36f7499a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: c294d56dcf7fd2870d27b21a17da9eb5d60efdc8
https://github.com/Perl/perl5/commit/c294d56dcf7fd2870d27b21a17da9eb5d60efdc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 9304642c443b305f0cb616286c12a61ebca8282f
https://github.com/Perl/perl5/commit/9304642c443b305f0cb616286c12a61ebca8282f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 668e59ec4bf73328532c5efeb73ca841c527c483
https://github.com/Perl/perl5/commit/668e59ec4bf73328532c5efeb73ca841c527c483
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: bc3b4713b0154b08b507c05d7c32a7d22e125874
https://github.com/Perl/perl5/commit/bc3b4713b0154b08b507c05d7c32a7d22e125874
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 587640373441830551b281951f642d89523b32f4
https://github.com/Perl/perl5/commit/587640373441830551b281951f642d89523b32f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: f57af6724be0916049882db8c3e1d6a03fe33cda
https://github.com/Perl/perl5/commit/f57af6724be0916049882db8c3e1d6a03fe33cda
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: c62bf5116bb4f9955aab055adae2c324795d4c46
https://github.com/Perl/perl5/commit/c62bf5116bb4f9955aab055adae2c324795d4c46
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: f696e9370c8208ebad0cfbb37415c16b1cb0ee90
https://github.com/Perl/perl5/commit/f696e9370c8208ebad0cfbb37415c16b1cb0ee90
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 3e744e49592d78308a02ce7119e4284d6bc91838
https://github.com/Perl/perl5/commit/3e744e49592d78308a02ce7119e4284d6bc91838
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 1f7fcbe221888898f386ddb393b31f74074934d7
https://github.com/Perl/perl5/commit/1f7fcbe221888898f386ddb393b31f74074934d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: abf5b3e6411dc62286751c6d42654363624de0d9
https://github.com/Perl/perl5/commit/abf5b3e6411dc62286751c6d42654363624de0d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 3c91c80831e92482525e0f600015a6deb59612d1
https://github.com/Perl/perl5/commit/3c91c80831e92482525e0f600015a6deb59612d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 4045fd86498efd318a75719eee5b8132abad5971
https://github.com/Perl/perl5/commit/4045fd86498efd318a75719eee5b8132abad5971
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 56489e2bebf5c49d6cb034f7a79e698aa0d1e744
https://github.com/Perl/perl5/commit/56489e2bebf5c49d6cb034f7a79e698aa0d1e744
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 603da0b837ea62d35e94e4eeda50a56d1b639c77
https://github.com/Perl/perl5/commit/603da0b837ea62d35e94e4eeda50a56d1b639c77
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 51c3e52c6bad89c147512dbc536c7821edefec46
https://github.com/Perl/perl5/commit/51c3e52c6bad89c147512dbc536c7821edefec46
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 863d7c5cbab01c217f0adb44694a7aa3adac9036
https://github.com/Perl/perl5/commit/863d7c5cbab01c217f0adb44694a7aa3adac9036
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: d1b2fea7e4de314a5750d0b26b012c70bbc53b0f
https://github.com/Perl/perl5/commit/d1b2fea7e4de314a5750d0b26b012c70bbc53b0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 0fc7a1a158101c0374b7976a57f9964919ac19c9
https://github.com/Perl/perl5/commit/0fc7a1a158101c0374b7976a57f9964919ac19c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 6863f37b139dbe2c7501d0f3b8867bb14c88daf1
https://github.com/Perl/perl5/commit/6863f37b139dbe2c7501d0f3b8867bb14c88daf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: c60d264ca2c0bc762280b6cfdfb58be3f3567c42
https://github.com/Perl/perl5/commit/c60d264ca2c0bc762280b6cfdfb58be3f3567c42
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 3ef2a1aca9d845b55b56437993adf9e8f9bf584b
https://github.com/Perl/perl5/commit/3ef2a1aca9d845b55b56437993adf9e8f9bf584b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 5ed4e4f6bc9e0f77ef22425a6f4de5526e2255bb
https://github.com/Perl/perl5/commit/5ed4e4f6bc9e0f77ef22425a6f4de5526e2255bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 406ee3e77ceda23607106b39d9f75c67298d6fb8
https://github.com/Perl/perl5/commit/406ee3e77ceda23607106b39d9f75c67298d6fb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: e3e8bef50856fb5319e5529e6e9091c1e2d86d36
https://github.com/Perl/perl5/commit/e3e8bef50856fb5319e5529e6e9091c1e2d86d36
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: 402d96912762c7ba0d92ff052f9fbcb038536c5f
https://github.com/Perl/perl5/commit/402d96912762c7ba0d92ff052f9fbcb038536c5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 304ed875987e52a566c02556244e603a617b1a52
https://github.com/Perl/perl5/commit/304ed875987e52a566c02556244e603a617b1a52
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 09032a850554075e6d80d0baeb3ca17c5557a2eb
https://github.com/Perl/perl5/commit/09032a850554075e6d80d0baeb3ca17c5557a2eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 297d8dfd1dcde4fac7cedbcd31eaf4064d41d507
https://github.com/Perl/perl5/commit/297d8dfd1dcde4fac7cedbcd31eaf4064d41d507
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 4cb8f981823df034f76172240ac5e043552742ad
https://github.com/Perl/perl5/commit/4cb8f981823df034f76172240ac5e043552742ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: ff296b330140b550892c980ce7d920c55dd5947b
https://github.com/Perl/perl5/commit/ff296b330140b550892c980ce7d920c55dd5947b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: ad5eaf863afc1009cd8ea42b94044a8c8132c955
https://github.com/Perl/perl5/commit/ad5eaf863afc1009cd8ea42b94044a8c8132c955
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 92cb96c98d0298dd115029f9645bef4764502e0f
https://github.com/Perl/perl5/commit/92cb96c98d0298dd115029f9645bef4764502e0f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 5bc877d54e805985b250f6f759245881ced2aa4d
https://github.com/Perl/perl5/commit/5bc877d54e805985b250f6f759245881ced2aa4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 1a1e7f9d3d6951be536f19f5ab6961da6b25f9cb
https://github.com/Perl/perl5/commit/1a1e7f9d3d6951be536f19f5ab6961da6b25f9cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 9aa1c53d7b7e5fbccdf1d7c7ab224fd52f91bfbc
https://github.com/Perl/perl5/commit/9aa1c53d7b7e5fbccdf1d7c7ab224fd52f91bfbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: c6c4bbbc9fdbee5e3c390f1730103fb0aebaa6c0
https://github.com/Perl/perl5/commit/c6c4bbbc9fdbee5e3c390f1730103fb0aebaa6c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 28a1caa6c9e9928aaad2516dff9a6b3353bf7779
https://github.com/Perl/perl5/commit/28a1caa6c9e9928aaad2516dff9a6b3353bf7779
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 8c624ad43ee212fcf11455ead104180e2d3b38a9
https://github.com/Perl/perl5/commit/8c624ad43ee212fcf11455ead104180e2d3b38a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 3408920c3b235d2b58b7ebb5d23929d425d8e17a
https://github.com/Perl/perl5/commit/3408920c3b235d2b58b7ebb5d23929d425d8e17a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 411d870a99d93abf20f0cda32db61878eb146ad5
https://github.com/Perl/perl5/commit/411d870a99d93abf20f0cda32db61878eb146ad5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 940f6b5f1daa924383aaaa9eb822c939c9626f21
https://github.com/Perl/perl5/commit/940f6b5f1daa924383aaaa9eb822c939c9626f21
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: e333f2acb3f6100072d8b5d8e6cf5bdb07a6d7dc
https://github.com/Perl/perl5/commit/e333f2acb3f6100072d8b5d8e6cf5bdb07a6d7dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: e58b4ef9edf9207dcf05b89df89f5d27696be1a1
https://github.com/Perl/perl5/commit/e58b4ef9edf9207dcf05b89df89f5d27696be1a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 6b46e8e2e83dc08a157db91179f84cbeb6f0d170
https://github.com/Perl/perl5/commit/6b46e8e2e83dc08a157db91179f84cbeb6f0d170
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 37e23f5312a8e14b7a5d23dba972493616049a51
https://github.com/Perl/perl5/commit/37e23f5312a8e14b7a5d23dba972493616049a51
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: b3decd55fa8775c8acba74d1140f0e71f744f5d9
https://github.com/Perl/perl5/commit/b3decd55fa8775c8acba74d1140f0e71f744f5d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 93af49c895346892eb84d32ea573d6456a220aef
https://github.com/Perl/perl5/commit/93af49c895346892eb84d32ea573d6456a220aef
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 522998f8f3231e0001bc35a1803796268a07834c
https://github.com/Perl/perl5/commit/522998f8f3231e0001bc35a1803796268a07834c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 54ff6b7602654d4c9e0bd7eb3d1d18d97de8e03a
https://github.com/Perl/perl5/commit/54ff6b7602654d4c9e0bd7eb3d1d18d97de8e03a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 06ffcca285e9c1d63c2d607fcbc3a20c84870f9a
https://github.com/Perl/perl5/commit/06ffcca285e9c1d63c2d607fcbc3a20c84870f9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: c2f494c2703730d3c0f8d7283bdc6e16cb99715a
https://github.com/Perl/perl5/commit/c2f494c2703730d3c0f8d7283bdc6e16cb99715a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: aeae8d19c45d6b919a9295e3e3f5d868d8d08362
https://github.com/Perl/perl5/commit/aeae8d19c45d6b919a9295e3e3f5d868d8d08362
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 6e50fda4e62140425e17e0ffb3d70bc9f7138fc4
https://github.com/Perl/perl5/commit/6e50fda4e62140425e17e0ffb3d70bc9f7138fc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 4cab32c8f2559008dd9a8151166f94a6a95ea1f3
https://github.com/Perl/perl5/commit/4cab32c8f2559008dd9a8151166f94a6a95ea1f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: aee3b0f6df89f41ead55ceed2eaf55d8aadfe689
https://github.com/Perl/perl5/commit/aee3b0f6df89f41ead55ceed2eaf55d8aadfe689
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 5f3259dbbf9afe1d2ada286743918d507936455c
https://github.com/Perl/perl5/commit/5f3259dbbf9afe1d2ada286743918d507936455c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: ddaf603cb7f434c520893406614786414ce6bbe3
https://github.com/Perl/perl5/commit/ddaf603cb7f434c520893406614786414ce6bbe3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 25bd375cf2f740ff1699250c8885d8d8b36e45df
https://github.com/Perl/perl5/commit/25bd375cf2f740ff1699250c8885d8d8b36e45df
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: 4c7aeca6d190310c222e22f3ff99f85c02f3b92b
https://github.com/Perl/perl5/commit/4c7aeca6d190310c222e22f3ff99f85c02f3b92b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: f99274ea25a6480f0631ddeb9cfeedb6f1e4683c
https://github.com/Perl/perl5/commit/f99274ea25a6480f0631ddeb9cfeedb6f1e4683c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 05ef1fc60e6db76dda7b29e95f5352690312acd0
https://github.com/Perl/perl5/commit/05ef1fc60e6db76dda7b29e95f5352690312acd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: b99537e549746238a882f017e0dd98b3fcb7cbdc
https://github.com/Perl/perl5/commit/b99537e549746238a882f017e0dd98b3fcb7cbdc
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 1e41e95ac059c6e181d34d0c436acd55fb4c3ec8
https://github.com/Perl/perl5/commit/1e41e95ac059c6e181d34d0c436acd55fb4c3ec8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 80d4a1c0721f0d89cd3ab44dd05651eab4e5a18a
https://github.com/Perl/perl5/commit/80d4a1c0721f0d89cd3ab44dd05651eab4e5a18a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: d0395aa6a27d8725e46f1b6a1ba8f355de862cbe
https://github.com/Perl/perl5/commit/d0395aa6a27d8725e46f1b6a1ba8f355de862cbe
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 3bb7dcd1e1f2db887ec3bc9f05cf33bd597faa59
https://github.com/Perl/perl5/commit/3bb7dcd1e1f2db887ec3bc9f05cf33bd597faa59
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 08780679db65fcd4cbad6cd860fd5e9c0e493a9c
https://github.com/Perl/perl5/commit/08780679db65fcd4cbad6cd860fd5e9c0e493a9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 47f3a01ee05685a68b3608aa7f72654ef5780b8a
https://github.com/Perl/perl5/commit/47f3a01ee05685a68b3608aa7f72654ef5780b8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 228607df24065d4a559de9bb42a3c09f3da4d1b3
https://github.com/Perl/perl5/commit/228607df24065d4a559de9bb42a3c09f3da4d1b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: a5d38d46b9669fe12dbfe4086d8197ec56f91ad2
https://github.com/Perl/perl5/commit/a5d38d46b9669fe12dbfe4086d8197ec56f91ad2
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: a0dffb608589322fbe830bc957013fafac684e9c
https://github.com/Perl/perl5/commit/a0dffb608589322fbe830bc957013fafac684e9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: aabb76e9bc45c3749c1253268109215b6e7f09c4
https://github.com/Perl/perl5/commit/aabb76e9bc45c3749c1253268109215b6e7f09c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: b837a4d6b534309353bec474e7273892f0966189
https://github.com/Perl/perl5/commit/b837a4d6b534309353bec474e7273892f0966189
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 182774065473444cad8d54885dd055e3258441d4
https://github.com/Perl/perl5/commit/182774065473444cad8d54885dd055e3258441d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: f84d7a89c1f50f4cf030d4e7c6c81a91e6804acb
https://github.com/Perl/perl5/commit/f84d7a89c1f50f4cf030d4e7c6c81a91e6804acb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 9071a409b945d8ad37d454d6227e916dcf99fb1e
https://github.com/Perl/perl5/commit/9071a409b945d8ad37d454d6227e916dcf99fb1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 3aeac96f09270717c6f3729fe3385969f7f9f99d
https://github.com/Perl/perl5/commit/3aeac96f09270717c6f3729fe3385969f7f9f99d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 07afc0803ba5920ca373f20d74e08c24713e82fa
https://github.com/Perl/perl5/commit/07afc0803ba5920ca373f20d74e08c24713e82fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: d19e725ade79fc54680b0c103db9f275fbbdf224
https://github.com/Perl/perl5/commit/d19e725ade79fc54680b0c103db9f275fbbdf224
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: dc29ebfd909a203e016fba7d8e30d1b743ddc303
https://github.com/Perl/perl5/commit/dc29ebfd909a203e016fba7d8e30d1b743ddc303
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 0c1d70ef6be1a11da8c908731fb236d7589f2e39
https://github.com/Perl/perl5/commit/0c1d70ef6be1a11da8c908731fb236d7589f2e39
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 6fb991fe5e6eb66fc384413f7412909d5978ed1a
https://github.com/Perl/perl5/commit/6fb991fe5e6eb66fc384413f7412909d5978ed1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 0abf1c8fd1cab5f072d02c032f9fc04ce30fe18d
https://github.com/Perl/perl5/commit/0abf1c8fd1cab5f072d02c032f9fc04ce30fe18d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: ffe3ecc9ef6b313e409f33ab72e4312086da6db1
https://github.com/Perl/perl5/commit/ffe3ecc9ef6b313e409f33ab72e4312086da6db1
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: ca0227cf77122c51552ccb2c5ffba5f4a1d0b205
https://github.com/Perl/perl5/commit/ca0227cf77122c51552ccb2c5ffba5f4a1d0b205
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: c836f599b21b94342f0fe2ce290454c08a4f9418
https://github.com/Perl/perl5/commit/c836f599b21b94342f0fe2ce290454c08a4f9418
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 0fbecf8e787f467201e8bba5f724d670d0bcf058
https://github.com/Perl/perl5/commit/0fbecf8e787f467201e8bba5f724d670d0bcf058
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: aa07ae4036ad3a482178b6ffa898e415a4c5c56a
https://github.com/Perl/perl5/commit/aa07ae4036ad3a482178b6ffa898e415a4c5c56a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 328b07cc94d3cde0d4256b23cfd1dfd91d401f3d
https://github.com/Perl/perl5/commit/328b07cc94d3cde0d4256b23cfd1dfd91d401f3d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 7990255f9d47f19d1dff353ac5d39e7a0c544a73
https://github.com/Perl/perl5/commit/7990255f9d47f19d1dff353ac5d39e7a0c544a73
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: fb0ae8148d60273d28ae2071b48ea4d654434498
https://github.com/Perl/perl5/commit/fb0ae8148d60273d28ae2071b48ea4d654434498
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: adcbc888a83aab8d31aef514c9af1d55334144ff
https://github.com/Perl/perl5/commit/adcbc888a83aab8d31aef514c9af1d55334144ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: a9edac819719db9fc179975afab55c64cfa09347
https://github.com/Perl/perl5/commit/a9edac819719db9fc179975afab55c64cfa09347
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 3d229f353a8529aa06830cc72f0368a6e4489418
https://github.com/Perl/perl5/commit/3d229f353a8529aa06830cc72f0368a6e4489418
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 326e47639b932dc029353400219c05d6f779f90c
https://github.com/Perl/perl5/commit/326e47639b932dc029353400219c05d6f779f90c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 2afade708e07784ae634c7027fe44acbd01b3a8e
https://github.com/Perl/perl5/commit/2afade708e07784ae634c7027fe44acbd01b3a8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 10a80bc9ee7eec6ab0c265d6dbeb81d51176db6b
https://github.com/Perl/perl5/commit/10a80bc9ee7eec6ab0c265d6dbeb81d51176db6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 1fb2ec926e980226291bbc321ef18487bf5ac943
https://github.com/Perl/perl5/commit/1fb2ec926e980226291bbc321ef18487bf5ac943
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 2741d157f53747ff65ef5cb82c70ba8a7b66eb79
https://github.com/Perl/perl5/commit/2741d157f53747ff65ef5cb82c70ba8a7b66eb79
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 55cf89ec3df722da62cc0f356693c0bf17a0c78e
https://github.com/Perl/perl5/commit/55cf89ec3df722da62cc0f356693c0bf17a0c78e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: d92bd7a01b76b732b9392c28f0f84cb12a12b72f
https://github.com/Perl/perl5/commit/d92bd7a01b76b732b9392c28f0f84cb12a12b72f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 455f06c9c80c8192bd9a5b27a5f81c560b102daa
https://github.com/Perl/perl5/commit/455f06c9c80c8192bd9a5b27a5f81c560b102daa
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 9a00a139ddf9f97d5c0e8d162f34046ac14b60ed
https://github.com/Perl/perl5/commit/9a00a139ddf9f97d5c0e8d162f34046ac14b60ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: fae2d3ee8244812255e12d3f9ada10dad496a7a4
https://github.com/Perl/perl5/commit/fae2d3ee8244812255e12d3f9ada10dad496a7a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 608b62369b339feeba24809718e74f61473955fa
https://github.com/Perl/perl5/commit/608b62369b339feeba24809718e74f61473955fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 74bafa03b13b6d0a553fe6b564340c2e7596fdf5
https://github.com/Perl/perl5/commit/74bafa03b13b6d0a553fe6b564340c2e7596fdf5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: b3ca0379d90c693272e37f2969819f0b1c5cf637
https://github.com/Perl/perl5/commit/b3ca0379d90c693272e37f2969819f0b1c5cf637
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 5a2963a07db47f750c8f173df59c922117fb8d83
https://github.com/Perl/perl5/commit/5a2963a07db47f750c8f173df59c922117fb8d83
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 70f9112b758c9410ed9a92651dcc2faff560eb03
https://github.com/Perl/perl5/commit/70f9112b758c9410ed9a92651dcc2faff560eb03
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: bb0b2b42b37741a894f331c666ca50f9b9a276aa
https://github.com/Perl/perl5/commit/bb0b2b42b37741a894f331c666ca50f9b9a276aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: d8e258626f3f42e5272604d020eb62af3c2e2449
https://github.com/Perl/perl5/commit/d8e258626f3f42e5272604d020eb62af3c2e2449
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c3019c277c5c9b4816757d409ff0fb17dfd92212
https://github.com/Perl/perl5/commit/c3019c277c5c9b4816757d409ff0fb17dfd92212
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 6983ad4f2331adcb0fc70c2a197dd5952a70eb98
https://github.com/Perl/perl5/commit/6983ad4f2331adcb0fc70c2a197dd5952a70eb98
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 5f9683a1fd2793900f784b45e60f854bf81d4eb5
https://github.com/Perl/perl5/commit/5f9683a1fd2793900f784b45e60f854bf81d4eb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 574f3ea1749fc4e96b6d9bc39015b4d081fe9341
https://github.com/Perl/perl5/commit/574f3ea1749fc4e96b6d9bc39015b4d081fe9341
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: a5d1ce7cab32c7588618841a6d8599a9c055ff31
https://github.com/Perl/perl5/commit/a5d1ce7cab32c7588618841a6d8599a9c055ff31
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: cae97c1dcb88f4d69a45499a3dd8682d96aa60fd
https://github.com/Perl/perl5/commit/cae97c1dcb88f4d69a45499a3dd8682d96aa60fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 4a5f9ece9afb967f4aa46d98b407fa0bf101f775
https://github.com/Perl/perl5/commit/4a5f9ece9afb967f4aa46d98b407fa0bf101f775
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 34d94a589c6584a8e19913359a53e0e5e3071a14
https://github.com/Perl/perl5/commit/34d94a589c6584a8e19913359a53e0e5e3071a14
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: ee5ef8a3a09464d660051b7b6a8e336576e42b42
https://github.com/Perl/perl5/commit/ee5ef8a3a09464d660051b7b6a8e336576e42b42
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 3dfe0faa5e50800afa1e97cca76c1a8446770af0
https://github.com/Perl/perl5/commit/3dfe0faa5e50800afa1e97cca76c1a8446770af0
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 67e196e6a79acc92f299f3e91a14343e0725eac4
https://github.com/Perl/perl5/commit/67e196e6a79acc92f299f3e91a14343e0725eac4
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 800357899cdab9e45717c9e5d12d300dbc06a1a3
https://github.com/Perl/perl5/commit/800357899cdab9e45717c9e5d12d300dbc06a1a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: df18e7451dfdfde127473852808bb73f7607ca13
https://github.com/Perl/perl5/commit/df18e7451dfdfde127473852808bb73f7607ca13
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: ef8cc3627175dba0ef489e2f5a7c63983e4bdca9
https://github.com/Perl/perl5/commit/ef8cc3627175dba0ef489e2f5a7c63983e4bdca9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: bf2524b8641e1bb0eaaf5092b10edcf237e84911
https://github.com/Perl/perl5/commit/bf2524b8641e1bb0eaaf5092b10edcf237e84911
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 231dce2224abafa5a783361001ec6e8b184d36aa
https://github.com/Perl/perl5/commit/231dce2224abafa5a783361001ec6e8b184d36aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 87e758e24012cdbf1abe38311e2f213f60effbef
https://github.com/Perl/perl5/commit/87e758e24012cdbf1abe38311e2f213f60effbef
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 37918665deb3782dfc5aa5e8f3b92ba4cd5eaab5
https://github.com/Perl/perl5/commit/37918665deb3782dfc5aa5e8f3b92ba4cd5eaab5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: aaf58374cb527fab8c622ab756ac97c30a3f95ff
https://github.com/Perl/perl5/commit/aaf58374cb527fab8c622ab756ac97c30a3f95ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: d5e00b92d308c3cb483eac24a1139c5cbc66ed87
https://github.com/Perl/perl5/commit/d5e00b92d308c3cb483eac24a1139c5cbc66ed87
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 1d934746b15d8783d8fc53edff20fe93e9ee6726
https://github.com/Perl/perl5/commit/1d934746b15d8783d8fc53edff20fe93e9ee6726
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: fcd4c4531c7f56531fd45acdcf6de2f5bea69055
https://github.com/Perl/perl5/commit/fcd4c4531c7f56531fd45acdcf6de2f5bea69055
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: ffb82abe082e56cb1697918a2bf9cbc200fe11f9
https://github.com/Perl/perl5/commit/ffb82abe082e56cb1697918a2bf9cbc200fe11f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 0d8231f8a9cf1dba067ce115b1e79736b6847cbb
https://github.com/Perl/perl5/commit/0d8231f8a9cf1dba067ce115b1e79736b6847cbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 8a150135349360e5851e768978daa2464c3cc76e
https://github.com/Perl/perl5/commit/8a150135349360e5851e768978daa2464c3cc76e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: c155bd08445973b38fb7e80805d3d0d3e7c539cb
https://github.com/Perl/perl5/commit/c155bd08445973b38fb7e80805d3d0d3e7c539cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 63104fb5191d38b45523a3cf98d4fafa8457581c
https://github.com/Perl/perl5/commit/63104fb5191d38b45523a3cf98d4fafa8457581c
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 8344d4b40cdd2521cbd52fd45196b9132857ea66
https://github.com/Perl/perl5/commit/8344d4b40cdd2521cbd52fd45196b9132857ea66
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 8fd7bc439292d23784ad780dc81886b3aeaf2366
https://github.com/Perl/perl5/commit/8fd7bc439292d23784ad780dc81886b3aeaf2366
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 1332c5ecbd3e2d2abd80e932de0293d9f7781b5f
https://github.com/Perl/perl5/commit/1332c5ecbd3e2d2abd80e932de0293d9f7781b5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 9282bc1c78356182050c160ef6e9a541e5adad5f
https://github.com/Perl/perl5/commit/9282bc1c78356182050c160ef6e9a541e5adad5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 1e3f8b712e555b702b230e0893f1b6870c556c58
https://github.com/Perl/perl5/commit/1e3f8b712e555b702b230e0893f1b6870c556c58
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 1cf23cf2f2c89e2bf46a1af5cfe0aeca7478f07a
https://github.com/Perl/perl5/commit/1cf23cf2f2c89e2bf46a1af5cfe0aeca7478f07a
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 96eb812ab5d6c48270575f10aaaec84f09cdbd40
https://github.com/Perl/perl5/commit/96eb812ab5d6c48270575f10aaaec84f09cdbd40
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 648747b0d6bbab85f45f6764860b8ad5e6561eeb
https://github.com/Perl/perl5/commit/648747b0d6bbab85f45f6764860b8ad5e6561eeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 02a776337622ac1cac84669c1be0264a69aec603
https://github.com/Perl/perl5/commit/02a776337622ac1cac84669c1be0264a69aec603
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: c613e9ac16e6051600706a519b8347fec07e0830
https://github.com/Perl/perl5/commit/c613e9ac16e6051600706a519b8347fec07e0830
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: f275853eba65657f9bb7d3b77252ca70452291b5
https://github.com/Perl/perl5/commit/f275853eba65657f9bb7d3b77252ca70452291b5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 5041b88318c45c08d0242adfc03a3b8536e9668b
https://github.com/Perl/perl5/commit/5041b88318c45c08d0242adfc03a3b8536e9668b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: f66c70208da0c5d28c6ef03b92e8e11c61ebb59b
https://github.com/Perl/perl5/commit/f66c70208da0c5d28c6ef03b92e8e11c61ebb59b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 5dc4f06249df3a6993760f5ad4f03e1e8e180d61
https://github.com/Perl/perl5/commit/5dc4f06249df3a6993760f5ad4f03e1e8e180d61
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 05dd6f61b736d2d88559692771fc02900fa7f8f7
https://github.com/Perl/perl5/commit/05dd6f61b736d2d88559692771fc02900fa7f8f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 67c4b62bc0d90bbcd0e621dd4e11cbed8629ac11
https://github.com/Perl/perl5/commit/67c4b62bc0d90bbcd0e621dd4e11cbed8629ac11
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: a6a97ea5d71a5e4b0dd51963ef1c0f0d9143b1fd
https://github.com/Perl/perl5/commit/a6a97ea5d71a5e4b0dd51963ef1c0f0d9143b1fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: cfb1a0ad081fe00fc781b844453db3bdac1d2f26
https://github.com/Perl/perl5/commit/cfb1a0ad081fe00fc781b844453db3bdac1d2f26
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 03676b37e63f4638213bcb86a3e4aff88e1849e5
https://github.com/Perl/perl5/commit/03676b37e63f4638213bcb86a3e4aff88e1849e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 14e381a56dbe54e89460d667539748ca70faf285
https://github.com/Perl/perl5/commit/14e381a56dbe54e89460d667539748ca70faf285
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: f08ef3ed4ca9ad1845ed482e4da6f89ecc2dd00e
https://github.com/Perl/perl5/commit/f08ef3ed4ca9ad1845ed482e4da6f89ecc2dd00e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 10a165c994982e3f6581b9bb4d6628556eff5f31
https://github.com/Perl/perl5/commit/10a165c994982e3f6581b9bb4d6628556eff5f31
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: e34d944ef5522c09aff732a1b1b912369779f75e
https://github.com/Perl/perl5/commit/e34d944ef5522c09aff732a1b1b912369779f75e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 871eba794deb5f5ef1315e42e3cefa38460d2dea
https://github.com/Perl/perl5/commit/871eba794deb5f5ef1315e42e3cefa38460d2dea
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 109c274e914f8e53631ea0582339fe228b1ac035
https://github.com/Perl/perl5/commit/109c274e914f8e53631ea0582339fe228b1ac035
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 0e086890d336813e5178f60ba8126d2ca0840cb7
https://github.com/Perl/perl5/commit/0e086890d336813e5178f60ba8126d2ca0840cb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: b0c0196fddca480c933c795fed8297efabd5d1e7
https://github.com/Perl/perl5/commit/b0c0196fddca480c933c795fed8297efabd5d1e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 32a36dff3cab83c82ee7d8ccd59387c6437460db
https://github.com/Perl/perl5/commit/32a36dff3cab83c82ee7d8ccd59387c6437460db
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: ee483d90c00ad39b8a78bc19552feae3fd026600
https://github.com/Perl/perl5/commit/ee483d90c00ad39b8a78bc19552feae3fd026600
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 85035023b8dca86f874fc16a2e4a9210940dde3b
https://github.com/Perl/perl5/commit/85035023b8dca86f874fc16a2e4a9210940dde3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: 918b8ad409493509547117b17cd8798f7e52c269
https://github.com/Perl/perl5/commit/918b8ad409493509547117b17cd8798f7e52c269
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 2c97c9a3f9baf5070f9648bd91b492ddd8f5b996
https://github.com/Perl/perl5/commit/2c97c9a3f9baf5070f9648bd91b492ddd8f5b996
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: c7f7908dbebe9e11c3c2c0517c4389114f6d4307
https://github.com/Perl/perl5/commit/c7f7908dbebe9e11c3c2c0517c4389114f6d4307
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 946bdf02e0905e92d88dcee08e9cfeb095bba461
https://github.com/Perl/perl5/commit/946bdf02e0905e92d88dcee08e9cfeb095bba461
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 52de4afadb450e1bc37c37b4bb5d271509824426
https://github.com/Perl/perl5/commit/52de4afadb450e1bc37c37b4bb5d271509824426
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: a0262b41a3e9ddaaf15232e4f85e9b76219c494e
https://github.com/Perl/perl5/commit/a0262b41a3e9ddaaf15232e4f85e9b76219c494e
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 1cc592b1ed704e42ab5821be40393c7ce633da29
https://github.com/Perl/perl5/commit/1cc592b1ed704e42ab5821be40393c7ce633da29
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: c2e478e7759835a531f8a81abd9f3e98248bb0d7
https://github.com/Perl/perl5/commit/c2e478e7759835a531f8a81abd9f3e98248bb0d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: eba9d50ba2afc895ceb266d2b05511c76d782909
https://github.com/Perl/perl5/commit/eba9d50ba2afc895ceb266d2b05511c76d782909
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 47f44f87dc2d4d2fb7063f876f56eecaf800858f
https://github.com/Perl/perl5/commit/47f44f87dc2d4d2fb7063f876f56eecaf800858f
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 35a69a19eaac515a69f664dcfc2348d6ec379bb8
https://github.com/Perl/perl5/commit/35a69a19eaac515a69f664dcfc2348d6ec379bb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 9dd0c971c61b0eeebee76ba30cb21aea71c2212d
https://github.com/Perl/perl5/commit/9dd0c971c61b0eeebee76ba30cb21aea71c2212d
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 72b081510b9020f2137834175ba56c9638fc5194
https://github.com/Perl/perl5/commit/72b081510b9020f2137834175ba56c9638fc5194
Author: Karl Williamson <[email protected]>
Date: 2021-04-21 (Wed, 21 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
38
Compare: https://github.com/Perl/perl5/compare/7c4afd841d31...72b081510b90
