Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 77cfdc1207aafc1dcb11505fe6daa5378829475f
https://github.com/Perl/perl5/commit/77cfdc1207aafc1dcb11505fe6daa5378829475f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 07c1fd04ab84d808da314f05466de83fd35ae9d6
https://github.com/Perl/perl5/commit/07c1fd04ab84d808da314f05466de83fd35ae9d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: c871dfc26f8f27fba710a2f5bd9d61ee312c32ad
https://github.com/Perl/perl5/commit/c871dfc26f8f27fba710a2f5bd9d61ee312c32ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: ab9e0ca4f5d178bcfd955e54646ac6de766cfa52
https://github.com/Perl/perl5/commit/ab9e0ca4f5d178bcfd955e54646ac6de766cfa52
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 8f221d475a940e9a3a0f021b253267c3e34d7d73
https://github.com/Perl/perl5/commit/8f221d475a940e9a3a0f021b253267c3e34d7d73
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 704d2f96cddf53e4e632c0857fb3e17de850c363
https://github.com/Perl/perl5/commit/704d2f96cddf53e4e632c0857fb3e17de850c363
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: ef67c49a61cebef6af3e5293ac02756eba4252e6
https://github.com/Perl/perl5/commit/ef67c49a61cebef6af3e5293ac02756eba4252e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 6a4bc88b445fbfcfae5398fdcb2d3d014bdc4f69
https://github.com/Perl/perl5/commit/6a4bc88b445fbfcfae5398fdcb2d3d014bdc4f69
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 49dcc75d7ae6bc0da84ba0ed53be36a70ffc5eb7
https://github.com/Perl/perl5/commit/49dcc75d7ae6bc0da84ba0ed53be36a70ffc5eb7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 1b033fc3901d7486e86537c986e27bc281e6ba2f
https://github.com/Perl/perl5/commit/1b033fc3901d7486e86537c986e27bc281e6ba2f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: d6ddc952c670795f0821a11b3796eb76a13bc2a7
https://github.com/Perl/perl5/commit/d6ddc952c670795f0821a11b3796eb76a13bc2a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: cff878a370c6b95355cfbc521e4295bd48201228
https://github.com/Perl/perl5/commit/cff878a370c6b95355cfbc521e4295bd48201228
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: da79413bcb84e5f77d01ccd84635554ba387f16a
https://github.com/Perl/perl5/commit/da79413bcb84e5f77d01ccd84635554ba387f16a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 97402489df16074ca492f546090728027d04b108
https://github.com/Perl/perl5/commit/97402489df16074ca492f546090728027d04b108
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 1f71afa6433a5607ff2a8195babf7751bf29e916
https://github.com/Perl/perl5/commit/1f71afa6433a5607ff2a8195babf7751bf29e916
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: f0946d5ebeeeabad301c37dcaf3d7ff12b74632c
https://github.com/Perl/perl5/commit/f0946d5ebeeeabad301c37dcaf3d7ff12b74632c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: b741aa497209ca7d461dc4776236d248d4c83bad
https://github.com/Perl/perl5/commit/b741aa497209ca7d461dc4776236d248d4c83bad
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 35be536057e7826814d0d80b24414868015a35b8
https://github.com/Perl/perl5/commit/35be536057e7826814d0d80b24414868015a35b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 0bb16974e57026b88d6bf74484da10ad6f92abf1
https://github.com/Perl/perl5/commit/0bb16974e57026b88d6bf74484da10ad6f92abf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 3b36988b0a5304d23347e238e45ca21ee545cef4
https://github.com/Perl/perl5/commit/3b36988b0a5304d23347e238e45ca21ee545cef4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 9bb71c6a0bd1f39d97a1302d9c329815fe212036
https://github.com/Perl/perl5/commit/9bb71c6a0bd1f39d97a1302d9c329815fe212036
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 180e508e48d7db95dc4d4bffbb8055c01606ec48
https://github.com/Perl/perl5/commit/180e508e48d7db95dc4d4bffbb8055c01606ec48
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 4ad183ee23990dea4f2da847ac52aefc84e6237e
https://github.com/Perl/perl5/commit/4ad183ee23990dea4f2da847ac52aefc84e6237e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 627cdb5a5554d0632788c08ad77fd6f7a9c63a0a
https://github.com/Perl/perl5/commit/627cdb5a5554d0632788c08ad77fd6f7a9c63a0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: d59d73473bfe92b0e37bba49a6eef7a44801284b
https://github.com/Perl/perl5/commit/d59d73473bfe92b0e37bba49a6eef7a44801284b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 6da364cfca5162a1e263573ba0d8f87d6564b371
https://github.com/Perl/perl5/commit/6da364cfca5162a1e263573ba0d8f87d6564b371
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: c690af0c73f9a1344cc3a462d2b33f225b5a42f2
https://github.com/Perl/perl5/commit/c690af0c73f9a1344cc3a462d2b33f225b5a42f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 0b8064c19a57d068ab8957e25a2dcece7bfb5272
https://github.com/Perl/perl5/commit/0b8064c19a57d068ab8957e25a2dcece7bfb5272
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 02b2035437dca5b797eb3df6fff26796420078cf
https://github.com/Perl/perl5/commit/02b2035437dca5b797eb3df6fff26796420078cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 93a273140e7e11e97702177b6b9bc600dd2e55c3
https://github.com/Perl/perl5/commit/93a273140e7e11e97702177b6b9bc600dd2e55c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 5ec1531cb05639f2509596ccccff7580dc55bdda
https://github.com/Perl/perl5/commit/5ec1531cb05639f2509596ccccff7580dc55bdda
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 368038849f1a46505012df62fbe20f126ba3a146
https://github.com/Perl/perl5/commit/368038849f1a46505012df62fbe20f126ba3a146
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 16b57963fae3606c24fc7595de160f95ef9fb180
https://github.com/Perl/perl5/commit/16b57963fae3606c24fc7595de160f95ef9fb180
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 3e8fb81c7d4d3fe690fb8c16b90ac0f0e2a48737
https://github.com/Perl/perl5/commit/3e8fb81c7d4d3fe690fb8c16b90ac0f0e2a48737
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 685f6dde8868a50c82be49662ef48823a5d44004
https://github.com/Perl/perl5/commit/685f6dde8868a50c82be49662ef48823a5d44004
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: eb351511f95792e9d6076504f2a8971a3be35038
https://github.com/Perl/perl5/commit/eb351511f95792e9d6076504f2a8971a3be35038
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 59644fbf7aed20689baa78a73bafce39209d69d5
https://github.com/Perl/perl5/commit/59644fbf7aed20689baa78a73bafce39209d69d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 4f2da9d488ed2dd4589307ba2e0df4223f3408c6
https://github.com/Perl/perl5/commit/4f2da9d488ed2dd4589307ba2e0df4223f3408c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 6953b53ba7ec6ba63529afd105d76590fc9ae7f6
https://github.com/Perl/perl5/commit/6953b53ba7ec6ba63529afd105d76590fc9ae7f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 929fefd29f6657a2345aaea681299d2e473d66c8
https://github.com/Perl/perl5/commit/929fefd29f6657a2345aaea681299d2e473d66c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 2f018e0eca64f8be5cb65f59bebffdc18581bc45
https://github.com/Perl/perl5/commit/2f018e0eca64f8be5cb65f59bebffdc18581bc45
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: c09a7f115e6d4da4d13e0af7eb54df1bec9a536f
https://github.com/Perl/perl5/commit/c09a7f115e6d4da4d13e0af7eb54df1bec9a536f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 43a642e7f519a18dc09929e99853cca100841c96
https://github.com/Perl/perl5/commit/43a642e7f519a18dc09929e99853cca100841c96
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: cac1709b4e579b0ac074079e65416fc091a9e351
https://github.com/Perl/perl5/commit/cac1709b4e579b0ac074079e65416fc091a9e351
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: c9170e40890e30fb4ea66724d40dcc630c8510bf
https://github.com/Perl/perl5/commit/c9170e40890e30fb4ea66724d40dcc630c8510bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 5a83c41b8104112a7743ef329a29b5e786e6efef
https://github.com/Perl/perl5/commit/5a83c41b8104112a7743ef329a29b5e786e6efef
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: a16584f82df3173d3971eae47a8d841eeeb4eeec
https://github.com/Perl/perl5/commit/a16584f82df3173d3971eae47a8d841eeeb4eeec
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 7b0bb44740cff395d8910f6348d304dda4af6800
https://github.com/Perl/perl5/commit/7b0bb44740cff395d8910f6348d304dda4af6800
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 51976ab0bff0635484c22460ad0b044ea4412734
https://github.com/Perl/perl5/commit/51976ab0bff0635484c22460ad0b044ea4412734
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: e0dea659292e226f8ec5ee87e5f9796c93864f46
https://github.com/Perl/perl5/commit/e0dea659292e226f8ec5ee87e5f9796c93864f46
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: f7724e31564ef66be47a06aa59ae12a40a3466ad
https://github.com/Perl/perl5/commit/f7724e31564ef66be47a06aa59ae12a40a3466ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 89e3c03031dc7dd884a1e122f713c91e0d714d31
https://github.com/Perl/perl5/commit/89e3c03031dc7dd884a1e122f713c91e0d714d31
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 0ba041307a427ab5faf8f784fa65caf69d6c7b85
https://github.com/Perl/perl5/commit/0ba041307a427ab5faf8f784fa65caf69d6c7b85
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: d24d663de74cac268bbf3b874371a94984eb2571
https://github.com/Perl/perl5/commit/d24d663de74cac268bbf3b874371a94984eb2571
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 9f6b2de4efc648d171600363ea7de57552b1f076
https://github.com/Perl/perl5/commit/9f6b2de4efc648d171600363ea7de57552b1f076
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 4f63e84d36fd4d7bdd313a27494bec892ec6f4cd
https://github.com/Perl/perl5/commit/4f63e84d36fd4d7bdd313a27494bec892ec6f4cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: c19dd886097221f2392c4919fc105b08da6c9047
https://github.com/Perl/perl5/commit/c19dd886097221f2392c4919fc105b08da6c9047
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: a6b164caf7376f3dd33c906905f8300ab9c604ac
https://github.com/Perl/perl5/commit/a6b164caf7376f3dd33c906905f8300ab9c604ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: ffb92317002430c73c890118b8d8522b203cec36
https://github.com/Perl/perl5/commit/ffb92317002430c73c890118b8d8522b203cec36
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 6dc4949f47a94b17b4f27bacfae4b3e5f8879aaf
https://github.com/Perl/perl5/commit/6dc4949f47a94b17b4f27bacfae4b3e5f8879aaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 2a3e3d309cbee1dcedefb30b11b1f4ddfbdd39c6
https://github.com/Perl/perl5/commit/2a3e3d309cbee1dcedefb30b11b1f4ddfbdd39c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 90753cd127deeb28fce6bca00836a9f2398707e9
https://github.com/Perl/perl5/commit/90753cd127deeb28fce6bca00836a9f2398707e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: fb40a63bacfd6a00e7a313c2b4e7847a43a96718
https://github.com/Perl/perl5/commit/fb40a63bacfd6a00e7a313c2b4e7847a43a96718
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 6c9f917e42caf28a424c07f3407a26812df91d48
https://github.com/Perl/perl5/commit/6c9f917e42caf28a424c07f3407a26812df91d48
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: a5b3de7be1963cdabad62839995ca73b0f448f43
https://github.com/Perl/perl5/commit/a5b3de7be1963cdabad62839995ca73b0f448f43
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: a518cae7d336f33e184b2df4caa3703c77ffb4d7
https://github.com/Perl/perl5/commit/a518cae7d336f33e184b2df4caa3703c77ffb4d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 247722a04b8cbc4ff794050627546bc3731f8b56
https://github.com/Perl/perl5/commit/247722a04b8cbc4ff794050627546bc3731f8b56
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 39c945cacabb43252917d080cf16af704c1dc42e
https://github.com/Perl/perl5/commit/39c945cacabb43252917d080cf16af704c1dc42e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 1d2ae496fad6a6a61d789557b6c7d3fcdb444545
https://github.com/Perl/perl5/commit/1d2ae496fad6a6a61d789557b6c7d3fcdb444545
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: c4a3355963ff13e2e1e28794dc81e9d513035d27
https://github.com/Perl/perl5/commit/c4a3355963ff13e2e1e28794dc81e9d513035d27
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: cf79e4c135e505b8fb09feb96c985e09a1c00302
https://github.com/Perl/perl5/commit/cf79e4c135e505b8fb09feb96c985e09a1c00302
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 12e744fa6e564206198c39eccd2771e213d35e5e
https://github.com/Perl/perl5/commit/12e744fa6e564206198c39eccd2771e213d35e5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: fbce4b5b06ea005f6b4b630eb858e20720882993
https://github.com/Perl/perl5/commit/fbce4b5b06ea005f6b4b630eb858e20720882993
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 27d45cbe536cebbae0c5a8e1bb43422bcb3b8006
https://github.com/Perl/perl5/commit/27d45cbe536cebbae0c5a8e1bb43422bcb3b8006
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 02f34404c6d9dca5f5d4cd0b2571e75aecdb1b61
https://github.com/Perl/perl5/commit/02f34404c6d9dca5f5d4cd0b2571e75aecdb1b61
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: c27847b0b3768dd7c5ce7102e3ea54364f7e4a04
https://github.com/Perl/perl5/commit/c27847b0b3768dd7c5ce7102e3ea54364f7e4a04
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 2fb20f1a9feef99ba66219157aec64c37a1277ef
https://github.com/Perl/perl5/commit/2fb20f1a9feef99ba66219157aec64c37a1277ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 709882836700dd9cb84b55e547c5511948ada1d2
https://github.com/Perl/perl5/commit/709882836700dd9cb84b55e547c5511948ada1d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 995fb54b5da986bfe50dc2ce2b2d082c990fc85d
https://github.com/Perl/perl5/commit/995fb54b5da986bfe50dc2ce2b2d082c990fc85d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: d215d49bd80c49eafa6c2fdee732aef09d1df6a4
https://github.com/Perl/perl5/commit/d215d49bd80c49eafa6c2fdee732aef09d1df6a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 9ef56ae648a1adddbdf9d0a73a9553809cc3495b
https://github.com/Perl/perl5/commit/9ef56ae648a1adddbdf9d0a73a9553809cc3495b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 2447f15460f0bc10223d4bb401c4e801b3dab335
https://github.com/Perl/perl5/commit/2447f15460f0bc10223d4bb401c4e801b3dab335
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 74d9e5fed1929580dba927b280f393965744900e
https://github.com/Perl/perl5/commit/74d9e5fed1929580dba927b280f393965744900e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: ac062018cf8c704e14679d403270cc61320779bc
https://github.com/Perl/perl5/commit/ac062018cf8c704e14679d403270cc61320779bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 6912190741ec21c54437ed2884ab2363caaa1a6b
https://github.com/Perl/perl5/commit/6912190741ec21c54437ed2884ab2363caaa1a6b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: aa8e417379786e4af2f34f08dd14f4c3c4267aa7
https://github.com/Perl/perl5/commit/aa8e417379786e4af2f34f08dd14f4c3c4267aa7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: eb84a5d06e556c84b8dc3db4d71793c43e763569
https://github.com/Perl/perl5/commit/eb84a5d06e556c84b8dc3db4d71793c43e763569
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: ce7930a8f85b78f3f3011ef157d950f5c20fbbe1
https://github.com/Perl/perl5/commit/ce7930a8f85b78f3f3011ef157d950f5c20fbbe1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 650d0205590bc13eaa03e2f22a225ec264b6c20d
https://github.com/Perl/perl5/commit/650d0205590bc13eaa03e2f22a225ec264b6c20d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 0c979c83dcbf7236af6dbd515124b8e3b9a636d5
https://github.com/Perl/perl5/commit/0c979c83dcbf7236af6dbd515124b8e3b9a636d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 7858e9220761c222e3253a8212add9f8f27a1b80
https://github.com/Perl/perl5/commit/7858e9220761c222e3253a8212add9f8f27a1b80
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 0eade67ca8ee701787afd197021e964b71a9b22e
https://github.com/Perl/perl5/commit/0eade67ca8ee701787afd197021e964b71a9b22e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: bcf8077c13243601f58e027200b2491be5e86040
https://github.com/Perl/perl5/commit/bcf8077c13243601f58e027200b2491be5e86040
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: dbafbe2e6d6c9bba5c401b622dc0afb525fceab7
https://github.com/Perl/perl5/commit/dbafbe2e6d6c9bba5c401b622dc0afb525fceab7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: a1ff8a5e4cd496d2df508610afa3a5adbbad2f12
https://github.com/Perl/perl5/commit/a1ff8a5e4cd496d2df508610afa3a5adbbad2f12
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 6b38f3323c56f6d82958a7af48480f2a9ae89ba1
https://github.com/Perl/perl5/commit/6b38f3323c56f6d82958a7af48480f2a9ae89ba1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: cbee883859cbaec003b0747f34058fe3c61f4717
https://github.com/Perl/perl5/commit/cbee883859cbaec003b0747f34058fe3c61f4717
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 0247d0c4e0564bcbc3bdd199b40a4b9301f3314d
https://github.com/Perl/perl5/commit/0247d0c4e0564bcbc3bdd199b40a4b9301f3314d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: bd7ea80603c17620506bc3d48a731d23083f5bd2
https://github.com/Perl/perl5/commit/bd7ea80603c17620506bc3d48a731d23083f5bd2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 313671c71f8965be4bed2c6a9e9d89b0b3816749
https://github.com/Perl/perl5/commit/313671c71f8965be4bed2c6a9e9d89b0b3816749
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: 7b5db38763d01710a3fb2d56de3151e41a90efbb
https://github.com/Perl/perl5/commit/7b5db38763d01710a3fb2d56de3151e41a90efbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: d9aa742fc7bb9262640d4bc423656fbd86ff9722
https://github.com/Perl/perl5/commit/d9aa742fc7bb9262640d4bc423656fbd86ff9722
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 57190aa16aaf20255504b5c6ac5c8d00722e6bf1
https://github.com/Perl/perl5/commit/57190aa16aaf20255504b5c6ac5c8d00722e6bf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 5aa3525713fb71ec7681a67e0936406706098f53
https://github.com/Perl/perl5/commit/5aa3525713fb71ec7681a67e0936406706098f53
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 2e9f5e35f8bf27305f8a0c3841ce592af2cc2541
https://github.com/Perl/perl5/commit/2e9f5e35f8bf27305f8a0c3841ce592af2cc2541
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: e2707cb4a2f8ea89bd1825dd604f5715b245189f
https://github.com/Perl/perl5/commit/e2707cb4a2f8ea89bd1825dd604f5715b245189f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: f4d7a9a113a37bea907306e65714a2da7ca5ec47
https://github.com/Perl/perl5/commit/f4d7a9a113a37bea907306e65714a2da7ca5ec47
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: ca0a780003831a4b3cba1baa5a109e3c2045c768
https://github.com/Perl/perl5/commit/ca0a780003831a4b3cba1baa5a109e3c2045c768
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 6c408cabcab6aa52156381379147e1c503a05086
https://github.com/Perl/perl5/commit/6c408cabcab6aa52156381379147e1c503a05086
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 3665db6c687811e04f4d98c5b7dfb0899ab327a6
https://github.com/Perl/perl5/commit/3665db6c687811e04f4d98c5b7dfb0899ab327a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: e79ae9a03ac31f6996fd80f935fa9329ab801405
https://github.com/Perl/perl5/commit/e79ae9a03ac31f6996fd80f935fa9329ab801405
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: fffc0cd9717a0139d926eb78dd4c3ef42b4d7367
https://github.com/Perl/perl5/commit/fffc0cd9717a0139d926eb78dd4c3ef42b4d7367
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 28876dbe7c587d29aa3656d0649445fc08c3ae68
https://github.com/Perl/perl5/commit/28876dbe7c587d29aa3656d0649445fc08c3ae68
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 0674be906fd1d0775962d2758ca124b9d4f2baac
https://github.com/Perl/perl5/commit/0674be906fd1d0775962d2758ca124b9d4f2baac
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: a15b3183fa8c7e74809c64f616f5c0254c2795ac
https://github.com/Perl/perl5/commit/a15b3183fa8c7e74809c64f616f5c0254c2795ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: aa4b75d9309b12e2be8145363aa69d07b1ef1e13
https://github.com/Perl/perl5/commit/aa4b75d9309b12e2be8145363aa69d07b1ef1e13
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 974d6b27452622c3f9d535370e71eeb491c36ede
https://github.com/Perl/perl5/commit/974d6b27452622c3f9d535370e71eeb491c36ede
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 771b7cfe63281b18e1b076ec399dd84648cd5d89
https://github.com/Perl/perl5/commit/771b7cfe63281b18e1b076ec399dd84648cd5d89
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 85e2b0b99d763ba82f3651586e20a8bd26ce94ad
https://github.com/Perl/perl5/commit/85e2b0b99d763ba82f3651586e20a8bd26ce94ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: e076cfdf8e87243eda74188f7c4c1314269f9a93
https://github.com/Perl/perl5/commit/e076cfdf8e87243eda74188f7c4c1314269f9a93
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 3cf446129b4b8540aabd3bca54aa2fcd4479fac3
https://github.com/Perl/perl5/commit/3cf446129b4b8540aabd3bca54aa2fcd4479fac3
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: a6f203ac8981aac45f9c025652f9f161184fe7d1
https://github.com/Perl/perl5/commit/a6f203ac8981aac45f9c025652f9f161184fe7d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: e665b256096cb71b200e4a94469f09bf17d5058b
https://github.com/Perl/perl5/commit/e665b256096cb71b200e4a94469f09bf17d5058b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: f8ec703e68ac43d161f0e534f224c3f083867fbd
https://github.com/Perl/perl5/commit/f8ec703e68ac43d161f0e534f224c3f083867fbd
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 90ff996c61b0bc3812b51a412748be6b47dba7ab
https://github.com/Perl/perl5/commit/90ff996c61b0bc3812b51a412748be6b47dba7ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 92bfef868ce56f54a4f3755ecadbd833e3b42699
https://github.com/Perl/perl5/commit/92bfef868ce56f54a4f3755ecadbd833e3b42699
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: 2de3c8b3d7b8d69450996cad764c304e4c403cfb
https://github.com/Perl/perl5/commit/2de3c8b3d7b8d69450996cad764c304e4c403cfb
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: ac8fd450610f1b8e62009ffbbde09930997beb0e
https://github.com/Perl/perl5/commit/ac8fd450610f1b8e62009ffbbde09930997beb0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 89a1f1dfbf0f70096b2c52a9f2b8fdd402cd6040
https://github.com/Perl/perl5/commit/89a1f1dfbf0f70096b2c52a9f2b8fdd402cd6040
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: c828da540e6e0790821f236e6878fe48b7b6aa49
https://github.com/Perl/perl5/commit/c828da540e6e0790821f236e6878fe48b7b6aa49
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: 162a56aebd982832406aa9957fb2e8957f12f73d
https://github.com/Perl/perl5/commit/162a56aebd982832406aa9957fb2e8957f12f73d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 48583ce4151c42eaf2fb38acdeff8aa6114022f8
https://github.com/Perl/perl5/commit/48583ce4151c42eaf2fb38acdeff8aa6114022f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 41ffe79bb9f0968cb2dc0bebf03c11ac7bdd61f3
https://github.com/Perl/perl5/commit/41ffe79bb9f0968cb2dc0bebf03c11ac7bdd61f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 80f57778cad7d47665ab7a76631c205cf4cfd68c
https://github.com/Perl/perl5/commit/80f57778cad7d47665ab7a76631c205cf4cfd68c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: 80af4dcfd09075c7102a0e1ffdcb0b6a255cbc66
https://github.com/Perl/perl5/commit/80af4dcfd09075c7102a0e1ffdcb0b6a255cbc66
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 1473796133023acb2607a4a77630e6b9d3174f63
https://github.com/Perl/perl5/commit/1473796133023acb2607a4a77630e6b9d3174f63
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: c393d608de4a36e8b86bf8f59d7fee26bc06c687
https://github.com/Perl/perl5/commit/c393d608de4a36e8b86bf8f59d7fee26bc06c687
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: a4b01ff25f240152b78e8da9198ab7add0cc796f
https://github.com/Perl/perl5/commit/a4b01ff25f240152b78e8da9198ab7add0cc796f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: f994f9857fe6dabeef25858e4a76283bd500213d
https://github.com/Perl/perl5/commit/f994f9857fe6dabeef25858e4a76283bd500213d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: d5a1e11696ced8cf5b37036455152278d61d97b0
https://github.com/Perl/perl5/commit/d5a1e11696ced8cf5b37036455152278d61d97b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 246b14b5bab213c2137256ddf5a0e3aa0e0e1231
https://github.com/Perl/perl5/commit/246b14b5bab213c2137256ddf5a0e3aa0e0e1231
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: a597929d22ab5dcebdb4f7f0bebde6e7062cd813
https://github.com/Perl/perl5/commit/a597929d22ab5dcebdb4f7f0bebde6e7062cd813
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: e98718e8f79866ba69248d3035234c3e85b655cf
https://github.com/Perl/perl5/commit/e98718e8f79866ba69248d3035234c3e85b655cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: e0e619d5e4aff673de3b2d0b7fbb437afa536952
https://github.com/Perl/perl5/commit/e0e619d5e4aff673de3b2d0b7fbb437afa536952
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: b79b6acecb3c766e44d527a508feba8e766e091b
https://github.com/Perl/perl5/commit/b79b6acecb3c766e44d527a508feba8e766e091b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 1b634203172a7486db96bab23e79725cfa87303a
https://github.com/Perl/perl5/commit/1b634203172a7486db96bab23e79725cfa87303a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: c9a0c29515214d76d2fa11f7e07ff3a47fb2d12f
https://github.com/Perl/perl5/commit/c9a0c29515214d76d2fa11f7e07ff3a47fb2d12f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 74407a1a925d82d9599b384e9b19fd5c395e456b
https://github.com/Perl/perl5/commit/74407a1a925d82d9599b384e9b19fd5c395e456b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 9d70cc09edfdbfde8c64e7337a36cedd570219c2
https://github.com/Perl/perl5/commit/9d70cc09edfdbfde8c64e7337a36cedd570219c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 3e872324d319864f89ebf40b280f7eedc1733cff
https://github.com/Perl/perl5/commit/3e872324d319864f89ebf40b280f7eedc1733cff
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 2595e2739e05f41047c4280b89792de7f0bc93d2
https://github.com/Perl/perl5/commit/2595e2739e05f41047c4280b89792de7f0bc93d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 47a8a77e0e8950440cd22c100f1325bef7547f23
https://github.com/Perl/perl5/commit/47a8a77e0e8950440cd22c100f1325bef7547f23
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 6378a09cad09f976aa0d9474ce168ae01c1ab7b0
https://github.com/Perl/perl5/commit/6378a09cad09f976aa0d9474ce168ae01c1ab7b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 799daf6dc4aaebd67be682453886bdd243539bb0
https://github.com/Perl/perl5/commit/799daf6dc4aaebd67be682453886bdd243539bb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: bd13af40d71faad5fd00162e960a2560389a47d0
https://github.com/Perl/perl5/commit/bd13af40d71faad5fd00162e960a2560389a47d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 06d76913a727feed67367b6d7ac966ec8c16359c
https://github.com/Perl/perl5/commit/06d76913a727feed67367b6d7ac966ec8c16359c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: af119af01bb24ec68dd1f3c3601da3dd9d8df65e
https://github.com/Perl/perl5/commit/af119af01bb24ec68dd1f3c3601da3dd9d8df65e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: acef36f6d587dd3af9658623acc1cd537ea13741
https://github.com/Perl/perl5/commit/acef36f6d587dd3af9658623acc1cd537ea13741
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 317ba849b2c53185913e63c2d27a43f7d40ec6ca
https://github.com/Perl/perl5/commit/317ba849b2c53185913e63c2d27a43f7d40ec6ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 4761d8df017ebb77cd4d2f55faffe8bb97b61eba
https://github.com/Perl/perl5/commit/4761d8df017ebb77cd4d2f55faffe8bb97b61eba
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 43630f669d3ea0839c5f4f1322cc3aad165d798c
https://github.com/Perl/perl5/commit/43630f669d3ea0839c5f4f1322cc3aad165d798c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 098d3886212a5107302cbf9b30638cd6101c11c9
https://github.com/Perl/perl5/commit/098d3886212a5107302cbf9b30638cd6101c11c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 4322fb0feeaf1ed59743924d4e00f08426dc95ba
https://github.com/Perl/perl5/commit/4322fb0feeaf1ed59743924d4e00f08426dc95ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: a86c5070ae8aad402e37a4fafd8535485c42564d
https://github.com/Perl/perl5/commit/a86c5070ae8aad402e37a4fafd8535485c42564d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: f99117d66972dab07b1e161161a1900baa53936b
https://github.com/Perl/perl5/commit/f99117d66972dab07b1e161161a1900baa53936b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 191b5372df20314fb470ab64698cf0831900e309
https://github.com/Perl/perl5/commit/191b5372df20314fb470ab64698cf0831900e309
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 3a2f47fa77ca9f6fab9df1f0d46b1f65746c59aa
https://github.com/Perl/perl5/commit/3a2f47fa77ca9f6fab9df1f0d46b1f65746c59aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: bb99f2015a7a563f464ecdb08812a24566c62084
https://github.com/Perl/perl5/commit/bb99f2015a7a563f464ecdb08812a24566c62084
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 3740a974da8e59d819950b7595f245cc0f56f138
https://github.com/Perl/perl5/commit/3740a974da8e59d819950b7595f245cc0f56f138
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 18eea7c4f6b3dcd8dd3314abaf940eafe34bed06
https://github.com/Perl/perl5/commit/18eea7c4f6b3dcd8dd3314abaf940eafe34bed06
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: b3ef6b5c210d43690c4d1521eebb8cf12e4c7478
https://github.com/Perl/perl5/commit/b3ef6b5c210d43690c4d1521eebb8cf12e4c7478
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 405cc5c919bf04f53224bc4be891faa1f4938c32
https://github.com/Perl/perl5/commit/405cc5c919bf04f53224bc4be891faa1f4938c32
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 04253a4bf246deb850c2424331e323ef7338eb67
https://github.com/Perl/perl5/commit/04253a4bf246deb850c2424331e323ef7338eb67
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 0b1947bfc78c759b7b146809f31ddea35f561e5c
https://github.com/Perl/perl5/commit/0b1947bfc78c759b7b146809f31ddea35f561e5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 7b602776080be15f0c6a93cb1c49766571e4ae82
https://github.com/Perl/perl5/commit/7b602776080be15f0c6a93cb1c49766571e4ae82
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 94553e57110f4b3972eeebe30f5a62e459d86f97
https://github.com/Perl/perl5/commit/94553e57110f4b3972eeebe30f5a62e459d86f97
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: c301e34b5ef47d22bf207286a3d9e7acd592a333
https://github.com/Perl/perl5/commit/c301e34b5ef47d22bf207286a3d9e7acd592a333
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 10bf7fc41e1aa588f77a4366aad3b0251fe628a9
https://github.com/Perl/perl5/commit/10bf7fc41e1aa588f77a4366aad3b0251fe628a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: e5bb9fdaa3cead2bd82dfa1d4bc28527fe84df87
https://github.com/Perl/perl5/commit/e5bb9fdaa3cead2bd82dfa1d4bc28527fe84df87
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: eb1e88cb3dc0fe35f8d2eb2b4f6ec3aa0a354666
https://github.com/Perl/perl5/commit/eb1e88cb3dc0fe35f8d2eb2b4f6ec3aa0a354666
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: e8036aed0fa9a51d47f919a8867314eaa1dc277e
https://github.com/Perl/perl5/commit/e8036aed0fa9a51d47f919a8867314eaa1dc277e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 480e651524ec2f389a80f448646f9185e837fdd3
https://github.com/Perl/perl5/commit/480e651524ec2f389a80f448646f9185e837fdd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 30a687da488d40dd03235af7e9aad4ed6e548f64
https://github.com/Perl/perl5/commit/30a687da488d40dd03235af7e9aad4ed6e548f64
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: ca6e21fe79ddee71148fbb6fe1216c50ff08c0ca
https://github.com/Perl/perl5/commit/ca6e21fe79ddee71148fbb6fe1216c50ff08c0ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 1fec3d1e7de87d183484230ff37204d6a21c9ffb
https://github.com/Perl/perl5/commit/1fec3d1e7de87d183484230ff37204d6a21c9ffb
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 0211359b8e69cdbfbec8ebe7707fffd27225c9b6
https://github.com/Perl/perl5/commit/0211359b8e69cdbfbec8ebe7707fffd27225c9b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 8c9eca8c9489db2aecf6282f638f0ba752132436
https://github.com/Perl/perl5/commit/8c9eca8c9489db2aecf6282f638f0ba752132436
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 26b54dee3b64bf9f1c4f39a6bcabcd393959aca7
https://github.com/Perl/perl5/commit/26b54dee3b64bf9f1c4f39a6bcabcd393959aca7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 55847e6ee17c34e3956567b7780962624b11121f
https://github.com/Perl/perl5/commit/55847e6ee17c34e3956567b7780962624b11121f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 3c11a734fe76d4fd3367b0049c9860d083be6126
https://github.com/Perl/perl5/commit/3c11a734fe76d4fd3367b0049c9860d083be6126
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: eaaeca1f0afcb10e1151b92c2ccb06635689e919
https://github.com/Perl/perl5/commit/eaaeca1f0afcb10e1151b92c2ccb06635689e919
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 4bd69e83b87d9b3e32a747b86e1d993be73930cf
https://github.com/Perl/perl5/commit/4bd69e83b87d9b3e32a747b86e1d993be73930cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: b47d437fdddb99afb8d797b278ff9dd1781d5cf2
https://github.com/Perl/perl5/commit/b47d437fdddb99afb8d797b278ff9dd1781d5cf2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 0708a9581c9ee619d283cd7a839f675396ec568a
https://github.com/Perl/perl5/commit/0708a9581c9ee619d283cd7a839f675396ec568a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: abba56b4837dd3cb1f8397fc5391446cf771dd5d
https://github.com/Perl/perl5/commit/abba56b4837dd3cb1f8397fc5391446cf771dd5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: eea239421a63a4461251fe03690ed95d48c6bd69
https://github.com/Perl/perl5/commit/eea239421a63a4461251fe03690ed95d48c6bd69
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 1a96f7322ae6555d72a1f264f8cacfadc0f9606b
https://github.com/Perl/perl5/commit/1a96f7322ae6555d72a1f264f8cacfadc0f9606b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: dd7a97aab4d10b9639122da1fb279a58300d2a8d
https://github.com/Perl/perl5/commit/dd7a97aab4d10b9639122da1fb279a58300d2a8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 58b07f043bbfeec356e9e32a2af72058a142cd3a
https://github.com/Perl/perl5/commit/58b07f043bbfeec356e9e32a2af72058a142cd3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: d5d518fb8901628dd9177ff817e683865aa5cc4e
https://github.com/Perl/perl5/commit/d5d518fb8901628dd9177ff817e683865aa5cc4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: f3c51e651605bbad55af31796b8e1ff861c6edda
https://github.com/Perl/perl5/commit/f3c51e651605bbad55af31796b8e1ff861c6edda
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 1529a49605ffc442db8cd3cd5b09e2e655422426
https://github.com/Perl/perl5/commit/1529a49605ffc442db8cd3cd5b09e2e655422426
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 0446b892eb3a829a6e9625ce9eab3581324fcab4
https://github.com/Perl/perl5/commit/0446b892eb3a829a6e9625ce9eab3581324fcab4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 539746b40e9eb22d22ec059d560bfbbaebedfab6
https://github.com/Perl/perl5/commit/539746b40e9eb22d22ec059d560bfbbaebedfab6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 27b89b142364313acb802b5128e09b0476d16e30
https://github.com/Perl/perl5/commit/27b89b142364313acb802b5128e09b0476d16e30
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 0da794a0628e3e3e4d244502f5b0ec758d9ba75e
https://github.com/Perl/perl5/commit/0da794a0628e3e3e4d244502f5b0ec758d9ba75e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 01e8bf1107ac490f5a4a37370b2c9039243d75ba
https://github.com/Perl/perl5/commit/01e8bf1107ac490f5a4a37370b2c9039243d75ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 2025efdecdfec60b91f201793422a75f7a5525f0
https://github.com/Perl/perl5/commit/2025efdecdfec60b91f201793422a75f7a5525f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 6700ace6d6356f3ac8061c2e9fbf684206e7b230
https://github.com/Perl/perl5/commit/6700ace6d6356f3ac8061c2e9fbf684206e7b230
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 0acd71f1356759d310ec2389cb5dcfc97dfc1991
https://github.com/Perl/perl5/commit/0acd71f1356759d310ec2389cb5dcfc97dfc1991
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 6740c07c1d244707eaa6b3c2af26bd16883056dc
https://github.com/Perl/perl5/commit/6740c07c1d244707eaa6b3c2af26bd16883056dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 762fa1dccb4fb4b71a9d221b872a7e8261141ed0
https://github.com/Perl/perl5/commit/762fa1dccb4fb4b71a9d221b872a7e8261141ed0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 19f52c9ca3837aee0276586501b9ac69d071f004
https://github.com/Perl/perl5/commit/19f52c9ca3837aee0276586501b9ac69d071f004
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 9ed09dcc29fc7984a0d68cf17e003bb8d211c524
https://github.com/Perl/perl5/commit/9ed09dcc29fc7984a0d68cf17e003bb8d211c524
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 317e824d4b7716ba75ad333d0f8de4e02a882a7c
https://github.com/Perl/perl5/commit/317e824d4b7716ba75ad333d0f8de4e02a882a7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 5860e80a3fb80fc3f63ee1f77d6adf1634647b11
https://github.com/Perl/perl5/commit/5860e80a3fb80fc3f63ee1f77d6adf1634647b11
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: d2289e131bfd0eeabf60565fdf69f29c168c9183
https://github.com/Perl/perl5/commit/d2289e131bfd0eeabf60565fdf69f29c168c9183
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 577f6f4c300abee577a58e145c67a4cd884e5678
https://github.com/Perl/perl5/commit/577f6f4c300abee577a58e145c67a4cd884e5678
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: b1624b7ffdf1015b2306d6c6c61c99c2c9f4183a
https://github.com/Perl/perl5/commit/b1624b7ffdf1015b2306d6c6c61c99c2c9f4183a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 4bdd1fb8bb927f62b0f7424dfb24075b1e3eda2c
https://github.com/Perl/perl5/commit/4bdd1fb8bb927f62b0f7424dfb24075b1e3eda2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 184b38e16425157d40011809fd52c782051bd4a4
https://github.com/Perl/perl5/commit/184b38e16425157d40011809fd52c782051bd4a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 221c64f47f9df78167b2fefdaa4b3f3c524f00f5
https://github.com/Perl/perl5/commit/221c64f47f9df78167b2fefdaa4b3f3c524f00f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: e9f82295816e1220f60180b9004f762f2030cde0
https://github.com/Perl/perl5/commit/e9f82295816e1220f60180b9004f762f2030cde0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 13965ee89e49bf710121038331a1bfecc05f5d4c
https://github.com/Perl/perl5/commit/13965ee89e49bf710121038331a1bfecc05f5d4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: 21788665dc4fa7ead7baf54e27ebd2e7a3e352bc
https://github.com/Perl/perl5/commit/21788665dc4fa7ead7baf54e27ebd2e7a3e352bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 0c819a5e1b0eb14b89097e138a4cfd84ce6a953c
https://github.com/Perl/perl5/commit/0c819a5e1b0eb14b89097e138a4cfd84ce6a953c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 3232cec6fe6c22c0eff73a75df7eb4a9cb76d469
https://github.com/Perl/perl5/commit/3232cec6fe6c22c0eff73a75df7eb4a9cb76d469
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 5bec24dc5d9a3002709b813838831243c9402254
https://github.com/Perl/perl5/commit/5bec24dc5d9a3002709b813838831243c9402254
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 22c95b71eb5c0e3ab7265465e423586fea43493b
https://github.com/Perl/perl5/commit/22c95b71eb5c0e3ab7265465e423586fea43493b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 7a2ea7b14d78392a4e530439638a356d44ac1b3c
https://github.com/Perl/perl5/commit/7a2ea7b14d78392a4e530439638a356d44ac1b3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: f06be3b80c24b07c9a9e894944f610a954da833b
https://github.com/Perl/perl5/commit/f06be3b80c24b07c9a9e894944f610a954da833b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 4f2f57cc08a9b92f648d93568faabcbd541ac69b
https://github.com/Perl/perl5/commit/4f2f57cc08a9b92f648d93568faabcbd541ac69b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 06440045177d241485ae28d9c14975c490f5ee48
https://github.com/Perl/perl5/commit/06440045177d241485ae28d9c14975c490f5ee48
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 0c162052c31daebed08acc5456c60bb5d314159c
https://github.com/Perl/perl5/commit/0c162052c31daebed08acc5456c60bb5d314159c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 51871fb4faa16fdcb2f49af2d348bf1d97bbf0f7
https://github.com/Perl/perl5/commit/51871fb4faa16fdcb2f49af2d348bf1d97bbf0f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 5f73126cc0ac8793b2d1cac3f94e02659e355840
https://github.com/Perl/perl5/commit/5f73126cc0ac8793b2d1cac3f94e02659e355840
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 0b43c4f8dae04dad828286ff927182ef35c33b2e
https://github.com/Perl/perl5/commit/0b43c4f8dae04dad828286ff927182ef35c33b2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 613cd1a80c6fe8cbe03c1359a26eb9f37280c383
https://github.com/Perl/perl5/commit/613cd1a80c6fe8cbe03c1359a26eb9f37280c383
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: c774144b91b9b43b677134d331ea35a99e7e8faa
https://github.com/Perl/perl5/commit/c774144b91b9b43b677134d331ea35a99e7e8faa
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: cb37cc00685dec2df400b37086245e81a597438c
https://github.com/Perl/perl5/commit/cb37cc00685dec2df400b37086245e81a597438c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: b0dd66a6665d172518a7ca3795bafe0215c8b98a
https://github.com/Perl/perl5/commit/b0dd66a6665d172518a7ca3795bafe0215c8b98a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 67aab3be28022cac079d936af327577e0dabba70
https://github.com/Perl/perl5/commit/67aab3be28022cac079d936af327577e0dabba70
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 2552e28f82ca824dd999a2297607f0cc6fcd4bc4
https://github.com/Perl/perl5/commit/2552e28f82ca824dd999a2297607f0cc6fcd4bc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 1eb9c5ac2b978b343452fe1f05344b3629b9d1ec
https://github.com/Perl/perl5/commit/1eb9c5ac2b978b343452fe1f05344b3629b9d1ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: ce5983f1789c74ef9eb2cf7a62be76766a347c4e
https://github.com/Perl/perl5/commit/ce5983f1789c74ef9eb2cf7a62be76766a347c4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: fd592c955a798bdf904436b3cc7dea31a8f3fc90
https://github.com/Perl/perl5/commit/fd592c955a798bdf904436b3cc7dea31a8f3fc90
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: a773d8cdb9f36010b99e73bcce8c2861f2e789a6
https://github.com/Perl/perl5/commit/a773d8cdb9f36010b99e73bcce8c2861f2e789a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 2f6d802421c7de3388f4a270c6c094ee26132ade
https://github.com/Perl/perl5/commit/2f6d802421c7de3388f4a270c6c094ee26132ade
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 474d6f2cd4082f4ab9504cc0a2a335ec1c67c88c
https://github.com/Perl/perl5/commit/474d6f2cd4082f4ab9504cc0a2a335ec1c67c88c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 559cf83c8dbb8a0d7356ba0ab37526e116659655
https://github.com/Perl/perl5/commit/559cf83c8dbb8a0d7356ba0ab37526e116659655
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 52633f6034aa727efd899dade4f4d50c6778b016
https://github.com/Perl/perl5/commit/52633f6034aa727efd899dade4f4d50c6778b016
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: 53e0ba8893274810d1d2c9cfdfef9d7fb7f6a8f9
https://github.com/Perl/perl5/commit/53e0ba8893274810d1d2c9cfdfef9d7fb7f6a8f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 9843a0775b15b5315fe708a56d8f31a7431151e2
https://github.com/Perl/perl5/commit/9843a0775b15b5315fe708a56d8f31a7431151e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: ef76c625ca8ca1cbcc0555dc907d3425058ca651
https://github.com/Perl/perl5/commit/ef76c625ca8ca1cbcc0555dc907d3425058ca651
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 858f9931d44ed2914d652b61a61d815ad8a12bf1
https://github.com/Perl/perl5/commit/858f9931d44ed2914d652b61a61d815ad8a12bf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: e183f80ef704881867878a7fb276dbffc4f8afbd
https://github.com/Perl/perl5/commit/e183f80ef704881867878a7fb276dbffc4f8afbd
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: fd94a5106aa922887dc241ee332e3894d1111026
https://github.com/Perl/perl5/commit/fd94a5106aa922887dc241ee332e3894d1111026
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
38
Commit: f7def85bb93f36f2e5ce455ed775b2d1c41a8a1b
https://github.com/Perl/perl5/commit/f7def85bb93f36f2e5ce455ed775b2d1c41a8a1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M lib/locale_threads.t
M t/loc_tools.pl
Log Message:
-----------
40
Compare: https://github.com/Perl/perl5/compare/ec9bdb21c0ba...f7def85bb93f
