Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: edf1beca6a5a5b03a098eba4350e451c11a99a1a
https://github.com/Perl/perl5/commit/edf1beca6a5a5b03a098eba4350e451c11a99a1a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 185aa2eb88f5a076e09ed3d9d18d21f67f60dc9f
https://github.com/Perl/perl5/commit/185aa2eb88f5a076e09ed3d9d18d21f67f60dc9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 385748a344ea7575d4d3772bced537ab133d43c4
https://github.com/Perl/perl5/commit/385748a344ea7575d4d3772bced537ab133d43c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 421d442fcc6d2eb17e3b143a38d5b182eb2f8ab7
https://github.com/Perl/perl5/commit/421d442fcc6d2eb17e3b143a38d5b182eb2f8ab7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 07615033a4aad67ff2ad295be3bf89586bbe587a
https://github.com/Perl/perl5/commit/07615033a4aad67ff2ad295be3bf89586bbe587a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 3f6b0abad469f9d1cfbc996d5713596e170686fa
https://github.com/Perl/perl5/commit/3f6b0abad469f9d1cfbc996d5713596e170686fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 9f89f7d2beeb829924e14ab734c036ee5d7709c2
https://github.com/Perl/perl5/commit/9f89f7d2beeb829924e14ab734c036ee5d7709c2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 885b0c70994f03dd80635f4474afbc6977b65ea9
https://github.com/Perl/perl5/commit/885b0c70994f03dd80635f4474afbc6977b65ea9
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 257072b4c402fddfbf33b05e91ca6fc81a9210a9
https://github.com/Perl/perl5/commit/257072b4c402fddfbf33b05e91ca6fc81a9210a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: acd1405546e39059ab6400ac422ffe85cda759ff
https://github.com/Perl/perl5/commit/acd1405546e39059ab6400ac422ffe85cda759ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 225543365ab59661eea904245685dd5f5e0a49ff
https://github.com/Perl/perl5/commit/225543365ab59661eea904245685dd5f5e0a49ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: a467eb83baa5f6a9082e0dd1a98f5709b9806e34
https://github.com/Perl/perl5/commit/a467eb83baa5f6a9082e0dd1a98f5709b9806e34
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: ea4db365e30fa916b9517f1a741f6e1ab8202136
https://github.com/Perl/perl5/commit/ea4db365e30fa916b9517f1a741f6e1ab8202136
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 68f54b5625d8a6b2cab3e3df31babb654a5631c0
https://github.com/Perl/perl5/commit/68f54b5625d8a6b2cab3e3df31babb654a5631c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: f8567e6579208c847e98d56a2bfd8b092af87513
https://github.com/Perl/perl5/commit/f8567e6579208c847e98d56a2bfd8b092af87513
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 773c244d7be8da6b71bda5421b0e2b56e0986945
https://github.com/Perl/perl5/commit/773c244d7be8da6b71bda5421b0e2b56e0986945
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 4b3ebd799f2de39ad1f5c6556fe91fc7154b4cd2
https://github.com/Perl/perl5/commit/4b3ebd799f2de39ad1f5c6556fe91fc7154b4cd2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 31d67e8805ba99744d6906a99d7fa9f285d3a25f
https://github.com/Perl/perl5/commit/31d67e8805ba99744d6906a99d7fa9f285d3a25f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 11f31eada9d48f076412b6738c4c6be4c24c61c8
https://github.com/Perl/perl5/commit/11f31eada9d48f076412b6738c4c6be4c24c61c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 581ab717b62b731779adce16c9d118647f1511bd
https://github.com/Perl/perl5/commit/581ab717b62b731779adce16c9d118647f1511bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 46a48d774147acc2482c9bd07271968ddae55c7c
https://github.com/Perl/perl5/commit/46a48d774147acc2482c9bd07271968ddae55c7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 307ef31281c6a9214718210768d69fee0dd0b66d
https://github.com/Perl/perl5/commit/307ef31281c6a9214718210768d69fee0dd0b66d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: aa5a0c33a2981e1644c691bcd13c81bf1e651361
https://github.com/Perl/perl5/commit/aa5a0c33a2981e1644c691bcd13c81bf1e651361
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: c99a73636e759935b7f5a781968c39c3045fcdd6
https://github.com/Perl/perl5/commit/c99a73636e759935b7f5a781968c39c3045fcdd6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: f73342ec3044358c2d87f74f64e53f411679ec1f
https://github.com/Perl/perl5/commit/f73342ec3044358c2d87f74f64e53f411679ec1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: d3c0f5f172c58fd49b250468e8b175e78e24fef8
https://github.com/Perl/perl5/commit/d3c0f5f172c58fd49b250468e8b175e78e24fef8
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: bd1ad65b98d9d00eb114d92e2dc3e8ce4d54304d
https://github.com/Perl/perl5/commit/bd1ad65b98d9d00eb114d92e2dc3e8ce4d54304d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: d062f4658cea746badddd19ce74dfec78aef76a5
https://github.com/Perl/perl5/commit/d062f4658cea746badddd19ce74dfec78aef76a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: a45a6c351240d77d5611e5e1df113085aa24e164
https://github.com/Perl/perl5/commit/a45a6c351240d77d5611e5e1df113085aa24e164
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 3b95c64ec61f6d5be1d8488e886b7521e36e293f
https://github.com/Perl/perl5/commit/3b95c64ec61f6d5be1d8488e886b7521e36e293f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: beea1bf2d4fc49b8e32f6264a9fb5298e8277dfa
https://github.com/Perl/perl5/commit/beea1bf2d4fc49b8e32f6264a9fb5298e8277dfa
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 0ee1b1a35efa7db1a59d3a6186b325491c8fb258
https://github.com/Perl/perl5/commit/0ee1b1a35efa7db1a59d3a6186b325491c8fb258
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: f1995909051a34d4196d71fa254d195528b6c772
https://github.com/Perl/perl5/commit/f1995909051a34d4196d71fa254d195528b6c772
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: c59bf79ad1eaec35871ea987d44a3515807a8a75
https://github.com/Perl/perl5/commit/c59bf79ad1eaec35871ea987d44a3515807a8a75
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 12355b3011502380c373a1473f570f0a0626aa28
https://github.com/Perl/perl5/commit/12355b3011502380c373a1473f570f0a0626aa28
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 60cdbdff3fa77bb611cf953f395741430828afd0
https://github.com/Perl/perl5/commit/60cdbdff3fa77bb611cf953f395741430828afd0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 2fb7e61622ffe0fca95b1c5fcb11603ac8893505
https://github.com/Perl/perl5/commit/2fb7e61622ffe0fca95b1c5fcb11603ac8893505
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 7be423847a43e146a3886edf9d29e968baed98ea
https://github.com/Perl/perl5/commit/7be423847a43e146a3886edf9d29e968baed98ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: d0c259d17b3bc0b0b672c71af76e78977dc09644
https://github.com/Perl/perl5/commit/d0c259d17b3bc0b0b672c71af76e78977dc09644
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 13acc784446b0a2c03470222766538a0ca199dd4
https://github.com/Perl/perl5/commit/13acc784446b0a2c03470222766538a0ca199dd4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 2007419deba6e8208cf0b74394bb44f86d502d1b
https://github.com/Perl/perl5/commit/2007419deba6e8208cf0b74394bb44f86d502d1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 18e531b32b0ae3ba7bd01c118965046dfc485f03
https://github.com/Perl/perl5/commit/18e531b32b0ae3ba7bd01c118965046dfc485f03
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: bac84bbfcfa3020ede011327e3e1fa9807b38ebc
https://github.com/Perl/perl5/commit/bac84bbfcfa3020ede011327e3e1fa9807b38ebc
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 93f6a30e1eca51b05199a4ce20b1096b65a69c3f
https://github.com/Perl/perl5/commit/93f6a30e1eca51b05199a4ce20b1096b65a69c3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 37808221df3a1fb39c30abf62ef970f7584c0f15
https://github.com/Perl/perl5/commit/37808221df3a1fb39c30abf62ef970f7584c0f15
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 75879e985ddcc496c3464991ae9399053cce3172
https://github.com/Perl/perl5/commit/75879e985ddcc496c3464991ae9399053cce3172
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 079d35fbe12f78d5b9fd5f4dfecfc3dddc6a5295
https://github.com/Perl/perl5/commit/079d35fbe12f78d5b9fd5f4dfecfc3dddc6a5295
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 4d049021a685a18d0356cf05fc3e5366a7937925
https://github.com/Perl/perl5/commit/4d049021a685a18d0356cf05fc3e5366a7937925
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: feb93e88934131039b94b12fab4a833a34eb702b
https://github.com/Perl/perl5/commit/feb93e88934131039b94b12fab4a833a34eb702b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: da1bfe2843c46a111264f98bee4d45f61cf47aaf
https://github.com/Perl/perl5/commit/da1bfe2843c46a111264f98bee4d45f61cf47aaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 262239dbb01df408fe96450606d4b57f58e74e86
https://github.com/Perl/perl5/commit/262239dbb01df408fe96450606d4b57f58e74e86
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 4f5e4506465f1982dc3a25ddc51db95efceba0c3
https://github.com/Perl/perl5/commit/4f5e4506465f1982dc3a25ddc51db95efceba0c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 22b8df6923bd6154e59576999f0f09a6800294f6
https://github.com/Perl/perl5/commit/22b8df6923bd6154e59576999f0f09a6800294f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: dc5aca7ee582e389fb1bf371af000bf42be7c1e6
https://github.com/Perl/perl5/commit/dc5aca7ee582e389fb1bf371af000bf42be7c1e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 1473f80442955c4d93bdb1263f2703ea3f4fa6be
https://github.com/Perl/perl5/commit/1473f80442955c4d93bdb1263f2703ea3f4fa6be
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 7f29ceec6bee4aed9d3803dd954f4240caf5bc02
https://github.com/Perl/perl5/commit/7f29ceec6bee4aed9d3803dd954f4240caf5bc02
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 9aacb84a4730f9895d44c94c986e222ac8243d40
https://github.com/Perl/perl5/commit/9aacb84a4730f9895d44c94c986e222ac8243d40
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: bf7650603635f9ffd43ab18d601f5868fb117860
https://github.com/Perl/perl5/commit/bf7650603635f9ffd43ab18d601f5868fb117860
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 230a7d3e1798bb448acb8ad391e3a27076b31f17
https://github.com/Perl/perl5/commit/230a7d3e1798bb448acb8ad391e3a27076b31f17
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 632c7bf683bb70343bef6bdfa07b4bf6ceb3c960
https://github.com/Perl/perl5/commit/632c7bf683bb70343bef6bdfa07b4bf6ceb3c960
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: c97c45746b3d4f503ff0d7eb6190855f403838a1
https://github.com/Perl/perl5/commit/c97c45746b3d4f503ff0d7eb6190855f403838a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: d98ba2ff907e132d095b0a454fca970bdd22be90
https://github.com/Perl/perl5/commit/d98ba2ff907e132d095b0a454fca970bdd22be90
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 5bfd171f410592fdf3c37d245eb2aea4834c9f1f
https://github.com/Perl/perl5/commit/5bfd171f410592fdf3c37d245eb2aea4834c9f1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 36aa076e41ed03cc8cc99d0065e4c7148ba884aa
https://github.com/Perl/perl5/commit/36aa076e41ed03cc8cc99d0065e4c7148ba884aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 34c38f0ede5adebc0992187f85b090b24707f046
https://github.com/Perl/perl5/commit/34c38f0ede5adebc0992187f85b090b24707f046
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: c75858c0fed784f5dc006b59762ae6d61da8b1c4
https://github.com/Perl/perl5/commit/c75858c0fed784f5dc006b59762ae6d61da8b1c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 8fb28253eaf8b48ad125a1733c526529f95cab91
https://github.com/Perl/perl5/commit/8fb28253eaf8b48ad125a1733c526529f95cab91
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 1a7e5cf4ea6fb6a649fb6fc58b5e119ca46e4bd3
https://github.com/Perl/perl5/commit/1a7e5cf4ea6fb6a649fb6fc58b5e119ca46e4bd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 21d97c8a6de5482075b6b8a7185688a07809aa2b
https://github.com/Perl/perl5/commit/21d97c8a6de5482075b6b8a7185688a07809aa2b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: e068103e88a676120687d274ae3f38574c7b96ce
https://github.com/Perl/perl5/commit/e068103e88a676120687d274ae3f38574c7b96ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 6c9ead3251351aee3f6d4c3244c82334450dae90
https://github.com/Perl/perl5/commit/6c9ead3251351aee3f6d4c3244c82334450dae90
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: a517d627aa5ecadaf245f5ecb80456bbe7c857af
https://github.com/Perl/perl5/commit/a517d627aa5ecadaf245f5ecb80456bbe7c857af
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 914ee7ee1d8a9cafda91f3307571db53b228437b
https://github.com/Perl/perl5/commit/914ee7ee1d8a9cafda91f3307571db53b228437b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: d3ef4d557a0fcd5fc421f3631f4ab2cab79425d6
https://github.com/Perl/perl5/commit/d3ef4d557a0fcd5fc421f3631f4ab2cab79425d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: d91dd77fc3e3b56d5e8f9d7446598fb135cc2f86
https://github.com/Perl/perl5/commit/d91dd77fc3e3b56d5e8f9d7446598fb135cc2f86
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: a88cd15e1532cfd77b3cf93396cbb9362a7ee020
https://github.com/Perl/perl5/commit/a88cd15e1532cfd77b3cf93396cbb9362a7ee020
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 72681cd3df33812d880366edeac8d18aa12168fc
https://github.com/Perl/perl5/commit/72681cd3df33812d880366edeac8d18aa12168fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 55bb12b38c30f9bce8033538d45c40521a503239
https://github.com/Perl/perl5/commit/55bb12b38c30f9bce8033538d45c40521a503239
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 7d9b6c97d0186701dff593b70d4f17219b5f8ad7
https://github.com/Perl/perl5/commit/7d9b6c97d0186701dff593b70d4f17219b5f8ad7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 175385d24b6a71cca83722078c425565daa7e1e2
https://github.com/Perl/perl5/commit/175385d24b6a71cca83722078c425565daa7e1e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 301c6f129e75a411fe769a3e08215a17300f3f1e
https://github.com/Perl/perl5/commit/301c6f129e75a411fe769a3e08215a17300f3f1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 28321099fa1b3497f11ce68045058a159c4e37c5
https://github.com/Perl/perl5/commit/28321099fa1b3497f11ce68045058a159c4e37c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 3e98c20608544a195e02a85b52c19ff9fa42eb1c
https://github.com/Perl/perl5/commit/3e98c20608544a195e02a85b52c19ff9fa42eb1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: db82f1c2445a20606c43b26d8c17dba709ca8e39
https://github.com/Perl/perl5/commit/db82f1c2445a20606c43b26d8c17dba709ca8e39
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 30d16c086fa04f19010cb1e37ea87ecea9b4644c
https://github.com/Perl/perl5/commit/30d16c086fa04f19010cb1e37ea87ecea9b4644c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 2df7768d1ac12af2dc008b27bd606ec358a1a190
https://github.com/Perl/perl5/commit/2df7768d1ac12af2dc008b27bd606ec358a1a190
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 9571e0ba8dea4acc614e162ccaffab9304077b20
https://github.com/Perl/perl5/commit/9571e0ba8dea4acc614e162ccaffab9304077b20
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 5cd22a43feb3da09e3c44666270f3436a22d7c91
https://github.com/Perl/perl5/commit/5cd22a43feb3da09e3c44666270f3436a22d7c91
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: ac749c97fc85f196e82bd7cafeb5dfcf6d503c5d
https://github.com/Perl/perl5/commit/ac749c97fc85f196e82bd7cafeb5dfcf6d503c5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 77dd12b649d1d206c2c112e4be898b49dc4d7c40
https://github.com/Perl/perl5/commit/77dd12b649d1d206c2c112e4be898b49dc4d7c40
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 8a8f8751c542316ddb122d6450a61583a74bcafc
https://github.com/Perl/perl5/commit/8a8f8751c542316ddb122d6450a61583a74bcafc
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: bd9ccdeee2dec5ebf79e2ce365659492dbe38d6d
https://github.com/Perl/perl5/commit/bd9ccdeee2dec5ebf79e2ce365659492dbe38d6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: c159c87ff34ebaabcf279f618ca8bd346967561d
https://github.com/Perl/perl5/commit/c159c87ff34ebaabcf279f618ca8bd346967561d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 796fad7a7cee727f73a008a5436933a2fb850db8
https://github.com/Perl/perl5/commit/796fad7a7cee727f73a008a5436933a2fb850db8
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 579feff06d686ce5765b6c003d410feecc91bfcd
https://github.com/Perl/perl5/commit/579feff06d686ce5765b6c003d410feecc91bfcd
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: a2677626f8f5e6eecebfb8fa6c4c0dd5df13c90c
https://github.com/Perl/perl5/commit/a2677626f8f5e6eecebfb8fa6c4c0dd5df13c90c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 41c384ec0015af1452b3e92bdfb2123f3e360e9b
https://github.com/Perl/perl5/commit/41c384ec0015af1452b3e92bdfb2123f3e360e9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 559b5502051fad8e7ea4108ccc25d6e1415f750c
https://github.com/Perl/perl5/commit/559b5502051fad8e7ea4108ccc25d6e1415f750c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: b80277fa32b3a6f17c62c9a0108701be0ad5ddbb
https://github.com/Perl/perl5/commit/b80277fa32b3a6f17c62c9a0108701be0ad5ddbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 69ac42578aaed4f0c1a2fc7846a573583c297f83
https://github.com/Perl/perl5/commit/69ac42578aaed4f0c1a2fc7846a573583c297f83
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: a9ecc1810de097cfa68d7bfc7bcddffc0c17a5a0
https://github.com/Perl/perl5/commit/a9ecc1810de097cfa68d7bfc7bcddffc0c17a5a0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: b39f582bc7236d001e2513b84f61055890e55aae
https://github.com/Perl/perl5/commit/b39f582bc7236d001e2513b84f61055890e55aae
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 56e869cd4b84a44ca118afbacec845e27bf29f24
https://github.com/Perl/perl5/commit/56e869cd4b84a44ca118afbacec845e27bf29f24
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 8b51510725921c5eb8b65b0423624f3b8ecdb5f9
https://github.com/Perl/perl5/commit/8b51510725921c5eb8b65b0423624f3b8ecdb5f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 595f4d45413695896707e657cba52cf9b6d648d1
https://github.com/Perl/perl5/commit/595f4d45413695896707e657cba52cf9b6d648d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: bf18e4b597080760faeb3a7c4a51e7e20c071592
https://github.com/Perl/perl5/commit/bf18e4b597080760faeb3a7c4a51e7e20c071592
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: cb7f57e0d76c6202202741a4cc72a8c72971e88b
https://github.com/Perl/perl5/commit/cb7f57e0d76c6202202741a4cc72a8c72971e88b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: c46ec902fb9d93e66c77f9cb72cc9b896b6cd214
https://github.com/Perl/perl5/commit/c46ec902fb9d93e66c77f9cb72cc9b896b6cd214
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 7f6538c3861a42d9f7ac8d6a8d2fb0d5084d6c32
https://github.com/Perl/perl5/commit/7f6538c3861a42d9f7ac8d6a8d2fb0d5084d6c32
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 1e89de6a5c856b393951d07a7edbb0f527f46c5d
https://github.com/Perl/perl5/commit/1e89de6a5c856b393951d07a7edbb0f527f46c5d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: fb161729587acf3821583a8bb096a20636cabda2
https://github.com/Perl/perl5/commit/fb161729587acf3821583a8bb096a20636cabda2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: f7ef416ce45c37fb853d26d340f07431addda2f3
https://github.com/Perl/perl5/commit/f7ef416ce45c37fb853d26d340f07431addda2f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: e2dfddfdcc2b50dfea10f83340f74586a528a811
https://github.com/Perl/perl5/commit/e2dfddfdcc2b50dfea10f83340f74586a528a811
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 82c459629f1ffe83d97cdad8b5a8031bac2bcb83
https://github.com/Perl/perl5/commit/82c459629f1ffe83d97cdad8b5a8031bac2bcb83
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 60938fb06631b3a8964af780ceec61e8d8c135f2
https://github.com/Perl/perl5/commit/60938fb06631b3a8964af780ceec61e8d8c135f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 955d68a5bfa5e93db19f47e92c123411acd574c1
https://github.com/Perl/perl5/commit/955d68a5bfa5e93db19f47e92c123411acd574c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 45d8b68dd11542e410709a554e48c26a3c79ab08
https://github.com/Perl/perl5/commit/45d8b68dd11542e410709a554e48c26a3c79ab08
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 96a8c2666bdc60206dfa7aebf4911286a459139d
https://github.com/Perl/perl5/commit/96a8c2666bdc60206dfa7aebf4911286a459139d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 4a9436dba156a60c19d95f6bfa617108a6cf66a6
https://github.com/Perl/perl5/commit/4a9436dba156a60c19d95f6bfa617108a6cf66a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: c5ca1ca8d794a8e6fd9feb235e945de4461505e0
https://github.com/Perl/perl5/commit/c5ca1ca8d794a8e6fd9feb235e945de4461505e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 4747f51fcc1de214d3e6180c1671f885c9fc98f4
https://github.com/Perl/perl5/commit/4747f51fcc1de214d3e6180c1671f885c9fc98f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: f166e0632b45bc93f2192ee1ed37463b7707b459
https://github.com/Perl/perl5/commit/f166e0632b45bc93f2192ee1ed37463b7707b459
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: b5f18f626f5d578ff9fbf1ccc56e4956b0a26405
https://github.com/Perl/perl5/commit/b5f18f626f5d578ff9fbf1ccc56e4956b0a26405
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: dae787dc525fb19bdbd14ce2aa61ff0d7fde7c50
https://github.com/Perl/perl5/commit/dae787dc525fb19bdbd14ce2aa61ff0d7fde7c50
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: f45f5670ecfd06087fa66b82611bad5b8d575412
https://github.com/Perl/perl5/commit/f45f5670ecfd06087fa66b82611bad5b8d575412
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: d3fffcf6e972d95a313ab3aa850621f82d4e211c
https://github.com/Perl/perl5/commit/d3fffcf6e972d95a313ab3aa850621f82d4e211c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: a5f871281454d29023c86e78958be6590351ca52
https://github.com/Perl/perl5/commit/a5f871281454d29023c86e78958be6590351ca52
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 08c346064bd164a4422b53129fa16ad30ae1f020
https://github.com/Perl/perl5/commit/08c346064bd164a4422b53129fa16ad30ae1f020
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 2831b9a2a4d136ade7586964fdb5bc0e7db9038d
https://github.com/Perl/perl5/commit/2831b9a2a4d136ade7586964fdb5bc0e7db9038d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 3c1db6df12df4ef5f415e51d8d1f2210e54920e2
https://github.com/Perl/perl5/commit/3c1db6df12df4ef5f415e51d8d1f2210e54920e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: b2376e0e445cd7efdeb60e8e59b34441d723a6ca
https://github.com/Perl/perl5/commit/b2376e0e445cd7efdeb60e8e59b34441d723a6ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: b27cc4e2e9e2c12d6224e7d794418921c43f4f4b
https://github.com/Perl/perl5/commit/b27cc4e2e9e2c12d6224e7d794418921c43f4f4b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 0f4348ac7aa8a59e14fce31639a0d24042e225bc
https://github.com/Perl/perl5/commit/0f4348ac7aa8a59e14fce31639a0d24042e225bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 14482caffe9724f0ebd8c3d19eb8b8cc67dd41ce
https://github.com/Perl/perl5/commit/14482caffe9724f0ebd8c3d19eb8b8cc67dd41ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: f97ce06cbca5ddf21aef39e4eb3b4aa22b6e5ae5
https://github.com/Perl/perl5/commit/f97ce06cbca5ddf21aef39e4eb3b4aa22b6e5ae5
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: f1b5174db6746602e3ccfd6f5bde5a4726145158
https://github.com/Perl/perl5/commit/f1b5174db6746602e3ccfd6f5bde5a4726145158
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: c6d196a723c9b68a22214c0006e59d86baef2a31
https://github.com/Perl/perl5/commit/c6d196a723c9b68a22214c0006e59d86baef2a31
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: cd197d43b05f38e0320596b7a27e5e5d23c28716
https://github.com/Perl/perl5/commit/cd197d43b05f38e0320596b7a27e5e5d23c28716
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: a8f1ab663b7e0dc6844b978bacfc5203c8556480
https://github.com/Perl/perl5/commit/a8f1ab663b7e0dc6844b978bacfc5203c8556480
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 3febe7671b17b6caab04edc6bb6d001786067910
https://github.com/Perl/perl5/commit/3febe7671b17b6caab04edc6bb6d001786067910
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: e48ccfd5f1f6254b97eb9f1b229155c21473f10a
https://github.com/Perl/perl5/commit/e48ccfd5f1f6254b97eb9f1b229155c21473f10a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 263caaaec9eef82ae9364d64557354a0a1c91a91
https://github.com/Perl/perl5/commit/263caaaec9eef82ae9364d64557354a0a1c91a91
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 8b0f4e842cea502e33ee02553568f9001e92cdaf
https://github.com/Perl/perl5/commit/8b0f4e842cea502e33ee02553568f9001e92cdaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 8f10e9698b3d7f7e58da6f0ad62daeb49ea23810
https://github.com/Perl/perl5/commit/8f10e9698b3d7f7e58da6f0ad62daeb49ea23810
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 9675413b956f7d1131807c1c2593a62270bb687d
https://github.com/Perl/perl5/commit/9675413b956f7d1131807c1c2593a62270bb687d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 6a3569513ff3f60bfbb48cc60dadde7581d6b94b
https://github.com/Perl/perl5/commit/6a3569513ff3f60bfbb48cc60dadde7581d6b94b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 9aed3d345fdb0ae460cdb7d964fa4cbb237f2d6d
https://github.com/Perl/perl5/commit/9aed3d345fdb0ae460cdb7d964fa4cbb237f2d6d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 851a0869d6a3170c80adf996929fcd24cb9591fb
https://github.com/Perl/perl5/commit/851a0869d6a3170c80adf996929fcd24cb9591fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: cfc71d3ed1cc6f359ead45562cb2907d4f0b8e63
https://github.com/Perl/perl5/commit/cfc71d3ed1cc6f359ead45562cb2907d4f0b8e63
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: d8e4cc17982a679bd6e258bb89ac34f4b4f948db
https://github.com/Perl/perl5/commit/d8e4cc17982a679bd6e258bb89ac34f4b4f948db
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: b96ee833bcda4f802b952733301bd9e51294c20f
https://github.com/Perl/perl5/commit/b96ee833bcda4f802b952733301bd9e51294c20f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: aa47bfcde3c5b2eb14a3bd44520ed3e17febb08e
https://github.com/Perl/perl5/commit/aa47bfcde3c5b2eb14a3bd44520ed3e17febb08e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 7fe3b7ba550e06bd99829ac8cb7fc3aa98633c6c
https://github.com/Perl/perl5/commit/7fe3b7ba550e06bd99829ac8cb7fc3aa98633c6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: c093b665cdcd69e57118b42d13d34b53120c3f37
https://github.com/Perl/perl5/commit/c093b665cdcd69e57118b42d13d34b53120c3f37
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: c663b105438f1914c9a1cee5a57b11ab85ca8788
https://github.com/Perl/perl5/commit/c663b105438f1914c9a1cee5a57b11ab85ca8788
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: cb15fbf2a8f2ae02265b445be65e3657f7310b20
https://github.com/Perl/perl5/commit/cb15fbf2a8f2ae02265b445be65e3657f7310b20
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: c24a1ffc00cabadc18e0dbafccd9cfd2025a5b16
https://github.com/Perl/perl5/commit/c24a1ffc00cabadc18e0dbafccd9cfd2025a5b16
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 88c54022832ff34309a4ec02945203e3ae98ea74
https://github.com/Perl/perl5/commit/88c54022832ff34309a4ec02945203e3ae98ea74
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: bfba8bb13d4db8cc9dc736419ce774a77181bd7f
https://github.com/Perl/perl5/commit/bfba8bb13d4db8cc9dc736419ce774a77181bd7f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 5082ac954930b2d6618d9663dbba216166ffbaa3
https://github.com/Perl/perl5/commit/5082ac954930b2d6618d9663dbba216166ffbaa3
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 7f1d3fac9223f0c4b45575cb03e5f48577728a20
https://github.com/Perl/perl5/commit/7f1d3fac9223f0c4b45575cb03e5f48577728a20
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 0beab6a4f4a3a1687d573ca33271cb683aec34e1
https://github.com/Perl/perl5/commit/0beab6a4f4a3a1687d573ca33271cb683aec34e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 2234c17382b0b80197d1994b530661bac95d5c0e
https://github.com/Perl/perl5/commit/2234c17382b0b80197d1994b530661bac95d5c0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: c79b0298f437b04533d931dc436efaa2e41e215f
https://github.com/Perl/perl5/commit/c79b0298f437b04533d931dc436efaa2e41e215f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 5af37169c7ec46ba563a7bfce1165cf2405db494
https://github.com/Perl/perl5/commit/5af37169c7ec46ba563a7bfce1165cf2405db494
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: ca733fc167f216f464e79a378f996bad55889d46
https://github.com/Perl/perl5/commit/ca733fc167f216f464e79a378f996bad55889d46
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 891ce85a2f09900a942ee97c3de9a446db22906b
https://github.com/Perl/perl5/commit/891ce85a2f09900a942ee97c3de9a446db22906b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: b1e14b0cf7e86054158e6290b4c544a8413d9605
https://github.com/Perl/perl5/commit/b1e14b0cf7e86054158e6290b4c544a8413d9605
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: d2d23fd49ca20867f53d7bf91d070a0e716f42ae
https://github.com/Perl/perl5/commit/d2d23fd49ca20867f53d7bf91d070a0e716f42ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 4b659b799ffe4071961e1079b715198b2588f198
https://github.com/Perl/perl5/commit/4b659b799ffe4071961e1079b715198b2588f198
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: f439be381c7d3d3e1083cf03fafe4acf8f8a76ba
https://github.com/Perl/perl5/commit/f439be381c7d3d3e1083cf03fafe4acf8f8a76ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 91c17f2926715b40098a74afb2cb0257b36ed8e6
https://github.com/Perl/perl5/commit/91c17f2926715b40098a74afb2cb0257b36ed8e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 1988d9a10ed11652b0863e5e8b33fbea853161a8
https://github.com/Perl/perl5/commit/1988d9a10ed11652b0863e5e8b33fbea853161a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 3f79ff88565fe40b37ef7fe7ed007f85ac646456
https://github.com/Perl/perl5/commit/3f79ff88565fe40b37ef7fe7ed007f85ac646456
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 3e6b713b5216ac65e767ffac0a5546de6c228e7d
https://github.com/Perl/perl5/commit/3e6b713b5216ac65e767ffac0a5546de6c228e7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 3a3529c9c51be72ccdf4026f8bbb488fdb46a07b
https://github.com/Perl/perl5/commit/3a3529c9c51be72ccdf4026f8bbb488fdb46a07b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 0f21acd27bc51d5f50f8cfd096ddba5327ba52c1
https://github.com/Perl/perl5/commit/0f21acd27bc51d5f50f8cfd096ddba5327ba52c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: badecf39ec56a63d86e3caf889dd877f0354d734
https://github.com/Perl/perl5/commit/badecf39ec56a63d86e3caf889dd877f0354d734
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: e3f0584b9e77fdac8eb999d95e01bd9689592d7b
https://github.com/Perl/perl5/commit/e3f0584b9e77fdac8eb999d95e01bd9689592d7b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 6eb25e2360588438b8c480a93dcfca160bd58cd1
https://github.com/Perl/perl5/commit/6eb25e2360588438b8c480a93dcfca160bd58cd1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: b2f5ff1118a52e5e1ad400d81e14af940f829736
https://github.com/Perl/perl5/commit/b2f5ff1118a52e5e1ad400d81e14af940f829736
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 91d1c191184347e7a54ff66bdeb6062bfaa5a5af
https://github.com/Perl/perl5/commit/91d1c191184347e7a54ff66bdeb6062bfaa5a5af
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 4977ce980c926fff0fe4192ec851b20d252ea9d0
https://github.com/Perl/perl5/commit/4977ce980c926fff0fe4192ec851b20d252ea9d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: bccce4016f7dbff06e65fcd711e7edd61e151d87
https://github.com/Perl/perl5/commit/bccce4016f7dbff06e65fcd711e7edd61e151d87
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 28b9d265430eb5cb3d7d603782a809c794b837ed
https://github.com/Perl/perl5/commit/28b9d265430eb5cb3d7d603782a809c794b837ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: d6ee59187a9d4bed9739af8f4f13ecb60ead46e7
https://github.com/Perl/perl5/commit/d6ee59187a9d4bed9739af8f4f13ecb60ead46e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5b47d3804ca166deb9d820fc1d02b9a47eff6986
https://github.com/Perl/perl5/commit/5b47d3804ca166deb9d820fc1d02b9a47eff6986
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: ff979f0d6fadba96cbab248d2f6e6237abc394c6
https://github.com/Perl/perl5/commit/ff979f0d6fadba96cbab248d2f6e6237abc394c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 2518b24c635d4f59650e0ae30ecbc9b8c675c596
https://github.com/Perl/perl5/commit/2518b24c635d4f59650e0ae30ecbc9b8c675c596
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 03c22daa0512303acfd52975ee5d4c3f736240f9
https://github.com/Perl/perl5/commit/03c22daa0512303acfd52975ee5d4c3f736240f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: d03478c94916ad435c7b6c5d0c2516a379bc39d7
https://github.com/Perl/perl5/commit/d03478c94916ad435c7b6c5d0c2516a379bc39d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 3f3cff3ca3d46028d6bc374bcfee413c8a3720f6
https://github.com/Perl/perl5/commit/3f3cff3ca3d46028d6bc374bcfee413c8a3720f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: bb29922b986e3283e369976300438393a69e7a1e
https://github.com/Perl/perl5/commit/bb29922b986e3283e369976300438393a69e7a1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: ba18433404097681a732de612a79eab571d12891
https://github.com/Perl/perl5/commit/ba18433404097681a732de612a79eab571d12891
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: ab38e04f818af7ef80c3591227392503e76cf942
https://github.com/Perl/perl5/commit/ab38e04f818af7ef80c3591227392503e76cf942
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 4476ece314db9cbe20f24ac16d06d1d0376c7d13
https://github.com/Perl/perl5/commit/4476ece314db9cbe20f24ac16d06d1d0376c7d13
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: b5810d561d47a966b78d0fe193b7f8cf0e8abd80
https://github.com/Perl/perl5/commit/b5810d561d47a966b78d0fe193b7f8cf0e8abd80
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: c80545728a5b145ba602fb2bfd7ee8581cd58726
https://github.com/Perl/perl5/commit/c80545728a5b145ba602fb2bfd7ee8581cd58726
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 4e0a243664eceaf2459cb82d6d7bebf2151a669b
https://github.com/Perl/perl5/commit/4e0a243664eceaf2459cb82d6d7bebf2151a669b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 56b8ddcd4cb44052c658a50db0a506d48fb95312
https://github.com/Perl/perl5/commit/56b8ddcd4cb44052c658a50db0a506d48fb95312
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 824cdbe2637d827567b86c5fb942faa00e54a03f
https://github.com/Perl/perl5/commit/824cdbe2637d827567b86c5fb942faa00e54a03f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: e714a0184a3452d727cf7cc7528379de12ec3e2e
https://github.com/Perl/perl5/commit/e714a0184a3452d727cf7cc7528379de12ec3e2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: e2b951d3f83f88f2fdd0fc2357bfa66f42b33e48
https://github.com/Perl/perl5/commit/e2b951d3f83f88f2fdd0fc2357bfa66f42b33e48
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: a7dc3172dc0340421b1dc8df1f28abc21cd6f99c
https://github.com/Perl/perl5/commit/a7dc3172dc0340421b1dc8df1f28abc21cd6f99c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 296622727dd700f68c7ba7ca9045e8f28fd0a9bf
https://github.com/Perl/perl5/commit/296622727dd700f68c7ba7ca9045e8f28fd0a9bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: fe4a99ba0e3a52c0bd05882b79e5bebc6d064a2b
https://github.com/Perl/perl5/commit/fe4a99ba0e3a52c0bd05882b79e5bebc6d064a2b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 64005e976f7dd99fec22bfe1513dbb15c051555c
https://github.com/Perl/perl5/commit/64005e976f7dd99fec22bfe1513dbb15c051555c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 80657d58d7adc4aa36ceda03e8450941291900e2
https://github.com/Perl/perl5/commit/80657d58d7adc4aa36ceda03e8450941291900e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: cf0ab04aab98946885cd075be552ff5034b8f5ca
https://github.com/Perl/perl5/commit/cf0ab04aab98946885cd075be552ff5034b8f5ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 9f925fcf1b7c9e9b3ef69e1ba5a775df0d7f6c5b
https://github.com/Perl/perl5/commit/9f925fcf1b7c9e9b3ef69e1ba5a775df0d7f6c5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 6502984cc1a5640b611da70e7a64a22506e04dfc
https://github.com/Perl/perl5/commit/6502984cc1a5640b611da70e7a64a22506e04dfc
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: cf5f7b07785edcb6ae06dfbad75c25dabcdf5c18
https://github.com/Perl/perl5/commit/cf5f7b07785edcb6ae06dfbad75c25dabcdf5c18
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: aede44a2436cc2abe451e03e62b1dc7e841f6bca
https://github.com/Perl/perl5/commit/aede44a2436cc2abe451e03e62b1dc7e841f6bca
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 028174717b4a28fb42dac13adb0bfb506683fc93
https://github.com/Perl/perl5/commit/028174717b4a28fb42dac13adb0bfb506683fc93
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 773761d51944eef848a4ae534ee39787c907e2b2
https://github.com/Perl/perl5/commit/773761d51944eef848a4ae534ee39787c907e2b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: d4a22599c518442ebe1c425a93e531b13e4c1fa1
https://github.com/Perl/perl5/commit/d4a22599c518442ebe1c425a93e531b13e4c1fa1
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: ff1fc19abcb73e6e1eae6918df37597e61cba3fd
https://github.com/Perl/perl5/commit/ff1fc19abcb73e6e1eae6918df37597e61cba3fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 334c063e72be4bb19bbc08563d71ca4a2065f5b7
https://github.com/Perl/perl5/commit/334c063e72be4bb19bbc08563d71ca4a2065f5b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 167488befe61c327284f33ceb96a1fd32c258b39
https://github.com/Perl/perl5/commit/167488befe61c327284f33ceb96a1fd32c258b39
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: e504ec56a9549772975ea507046080d653243364
https://github.com/Perl/perl5/commit/e504ec56a9549772975ea507046080d653243364
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: ddf346f9e0c5d20b050271e7f46de1fe545f8697
https://github.com/Perl/perl5/commit/ddf346f9e0c5d20b050271e7f46de1fe545f8697
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 522e09bbca50468078c5b24332f0d1f832bc6388
https://github.com/Perl/perl5/commit/522e09bbca50468078c5b24332f0d1f832bc6388
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: c8fa526d16543d4dceeb1bfc9148967e6f9bc170
https://github.com/Perl/perl5/commit/c8fa526d16543d4dceeb1bfc9148967e6f9bc170
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 729d6693c03265aa24890a6f0e7a4ba6f67282fe
https://github.com/Perl/perl5/commit/729d6693c03265aa24890a6f0e7a4ba6f67282fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: aa9a31578a7cb17a7b9d3c81ae81151972695b8b
https://github.com/Perl/perl5/commit/aa9a31578a7cb17a7b9d3c81ae81151972695b8b
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 4107b765551169f10d0d26adb2462ee569ccb4ad
https://github.com/Perl/perl5/commit/4107b765551169f10d0d26adb2462ee569ccb4ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 12d078b9214dc10533c5f6be1acd8e1cd7e85fb8
https://github.com/Perl/perl5/commit/12d078b9214dc10533c5f6be1acd8e1cd7e85fb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 2e8289455165837851a8e8eaf4d4cc1b19e2ae5e
https://github.com/Perl/perl5/commit/2e8289455165837851a8e8eaf4d4cc1b19e2ae5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: e88846f47f440bba5c4c014d5ffe32d343ba50ca
https://github.com/Perl/perl5/commit/e88846f47f440bba5c4c014d5ffe32d343ba50ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 94c6d97df95ada79e3d4a2cff97f345e8c7dfd37
https://github.com/Perl/perl5/commit/94c6d97df95ada79e3d4a2cff97f345e8c7dfd37
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: a427f542fddd4e3afd47e82b3355367ffbbde58f
https://github.com/Perl/perl5/commit/a427f542fddd4e3afd47e82b3355367ffbbde58f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 77ee5c004692acfebf4158d0b5e726cfb9b466d2
https://github.com/Perl/perl5/commit/77ee5c004692acfebf4158d0b5e726cfb9b466d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 6655ed8326c155608f6c3c55fabb4e0823a24754
https://github.com/Perl/perl5/commit/6655ed8326c155608f6c3c55fabb4e0823a24754
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 2d0d4cac63c28a03e50be48c28ea31381c9306fa
https://github.com/Perl/perl5/commit/2d0d4cac63c28a03e50be48c28ea31381c9306fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 7de3f184f39e6392d823cb5025714f2631839d6a
https://github.com/Perl/perl5/commit/7de3f184f39e6392d823cb5025714f2631839d6a
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 8bc2f15388cc7ebbc0a2c5f6f31c588476a1d028
https://github.com/Perl/perl5/commit/8bc2f15388cc7ebbc0a2c5f6f31c588476a1d028
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 333030ad5b3e6467e5b207a0e0718b64cb4f0866
https://github.com/Perl/perl5/commit/333030ad5b3e6467e5b207a0e0718b64cb4f0866
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 0f57cebd553dd596226d60070379fa449f9113b7
https://github.com/Perl/perl5/commit/0f57cebd553dd596226d60070379fa449f9113b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 4cf6cdbf68d8188f865a1b354446e0fa73e93b67
https://github.com/Perl/perl5/commit/4cf6cdbf68d8188f865a1b354446e0fa73e93b67
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 34ee49f98aff34ce7353e0ff7aeabab7abd442ad
https://github.com/Perl/perl5/commit/34ee49f98aff34ce7353e0ff7aeabab7abd442ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: f861d1cae0ef89c8b3ba2ac2488a292afed62d76
https://github.com/Perl/perl5/commit/f861d1cae0ef89c8b3ba2ac2488a292afed62d76
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 872181d151f707636e0160987de088a1a33dc2e4
https://github.com/Perl/perl5/commit/872181d151f707636e0160987de088a1a33dc2e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: cc164160434cb601a0b26da60a56ec8b8798b774
https://github.com/Perl/perl5/commit/cc164160434cb601a0b26da60a56ec8b8798b774
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: e8775f3b5eb145bb32818e06080217832b113664
https://github.com/Perl/perl5/commit/e8775f3b5eb145bb32818e06080217832b113664
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: 05cfedcd393f03d50a9899c2cf79fe1dc53b6d20
https://github.com/Perl/perl5/commit/05cfedcd393f03d50a9899c2cf79fe1dc53b6d20
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: eba282f692f88a02671ed3a43daedcd20c8ad2e6
https://github.com/Perl/perl5/commit/eba282f692f88a02671ed3a43daedcd20c8ad2e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 3b92f5e41ef8296ab314ef06778b4c61cd281806
https://github.com/Perl/perl5/commit/3b92f5e41ef8296ab314ef06778b4c61cd281806
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 2f86d2d8da4f6bdfd70faa3716de12fc9ac27155
https://github.com/Perl/perl5/commit/2f86d2d8da4f6bdfd70faa3716de12fc9ac27155
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 56ad873591627a9072b184b11c983b38daffef2d
https://github.com/Perl/perl5/commit/56ad873591627a9072b184b11c983b38daffef2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 9d2f5359266cc30a41af79652a39da772b97f941
https://github.com/Perl/perl5/commit/9d2f5359266cc30a41af79652a39da772b97f941
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 4fe38dd08d9c4f8897699ea3fb15eb44efa3baca
https://github.com/Perl/perl5/commit/4fe38dd08d9c4f8897699ea3fb15eb44efa3baca
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: 19928db343c2974fd626405cb8d0532da27c70fb
https://github.com/Perl/perl5/commit/19928db343c2974fd626405cb8d0532da27c70fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: e6eff57297ab5e0428843cd0eba1f5b7e64c668f
https://github.com/Perl/perl5/commit/e6eff57297ab5e0428843cd0eba1f5b7e64c668f
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: e435b8e9c85adead5fd8f40851da7cc29c3a4729
https://github.com/Perl/perl5/commit/e435b8e9c85adead5fd8f40851da7cc29c3a4729
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 9708ba921917c5ee151fa784cb1ca0d2ff3b79f8
https://github.com/Perl/perl5/commit/9708ba921917c5ee151fa784cb1ca0d2ff3b79f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 999fc27f7b0abd1a806072ac34acac6c3f557b1c
https://github.com/Perl/perl5/commit/999fc27f7b0abd1a806072ac34acac6c3f557b1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-22 (Thu, 22 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
41
Compare: https://github.com/Perl/perl5/compare/f7def85bb93f...999fc27f7b0a
