Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 84f937abaadf46d341cfda7b94f1c84dfb77e9ad
https://github.com/Perl/perl5/commit/84f937abaadf46d341cfda7b94f1c84dfb77e9ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 10dad0cef161e018f6ef17d4ca29dcbb77c96a6e
https://github.com/Perl/perl5/commit/10dad0cef161e018f6ef17d4ca29dcbb77c96a6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 3c15004c27423a1e19ba87c4673d058b600a8459
https://github.com/Perl/perl5/commit/3c15004c27423a1e19ba87c4673d058b600a8459
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 89d5d4f98fae091e389a806020f119d7fc0de3f7
https://github.com/Perl/perl5/commit/89d5d4f98fae091e389a806020f119d7fc0de3f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 014cfb25842e7b1367a0adfd28bd94bf11cb3610
https://github.com/Perl/perl5/commit/014cfb25842e7b1367a0adfd28bd94bf11cb3610
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 98b3aabadaa3d2fc6b2b189a35987faece80f7e0
https://github.com/Perl/perl5/commit/98b3aabadaa3d2fc6b2b189a35987faece80f7e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: d0a3b858523f26ec8aa7854af0ac9cf705f4dc31
https://github.com/Perl/perl5/commit/d0a3b858523f26ec8aa7854af0ac9cf705f4dc31
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: d9fcf5331a9f8fe0c2c4cee223ef05a7628e8f17
https://github.com/Perl/perl5/commit/d9fcf5331a9f8fe0c2c4cee223ef05a7628e8f17
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 4a1e42fb851964d3876801ee4c249f0be188f182
https://github.com/Perl/perl5/commit/4a1e42fb851964d3876801ee4c249f0be188f182
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: fa7f5809a3be7de9c1861332916c5ad973765c40
https://github.com/Perl/perl5/commit/fa7f5809a3be7de9c1861332916c5ad973765c40
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 9f0af9dfff4bf1c09f81b8eab7a25badefa3b069
https://github.com/Perl/perl5/commit/9f0af9dfff4bf1c09f81b8eab7a25badefa3b069
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 1683ead629234f6e6b1a62771f21e1f0a1a7abca
https://github.com/Perl/perl5/commit/1683ead629234f6e6b1a62771f21e1f0a1a7abca
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: e3bdcb97b2f6d0dc83ff40606c394fbb24fe4d99
https://github.com/Perl/perl5/commit/e3bdcb97b2f6d0dc83ff40606c394fbb24fe4d99
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: d65b5e3f402c721c7734d396aba9a267bbc258d6
https://github.com/Perl/perl5/commit/d65b5e3f402c721c7734d396aba9a267bbc258d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 2293336ed590e9b1681fc5aa86768018eefedcf1
https://github.com/Perl/perl5/commit/2293336ed590e9b1681fc5aa86768018eefedcf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 6f01f0c7051c2338e185cd0846d36e2c886ead58
https://github.com/Perl/perl5/commit/6f01f0c7051c2338e185cd0846d36e2c886ead58
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: eab0160ba550b07a8efb23d1541981bcff2f867e
https://github.com/Perl/perl5/commit/eab0160ba550b07a8efb23d1541981bcff2f867e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: ee4a766c68d2bbafdfdfc8665f59fa221ba13569
https://github.com/Perl/perl5/commit/ee4a766c68d2bbafdfdfc8665f59fa221ba13569
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: dcb74338fde3afe7e959eefacbcac135dd62aaac
https://github.com/Perl/perl5/commit/dcb74338fde3afe7e959eefacbcac135dd62aaac
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 671f5a8800125a00128c2ca35fc4a81e8d333341
https://github.com/Perl/perl5/commit/671f5a8800125a00128c2ca35fc4a81e8d333341
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 47df146a312e0ac265eab0fbfb289c2dc940330b
https://github.com/Perl/perl5/commit/47df146a312e0ac265eab0fbfb289c2dc940330b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 6bc324b743d642e85f0513ee5a31b3d38d9c2e99
https://github.com/Perl/perl5/commit/6bc324b743d642e85f0513ee5a31b3d38d9c2e99
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 2c4bd8c0ca0b76ef04de28e9bb31312fdf27ebee
https://github.com/Perl/perl5/commit/2c4bd8c0ca0b76ef04de28e9bb31312fdf27ebee
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 4071b1cf8f85c097de9f9fcef39f09376364a069
https://github.com/Perl/perl5/commit/4071b1cf8f85c097de9f9fcef39f09376364a069
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 66b236732b4dc76711a4f82418ffe180068f64f0
https://github.com/Perl/perl5/commit/66b236732b4dc76711a4f82418ffe180068f64f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 04648545cd426f31c233ed828fd3ad5e2f68341d
https://github.com/Perl/perl5/commit/04648545cd426f31c233ed828fd3ad5e2f68341d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 101183c85c4a8e38b0552c2cc385194ca750a23c
https://github.com/Perl/perl5/commit/101183c85c4a8e38b0552c2cc385194ca750a23c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: fc1e304074421aefca1f3392f6c38345f3e43153
https://github.com/Perl/perl5/commit/fc1e304074421aefca1f3392f6c38345f3e43153
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: c153e41ca0879f55162b46e883f05fac99da7704
https://github.com/Perl/perl5/commit/c153e41ca0879f55162b46e883f05fac99da7704
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 96186fd9cfc466f3afea68a4c46dfebf6f0a391f
https://github.com/Perl/perl5/commit/96186fd9cfc466f3afea68a4c46dfebf6f0a391f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 5af6a98328a16b506de965c3e96f06373ec1404a
https://github.com/Perl/perl5/commit/5af6a98328a16b506de965c3e96f06373ec1404a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 64b2aa713149b0072ca91f08fce092427e706623
https://github.com/Perl/perl5/commit/64b2aa713149b0072ca91f08fce092427e706623
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 656d7200ec670e8337c42a036f06e5d1a64e9818
https://github.com/Perl/perl5/commit/656d7200ec670e8337c42a036f06e5d1a64e9818
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: a3553981007551ba0a4717f363101ceea457c71c
https://github.com/Perl/perl5/commit/a3553981007551ba0a4717f363101ceea457c71c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 8e968534d94645d4afc9e98e786988588299847e
https://github.com/Perl/perl5/commit/8e968534d94645d4afc9e98e786988588299847e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: 7ce73a7002804f8d18ddb93e82a45cd46b23053d
https://github.com/Perl/perl5/commit/7ce73a7002804f8d18ddb93e82a45cd46b23053d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 54d55f0cd835de0e8b236b8c31e60939b57b69e7
https://github.com/Perl/perl5/commit/54d55f0cd835de0e8b236b8c31e60939b57b69e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: bdf7eee40aededf2411daa44a3ee1c3f683fed4a
https://github.com/Perl/perl5/commit/bdf7eee40aededf2411daa44a3ee1c3f683fed4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 9a589e9e3bd7c8fb653189317a224eaf5ccd700e
https://github.com/Perl/perl5/commit/9a589e9e3bd7c8fb653189317a224eaf5ccd700e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: d6e1985da4ddf2e75fe871541b6a382724be090e
https://github.com/Perl/perl5/commit/d6e1985da4ddf2e75fe871541b6a382724be090e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: d6627d3e6c61f73a0a3bc22aa4918356ce50af0c
https://github.com/Perl/perl5/commit/d6627d3e6c61f73a0a3bc22aa4918356ce50af0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 42327a537d32f040375c348daebe2487321d6fd7
https://github.com/Perl/perl5/commit/42327a537d32f040375c348daebe2487321d6fd7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 8db378eb56577ac299b053321063f270fe252f83
https://github.com/Perl/perl5/commit/8db378eb56577ac299b053321063f270fe252f83
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 43c7dad6eccf88c00dc7221aef49df75b0354d19
https://github.com/Perl/perl5/commit/43c7dad6eccf88c00dc7221aef49df75b0354d19
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 0f7aa774766843f8217db90ef7ea48565320134c
https://github.com/Perl/perl5/commit/0f7aa774766843f8217db90ef7ea48565320134c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 113453282e07d545d0418378a523d9c43de27b0c
https://github.com/Perl/perl5/commit/113453282e07d545d0418378a523d9c43de27b0c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 69d037ac3628a73c0a6c6c9b2da4a972e6cd15a8
https://github.com/Perl/perl5/commit/69d037ac3628a73c0a6c6c9b2da4a972e6cd15a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 8501f8d9fe71fe6c7abd5ff7b012f46755f40754
https://github.com/Perl/perl5/commit/8501f8d9fe71fe6c7abd5ff7b012f46755f40754
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 1b18a668fd1fee24af2ef8160c9c003fb3ee8c4e
https://github.com/Perl/perl5/commit/1b18a668fd1fee24af2ef8160c9c003fb3ee8c4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: c489a1af63bc972173513dacce20c150bbda6ab1
https://github.com/Perl/perl5/commit/c489a1af63bc972173513dacce20c150bbda6ab1
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: aa8bd43b036af66c67d6779b1803f2fab60f952c
https://github.com/Perl/perl5/commit/aa8bd43b036af66c67d6779b1803f2fab60f952c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 5f8a42732ace0196e810f6bb35405e248dbe2883
https://github.com/Perl/perl5/commit/5f8a42732ace0196e810f6bb35405e248dbe2883
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 83a3e46c54d7528d067f371af2e9b228a08b4760
https://github.com/Perl/perl5/commit/83a3e46c54d7528d067f371af2e9b228a08b4760
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: a046dd2c7debfa1cf8b822e544f6d5c4f5b3a2d0
https://github.com/Perl/perl5/commit/a046dd2c7debfa1cf8b822e544f6d5c4f5b3a2d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 6ca2d75814250e1f0e7c8ef9c09a95152e10c876
https://github.com/Perl/perl5/commit/6ca2d75814250e1f0e7c8ef9c09a95152e10c876
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: d02666d4e68d23f68df03a02eb04bf5a3e935ad0
https://github.com/Perl/perl5/commit/d02666d4e68d23f68df03a02eb04bf5a3e935ad0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 8bb47827b73ad077532e499ef8ce79a4898c894d
https://github.com/Perl/perl5/commit/8bb47827b73ad077532e499ef8ce79a4898c894d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: e772915ec76266ec7814d6b318f90f47cb85303b
https://github.com/Perl/perl5/commit/e772915ec76266ec7814d6b318f90f47cb85303b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 37fdd9331b3ac64e2721e30d175d4f534c2244ec
https://github.com/Perl/perl5/commit/37fdd9331b3ac64e2721e30d175d4f534c2244ec
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 19e2ddacc6645c3dd43b4d539c3b14b3a5326e93
https://github.com/Perl/perl5/commit/19e2ddacc6645c3dd43b4d539c3b14b3a5326e93
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 6eaa3f046d9eb713630cecd9ec7be66ccf51203f
https://github.com/Perl/perl5/commit/6eaa3f046d9eb713630cecd9ec7be66ccf51203f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 1db4e1ea34a5afa1f844f208a41a09157bf32a37
https://github.com/Perl/perl5/commit/1db4e1ea34a5afa1f844f208a41a09157bf32a37
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 098bbd46b715c149364fd479cc4d826816c72aff
https://github.com/Perl/perl5/commit/098bbd46b715c149364fd479cc4d826816c72aff
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: c0d93d3496c9994f21e6d57e34c24e2fd4d7b6ce
https://github.com/Perl/perl5/commit/c0d93d3496c9994f21e6d57e34c24e2fd4d7b6ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: d9b2091b485989adbbe815c3ed4c86b8d0adc311
https://github.com/Perl/perl5/commit/d9b2091b485989adbbe815c3ed4c86b8d0adc311
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: a4546032d65dcd25753b3cce1164cea6d07853ef
https://github.com/Perl/perl5/commit/a4546032d65dcd25753b3cce1164cea6d07853ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: e6067cd300d50c62c9cc2dcce316010fcaebd157
https://github.com/Perl/perl5/commit/e6067cd300d50c62c9cc2dcce316010fcaebd157
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: b0f980a5e4b48c4734a1da5e8fc2d5915f3677bd
https://github.com/Perl/perl5/commit/b0f980a5e4b48c4734a1da5e8fc2d5915f3677bd
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 0c6c10ee94a6a8a53c251395f06472135c95e54f
https://github.com/Perl/perl5/commit/0c6c10ee94a6a8a53c251395f06472135c95e54f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 8a4f11d8f8e48c80b2bfb499c4f5ad5c1478fbfd
https://github.com/Perl/perl5/commit/8a4f11d8f8e48c80b2bfb499c4f5ad5c1478fbfd
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 06946ed841c71c962e63c18f3f4fe01ae6739b80
https://github.com/Perl/perl5/commit/06946ed841c71c962e63c18f3f4fe01ae6739b80
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: 68c4a3e3b48bb3603ac6b84e5ce5f8419ec64df7
https://github.com/Perl/perl5/commit/68c4a3e3b48bb3603ac6b84e5ce5f8419ec64df7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: ea9a98269752cc790bbdba774150aa108b83c7ae
https://github.com/Perl/perl5/commit/ea9a98269752cc790bbdba774150aa108b83c7ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 07a9f185f4907fe60ca091655400a692853c2d30
https://github.com/Perl/perl5/commit/07a9f185f4907fe60ca091655400a692853c2d30
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: ad3c420cd39f0d3fbe97fb29fd765508230a9705
https://github.com/Perl/perl5/commit/ad3c420cd39f0d3fbe97fb29fd765508230a9705
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: b671903ad655518645730a98e0d90d2ac3db37bf
https://github.com/Perl/perl5/commit/b671903ad655518645730a98e0d90d2ac3db37bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: a801a65ac9f1f0b9ce8be3ef3085dc9137e9788b
https://github.com/Perl/perl5/commit/a801a65ac9f1f0b9ce8be3ef3085dc9137e9788b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 45f4385fb59fdf3dc9c306b0ed0bdcfdbbe3e9be
https://github.com/Perl/perl5/commit/45f4385fb59fdf3dc9c306b0ed0bdcfdbbe3e9be
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: b9f05f52d692c4a00f63c8045ddd14986fe7c278
https://github.com/Perl/perl5/commit/b9f05f52d692c4a00f63c8045ddd14986fe7c278
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 6f52a11b27a66223a5e5e891b924fd0322c4ac7c
https://github.com/Perl/perl5/commit/6f52a11b27a66223a5e5e891b924fd0322c4ac7c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 71b28ad15824f036f49227ee1cab5f0dd8849649
https://github.com/Perl/perl5/commit/71b28ad15824f036f49227ee1cab5f0dd8849649
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 924d89a6d2b784f0ac4f899fcabe6043067e6ebe
https://github.com/Perl/perl5/commit/924d89a6d2b784f0ac4f899fcabe6043067e6ebe
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 7d270ad3cf6e00db44ccf613343527aba0ed492e
https://github.com/Perl/perl5/commit/7d270ad3cf6e00db44ccf613343527aba0ed492e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 392150dbd054483ef9daca16c54e672675f822ac
https://github.com/Perl/perl5/commit/392150dbd054483ef9daca16c54e672675f822ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 9a1a3fcdb2495801c93c395f6f5c0381611da6da
https://github.com/Perl/perl5/commit/9a1a3fcdb2495801c93c395f6f5c0381611da6da
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 6dde153d2e3aabdc43e0fb8450f72d4ba59a2d93
https://github.com/Perl/perl5/commit/6dde153d2e3aabdc43e0fb8450f72d4ba59a2d93
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 967b082d8114092725196e3cf3ed7baa7dee0560
https://github.com/Perl/perl5/commit/967b082d8114092725196e3cf3ed7baa7dee0560
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 0c9878a5e6035fbdb679aa28be0d53e43cad24f6
https://github.com/Perl/perl5/commit/0c9878a5e6035fbdb679aa28be0d53e43cad24f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 17f141e429072fa3a71a7bf900cf40b015c8010e
https://github.com/Perl/perl5/commit/17f141e429072fa3a71a7bf900cf40b015c8010e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: fdc09e524953bfc1c65c9b3379d9be1d4f3afc87
https://github.com/Perl/perl5/commit/fdc09e524953bfc1c65c9b3379d9be1d4f3afc87
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: cb494752c460c732ce2533be57b413743ae9168d
https://github.com/Perl/perl5/commit/cb494752c460c732ce2533be57b413743ae9168d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 6904c364167996d03a5452d6fefe2418d36d6d4e
https://github.com/Perl/perl5/commit/6904c364167996d03a5452d6fefe2418d36d6d4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 4738514b6ea3e19b9e3b69bdca3bf74adffaa428
https://github.com/Perl/perl5/commit/4738514b6ea3e19b9e3b69bdca3bf74adffaa428
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: f356c0eb357b9bee0f43a7d0d342bba30600e4de
https://github.com/Perl/perl5/commit/f356c0eb357b9bee0f43a7d0d342bba30600e4de
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 03c44713ae8fd1e0619aab1a424a82161ad2906b
https://github.com/Perl/perl5/commit/03c44713ae8fd1e0619aab1a424a82161ad2906b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 159721fa762d5e98d2a6025077c4396536c278d6
https://github.com/Perl/perl5/commit/159721fa762d5e98d2a6025077c4396536c278d6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 98eb69d3f8afe9e345e33b894883dd2204d36627
https://github.com/Perl/perl5/commit/98eb69d3f8afe9e345e33b894883dd2204d36627
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 0d8a682081da87e8323237d94b4bc89ee903723b
https://github.com/Perl/perl5/commit/0d8a682081da87e8323237d94b4bc89ee903723b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: f03a4e2b99f35e8068a7c2b8472c0a70440cb9e9
https://github.com/Perl/perl5/commit/f03a4e2b99f35e8068a7c2b8472c0a70440cb9e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 9e956616e37d8dc4d1b0a5d3c19df1a5f5770bff
https://github.com/Perl/perl5/commit/9e956616e37d8dc4d1b0a5d3c19df1a5f5770bff
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: 15060592af68c3476791d052a52eccf1c4454854
https://github.com/Perl/perl5/commit/15060592af68c3476791d052a52eccf1c4454854
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 12fe2353922a4f5c618452176faa89c045e3e781
https://github.com/Perl/perl5/commit/12fe2353922a4f5c618452176faa89c045e3e781
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: f27f7c9bf499363924ae13ace507d12af2dca87a
https://github.com/Perl/perl5/commit/f27f7c9bf499363924ae13ace507d12af2dca87a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 1ef72e06d4b405586c0b929980a37719019f1d0d
https://github.com/Perl/perl5/commit/1ef72e06d4b405586c0b929980a37719019f1d0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 027a3a6627e3d5679db5f1bdaf5a51b5612e7a83
https://github.com/Perl/perl5/commit/027a3a6627e3d5679db5f1bdaf5a51b5612e7a83
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: e06d788b23c699c1509a9eb5f6809ac35cfdf9af
https://github.com/Perl/perl5/commit/e06d788b23c699c1509a9eb5f6809ac35cfdf9af
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: fa6dbe9719d30a725a76290c8ca96a26a61df93a
https://github.com/Perl/perl5/commit/fa6dbe9719d30a725a76290c8ca96a26a61df93a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 46ceec1345c597bdfe6a2dff2c75090f69924fe8
https://github.com/Perl/perl5/commit/46ceec1345c597bdfe6a2dff2c75090f69924fe8
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: f6df9f3bfbd38391922617eacf7a17f6992f84fb
https://github.com/Perl/perl5/commit/f6df9f3bfbd38391922617eacf7a17f6992f84fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: c0f4b37a786b90678db07e7aa20e052fa168346a
https://github.com/Perl/perl5/commit/c0f4b37a786b90678db07e7aa20e052fa168346a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 091943d6502d1fd7808a348b4411ddc489a83dee
https://github.com/Perl/perl5/commit/091943d6502d1fd7808a348b4411ddc489a83dee
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 9c2bb73968de76f5e3428b61a04d7494c1ff20e0
https://github.com/Perl/perl5/commit/9c2bb73968de76f5e3428b61a04d7494c1ff20e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 74a1a6af10b53a28c50be85499bd549052d2672d
https://github.com/Perl/perl5/commit/74a1a6af10b53a28c50be85499bd549052d2672d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 01f72eb60573f249aebafd95ba3dd0acd684a01f
https://github.com/Perl/perl5/commit/01f72eb60573f249aebafd95ba3dd0acd684a01f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 74ff79b30771f14a980bd8665bd4ed1618c76dae
https://github.com/Perl/perl5/commit/74ff79b30771f14a980bd8665bd4ed1618c76dae
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: f37c6ba6cfd692f1bb287537b7cf2a3e92edfa38
https://github.com/Perl/perl5/commit/f37c6ba6cfd692f1bb287537b7cf2a3e92edfa38
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 9cd54a0623d2ee59bed9b2659dbe74ba07759b74
https://github.com/Perl/perl5/commit/9cd54a0623d2ee59bed9b2659dbe74ba07759b74
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 11a7dd4bfb729a93d5a10de60624ecebdede1b4e
https://github.com/Perl/perl5/commit/11a7dd4bfb729a93d5a10de60624ecebdede1b4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 0916140f14514564ee9f4cd7c39092b2d3cc9171
https://github.com/Perl/perl5/commit/0916140f14514564ee9f4cd7c39092b2d3cc9171
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 53988b79f729e81c50f40efa9e418a4815050ef1
https://github.com/Perl/perl5/commit/53988b79f729e81c50f40efa9e418a4815050ef1
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 5ed21b0741baae7c76d0fd2730f421b15e356c8e
https://github.com/Perl/perl5/commit/5ed21b0741baae7c76d0fd2730f421b15e356c8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 6b9665a1e431527f07be433fde1fd3d9406f86d3
https://github.com/Perl/perl5/commit/6b9665a1e431527f07be433fde1fd3d9406f86d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 2fba2a9b826cdac406a5406ea290f39c49fcff8f
https://github.com/Perl/perl5/commit/2fba2a9b826cdac406a5406ea290f39c49fcff8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 668cf71a2cb824cace1dc5df613e3a20ecf87e2c
https://github.com/Perl/perl5/commit/668cf71a2cb824cace1dc5df613e3a20ecf87e2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 20a52aea6d32b2362992b6e93a09c41e11043bbe
https://github.com/Perl/perl5/commit/20a52aea6d32b2362992b6e93a09c41e11043bbe
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 50041f2eae9946e703d7960b4f628eacdcc48ae6
https://github.com/Perl/perl5/commit/50041f2eae9946e703d7960b4f628eacdcc48ae6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: f3000d83439be1ebfdf373b64ac7b96a6c92aa20
https://github.com/Perl/perl5/commit/f3000d83439be1ebfdf373b64ac7b96a6c92aa20
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 7db11ffe071df7a21f3ec6ac4ed0b388754070ba
https://github.com/Perl/perl5/commit/7db11ffe071df7a21f3ec6ac4ed0b388754070ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: df7895afce04d9b427567f532f892f333a24fa18
https://github.com/Perl/perl5/commit/df7895afce04d9b427567f532f892f333a24fa18
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 274e7412c4771a61ebbff5e20bce9e5c71057216
https://github.com/Perl/perl5/commit/274e7412c4771a61ebbff5e20bce9e5c71057216
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: 760feedc79892f1cc3ff8bd14e1efe68a37eb413
https://github.com/Perl/perl5/commit/760feedc79892f1cc3ff8bd14e1efe68a37eb413
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 39b07d1b97bff9338126c9df9e9738bf93fffbd3
https://github.com/Perl/perl5/commit/39b07d1b97bff9338126c9df9e9738bf93fffbd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: f8bda36c4f002e16b20d0ba4a857cdcb8b0e57a7
https://github.com/Perl/perl5/commit/f8bda36c4f002e16b20d0ba4a857cdcb8b0e57a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 9a0662bdba288d2938aec815671880e910364b60
https://github.com/Perl/perl5/commit/9a0662bdba288d2938aec815671880e910364b60
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: f108c22f30791348e49eb9030866cedd4290eb9b
https://github.com/Perl/perl5/commit/f108c22f30791348e49eb9030866cedd4290eb9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: ca432bbce0ad42c92f0cb79c977483d60f37cec2
https://github.com/Perl/perl5/commit/ca432bbce0ad42c92f0cb79c977483d60f37cec2
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: f3b6d798be5a173c842a4348e736bdbdb1686c06
https://github.com/Perl/perl5/commit/f3b6d798be5a173c842a4348e736bdbdb1686c06
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 36c7ad05f838ccd7772266651c067467ee7744fc
https://github.com/Perl/perl5/commit/36c7ad05f838ccd7772266651c067467ee7744fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 0df9cc0ee69c2435df6cfebc1eca16ece423ff42
https://github.com/Perl/perl5/commit/0df9cc0ee69c2435df6cfebc1eca16ece423ff42
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: f938dda3f7cec4ed03a7bb4add28340942858048
https://github.com/Perl/perl5/commit/f938dda3f7cec4ed03a7bb4add28340942858048
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 794a94342dbfbae86f3e4891bdb63a2e14bdb82b
https://github.com/Perl/perl5/commit/794a94342dbfbae86f3e4891bdb63a2e14bdb82b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: ce79ed678e0233f5e07e212cb43489876a6f5c65
https://github.com/Perl/perl5/commit/ce79ed678e0233f5e07e212cb43489876a6f5c65
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: d8215fdec434731545cc555f6ef6584dcdd50ff4
https://github.com/Perl/perl5/commit/d8215fdec434731545cc555f6ef6584dcdd50ff4
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 7782ea0f6fefa0e108f726347ee348a91616e414
https://github.com/Perl/perl5/commit/7782ea0f6fefa0e108f726347ee348a91616e414
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 5c1d6a0129ddc97aadea97601e23e399f30b071e
https://github.com/Perl/perl5/commit/5c1d6a0129ddc97aadea97601e23e399f30b071e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 6c2a002ad3c2df83b6659479720aab142ce7bded
https://github.com/Perl/perl5/commit/6c2a002ad3c2df83b6659479720aab142ce7bded
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 28e3c62bcf7e62675e1cb67c7ff3eb547f3a49eb
https://github.com/Perl/perl5/commit/28e3c62bcf7e62675e1cb67c7ff3eb547f3a49eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: afd7588ee48115ff61e5cf913c257931c6afe1ed
https://github.com/Perl/perl5/commit/afd7588ee48115ff61e5cf913c257931c6afe1ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 26931ead46ba4791552612958a6dd790d755c146
https://github.com/Perl/perl5/commit/26931ead46ba4791552612958a6dd790d755c146
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: db1017b34ab21f38a0f648f0826a7836272844d1
https://github.com/Perl/perl5/commit/db1017b34ab21f38a0f648f0826a7836272844d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 271cb9b8b1853d45ba9f9bcaa33a5570f026bf15
https://github.com/Perl/perl5/commit/271cb9b8b1853d45ba9f9bcaa33a5570f026bf15
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 395e9b0e42276b4f6a19b7e1057896d783cd99cd
https://github.com/Perl/perl5/commit/395e9b0e42276b4f6a19b7e1057896d783cd99cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 11f22b7ddf336ab0261e97842c5687a6f8065883
https://github.com/Perl/perl5/commit/11f22b7ddf336ab0261e97842c5687a6f8065883
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: ca515663653cc93c945532ca7c1cbcd2c589c9c9
https://github.com/Perl/perl5/commit/ca515663653cc93c945532ca7c1cbcd2c589c9c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: e9e2b4b0c65d4912dde838f5c2179432f3644f13
https://github.com/Perl/perl5/commit/e9e2b4b0c65d4912dde838f5c2179432f3644f13
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 3d04b1210ba955e08a36963d982c187993fb8bf1
https://github.com/Perl/perl5/commit/3d04b1210ba955e08a36963d982c187993fb8bf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 692632a8cb2d86a5444bce18e787f9a88419a52e
https://github.com/Perl/perl5/commit/692632a8cb2d86a5444bce18e787f9a88419a52e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: d6c914528b4188f02b634a6916654b025229c274
https://github.com/Perl/perl5/commit/d6c914528b4188f02b634a6916654b025229c274
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 719b35ff7751b41dcf96d74a097de341219e1967
https://github.com/Perl/perl5/commit/719b35ff7751b41dcf96d74a097de341219e1967
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: cb7c27ae0d4efa1419b7647ba4159896d9e17ca5
https://github.com/Perl/perl5/commit/cb7c27ae0d4efa1419b7647ba4159896d9e17ca5
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 1b5d25c59df189b32bb6eaf5333d4a8f9c59a6e5
https://github.com/Perl/perl5/commit/1b5d25c59df189b32bb6eaf5333d4a8f9c59a6e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: a41627e109ccc1bc250f1fbf3c02c48f13980917
https://github.com/Perl/perl5/commit/a41627e109ccc1bc250f1fbf3c02c48f13980917
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 73c8706bb8931022774a6497f789ab6d70f7fb04
https://github.com/Perl/perl5/commit/73c8706bb8931022774a6497f789ab6d70f7fb04
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 90dd8f2cf3fa0afba5ddfefb52f77c9bc3b6fbf1
https://github.com/Perl/perl5/commit/90dd8f2cf3fa0afba5ddfefb52f77c9bc3b6fbf1
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 040115248ff5c11c312ed5668c279b66af9cc6f2
https://github.com/Perl/perl5/commit/040115248ff5c11c312ed5668c279b66af9cc6f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: bb4df8e49e6a5f5b8da5f24ab733d23f76582cec
https://github.com/Perl/perl5/commit/bb4df8e49e6a5f5b8da5f24ab733d23f76582cec
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: e246be4cc7acf93a9b08d6e02b3bd40425b0eb21
https://github.com/Perl/perl5/commit/e246be4cc7acf93a9b08d6e02b3bd40425b0eb21
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: de8c50836fb16e08e9d0f16aba86604ba176e94b
https://github.com/Perl/perl5/commit/de8c50836fb16e08e9d0f16aba86604ba176e94b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: af5862ab49af481b63263bc215134e3455ff9da9
https://github.com/Perl/perl5/commit/af5862ab49af481b63263bc215134e3455ff9da9
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 7a2bdde276de92a72e9912412978164a3be59235
https://github.com/Perl/perl5/commit/7a2bdde276de92a72e9912412978164a3be59235
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: b49cc9d7697a9d3b102268251a2b59c3d8a7d579
https://github.com/Perl/perl5/commit/b49cc9d7697a9d3b102268251a2b59c3d8a7d579
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: cf48e61cdd7c140f6c65c0352312ae479e9138b0
https://github.com/Perl/perl5/commit/cf48e61cdd7c140f6c65c0352312ae479e9138b0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: d1e46f118d50a2bdbd4554c697aeb08354726e34
https://github.com/Perl/perl5/commit/d1e46f118d50a2bdbd4554c697aeb08354726e34
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: ed880819857e221191a62239c51666a487ce2c09
https://github.com/Perl/perl5/commit/ed880819857e221191a62239c51666a487ce2c09
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: c45f7cb587cdb128f20043cb37e2a56eddad9e45
https://github.com/Perl/perl5/commit/c45f7cb587cdb128f20043cb37e2a56eddad9e45
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 790be248c887ff37f823bbad147df59957872ba6
https://github.com/Perl/perl5/commit/790be248c887ff37f823bbad147df59957872ba6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 29aa2a691f81240909bdd393b8ec6ff996433e09
https://github.com/Perl/perl5/commit/29aa2a691f81240909bdd393b8ec6ff996433e09
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 8058f536f4fb418713c7f05ffd690f48c7cd2b5a
https://github.com/Perl/perl5/commit/8058f536f4fb418713c7f05ffd690f48c7cd2b5a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 13204e2a978a62f70965074468b41e3ebbbb7d93
https://github.com/Perl/perl5/commit/13204e2a978a62f70965074468b41e3ebbbb7d93
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 27e556183f57dd2581ad976f5bbf5329fa6de34e
https://github.com/Perl/perl5/commit/27e556183f57dd2581ad976f5bbf5329fa6de34e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: d4c46d3582b1c22172f212efee6c8c9c7e682c33
https://github.com/Perl/perl5/commit/d4c46d3582b1c22172f212efee6c8c9c7e682c33
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 40577b017bf3d3ec11fa1ec1ef42355c1757ed56
https://github.com/Perl/perl5/commit/40577b017bf3d3ec11fa1ec1ef42355c1757ed56
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: b72325f616b981e02019971f330d2c8af1b4bef3
https://github.com/Perl/perl5/commit/b72325f616b981e02019971f330d2c8af1b4bef3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 3b2e4ec30e61f723caa1fb304478aaab1406485a
https://github.com/Perl/perl5/commit/3b2e4ec30e61f723caa1fb304478aaab1406485a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 990ea1143f983cd55b6e212f4b301524b564701d
https://github.com/Perl/perl5/commit/990ea1143f983cd55b6e212f4b301524b564701d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 7bce137966d44cbb6a35bb0e6ffb79b7a0eefe9a
https://github.com/Perl/perl5/commit/7bce137966d44cbb6a35bb0e6ffb79b7a0eefe9a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: b41b7f6b9ec22825fed435785e5f8dc38c6683aa
https://github.com/Perl/perl5/commit/b41b7f6b9ec22825fed435785e5f8dc38c6683aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 0f854073e0bcf940008e2ba392416f45b08ccfa9
https://github.com/Perl/perl5/commit/0f854073e0bcf940008e2ba392416f45b08ccfa9
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: e5d41b7e7e9a9ad4a5495eaeb5dcf6964a931315
https://github.com/Perl/perl5/commit/e5d41b7e7e9a9ad4a5495eaeb5dcf6964a931315
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 4de8d424e4641451b67651c68f781aa4489328fd
https://github.com/Perl/perl5/commit/4de8d424e4641451b67651c68f781aa4489328fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 745c52f2b0760f975324ea503724f8482bb963b4
https://github.com/Perl/perl5/commit/745c52f2b0760f975324ea503724f8482bb963b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: fcc8fe2bd0516080ec3dedf8a55b352be65f7e57
https://github.com/Perl/perl5/commit/fcc8fe2bd0516080ec3dedf8a55b352be65f7e57
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 7039f96d9633406e1a3242211aee69ac738dc097
https://github.com/Perl/perl5/commit/7039f96d9633406e1a3242211aee69ac738dc097
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: fe8b764c8027baad7c5f34323a1bd141a1ce570e
https://github.com/Perl/perl5/commit/fe8b764c8027baad7c5f34323a1bd141a1ce570e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 7ce54c176713f21b12b409a57066900401ce191d
https://github.com/Perl/perl5/commit/7ce54c176713f21b12b409a57066900401ce191d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 1371e4ed968f00b6edcca5804145cce2792c7363
https://github.com/Perl/perl5/commit/1371e4ed968f00b6edcca5804145cce2792c7363
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: b7ecf6c6632f38fd461936961b29336879796e5f
https://github.com/Perl/perl5/commit/b7ecf6c6632f38fd461936961b29336879796e5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 6221c9956b09360021113d90a1209ebb7799d8eb
https://github.com/Perl/perl5/commit/6221c9956b09360021113d90a1209ebb7799d8eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 87e0aa55d78376ac7a9c02cb76efc7047ae74da5
https://github.com/Perl/perl5/commit/87e0aa55d78376ac7a9c02cb76efc7047ae74da5
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 944c7efcd80b62d3573591a22ad2e5758a155216
https://github.com/Perl/perl5/commit/944c7efcd80b62d3573591a22ad2e5758a155216
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: d8ae7955403f640f83bace5013a47115c774059b
https://github.com/Perl/perl5/commit/d8ae7955403f640f83bace5013a47115c774059b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: cd1b7651841bb85ed0406c532c7e21d558941fdf
https://github.com/Perl/perl5/commit/cd1b7651841bb85ed0406c532c7e21d558941fdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: fd9485eebf8f1909ec47abb367d2c140145387bf
https://github.com/Perl/perl5/commit/fd9485eebf8f1909ec47abb367d2c140145387bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 7a9129cff583812e20b6b207ada475842f1fe5e0
https://github.com/Perl/perl5/commit/7a9129cff583812e20b6b207ada475842f1fe5e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: b0af6cde06963231d31e562e4cb14e08b21f0b11
https://github.com/Perl/perl5/commit/b0af6cde06963231d31e562e4cb14e08b21f0b11
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 649659fd79f9ede6660c7ca6bd125eef9033a820
https://github.com/Perl/perl5/commit/649659fd79f9ede6660c7ca6bd125eef9033a820
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: e32788eb07aaa831fef9850b3e4288ad920d7e81
https://github.com/Perl/perl5/commit/e32788eb07aaa831fef9850b3e4288ad920d7e81
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 8611267b7a63fd15478773b23d5713b72a4b3972
https://github.com/Perl/perl5/commit/8611267b7a63fd15478773b23d5713b72a4b3972
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: f4dcc19666ba19ba66ea50d20d12354c82885310
https://github.com/Perl/perl5/commit/f4dcc19666ba19ba66ea50d20d12354c82885310
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 985ad6a61aea3c885c5fdce824e4358909d94c2d
https://github.com/Perl/perl5/commit/985ad6a61aea3c885c5fdce824e4358909d94c2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: e7631c520bafd9f2f6819ae15840b07efae0b241
https://github.com/Perl/perl5/commit/e7631c520bafd9f2f6819ae15840b07efae0b241
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 31c7cf9f81a4dd01c8fadcb6198ad0f808dc608e
https://github.com/Perl/perl5/commit/31c7cf9f81a4dd01c8fadcb6198ad0f808dc608e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 56c677e1171fc10d5076c9bb2f556a1f6c016a03
https://github.com/Perl/perl5/commit/56c677e1171fc10d5076c9bb2f556a1f6c016a03
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: ed6d9deac6a84d8bcb2de5327e9837787d0f446d
https://github.com/Perl/perl5/commit/ed6d9deac6a84d8bcb2de5327e9837787d0f446d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: afed9bbf825097b9bf68fd82dc4f8c7cb7e4cc62
https://github.com/Perl/perl5/commit/afed9bbf825097b9bf68fd82dc4f8c7cb7e4cc62
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 2d34a03e2e28976ff664e0a797601d0595498100
https://github.com/Perl/perl5/commit/2d34a03e2e28976ff664e0a797601d0595498100
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 2b1728e020b905ac531142fe6edd3f7e25e0e4bf
https://github.com/Perl/perl5/commit/2b1728e020b905ac531142fe6edd3f7e25e0e4bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 8a8213807165d9350171354ffae68a5e08e4c930
https://github.com/Perl/perl5/commit/8a8213807165d9350171354ffae68a5e08e4c930
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: dcd8bc7d5d456de6a2414f0577c07db7c2bb9778
https://github.com/Perl/perl5/commit/dcd8bc7d5d456de6a2414f0577c07db7c2bb9778
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: a229aec4911f7977c2cbe4235c30d280bb36d2cf
https://github.com/Perl/perl5/commit/a229aec4911f7977c2cbe4235c30d280bb36d2cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 6bb43d6aee2d51adb8160c3623a48a65b5120997
https://github.com/Perl/perl5/commit/6bb43d6aee2d51adb8160c3623a48a65b5120997
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 3763b9bb67606dc41f73248e723139197d627162
https://github.com/Perl/perl5/commit/3763b9bb67606dc41f73248e723139197d627162
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 063fe0b9bab19dfc4f98b2c90dcd8c235d2c68d0
https://github.com/Perl/perl5/commit/063fe0b9bab19dfc4f98b2c90dcd8c235d2c68d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: ef46c920705f3c7fb5fcab64156aa5c7d162fc96
https://github.com/Perl/perl5/commit/ef46c920705f3c7fb5fcab64156aa5c7d162fc96
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: cad095ee3777146b5d8d982348dc8419e4800e45
https://github.com/Perl/perl5/commit/cad095ee3777146b5d8d982348dc8419e4800e45
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 22cce721448491c320fc884b8ce031f5723da0af
https://github.com/Perl/perl5/commit/22cce721448491c320fc884b8ce031f5723da0af
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 8e14fa010566d86347a0521a4a19b85e8b65e663
https://github.com/Perl/perl5/commit/8e14fa010566d86347a0521a4a19b85e8b65e663
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 83e7ae81015b2fab36e1ced6f9a49d23ec0a190c
https://github.com/Perl/perl5/commit/83e7ae81015b2fab36e1ced6f9a49d23ec0a190c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: fb2b532f6e64c1ee66abfaf7883bf966a8151c51
https://github.com/Perl/perl5/commit/fb2b532f6e64c1ee66abfaf7883bf966a8151c51
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 16f0977ae43f533679a2c0dfe521c997aaef8579
https://github.com/Perl/perl5/commit/16f0977ae43f533679a2c0dfe521c997aaef8579
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: 5de3c51fa8fdf455146c187bfe2a73c99ea3a4a8
https://github.com/Perl/perl5/commit/5de3c51fa8fdf455146c187bfe2a73c99ea3a4a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 38f53eb77d2af54446c3ce2b17fa9d66814d0dfa
https://github.com/Perl/perl5/commit/38f53eb77d2af54446c3ce2b17fa9d66814d0dfa
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: eed073681ced2af292bde8e6fff6e4b547b41a7d
https://github.com/Perl/perl5/commit/eed073681ced2af292bde8e6fff6e4b547b41a7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 25ddf502c676f4b0eaeadb89bdc3d3db58e6d1ac
https://github.com/Perl/perl5/commit/25ddf502c676f4b0eaeadb89bdc3d3db58e6d1ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: cc3ab90601a2ad7a197c0a56438bf7ead69cbc07
https://github.com/Perl/perl5/commit/cc3ab90601a2ad7a197c0a56438bf7ead69cbc07
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 1b09cc8db3d654a0a4b0e634dea3ca9d0bc3c213
https://github.com/Perl/perl5/commit/1b09cc8db3d654a0a4b0e634dea3ca9d0bc3c213
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 6d91faf7b084d04f1718c2e4821fc28f421574c6
https://github.com/Perl/perl5/commit/6d91faf7b084d04f1718c2e4821fc28f421574c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: c3e20260086be622b2c4d0f4f3a40fb57908cae2
https://github.com/Perl/perl5/commit/c3e20260086be622b2c4d0f4f3a40fb57908cae2
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: c97117fe9c5cb5e770d6152fb43d5540f5b574de
https://github.com/Perl/perl5/commit/c97117fe9c5cb5e770d6152fb43d5540f5b574de
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: dc7da6909c6aafe366af4e5a402c45b0e65e49c7
https://github.com/Perl/perl5/commit/dc7da6909c6aafe366af4e5a402c45b0e65e49c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 14fd18aa6b50d3e638f50d421473a39c49dceea2
https://github.com/Perl/perl5/commit/14fd18aa6b50d3e638f50d421473a39c49dceea2
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 99b82ec034e1b5f704230654ba4ee8eda59fdded
https://github.com/Perl/perl5/commit/99b82ec034e1b5f704230654ba4ee8eda59fdded
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 12faa8cf6e80392af2c205a815d4b430eacdcc52
https://github.com/Perl/perl5/commit/12faa8cf6e80392af2c205a815d4b430eacdcc52
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 99fa9c8ba695e36345bba83b26d009c50e967c05
https://github.com/Perl/perl5/commit/99fa9c8ba695e36345bba83b26d009c50e967c05
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: 8d6a9569fd39d243eca8b175c7e741066c5bd53f
https://github.com/Perl/perl5/commit/8d6a9569fd39d243eca8b175c7e741066c5bd53f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 502a11f456af0d6ae9f55a5e40131962e90d69b8
https://github.com/Perl/perl5/commit/502a11f456af0d6ae9f55a5e40131962e90d69b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: ee142928c9c11ba1ae87c0f6b4c8381aba9f4cef
https://github.com/Perl/perl5/commit/ee142928c9c11ba1ae87c0f6b4c8381aba9f4cef
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 7b7ca1c35afc3e9a2f24422f9014a19ff8689af2
https://github.com/Perl/perl5/commit/7b7ca1c35afc3e9a2f24422f9014a19ff8689af2
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 01f950571c5cb695774452b3ad1fbc0dd4cd9d2a
https://github.com/Perl/perl5/commit/01f950571c5cb695774452b3ad1fbc0dd4cd9d2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 6b693ce2b6e030aa8af3bf16e6c8a06fe6a8005e
https://github.com/Perl/perl5/commit/6b693ce2b6e030aa8af3bf16e6c8a06fe6a8005e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 4700ff8adafdeff181cc730d745c073053478f2c
https://github.com/Perl/perl5/commit/4700ff8adafdeff181cc730d745c073053478f2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: bcb18525f6d1ffe093fd440b385b9d1dfabc3551
https://github.com/Perl/perl5/commit/bcb18525f6d1ffe093fd440b385b9d1dfabc3551
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 792c8edfec784fa1a396a014a7497b1dfcfc2d68
https://github.com/Perl/perl5/commit/792c8edfec784fa1a396a014a7497b1dfcfc2d68
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: f0d8ce176c4b691b93734e9c029653c78092a0be
https://github.com/Perl/perl5/commit/f0d8ce176c4b691b93734e9c029653c78092a0be
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: aa51291be0f4a0dba747c455f797d0d6e77c6668
https://github.com/Perl/perl5/commit/aa51291be0f4a0dba747c455f797d0d6e77c6668
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: d5e205c5047caa5b4afabc9cdcc324be1d9847ea
https://github.com/Perl/perl5/commit/d5e205c5047caa5b4afabc9cdcc324be1d9847ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
41
Commit: 38a14e31b1d5218d4eae3256b1fe93353642e493
https://github.com/Perl/perl5/commit/38a14e31b1d5218d4eae3256b1fe93353642e493
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
M t/loc_tools.pl
Log Message:
-----------
42
Compare: https://github.com/Perl/perl5/compare/999fc27f7b0a...38a14e31b1d5
