Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: ca3eb5af3337ad7ff18112d9d3ff3910cca6ba20
https://github.com/Perl/perl5/commit/ca3eb5af3337ad7ff18112d9d3ff3910cca6ba20
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: f9690baa41a708c540e662e2a4a994a49a093e2c
https://github.com/Perl/perl5/commit/f9690baa41a708c540e662e2a4a994a49a093e2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 6c1004b5b8082441f66f99f2bc6cd143863a7c9b
https://github.com/Perl/perl5/commit/6c1004b5b8082441f66f99f2bc6cd143863a7c9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: ccabf6bf6a3c9a675d945090f8cd22e52f2949fb
https://github.com/Perl/perl5/commit/ccabf6bf6a3c9a675d945090f8cd22e52f2949fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: e22a1b27554e93ecf1bd22730462d30fc488bfe9
https://github.com/Perl/perl5/commit/e22a1b27554e93ecf1bd22730462d30fc488bfe9
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 6fd286ec421d29fdc6970299fc8087b6260d8a79
https://github.com/Perl/perl5/commit/6fd286ec421d29fdc6970299fc8087b6260d8a79
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 3b010f3d399bc7e3fbebbab2a64d83cea700df42
https://github.com/Perl/perl5/commit/3b010f3d399bc7e3fbebbab2a64d83cea700df42
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: a9548f5fdd1c1edaad3705191ee9735aca3be01c
https://github.com/Perl/perl5/commit/a9548f5fdd1c1edaad3705191ee9735aca3be01c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: f7be5df0f5462217dfd8f0a92d0d5293d433d477
https://github.com/Perl/perl5/commit/f7be5df0f5462217dfd8f0a92d0d5293d433d477
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 4077841addc34baec137435bacc369bc02fe7323
https://github.com/Perl/perl5/commit/4077841addc34baec137435bacc369bc02fe7323
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 4f1ad1f08ebf91363bc3af04d0a16acccf461d6f
https://github.com/Perl/perl5/commit/4f1ad1f08ebf91363bc3af04d0a16acccf461d6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 6e5658cff631a4266417e8e64b226a370982da55
https://github.com/Perl/perl5/commit/6e5658cff631a4266417e8e64b226a370982da55
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 91bdb287bc63fd7b2619f97f3db44a6d04af4f4a
https://github.com/Perl/perl5/commit/91bdb287bc63fd7b2619f97f3db44a6d04af4f4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: e63c230b7c3da2365870b962b1f12d8faa9fe62e
https://github.com/Perl/perl5/commit/e63c230b7c3da2365870b962b1f12d8faa9fe62e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: 98f672df91323b25d2b8aaf49a24d1212a4b387d
https://github.com/Perl/perl5/commit/98f672df91323b25d2b8aaf49a24d1212a4b387d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: c590dacbca3259bcc72ec0bfa3b5cec6828aa20a
https://github.com/Perl/perl5/commit/c590dacbca3259bcc72ec0bfa3b5cec6828aa20a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 3ad424031273e8521f44fa06bfed04949541b968
https://github.com/Perl/perl5/commit/3ad424031273e8521f44fa06bfed04949541b968
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 206e840b53619f2a491232f99a80590f9de0a065
https://github.com/Perl/perl5/commit/206e840b53619f2a491232f99a80590f9de0a065
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 8ef16b7b0462a56bc1b400487a05ea544b48bbce
https://github.com/Perl/perl5/commit/8ef16b7b0462a56bc1b400487a05ea544b48bbce
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: db6a32419e66b37a96e27c5840ef54f570ac64be
https://github.com/Perl/perl5/commit/db6a32419e66b37a96e27c5840ef54f570ac64be
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: c2327e0d2150d31d46ea1eae373ea471692a43e3
https://github.com/Perl/perl5/commit/c2327e0d2150d31d46ea1eae373ea471692a43e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 361f7a76977f5ef1c9e232cce5482d1ea5ed3375
https://github.com/Perl/perl5/commit/361f7a76977f5ef1c9e232cce5482d1ea5ed3375
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 541a05ebad4d031c69a955e81d07545d293dc461
https://github.com/Perl/perl5/commit/541a05ebad4d031c69a955e81d07545d293dc461
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 267edcac30ac1ce6feeaa58840f52acc9dd06434
https://github.com/Perl/perl5/commit/267edcac30ac1ce6feeaa58840f52acc9dd06434
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: ff4dfacff21ddcc8148f771baa4d4e6c987a7779
https://github.com/Perl/perl5/commit/ff4dfacff21ddcc8148f771baa4d4e6c987a7779
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: ba6984e3311a37924e0d69febdf4a1822265c03a
https://github.com/Perl/perl5/commit/ba6984e3311a37924e0d69febdf4a1822265c03a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: a53f3762405ec3a41d92dd3b99199266f7f713fd
https://github.com/Perl/perl5/commit/a53f3762405ec3a41d92dd3b99199266f7f713fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 8dca759dc293227df036d147cb9584dfda2de605
https://github.com/Perl/perl5/commit/8dca759dc293227df036d147cb9584dfda2de605
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: e7e3645e8807cae7b18c6b2d05742bf05ba73482
https://github.com/Perl/perl5/commit/e7e3645e8807cae7b18c6b2d05742bf05ba73482
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 897f63cb69ced855a62ee5648d1722b8dc7e9fcc
https://github.com/Perl/perl5/commit/897f63cb69ced855a62ee5648d1722b8dc7e9fcc
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: b17ee953b332a96a1b7866cd14fea06eb644278e
https://github.com/Perl/perl5/commit/b17ee953b332a96a1b7866cd14fea06eb644278e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: be0da1c66fff372319de32d478ca4a393cc8d6ed
https://github.com/Perl/perl5/commit/be0da1c66fff372319de32d478ca4a393cc8d6ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 183880232b866d8be5fa4b30de63ec6bbe183a88
https://github.com/Perl/perl5/commit/183880232b866d8be5fa4b30de63ec6bbe183a88
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 869c3f52410e7cb547754af56cda7dd216b209d9
https://github.com/Perl/perl5/commit/869c3f52410e7cb547754af56cda7dd216b209d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: b2b236bb4dc5915b58becd938ad2d4238fa755f4
https://github.com/Perl/perl5/commit/b2b236bb4dc5915b58becd938ad2d4238fa755f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: d591741474128ec27c9263fc0b0f1556873ec098
https://github.com/Perl/perl5/commit/d591741474128ec27c9263fc0b0f1556873ec098
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 9c2b3e9077d03164b30e3fdcdf1d3d4270c6e697
https://github.com/Perl/perl5/commit/9c2b3e9077d03164b30e3fdcdf1d3d4270c6e697
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: d6791cc5de66b466f1fd8a4fa18e34848915b71d
https://github.com/Perl/perl5/commit/d6791cc5de66b466f1fd8a4fa18e34848915b71d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: f5d2c345904ea4d5730d5a9a9698da7b0788eaa6
https://github.com/Perl/perl5/commit/f5d2c345904ea4d5730d5a9a9698da7b0788eaa6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: 8a127b306ba2eea466aec094ded819b881cfed04
https://github.com/Perl/perl5/commit/8a127b306ba2eea466aec094ded819b881cfed04
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 07aa436f23585f8e313b41a26453d2a4330599e6
https://github.com/Perl/perl5/commit/07aa436f23585f8e313b41a26453d2a4330599e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 31833f629ccd04f4d91cbc9fd5285bde73ea7bd5
https://github.com/Perl/perl5/commit/31833f629ccd04f4d91cbc9fd5285bde73ea7bd5
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 131cd8389e3c84a9a41de190082a9e5b76890fdf
https://github.com/Perl/perl5/commit/131cd8389e3c84a9a41de190082a9e5b76890fdf
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 69668bb125992b3681511aee259c3a0e33badf4a
https://github.com/Perl/perl5/commit/69668bb125992b3681511aee259c3a0e33badf4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 955d51b6fbce22abf20d4cf5977d5b4aec72c348
https://github.com/Perl/perl5/commit/955d51b6fbce22abf20d4cf5977d5b4aec72c348
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 71c08af8a5ae90b9bee03f4a54f8e58e61033384
https://github.com/Perl/perl5/commit/71c08af8a5ae90b9bee03f4a54f8e58e61033384
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: b4e86958c6c6a5804782fd4af3be9cb7d0c701de
https://github.com/Perl/perl5/commit/b4e86958c6c6a5804782fd4af3be9cb7d0c701de
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 324a7e39e159d06a267a2fcea3a5b707be16ec40
https://github.com/Perl/perl5/commit/324a7e39e159d06a267a2fcea3a5b707be16ec40
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 5c46f7dd0216f51869d8ec935eb4d0fe9377cd5b
https://github.com/Perl/perl5/commit/5c46f7dd0216f51869d8ec935eb4d0fe9377cd5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: c624ed07b423b5b19c5b747fc3732c0b4d65abed
https://github.com/Perl/perl5/commit/c624ed07b423b5b19c5b747fc3732c0b4d65abed
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 79f0369375fcb38c24161c8dc1a4e62501baed4e
https://github.com/Perl/perl5/commit/79f0369375fcb38c24161c8dc1a4e62501baed4e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 6804e49188b6443b3e7ab553ed6fa6abb2e4992f
https://github.com/Perl/perl5/commit/6804e49188b6443b3e7ab553ed6fa6abb2e4992f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: 720d57db4f44837eb0eace0ab9acdad7b10bb6e7
https://github.com/Perl/perl5/commit/720d57db4f44837eb0eace0ab9acdad7b10bb6e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 318f558005b2773c9c917c3e2e13af267b2e2999
https://github.com/Perl/perl5/commit/318f558005b2773c9c917c3e2e13af267b2e2999
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: c3c8340948e9f5059e7efad6dc5e94610e6973e5
https://github.com/Perl/perl5/commit/c3c8340948e9f5059e7efad6dc5e94610e6973e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: be824db5acff3adaab85a8fee370eaf00ee73ffc
https://github.com/Perl/perl5/commit/be824db5acff3adaab85a8fee370eaf00ee73ffc
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 645d21184a67c5418473140d2033ba3339d3f57e
https://github.com/Perl/perl5/commit/645d21184a67c5418473140d2033ba3339d3f57e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: 59cca5f238864b344967bb8ab5fed56950bcb6ff
https://github.com/Perl/perl5/commit/59cca5f238864b344967bb8ab5fed56950bcb6ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 1f3d48211f0f57f0a7db952290320b1b743b4f4d
https://github.com/Perl/perl5/commit/1f3d48211f0f57f0a7db952290320b1b743b4f4d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 463105f5870b02eac3de34175aba24d5952f524b
https://github.com/Perl/perl5/commit/463105f5870b02eac3de34175aba24d5952f524b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 5218f09d29ec0a67529fc1282a6b7869281c751d
https://github.com/Perl/perl5/commit/5218f09d29ec0a67529fc1282a6b7869281c751d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 7909064934313f14bcad42eb100ac4356c106f2e
https://github.com/Perl/perl5/commit/7909064934313f14bcad42eb100ac4356c106f2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 05b2788d42ff2109aab54f393e76760e6b8d8c38
https://github.com/Perl/perl5/commit/05b2788d42ff2109aab54f393e76760e6b8d8c38
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 5d5d3ab1b20f72f1c972c6b02c8ab08d67412bc0
https://github.com/Perl/perl5/commit/5d5d3ab1b20f72f1c972c6b02c8ab08d67412bc0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 851c6b2b9bc53a98af1968e07a8504a8a517307e
https://github.com/Perl/perl5/commit/851c6b2b9bc53a98af1968e07a8504a8a517307e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 5c0a9bf548877a9e346aad0bcea8559b4284fb86
https://github.com/Perl/perl5/commit/5c0a9bf548877a9e346aad0bcea8559b4284fb86
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: fec575aab28d1453f5974d53cc17236a0cf75440
https://github.com/Perl/perl5/commit/fec575aab28d1453f5974d53cc17236a0cf75440
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 8c89eaddff936fc1f98987876b8ca0fc14ce7886
https://github.com/Perl/perl5/commit/8c89eaddff936fc1f98987876b8ca0fc14ce7886
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: e5cf9c874dd088e45e83ace3549242792ea1c6a3
https://github.com/Perl/perl5/commit/e5cf9c874dd088e45e83ace3549242792ea1c6a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: d8248310f8e21789acd29c6ae23b311c7b078e5c
https://github.com/Perl/perl5/commit/d8248310f8e21789acd29c6ae23b311c7b078e5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: d2e727fc2b907c01db0fa27416401f8a613911a8
https://github.com/Perl/perl5/commit/d2e727fc2b907c01db0fa27416401f8a613911a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: cbf14467db89d42ff0077b441247b46930418eca
https://github.com/Perl/perl5/commit/cbf14467db89d42ff0077b441247b46930418eca
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 1e72800b19b29366b84b61253df8efaf7b546eb5
https://github.com/Perl/perl5/commit/1e72800b19b29366b84b61253df8efaf7b546eb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 19f05410fe4b754d29470cd5f3ed1b4efe98f548
https://github.com/Perl/perl5/commit/19f05410fe4b754d29470cd5f3ed1b4efe98f548
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: 5b014d2c3295100420ed5992e4afdc0449e52b5b
https://github.com/Perl/perl5/commit/5b014d2c3295100420ed5992e4afdc0449e52b5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 620018a376a70a8a2f132963fddf8a28e1540590
https://github.com/Perl/perl5/commit/620018a376a70a8a2f132963fddf8a28e1540590
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 4b0208c114473338b3f1986fab14247d7ddf1160
https://github.com/Perl/perl5/commit/4b0208c114473338b3f1986fab14247d7ddf1160
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 553d54271c12d534a44e0d6a1cfa043a2c77335b
https://github.com/Perl/perl5/commit/553d54271c12d534a44e0d6a1cfa043a2c77335b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 5aa6b6166174eebe79625abfca65affc274e2dfa
https://github.com/Perl/perl5/commit/5aa6b6166174eebe79625abfca65affc274e2dfa
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: 11f7c857d3dd8d7e623835217665f43e193e0944
https://github.com/Perl/perl5/commit/11f7c857d3dd8d7e623835217665f43e193e0944
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 0f3b349f96b85070cbe4c643989f30fc044c3904
https://github.com/Perl/perl5/commit/0f3b349f96b85070cbe4c643989f30fc044c3904
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 7af6cb6a9000d8f695a049fb142312622c399570
https://github.com/Perl/perl5/commit/7af6cb6a9000d8f695a049fb142312622c399570
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 849064f2970342741e971261cf64a4b3b731b8d1
https://github.com/Perl/perl5/commit/849064f2970342741e971261cf64a4b3b731b8d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: 73cd100ef573dfc89c8a8e4a8f3ed5e800a6c76c
https://github.com/Perl/perl5/commit/73cd100ef573dfc89c8a8e4a8f3ed5e800a6c76c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 5616801c5d8b6ed476e49217052434f002645e11
https://github.com/Perl/perl5/commit/5616801c5d8b6ed476e49217052434f002645e11
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: eb480d5d548e0144391f9a8fbef0409cf86d68f8
https://github.com/Perl/perl5/commit/eb480d5d548e0144391f9a8fbef0409cf86d68f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: ca8ac8053adb04b9f66f27ed1d16b27f6cc51cfb
https://github.com/Perl/perl5/commit/ca8ac8053adb04b9f66f27ed1d16b27f6cc51cfb
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: cedc0e67519ed67b2ce55b0bd0bd7340dc359041
https://github.com/Perl/perl5/commit/cedc0e67519ed67b2ce55b0bd0bd7340dc359041
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 4129e792144c1be671d24cc5367d12aaf3f249ce
https://github.com/Perl/perl5/commit/4129e792144c1be671d24cc5367d12aaf3f249ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 6acf90446c8112c51ee1abd3c1b2395d4f5b612f
https://github.com/Perl/perl5/commit/6acf90446c8112c51ee1abd3c1b2395d4f5b612f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: e197af8c8e53e5a2cf6d50bb3f054147b22d988d
https://github.com/Perl/perl5/commit/e197af8c8e53e5a2cf6d50bb3f054147b22d988d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 894a3acff8b9599431e52ccc35eeb59e0dbc1831
https://github.com/Perl/perl5/commit/894a3acff8b9599431e52ccc35eeb59e0dbc1831
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 41c4dba88958e16c0efcee8cd96d5c1d6df23f56
https://github.com/Perl/perl5/commit/41c4dba88958e16c0efcee8cd96d5c1d6df23f56
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 5b5fa2ad4b9c9ada62438eff78d404156f9a5dfe
https://github.com/Perl/perl5/commit/5b5fa2ad4b9c9ada62438eff78d404156f9a5dfe
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: e3d9dffd3b2a47fb689ef3dd96476afffa446067
https://github.com/Perl/perl5/commit/e3d9dffd3b2a47fb689ef3dd96476afffa446067
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 3c912183524c02b9a2e70b79583ccbddabad5381
https://github.com/Perl/perl5/commit/3c912183524c02b9a2e70b79583ccbddabad5381
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: a564fc627ae6db109e9b1a18565f8da9268ce57a
https://github.com/Perl/perl5/commit/a564fc627ae6db109e9b1a18565f8da9268ce57a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: d992f2e7065926ddb3c19173ae0c3516c6517ebc
https://github.com/Perl/perl5/commit/d992f2e7065926ddb3c19173ae0c3516c6517ebc
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 4cc2723d76f5be1128c6c7e796a05bbd762ae976
https://github.com/Perl/perl5/commit/4cc2723d76f5be1128c6c7e796a05bbd762ae976
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: e8f2a4962f2b3c3cf7aaddf550e9c7fa236b5932
https://github.com/Perl/perl5/commit/e8f2a4962f2b3c3cf7aaddf550e9c7fa236b5932
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: b8b72d84376e6e68bb5635b02da6604593b0ec07
https://github.com/Perl/perl5/commit/b8b72d84376e6e68bb5635b02da6604593b0ec07
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 98229c93ac5ab7321ed479d9d4e7ec1d7d8bc42c
https://github.com/Perl/perl5/commit/98229c93ac5ab7321ed479d9d4e7ec1d7d8bc42c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 62a7c834814288733860bfb535af8916cf0d2d56
https://github.com/Perl/perl5/commit/62a7c834814288733860bfb535af8916cf0d2d56
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: b360f1af94a2dc9d008c67bafc9da05278f745f1
https://github.com/Perl/perl5/commit/b360f1af94a2dc9d008c67bafc9da05278f745f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: bd4da70ffc57f931aa473501ff351d00302f09e2
https://github.com/Perl/perl5/commit/bd4da70ffc57f931aa473501ff351d00302f09e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: b0444d92946257a48bfc1ecfda2bdbdc65bbf7ed
https://github.com/Perl/perl5/commit/b0444d92946257a48bfc1ecfda2bdbdc65bbf7ed
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 8cca677a3ea6d9cd23e5341400668e20afaead98
https://github.com/Perl/perl5/commit/8cca677a3ea6d9cd23e5341400668e20afaead98
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: b53a5e7a205f36e5c3b4fea1513516fda86dc922
https://github.com/Perl/perl5/commit/b53a5e7a205f36e5c3b4fea1513516fda86dc922
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 3a54cf7d8eabfd3ec6cd5f43f8c40a8e732596ad
https://github.com/Perl/perl5/commit/3a54cf7d8eabfd3ec6cd5f43f8c40a8e732596ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 0b97cd43207f4c5dda0fa2c9510fc4a5a178bae6
https://github.com/Perl/perl5/commit/0b97cd43207f4c5dda0fa2c9510fc4a5a178bae6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 120cb9bad95863eccef81cda70aed0310a2dff2d
https://github.com/Perl/perl5/commit/120cb9bad95863eccef81cda70aed0310a2dff2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: b942a1c9dbd1ed7344c621bdeb334a51b499f5fc
https://github.com/Perl/perl5/commit/b942a1c9dbd1ed7344c621bdeb334a51b499f5fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: fddfba6da7f8aeffd617330739ad32b52f72d7d3
https://github.com/Perl/perl5/commit/fddfba6da7f8aeffd617330739ad32b52f72d7d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: de036084f1a091acab2288dac857ba4e58346427
https://github.com/Perl/perl5/commit/de036084f1a091acab2288dac857ba4e58346427
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 13cc0ed42fe7a6d72f318f58717b07b55f72782b
https://github.com/Perl/perl5/commit/13cc0ed42fe7a6d72f318f58717b07b55f72782b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: a96bb8be86939890e5ca890c634791ff8b6b3911
https://github.com/Perl/perl5/commit/a96bb8be86939890e5ca890c634791ff8b6b3911
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 36fdf5467a7a61f8991ab06346b9ef9e5c829dce
https://github.com/Perl/perl5/commit/36fdf5467a7a61f8991ab06346b9ef9e5c829dce
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 1ab41f418c1864e8343d957fd9562133e72e2f15
https://github.com/Perl/perl5/commit/1ab41f418c1864e8343d957fd9562133e72e2f15
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: db21571707201790ca626a87ea4a6924d143ab3c
https://github.com/Perl/perl5/commit/db21571707201790ca626a87ea4a6924d143ab3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: cd4bc038c8d779f08e06eb92682e538469966624
https://github.com/Perl/perl5/commit/cd4bc038c8d779f08e06eb92682e538469966624
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: e2b5899fa4f92fbc6b3fe9c67c71ab1f44e65061
https://github.com/Perl/perl5/commit/e2b5899fa4f92fbc6b3fe9c67c71ab1f44e65061
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 56ed71c080134ed5ae49ace820cde2f3bcf8aa1f
https://github.com/Perl/perl5/commit/56ed71c080134ed5ae49ace820cde2f3bcf8aa1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 584186b71d0f3e20f43ce5eec913e67ece8da4ab
https://github.com/Perl/perl5/commit/584186b71d0f3e20f43ce5eec913e67ece8da4ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: ce5caf473f244c848c84c9251ea8342a28e31bc3
https://github.com/Perl/perl5/commit/ce5caf473f244c848c84c9251ea8342a28e31bc3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 63fefa7aa0bdb6c29c5ef88ecefb37a48be34952
https://github.com/Perl/perl5/commit/63fefa7aa0bdb6c29c5ef88ecefb37a48be34952
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 989b5d67646eedffc9395e481dd1cb568e95de30
https://github.com/Perl/perl5/commit/989b5d67646eedffc9395e481dd1cb568e95de30
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: fd2f58577d489013ee1dee1657fe6869ae99f306
https://github.com/Perl/perl5/commit/fd2f58577d489013ee1dee1657fe6869ae99f306
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 326e85563a8a8c4f8cdc3b4244faf7a3d4dbdd3f
https://github.com/Perl/perl5/commit/326e85563a8a8c4f8cdc3b4244faf7a3d4dbdd3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 400f8ce81e800ee6e0e55b128a1cfc989fa6cc69
https://github.com/Perl/perl5/commit/400f8ce81e800ee6e0e55b128a1cfc989fa6cc69
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 00e0bb9e2237a4aed43c045c6235f939ca49a055
https://github.com/Perl/perl5/commit/00e0bb9e2237a4aed43c045c6235f939ca49a055
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: f8ab9dfacb14e727428488fbd6f584c8f904c593
https://github.com/Perl/perl5/commit/f8ab9dfacb14e727428488fbd6f584c8f904c593
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: d28e32addd17cced5a8adb83cc28d4809bfcb22f
https://github.com/Perl/perl5/commit/d28e32addd17cced5a8adb83cc28d4809bfcb22f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: df0c86134f256e468e424812e59d1a0729ede986
https://github.com/Perl/perl5/commit/df0c86134f256e468e424812e59d1a0729ede986
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: f5f6ef9725cb9ca74c43fe4dc1a8dc7026594092
https://github.com/Perl/perl5/commit/f5f6ef9725cb9ca74c43fe4dc1a8dc7026594092
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: 609ef5bd3238c2fea21cdeca80344fc95c93879d
https://github.com/Perl/perl5/commit/609ef5bd3238c2fea21cdeca80344fc95c93879d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: bfe8153584be1a67197f9dba10490103631d6609
https://github.com/Perl/perl5/commit/bfe8153584be1a67197f9dba10490103631d6609
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: 087382f88acf17134c5aa8c3376899c8b789e7a9
https://github.com/Perl/perl5/commit/087382f88acf17134c5aa8c3376899c8b789e7a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 72c2a50214384c161b6e8ebb992109accb01910d
https://github.com/Perl/perl5/commit/72c2a50214384c161b6e8ebb992109accb01910d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 757e4b7a4518f08b01fe0dfd98e5df8699c6e6be
https://github.com/Perl/perl5/commit/757e4b7a4518f08b01fe0dfd98e5df8699c6e6be
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 87601f3823ba9bf1b8d119200f56654039753102
https://github.com/Perl/perl5/commit/87601f3823ba9bf1b8d119200f56654039753102
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: a363686a6b47ee414851697f1add628971867771
https://github.com/Perl/perl5/commit/a363686a6b47ee414851697f1add628971867771
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: a3d6833b31a5c51436f3cb542ba697a0ebb408a9
https://github.com/Perl/perl5/commit/a3d6833b31a5c51436f3cb542ba697a0ebb408a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 1269811cae0a78163debabebb13ca00a0d45e629
https://github.com/Perl/perl5/commit/1269811cae0a78163debabebb13ca00a0d45e629
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 14d52589a21c115b37e9092e29ef9f4a7dd10395
https://github.com/Perl/perl5/commit/14d52589a21c115b37e9092e29ef9f4a7dd10395
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: fc7fa793333618e3d8d811d267030664e98b1e96
https://github.com/Perl/perl5/commit/fc7fa793333618e3d8d811d267030664e98b1e96
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: cff0ed3bd27c52372161a89f3510bb87a09ad303
https://github.com/Perl/perl5/commit/cff0ed3bd27c52372161a89f3510bb87a09ad303
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 91f5ce0415102d129d7495498e97fee8ced68a00
https://github.com/Perl/perl5/commit/91f5ce0415102d129d7495498e97fee8ced68a00
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 415fba85d8a48c425568bb73a80870f5b3d84c0d
https://github.com/Perl/perl5/commit/415fba85d8a48c425568bb73a80870f5b3d84c0d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 9341589adc8e0a9b638d8fb5ba8450ae71959696
https://github.com/Perl/perl5/commit/9341589adc8e0a9b638d8fb5ba8450ae71959696
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 28afdfe7799daee72a636ea08d7227618d0f2471
https://github.com/Perl/perl5/commit/28afdfe7799daee72a636ea08d7227618d0f2471
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 1977f91819b898fba44edec9fa8cb87ba144d467
https://github.com/Perl/perl5/commit/1977f91819b898fba44edec9fa8cb87ba144d467
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 7aee72f0037b569775a29565fdc345211b767784
https://github.com/Perl/perl5/commit/7aee72f0037b569775a29565fdc345211b767784
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 9c42f51b53274e75b77dba22e8bff5254235ce78
https://github.com/Perl/perl5/commit/9c42f51b53274e75b77dba22e8bff5254235ce78
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 0e02bda16fc1cb261df9438bc5c4add1a65379c1
https://github.com/Perl/perl5/commit/0e02bda16fc1cb261df9438bc5c4add1a65379c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: ad4f36c51f9a692e4c869f7d2af706b06fbe8726
https://github.com/Perl/perl5/commit/ad4f36c51f9a692e4c869f7d2af706b06fbe8726
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 1d1c4005870a769028074a9482d12f7ad1a172f5
https://github.com/Perl/perl5/commit/1d1c4005870a769028074a9482d12f7ad1a172f5
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 79be2b744625426749a9d6e6611f466cbe5d98c7
https://github.com/Perl/perl5/commit/79be2b744625426749a9d6e6611f466cbe5d98c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: d033cb8903194681d03cc50be70a9e2877bf392d
https://github.com/Perl/perl5/commit/d033cb8903194681d03cc50be70a9e2877bf392d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 9b1f00a2e64350ecfa2b26590b3d2375619e4239
https://github.com/Perl/perl5/commit/9b1f00a2e64350ecfa2b26590b3d2375619e4239
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: f91d2d9650465115e951afc306d30d886d535010
https://github.com/Perl/perl5/commit/f91d2d9650465115e951afc306d30d886d535010
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 0ccf509449467a08b8f314353def1832b4b97bcb
https://github.com/Perl/perl5/commit/0ccf509449467a08b8f314353def1832b4b97bcb
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: c7fbf600c4a22c6d968a62b884b4127dc8d1f843
https://github.com/Perl/perl5/commit/c7fbf600c4a22c6d968a62b884b4127dc8d1f843
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 45b629c672c91309dca2c2ebeaddbc8a9588794f
https://github.com/Perl/perl5/commit/45b629c672c91309dca2c2ebeaddbc8a9588794f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: bb571089d9c5f634d4d65390fc7bd15fdbe61f35
https://github.com/Perl/perl5/commit/bb571089d9c5f634d4d65390fc7bd15fdbe61f35
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 6c6e576eeea4a79a327e7d58613480b818fc6c50
https://github.com/Perl/perl5/commit/6c6e576eeea4a79a327e7d58613480b818fc6c50
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 76908fd29c9a4f27f1ab6a5f450464047ca06e20
https://github.com/Perl/perl5/commit/76908fd29c9a4f27f1ab6a5f450464047ca06e20
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: cbbe2843afefbeeb71742c154c6efcf4af090c10
https://github.com/Perl/perl5/commit/cbbe2843afefbeeb71742c154c6efcf4af090c10
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 78f26f3d628fa225540f11a27da5052ce19b3b2d
https://github.com/Perl/perl5/commit/78f26f3d628fa225540f11a27da5052ce19b3b2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 93427293bb0031cf049fd8b31901a2027564a83b
https://github.com/Perl/perl5/commit/93427293bb0031cf049fd8b31901a2027564a83b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: bd6fa7612ae7236eff22e58a834c221908a65c70
https://github.com/Perl/perl5/commit/bd6fa7612ae7236eff22e58a834c221908a65c70
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 37c6003e77f71c0ae74dd55964d34e55e5944501
https://github.com/Perl/perl5/commit/37c6003e77f71c0ae74dd55964d34e55e5944501
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 681a0b3b77d0c4a240bedbf57f80a75295145941
https://github.com/Perl/perl5/commit/681a0b3b77d0c4a240bedbf57f80a75295145941
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: a7d0c6ec0861fd32ecbad64a32d192d98ad2bc1c
https://github.com/Perl/perl5/commit/a7d0c6ec0861fd32ecbad64a32d192d98ad2bc1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 3f83811ccad23a1b91c680d2895a3228d9c503a5
https://github.com/Perl/perl5/commit/3f83811ccad23a1b91c680d2895a3228d9c503a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 93bdc751561b51d749e5f60d8e8728a52e08b533
https://github.com/Perl/perl5/commit/93bdc751561b51d749e5f60d8e8728a52e08b533
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 1e3b5561ba0d4194e991b494e89641c3553cf5aa
https://github.com/Perl/perl5/commit/1e3b5561ba0d4194e991b494e89641c3553cf5aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 86584e32c6791550c54c700233b0bfb9f1fe9179
https://github.com/Perl/perl5/commit/86584e32c6791550c54c700233b0bfb9f1fe9179
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 25a9451f5b02af21c1634b0ed1356c3f28a9121d
https://github.com/Perl/perl5/commit/25a9451f5b02af21c1634b0ed1356c3f28a9121d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 46019e19aef2e350f0fe5bb51e029ec70ab4826e
https://github.com/Perl/perl5/commit/46019e19aef2e350f0fe5bb51e029ec70ab4826e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 56a039dfdd24779ef81078b5a737abc5a4c0b723
https://github.com/Perl/perl5/commit/56a039dfdd24779ef81078b5a737abc5a4c0b723
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 6534fc328a7cdb02e65a92586bde0f3ce4c88c8d
https://github.com/Perl/perl5/commit/6534fc328a7cdb02e65a92586bde0f3ce4c88c8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: f286b11d6a3fd87a32b9db42a117dd9e12fceed6
https://github.com/Perl/perl5/commit/f286b11d6a3fd87a32b9db42a117dd9e12fceed6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: 22b7fcfe2f3fb9f4161f2985bcbdb8c3a852c8d8
https://github.com/Perl/perl5/commit/22b7fcfe2f3fb9f4161f2985bcbdb8c3a852c8d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 6dda79efe97838f92b8286bcd30f9bd48d36f96f
https://github.com/Perl/perl5/commit/6dda79efe97838f92b8286bcd30f9bd48d36f96f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 00924e30257182fc72c5c8adb8fd542356449346
https://github.com/Perl/perl5/commit/00924e30257182fc72c5c8adb8fd542356449346
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: c372fb03900d8299f6d4aa1d830df6c68ce77f3e
https://github.com/Perl/perl5/commit/c372fb03900d8299f6d4aa1d830df6c68ce77f3e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 1490996f85741178830c5e2b5c31800502f1a823
https://github.com/Perl/perl5/commit/1490996f85741178830c5e2b5c31800502f1a823
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 121925ff98f718d5f024cac8c7440e2571a93f4f
https://github.com/Perl/perl5/commit/121925ff98f718d5f024cac8c7440e2571a93f4f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 64a7235992d6b033255f320fb9fa43f69f8c7886
https://github.com/Perl/perl5/commit/64a7235992d6b033255f320fb9fa43f69f8c7886
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 137e4aa67ea43fcec7c6831d0807afeb73c2dad7
https://github.com/Perl/perl5/commit/137e4aa67ea43fcec7c6831d0807afeb73c2dad7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: e8fe3f4747fdaef94d292b44868039ffcab0690f
https://github.com/Perl/perl5/commit/e8fe3f4747fdaef94d292b44868039ffcab0690f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 7942bfb75f23ce8ea17070a5f1ea2760c9038de7
https://github.com/Perl/perl5/commit/7942bfb75f23ce8ea17070a5f1ea2760c9038de7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: ea29108676bece644a8d7eca6de2393871fef751
https://github.com/Perl/perl5/commit/ea29108676bece644a8d7eca6de2393871fef751
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 8a43a021981a17668f722bf25352bfd5e092ecae
https://github.com/Perl/perl5/commit/8a43a021981a17668f722bf25352bfd5e092ecae
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 358a02a7b578387bbd4aeaf91644a1958cc6590e
https://github.com/Perl/perl5/commit/358a02a7b578387bbd4aeaf91644a1958cc6590e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: ad81c3308b61892f9f712a39003f045efbf47ad2
https://github.com/Perl/perl5/commit/ad81c3308b61892f9f712a39003f045efbf47ad2
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: a81252a5cb811d04d46cf254335441650b9e6bf0
https://github.com/Perl/perl5/commit/a81252a5cb811d04d46cf254335441650b9e6bf0
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 1fff786fdbdcd63b95d7815cded6f08b8cdc706a
https://github.com/Perl/perl5/commit/1fff786fdbdcd63b95d7815cded6f08b8cdc706a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: c8c5bbf1f6d2d6f7211945bd58df76140abb8985
https://github.com/Perl/perl5/commit/c8c5bbf1f6d2d6f7211945bd58df76140abb8985
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 99632c01bad4d7a2d2d45ba4d515875d1ab60e60
https://github.com/Perl/perl5/commit/99632c01bad4d7a2d2d45ba4d515875d1ab60e60
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 5d2208c6dd45d9d807dc784ee590a8a1b9141e97
https://github.com/Perl/perl5/commit/5d2208c6dd45d9d807dc784ee590a8a1b9141e97
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 34f01e92552c38bf8d6f13f948c8434a295b44d3
https://github.com/Perl/perl5/commit/34f01e92552c38bf8d6f13f948c8434a295b44d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 7385503640b745d6d77f370cdab3d962c39259cd
https://github.com/Perl/perl5/commit/7385503640b745d6d77f370cdab3d962c39259cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 2f943a4948478c0dbaec06daad31b0a3692fae32
https://github.com/Perl/perl5/commit/2f943a4948478c0dbaec06daad31b0a3692fae32
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 6c67acf2530119f2190fc813c308c982fd0f6fde
https://github.com/Perl/perl5/commit/6c67acf2530119f2190fc813c308c982fd0f6fde
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: a42669abab917f5edc28e2189acaa6c1d89b7a60
https://github.com/Perl/perl5/commit/a42669abab917f5edc28e2189acaa6c1d89b7a60
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 3e9379ee0779b0ef20016c31d4fd163c551b111a
https://github.com/Perl/perl5/commit/3e9379ee0779b0ef20016c31d4fd163c551b111a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 8b0b55312865b957eee7cf192b7fb7a5cc17ee7e
https://github.com/Perl/perl5/commit/8b0b55312865b957eee7cf192b7fb7a5cc17ee7e
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: 8e4b9333849f7bce86d9b6f621ce45412c427929
https://github.com/Perl/perl5/commit/8e4b9333849f7bce86d9b6f621ce45412c427929
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: c8e475cbfea162fd6979eb79f3876d1a9dd8e51b
https://github.com/Perl/perl5/commit/c8e475cbfea162fd6979eb79f3876d1a9dd8e51b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 4d40854fc2c468985be23d1badedc0dfdfa24ef2
https://github.com/Perl/perl5/commit/4d40854fc2c468985be23d1badedc0dfdfa24ef2
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: dc97f8c82246056094e8a70a1d74dbde87fe0757
https://github.com/Perl/perl5/commit/dc97f8c82246056094e8a70a1d74dbde87fe0757
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 09ebb3ef5fa556e61b0266224cf0dcfba3dc4bbc
https://github.com/Perl/perl5/commit/09ebb3ef5fa556e61b0266224cf0dcfba3dc4bbc
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 0c25661cd99c2f8ea4c2a25b5484db7fc8ddfadf
https://github.com/Perl/perl5/commit/0c25661cd99c2f8ea4c2a25b5484db7fc8ddfadf
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 074643f25fa8410088b4d7ab08ca4c2849f6cf3b
https://github.com/Perl/perl5/commit/074643f25fa8410088b4d7ab08ca4c2849f6cf3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 231d84bb6208743b66ef01bcefd9ee3a713606ef
https://github.com/Perl/perl5/commit/231d84bb6208743b66ef01bcefd9ee3a713606ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 45229c1680959693ec687a5443c373a82ef40138
https://github.com/Perl/perl5/commit/45229c1680959693ec687a5443c373a82ef40138
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 2692455839b2b40dde5835a45585f0abcd5c6e6c
https://github.com/Perl/perl5/commit/2692455839b2b40dde5835a45585f0abcd5c6e6c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 7fbc599d92a4fc0ddc846258ecba597e6c4fdbdc
https://github.com/Perl/perl5/commit/7fbc599d92a4fc0ddc846258ecba597e6c4fdbdc
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: 812095865ebe568faa92e25fcc92975bca24f391
https://github.com/Perl/perl5/commit/812095865ebe568faa92e25fcc92975bca24f391
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: a3be855c93064407271a893ba605258adaa3dc95
https://github.com/Perl/perl5/commit/a3be855c93064407271a893ba605258adaa3dc95
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: cd178181854ead08faa9a87841c2989da8c4f3d7
https://github.com/Perl/perl5/commit/cd178181854ead08faa9a87841c2989da8c4f3d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 01d550cc741aa58858f128ecfb8e9f3c54bb9898
https://github.com/Perl/perl5/commit/01d550cc741aa58858f128ecfb8e9f3c54bb9898
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 1ba135ed66b3087183695be3b519fcc757707822
https://github.com/Perl/perl5/commit/1ba135ed66b3087183695be3b519fcc757707822
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: 6dbc7ba404016a280ea304f9bb880965ad961fb9
https://github.com/Perl/perl5/commit/6dbc7ba404016a280ea304f9bb880965ad961fb9
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: e9310433147942c7ee1cd95a149e31d1c0cf165f
https://github.com/Perl/perl5/commit/e9310433147942c7ee1cd95a149e31d1c0cf165f
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: 0b7204953b6601d1616d609a013c06efbffc50be
https://github.com/Perl/perl5/commit/0b7204953b6601d1616d609a013c06efbffc50be
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 84d85bfd25400219f389fd1e0cb6bd943044494a
https://github.com/Perl/perl5/commit/84d85bfd25400219f389fd1e0cb6bd943044494a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 062e616e5e5696bb79165f1f390a85bb04bc629a
https://github.com/Perl/perl5/commit/062e616e5e5696bb79165f1f390a85bb04bc629a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 9ec9fbbfb59010d012f7b1de3f1c9fe1e7efa679
https://github.com/Perl/perl5/commit/9ec9fbbfb59010d012f7b1de3f1c9fe1e7efa679
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: d05fede347c919c68255f0274a6230589d65152d
https://github.com/Perl/perl5/commit/d05fede347c919c68255f0274a6230589d65152d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: ab1164f7ddca0833cd7b9a3fa7d87511f729d8f6
https://github.com/Perl/perl5/commit/ab1164f7ddca0833cd7b9a3fa7d87511f729d8f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 39f90423de9738c340d4ea77d805060fb716a314
https://github.com/Perl/perl5/commit/39f90423de9738c340d4ea77d805060fb716a314
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: d8395e5ad62ca865d87e4d8a0cf96bd8eb8446e4
https://github.com/Perl/perl5/commit/d8395e5ad62ca865d87e4d8a0cf96bd8eb8446e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: a943bbc7983b2458bcc05e3f2c8446a2d4c59273
https://github.com/Perl/perl5/commit/a943bbc7983b2458bcc05e3f2c8446a2d4c59273
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 00b48b0efbda5d6b64b09b99634cd5b01a683021
https://github.com/Perl/perl5/commit/00b48b0efbda5d6b64b09b99634cd5b01a683021
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: cf2623ab47b1ec82436a2fddbb89a50eb0ee693a
https://github.com/Perl/perl5/commit/cf2623ab47b1ec82436a2fddbb89a50eb0ee693a
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 980df1a19cab1919a0ddbd566390ac4b0568d22d
https://github.com/Perl/perl5/commit/980df1a19cab1919a0ddbd566390ac4b0568d22d
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 3b33dc650244f73a6fe070cc8464b1bd0c10aa3c
https://github.com/Perl/perl5/commit/3b33dc650244f73a6fe070cc8464b1bd0c10aa3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 858e8e177458923a57949406a73cbaf4dd2cd724
https://github.com/Perl/perl5/commit/858e8e177458923a57949406a73cbaf4dd2cd724
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 0234137334b3f4c3a5787ce1458f8d89c93fcbab
https://github.com/Perl/perl5/commit/0234137334b3f4c3a5787ce1458f8d89c93fcbab
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: afc54044054896bfe27b27c33f816d514411de94
https://github.com/Perl/perl5/commit/afc54044054896bfe27b27c33f816d514411de94
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 49de8acdfeacef8e6080f617a14d8dde54cb3957
https://github.com/Perl/perl5/commit/49de8acdfeacef8e6080f617a14d8dde54cb3957
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: 70414d51122fb33516c70b1418585a18df9cdea7
https://github.com/Perl/perl5/commit/70414d51122fb33516c70b1418585a18df9cdea7
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: c53f9a258580a2d2999c050d991d83669215c72b
https://github.com/Perl/perl5/commit/c53f9a258580a2d2999c050d991d83669215c72b
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 86de949a485e66ac0671e43ba8dcc7033b695e90
https://github.com/Perl/perl5/commit/86de949a485e66ac0671e43ba8dcc7033b695e90
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 1477bf680a88450d914f07379b62e04e1811c1e3
https://github.com/Perl/perl5/commit/1477bf680a88450d914f07379b62e04e1811c1e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: be55103c05acdaff4c3b2ec596ea41cd836d68f6
https://github.com/Perl/perl5/commit/be55103c05acdaff4c3b2ec596ea41cd836d68f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 0d47508331e65621b99aa4981eb3903f1d494b72
https://github.com/Perl/perl5/commit/0d47508331e65621b99aa4981eb3903f1d494b72
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 29bfe67e6f2e6d980b00ef43fb904a2b554bac44
https://github.com/Perl/perl5/commit/29bfe67e6f2e6d980b00ef43fb904a2b554bac44
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 747ab2eed8fb1453e8adb60d654308f852c2adc6
https://github.com/Perl/perl5/commit/747ab2eed8fb1453e8adb60d654308f852c2adc6
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: 23d2ced2bffc628fd5b98794baa19088c6a0f622
https://github.com/Perl/perl5/commit/23d2ced2bffc628fd5b98794baa19088c6a0f622
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 6cf787b7643f3556e288976375c235fdfeab7ad3
https://github.com/Perl/perl5/commit/6cf787b7643f3556e288976375c235fdfeab7ad3
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: b78ae9613714b593b022a72b6d20fddf952eb611
https://github.com/Perl/perl5/commit/b78ae9613714b593b022a72b6d20fddf952eb611
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 559ce85e2a584e4a0ec852950905635e82f01d67
https://github.com/Perl/perl5/commit/559ce85e2a584e4a0ec852950905635e82f01d67
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 222c40f7db29ed356bb28559277d8d6b75e1fc67
https://github.com/Perl/perl5/commit/222c40f7db29ed356bb28559277d8d6b75e1fc67
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
41
Commit: fa549dd3869ebb9218de480f4048ce3b4e3bfe16
https://github.com/Perl/perl5/commit/fa549dd3869ebb9218de480f4048ce3b4e3bfe16
Author: Karl Williamson <[email protected]>
Date: 2021-04-23 (Fri, 23 Apr 2021)
Changed paths:
M lib/locale_threads.t
M locale.c
M t/loc_tools.pl
Log Message:
-----------
42
Compare: https://github.com/Perl/perl5/compare/38a14e31b1d5...fa549dd3869e
