Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: 64a6436d76c2ae143a6ef6092809bc39ff9da0e5
https://github.com/Perl/perl5/commit/64a6436d76c2ae143a6ef6092809bc39ff9da0e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: d614a4cc89e088d6fc05c5ba7f5da4855f8e8dba
https://github.com/Perl/perl5/commit/d614a4cc89e088d6fc05c5ba7f5da4855f8e8dba
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 3df5593b2d54d24b46691056b7b2f99daea16243
https://github.com/Perl/perl5/commit/3df5593b2d54d24b46691056b7b2f99daea16243
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 98c6e4d5ed4b8b0a26b5e8675068276b92cdf4d5
https://github.com/Perl/perl5/commit/98c6e4d5ed4b8b0a26b5e8675068276b92cdf4d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: 00880d0fb2b78e2b61928dbc622023d5919d476f
https://github.com/Perl/perl5/commit/00880d0fb2b78e2b61928dbc622023d5919d476f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 2e9095340829ac202b9d5fd16d2cdb195c6bc8dd
https://github.com/Perl/perl5/commit/2e9095340829ac202b9d5fd16d2cdb195c6bc8dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: f52274614a78e587f491c4b3e7626ec0bd96ec82
https://github.com/Perl/perl5/commit/f52274614a78e587f491c4b3e7626ec0bd96ec82
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: c7a576e09ffb503712c1464bab7d000f42596544
https://github.com/Perl/perl5/commit/c7a576e09ffb503712c1464bab7d000f42596544
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 50e3191db019304b8296bbd9173512b11276527f
https://github.com/Perl/perl5/commit/50e3191db019304b8296bbd9173512b11276527f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 20a20ee7f70ee22cd71e7f42f65d266a9f35bcff
https://github.com/Perl/perl5/commit/20a20ee7f70ee22cd71e7f42f65d266a9f35bcff
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: caf28f5cae7c16919bfa399a5d12d828468f8dfb
https://github.com/Perl/perl5/commit/caf28f5cae7c16919bfa399a5d12d828468f8dfb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 894586f2a89b604dfb1ec48e793dcbbd65e8e77e
https://github.com/Perl/perl5/commit/894586f2a89b604dfb1ec48e793dcbbd65e8e77e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: d1ee62a28f661bc9535fbef74d72c12c8caec1f1
https://github.com/Perl/perl5/commit/d1ee62a28f661bc9535fbef74d72c12c8caec1f1
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 373e2dd209b107bdfc2f978eb44f7feefe4fe8f3
https://github.com/Perl/perl5/commit/373e2dd209b107bdfc2f978eb44f7feefe4fe8f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: be5d4432eb3b1d924a176f4ec29db095d7874572
https://github.com/Perl/perl5/commit/be5d4432eb3b1d924a176f4ec29db095d7874572
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: b4817cae081fb8723733da2e96400e3252dfcaec
https://github.com/Perl/perl5/commit/b4817cae081fb8723733da2e96400e3252dfcaec
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: 8d020fdabadd9681878ab85cf2ffe81d2c565bdb
https://github.com/Perl/perl5/commit/8d020fdabadd9681878ab85cf2ffe81d2c565bdb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 4fddc63411f3773033fc0b28d5e784f268c1a81a
https://github.com/Perl/perl5/commit/4fddc63411f3773033fc0b28d5e784f268c1a81a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 4fc66c88a6a190553ba8684105116acc5e5df7ff
https://github.com/Perl/perl5/commit/4fc66c88a6a190553ba8684105116acc5e5df7ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 83c3fea832f5d31147e1a7d78af537ed5e8325b4
https://github.com/Perl/perl5/commit/83c3fea832f5d31147e1a7d78af537ed5e8325b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 3eb17c4a2521c5363878372ba3f467d1f340899b
https://github.com/Perl/perl5/commit/3eb17c4a2521c5363878372ba3f467d1f340899b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 0997eea442f912ef782d6f3d41aab21ea29907c3
https://github.com/Perl/perl5/commit/0997eea442f912ef782d6f3d41aab21ea29907c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: f6a4ed7919599328a1828c27732f029e1cf2b2cf
https://github.com/Perl/perl5/commit/f6a4ed7919599328a1828c27732f029e1cf2b2cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: 2d7f0deb8c2631990e90cb8e839874fafff5cb96
https://github.com/Perl/perl5/commit/2d7f0deb8c2631990e90cb8e839874fafff5cb96
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 703b692b84d3868c2e9a43563db6acb41e2f443e
https://github.com/Perl/perl5/commit/703b692b84d3868c2e9a43563db6acb41e2f443e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 1e1deea36db2b9a95742d95793c18ee545347d65
https://github.com/Perl/perl5/commit/1e1deea36db2b9a95742d95793c18ee545347d65
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 87f5806305086d8837a81f4670246113ac3e3e4c
https://github.com/Perl/perl5/commit/87f5806305086d8837a81f4670246113ac3e3e4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 629873332b60744781623e0e32b60fecc93b4207
https://github.com/Perl/perl5/commit/629873332b60744781623e0e32b60fecc93b4207
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 13a8c21c446ba75454174544ca4570dc197912c3
https://github.com/Perl/perl5/commit/13a8c21c446ba75454174544ca4570dc197912c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 0cca9e9b27ce9c1bd8144668500f4a7d2d639576
https://github.com/Perl/perl5/commit/0cca9e9b27ce9c1bd8144668500f4a7d2d639576
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: e1988f8e2acfb03d7f3ce26605f9e87436f1ea18
https://github.com/Perl/perl5/commit/e1988f8e2acfb03d7f3ce26605f9e87436f1ea18
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 45b9515a7c52b6f47b8c0cce182908cd261bb974
https://github.com/Perl/perl5/commit/45b9515a7c52b6f47b8c0cce182908cd261bb974
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: a7e79eb02af01ae33435a5f34c42ba3557598c49
https://github.com/Perl/perl5/commit/a7e79eb02af01ae33435a5f34c42ba3557598c49
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 5eea245a2b3c5b8ac25cb5099e54d732fa749b80
https://github.com/Perl/perl5/commit/5eea245a2b3c5b8ac25cb5099e54d732fa749b80
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 9deba512169e79c3a764247c0a209d24f633e99f
https://github.com/Perl/perl5/commit/9deba512169e79c3a764247c0a209d24f633e99f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: cf5bba5c4516e0cead895310020e3506f2c254b7
https://github.com/Perl/perl5/commit/cf5bba5c4516e0cead895310020e3506f2c254b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: f257c31fc432dc574a27b4ddfe1b622fabc62496
https://github.com/Perl/perl5/commit/f257c31fc432dc574a27b4ddfe1b622fabc62496
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 07e200129edad83190561ac0bf3eec0481dd8478
https://github.com/Perl/perl5/commit/07e200129edad83190561ac0bf3eec0481dd8478
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 67a50f75502751e4eeff384d9631f436bc50eb0a
https://github.com/Perl/perl5/commit/67a50f75502751e4eeff384d9631f436bc50eb0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: bb85c0e08d1054120a12af23eb7c8e8883de5741
https://github.com/Perl/perl5/commit/bb85c0e08d1054120a12af23eb7c8e8883de5741
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 2f74809ab241477584abd69ef2ac7f465c25a17e
https://github.com/Perl/perl5/commit/2f74809ab241477584abd69ef2ac7f465c25a17e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 67f6c4b0cfcb04b3bd353482b85b994b63eca821
https://github.com/Perl/perl5/commit/67f6c4b0cfcb04b3bd353482b85b994b63eca821
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: 21dbd1aa8d66a15e6dcc89958e894f979aa3d995
https://github.com/Perl/perl5/commit/21dbd1aa8d66a15e6dcc89958e894f979aa3d995
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 4901d56d3c729aa532b470160b5a32fe3a8824a3
https://github.com/Perl/perl5/commit/4901d56d3c729aa532b470160b5a32fe3a8824a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: a71f4cffec7c68d429674882207f1dbad6bf3465
https://github.com/Perl/perl5/commit/a71f4cffec7c68d429674882207f1dbad6bf3465
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 89f34d656cba96be294304656295f9ee3bc8000d
https://github.com/Perl/perl5/commit/89f34d656cba96be294304656295f9ee3bc8000d
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 50f84b7eb8cf9a583c7bd4fd6185827e5ab373dc
https://github.com/Perl/perl5/commit/50f84b7eb8cf9a583c7bd4fd6185827e5ab373dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 680a31f54027567535df0b64a4bb7e2328dc944b
https://github.com/Perl/perl5/commit/680a31f54027567535df0b64a4bb7e2328dc944b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 12c745ce66d42c9ae7c6a05c0b27fe84a7c3b1d8
https://github.com/Perl/perl5/commit/12c745ce66d42c9ae7c6a05c0b27fe84a7c3b1d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: ca0ddf975f917adf65298e72f2bf2bd79d236e1c
https://github.com/Perl/perl5/commit/ca0ddf975f917adf65298e72f2bf2bd79d236e1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 1eca9b6bed340b97367be2cafb666d81a8ebbbaa
https://github.com/Perl/perl5/commit/1eca9b6bed340b97367be2cafb666d81a8ebbbaa
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: c0a40210141dad468fbe211ed944709d0253cae2
https://github.com/Perl/perl5/commit/c0a40210141dad468fbe211ed944709d0253cae2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: e9344363a2787e7eccead1e7bfe61a2304f7687c
https://github.com/Perl/perl5/commit/e9344363a2787e7eccead1e7bfe61a2304f7687c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: 445eeb27ec9d4d16cc76080e06cae132c9123930
https://github.com/Perl/perl5/commit/445eeb27ec9d4d16cc76080e06cae132c9123930
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: 12199a43c9bd77894407763e9a2e3d38cdf70ffb
https://github.com/Perl/perl5/commit/12199a43c9bd77894407763e9a2e3d38cdf70ffb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: ca0929f7edceb15c55cbca0594afefa586b15fa0
https://github.com/Perl/perl5/commit/ca0929f7edceb15c55cbca0594afefa586b15fa0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 96d695f9dea32ad5d5b87d17cea357436e2e28ea
https://github.com/Perl/perl5/commit/96d695f9dea32ad5d5b87d17cea357436e2e28ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: 28057782c1e46175eea30b18c60111a296eb64e2
https://github.com/Perl/perl5/commit/28057782c1e46175eea30b18c60111a296eb64e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 0a3792fe4e4df630ef640dd85a9a16b72c3f1350
https://github.com/Perl/perl5/commit/0a3792fe4e4df630ef640dd85a9a16b72c3f1350
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 524676c78c41b6aa6e51cf87515c6eae0669c23d
https://github.com/Perl/perl5/commit/524676c78c41b6aa6e51cf87515c6eae0669c23d
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 9096451c51b68a13292673803ee4efa0ff54089a
https://github.com/Perl/perl5/commit/9096451c51b68a13292673803ee4efa0ff54089a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 182182cf34a60e2032e52d25a16024475c788e2c
https://github.com/Perl/perl5/commit/182182cf34a60e2032e52d25a16024475c788e2c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: a6f104815a80277ca7a7e1ac9393120b425c2b3f
https://github.com/Perl/perl5/commit/a6f104815a80277ca7a7e1ac9393120b425c2b3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 33222ae36d220225bceaa0abd3673367f8bcac97
https://github.com/Perl/perl5/commit/33222ae36d220225bceaa0abd3673367f8bcac97
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 1149e3ed10076975b2f84c3ad6136b2c05bd3e80
https://github.com/Perl/perl5/commit/1149e3ed10076975b2f84c3ad6136b2c05bd3e80
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 7629eacfc2f94e7910cc553a6e204ef299c0e367
https://github.com/Perl/perl5/commit/7629eacfc2f94e7910cc553a6e204ef299c0e367
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 21f7893848230859950cf847aa5b460fe1c84008
https://github.com/Perl/perl5/commit/21f7893848230859950cf847aa5b460fe1c84008
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: cb393769942cfabc0daefc17763940e34fbe78b7
https://github.com/Perl/perl5/commit/cb393769942cfabc0daefc17763940e34fbe78b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 76f6c04303d91a4e4900a3b6baf5bec00479d2a3
https://github.com/Perl/perl5/commit/76f6c04303d91a4e4900a3b6baf5bec00479d2a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: 5a06ea1e284cbee88dfbecce7a2ceb46075372c6
https://github.com/Perl/perl5/commit/5a06ea1e284cbee88dfbecce7a2ceb46075372c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: f3f5f5d67361740e9f03a6b08be870cfbc86bf51
https://github.com/Perl/perl5/commit/f3f5f5d67361740e9f03a6b08be870cfbc86bf51
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: e14e4009da4e482652b70c7c8315d6c00637c960
https://github.com/Perl/perl5/commit/e14e4009da4e482652b70c7c8315d6c00637c960
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 12823bcd077226cef49c01ec9737fd520d75fcb0
https://github.com/Perl/perl5/commit/12823bcd077226cef49c01ec9737fd520d75fcb0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 328669854cb4711259e4f3d858c85abcd076708e
https://github.com/Perl/perl5/commit/328669854cb4711259e4f3d858c85abcd076708e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: bb2de78d208687b3fd176886b5c8d77d9d72d9c3
https://github.com/Perl/perl5/commit/bb2de78d208687b3fd176886b5c8d77d9d72d9c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 4dce24e95e37ceefa905fa5030122e2e640216ee
https://github.com/Perl/perl5/commit/4dce24e95e37ceefa905fa5030122e2e640216ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: 8de0a654f5da52c873392cee1fa03257eb7aa8f3
https://github.com/Perl/perl5/commit/8de0a654f5da52c873392cee1fa03257eb7aa8f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 0af532e60616d3fc82ec25a4bd858282961d04f3
https://github.com/Perl/perl5/commit/0af532e60616d3fc82ec25a4bd858282961d04f3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 2ceb8fb3ab8c75b3ad13faa1b0081815ad8986c4
https://github.com/Perl/perl5/commit/2ceb8fb3ab8c75b3ad13faa1b0081815ad8986c4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: bc8c35b2332a9581d7cf7b55096390ce81694ccb
https://github.com/Perl/perl5/commit/bc8c35b2332a9581d7cf7b55096390ce81694ccb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 294e3b16a33125a840f71db2b5db0a75af83eb51
https://github.com/Perl/perl5/commit/294e3b16a33125a840f71db2b5db0a75af83eb51
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: d1c2db2dce2f40234c6ae1cbdb77a5f721400ee0
https://github.com/Perl/perl5/commit/d1c2db2dce2f40234c6ae1cbdb77a5f721400ee0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: a51e8d1804bcf947db19af1d512b13c7b6ce16e2
https://github.com/Perl/perl5/commit/a51e8d1804bcf947db19af1d512b13c7b6ce16e2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: bf0518dbfdfa3f15016d918c5e39135d8f20d96c
https://github.com/Perl/perl5/commit/bf0518dbfdfa3f15016d918c5e39135d8f20d96c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 1163a1bfa71a2970f9a355126249ec6ad8bb03ad
https://github.com/Perl/perl5/commit/1163a1bfa71a2970f9a355126249ec6ad8bb03ad
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: 41f4e6d60ec281fa5f8c98aa7c480673bbb2feee
https://github.com/Perl/perl5/commit/41f4e6d60ec281fa5f8c98aa7c480673bbb2feee
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: b42c5cbf5ab88d9eedbc4f98c492e2c65d850863
https://github.com/Perl/perl5/commit/b42c5cbf5ab88d9eedbc4f98c492e2c65d850863
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 755ed57e5dca4b19e4095733172b13490153c5fa
https://github.com/Perl/perl5/commit/755ed57e5dca4b19e4095733172b13490153c5fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: c0907744421190b2c5a5ee6b2ad967724d7cd302
https://github.com/Perl/perl5/commit/c0907744421190b2c5a5ee6b2ad967724d7cd302
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 4ffe3c5f3bb9b651d87467337e2a55aca9c7bdfd
https://github.com/Perl/perl5/commit/4ffe3c5f3bb9b651d87467337e2a55aca9c7bdfd
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 0bf1f8d9448293d393b0441a2527c79ba1a3578a
https://github.com/Perl/perl5/commit/0bf1f8d9448293d393b0441a2527c79ba1a3578a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: de16b13338d956895c9a28300373faf44eede9b8
https://github.com/Perl/perl5/commit/de16b13338d956895c9a28300373faf44eede9b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 7c289a4896ae61b08f2b47fce472e3834309efe8
https://github.com/Perl/perl5/commit/7c289a4896ae61b08f2b47fce472e3834309efe8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 87d60755337683a2a841bb2896e3e19e538c0dc2
https://github.com/Perl/perl5/commit/87d60755337683a2a841bb2896e3e19e538c0dc2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: dc5415d0016fa755f35b3eb8c6205262378eaf71
https://github.com/Perl/perl5/commit/dc5415d0016fa755f35b3eb8c6205262378eaf71
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: 790e91914f885fae257aa82edfe255ed73715089
https://github.com/Perl/perl5/commit/790e91914f885fae257aa82edfe255ed73715089
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: b5d0a96f4b1b5930d30ac452ff23d0c6a02a0b1b
https://github.com/Perl/perl5/commit/b5d0a96f4b1b5930d30ac452ff23d0c6a02a0b1b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 2e94ac8b52eed548a3b36af2c1157db28b85e8d7
https://github.com/Perl/perl5/commit/2e94ac8b52eed548a3b36af2c1157db28b85e8d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: 10fac1186c0ae4e3cf3319ab0ba711680dee1fee
https://github.com/Perl/perl5/commit/10fac1186c0ae4e3cf3319ab0ba711680dee1fee
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 4661bb4642ea6424c8ec21b2e0f2526fbe5d96fc
https://github.com/Perl/perl5/commit/4661bb4642ea6424c8ec21b2e0f2526fbe5d96fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: 2561c5c3c2c6d4faf646e1d44036e4493be86486
https://github.com/Perl/perl5/commit/2561c5c3c2c6d4faf646e1d44036e4493be86486
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 70c509d56f20ccf2ce2c9ebe9a277eab46fb0e41
https://github.com/Perl/perl5/commit/70c509d56f20ccf2ce2c9ebe9a277eab46fb0e41
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: e5a2921e43e78e849a45c502c01539e41111b387
https://github.com/Perl/perl5/commit/e5a2921e43e78e849a45c502c01539e41111b387
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 8e0b74e21661510bac6509c6e11f1bed1c96af25
https://github.com/Perl/perl5/commit/8e0b74e21661510bac6509c6e11f1bed1c96af25
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: a3739592a0b826adc4670135912d297361af8a3a
https://github.com/Perl/perl5/commit/a3739592a0b826adc4670135912d297361af8a3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: d3b87f8ce3026e17967f5c9cbe13401b826724a6
https://github.com/Perl/perl5/commit/d3b87f8ce3026e17967f5c9cbe13401b826724a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 816ddeb358619e2ad1d6c9c2f183cd0679c86a6e
https://github.com/Perl/perl5/commit/816ddeb358619e2ad1d6c9c2f183cd0679c86a6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: 43afa2d9dc5f4418d51143a8cf86e661aa18d905
https://github.com/Perl/perl5/commit/43afa2d9dc5f4418d51143a8cf86e661aa18d905
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: b82f0463a47d62d1dd5970c3d9f080e90e300f57
https://github.com/Perl/perl5/commit/b82f0463a47d62d1dd5970c3d9f080e90e300f57
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 6fd5497ae3e3bbd799640f4ab205fce04141d4fe
https://github.com/Perl/perl5/commit/6fd5497ae3e3bbd799640f4ab205fce04141d4fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 87b30db28287e9f9093ba335202cd9ff23a7f53e
https://github.com/Perl/perl5/commit/87b30db28287e9f9093ba335202cd9ff23a7f53e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 684155b770887540a19cef958b258e4a2124c1e1
https://github.com/Perl/perl5/commit/684155b770887540a19cef958b258e4a2124c1e1
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 39df1bdb059ea1098ed5399f1fe3200578c05655
https://github.com/Perl/perl5/commit/39df1bdb059ea1098ed5399f1fe3200578c05655
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 579d0b272fab18880b2c19be313eef9b4e580f8e
https://github.com/Perl/perl5/commit/579d0b272fab18880b2c19be313eef9b4e580f8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: e20eac60344364e01f7c57d95833ee38a335f994
https://github.com/Perl/perl5/commit/e20eac60344364e01f7c57d95833ee38a335f994
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: aa7cde48dbcf63f8b06ffcfbbb8d413a46ad1908
https://github.com/Perl/perl5/commit/aa7cde48dbcf63f8b06ffcfbbb8d413a46ad1908
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: f71f71f5d73e1f455cf1aba491a7d6f3ed26e3f0
https://github.com/Perl/perl5/commit/f71f71f5d73e1f455cf1aba491a7d6f3ed26e3f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: d350505adf2ffbaa3e3f574d31d087d766ea3a5a
https://github.com/Perl/perl5/commit/d350505adf2ffbaa3e3f574d31d087d766ea3a5a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: d6a75396b10ae62e87a2019a8a25ff186d3ab73c
https://github.com/Perl/perl5/commit/d6a75396b10ae62e87a2019a8a25ff186d3ab73c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 5b9eefcc49be8829a4671f6285729ce4c16fd0eb
https://github.com/Perl/perl5/commit/5b9eefcc49be8829a4671f6285729ce4c16fd0eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 6694de72b86c24f180efa7d5e96e672688fc97ef
https://github.com/Perl/perl5/commit/6694de72b86c24f180efa7d5e96e672688fc97ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: f8cce73ef9df8d3f671522850ffb55d7cb0b4d68
https://github.com/Perl/perl5/commit/f8cce73ef9df8d3f671522850ffb55d7cb0b4d68
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: 013f8cca352a249b3d37ec96bdbf42cc220a82f9
https://github.com/Perl/perl5/commit/013f8cca352a249b3d37ec96bdbf42cc220a82f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 01ee3087e5bb23af919b152e1518dd2e50e7b49b
https://github.com/Perl/perl5/commit/01ee3087e5bb23af919b152e1518dd2e50e7b49b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: be16c5455f13e733aba6cf2c4be45bb1153f275d
https://github.com/Perl/perl5/commit/be16c5455f13e733aba6cf2c4be45bb1153f275d
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 9490859b880c479b82b9a1b5eed5db51def6d4e6
https://github.com/Perl/perl5/commit/9490859b880c479b82b9a1b5eed5db51def6d4e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: acdd9e440262357fba9c62b6df77ff066fc9c775
https://github.com/Perl/perl5/commit/acdd9e440262357fba9c62b6df77ff066fc9c775
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: c0cf98b1e8537bae461275b6f3e852ff4da6da5c
https://github.com/Perl/perl5/commit/c0cf98b1e8537bae461275b6f3e852ff4da6da5c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: d1e5f6849a8894e2f8d9d841835934569b3fcc51
https://github.com/Perl/perl5/commit/d1e5f6849a8894e2f8d9d841835934569b3fcc51
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 4a84bf5676e1d0bcabb17083413787cb2707c2df
https://github.com/Perl/perl5/commit/4a84bf5676e1d0bcabb17083413787cb2707c2df
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: b9cb0b25a8109f57b8d71e459a828539b09e9edb
https://github.com/Perl/perl5/commit/b9cb0b25a8109f57b8d71e459a828539b09e9edb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 1b0cb7cb2949459cf1358348b7f9cfbb0927eac2
https://github.com/Perl/perl5/commit/1b0cb7cb2949459cf1358348b7f9cfbb0927eac2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: c4fa062caa2f44010fe11a5698913f58e3213839
https://github.com/Perl/perl5/commit/c4fa062caa2f44010fe11a5698913f58e3213839
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 52a7cf3e83ec60ae61b0824efd51374fcf667c1c
https://github.com/Perl/perl5/commit/52a7cf3e83ec60ae61b0824efd51374fcf667c1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: 60fb40839db93965edc0c1e7927f91b56e2f266c
https://github.com/Perl/perl5/commit/60fb40839db93965edc0c1e7927f91b56e2f266c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 482d5f51a5c279fb29e1e2577808f84b31375705
https://github.com/Perl/perl5/commit/482d5f51a5c279fb29e1e2577808f84b31375705
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: afd700f1b83562979355e5257f612b5a7fadf6b2
https://github.com/Perl/perl5/commit/afd700f1b83562979355e5257f612b5a7fadf6b2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 6734e12e95e54d984f9ab8a03e209a28aa5fb374
https://github.com/Perl/perl5/commit/6734e12e95e54d984f9ab8a03e209a28aa5fb374
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: f4b3ad9c040d90fe04654bf8a2d00187aa040b76
https://github.com/Perl/perl5/commit/f4b3ad9c040d90fe04654bf8a2d00187aa040b76
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 77f49b39c255f23b4c67423a0aa8a834a28c3141
https://github.com/Perl/perl5/commit/77f49b39c255f23b4c67423a0aa8a834a28c3141
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 912bc10f31cba392f4e17ee62e328356ac31a735
https://github.com/Perl/perl5/commit/912bc10f31cba392f4e17ee62e328356ac31a735
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 69ccef6dd3db01bb0cc9eb377cd0381d7dc9a6a6
https://github.com/Perl/perl5/commit/69ccef6dd3db01bb0cc9eb377cd0381d7dc9a6a6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 5a5d7a41431cb2298f78d47b6cce4c710a2ee1be
https://github.com/Perl/perl5/commit/5a5d7a41431cb2298f78d47b6cce4c710a2ee1be
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 06f039db63b5c798178d41590a4be79d34424b19
https://github.com/Perl/perl5/commit/06f039db63b5c798178d41590a4be79d34424b19
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 76a4233f65450a4118724c6591274574dfc1e925
https://github.com/Perl/perl5/commit/76a4233f65450a4118724c6591274574dfc1e925
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 95f48b1356c33b58e5b752c2915a2660da6d74f4
https://github.com/Perl/perl5/commit/95f48b1356c33b58e5b752c2915a2660da6d74f4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 87c60ae26137db24466f3cf6fe8e6e6d5633c413
https://github.com/Perl/perl5/commit/87c60ae26137db24466f3cf6fe8e6e6d5633c413
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: d2db0598746e461693561a58dcb3f5debe13731e
https://github.com/Perl/perl5/commit/d2db0598746e461693561a58dcb3f5debe13731e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 5961bb087c7b537ba68b00bbeeb3b80711d9ae3c
https://github.com/Perl/perl5/commit/5961bb087c7b537ba68b00bbeeb3b80711d9ae3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: bdbdde9b3a2c9cf2a140608593ca83fffae1e35d
https://github.com/Perl/perl5/commit/bdbdde9b3a2c9cf2a140608593ca83fffae1e35d
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 8663a40c851c82e219b8662d4ae7c7f4a1d8778b
https://github.com/Perl/perl5/commit/8663a40c851c82e219b8662d4ae7c7f4a1d8778b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 1738469660998c88c56311af9313cd569fe93896
https://github.com/Perl/perl5/commit/1738469660998c88c56311af9313cd569fe93896
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 420c7cc06f7d4e327569a5d6fa0430d3b56ed530
https://github.com/Perl/perl5/commit/420c7cc06f7d4e327569a5d6fa0430d3b56ed530
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: 5269aaef87bf7c2b63f9ddb7103f6435c620f043
https://github.com/Perl/perl5/commit/5269aaef87bf7c2b63f9ddb7103f6435c620f043
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 718c6ba1a727408748aaa0ea12d13569966ad8dd
https://github.com/Perl/perl5/commit/718c6ba1a727408748aaa0ea12d13569966ad8dd
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 7ef1edf2822daa747c6a4990bf0d720a7b7bb529
https://github.com/Perl/perl5/commit/7ef1edf2822daa747c6a4990bf0d720a7b7bb529
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 2e2dd25dbaf9d0dfc5341b632b8b76c7b57a038e
https://github.com/Perl/perl5/commit/2e2dd25dbaf9d0dfc5341b632b8b76c7b57a038e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 41e71bcee1950641db45d4fd0d087916e7f3a1fa
https://github.com/Perl/perl5/commit/41e71bcee1950641db45d4fd0d087916e7f3a1fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: efd6a3a8e7f758251a5e2316098096a2a83f77ce
https://github.com/Perl/perl5/commit/efd6a3a8e7f758251a5e2316098096a2a83f77ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 742c93864964ac8d9e60e3209e8554305e73a6a7
https://github.com/Perl/perl5/commit/742c93864964ac8d9e60e3209e8554305e73a6a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 9589089df85128b47696aff529eb961259d3f0fa
https://github.com/Perl/perl5/commit/9589089df85128b47696aff529eb961259d3f0fa
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 2971566580f35d1b1e7242c7adff030900f84630
https://github.com/Perl/perl5/commit/2971566580f35d1b1e7242c7adff030900f84630
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 55fcb9061ab9c9f23b2004bc84fdc4608a9236af
https://github.com/Perl/perl5/commit/55fcb9061ab9c9f23b2004bc84fdc4608a9236af
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: cd2ba92f442538929ff9bf6ec990a8cdbac0d179
https://github.com/Perl/perl5/commit/cd2ba92f442538929ff9bf6ec990a8cdbac0d179
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: be459db8cd3108d2c41acab77d3fc091fe9095ca
https://github.com/Perl/perl5/commit/be459db8cd3108d2c41acab77d3fc091fe9095ca
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: 41cc7dba0200ebedd0d800cbd701269fb625cf72
https://github.com/Perl/perl5/commit/41cc7dba0200ebedd0d800cbd701269fb625cf72
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: ab1cb184f517f75b390f2abf405e6ecb3100be55
https://github.com/Perl/perl5/commit/ab1cb184f517f75b390f2abf405e6ecb3100be55
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: b6c553ea147cb3e2941ddaf8657bd9a61b8a71cc
https://github.com/Perl/perl5/commit/b6c553ea147cb3e2941ddaf8657bd9a61b8a71cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: ef8bcdf1072ab2c9224bb5f29f96076d8f5209d8
https://github.com/Perl/perl5/commit/ef8bcdf1072ab2c9224bb5f29f96076d8f5209d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: c89699d2c334d49ff0d94a2898bd66728fe0d427
https://github.com/Perl/perl5/commit/c89699d2c334d49ff0d94a2898bd66728fe0d427
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: c58c781db8e71b2b601181cb37b45b03763a8f31
https://github.com/Perl/perl5/commit/c58c781db8e71b2b601181cb37b45b03763a8f31
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: c9769eabca2ab4b4dec2a9e9c0ede971aece4e80
https://github.com/Perl/perl5/commit/c9769eabca2ab4b4dec2a9e9c0ede971aece4e80
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: d0fff5a4430a3310a387445476fc78e613c132db
https://github.com/Perl/perl5/commit/d0fff5a4430a3310a387445476fc78e613c132db
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 341e63869e811307c246e4cfeb897dcbd57934a7
https://github.com/Perl/perl5/commit/341e63869e811307c246e4cfeb897dcbd57934a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: 8bc36045e4d1f6dbd3824fde3910dd351dab3040
https://github.com/Perl/perl5/commit/8bc36045e4d1f6dbd3824fde3910dd351dab3040
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: c66a1cb36438f60a8a2d03b99c8a7f72ede25d76
https://github.com/Perl/perl5/commit/c66a1cb36438f60a8a2d03b99c8a7f72ede25d76
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: de4735b0fe8aa59af797e04c36d8be211647a678
https://github.com/Perl/perl5/commit/de4735b0fe8aa59af797e04c36d8be211647a678
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: f85335b0dd7bb224bc23e179e09fcc4f39955745
https://github.com/Perl/perl5/commit/f85335b0dd7bb224bc23e179e09fcc4f39955745
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 13b80a52a6d145a21f19ab43eff928e6df9692d1
https://github.com/Perl/perl5/commit/13b80a52a6d145a21f19ab43eff928e6df9692d1
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: 7f7701f0c5c791751b31e679df26e2415333b6d7
https://github.com/Perl/perl5/commit/7f7701f0c5c791751b31e679df26e2415333b6d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: fec7a8c7dbb097241005b0423f316bc6ea664be0
https://github.com/Perl/perl5/commit/fec7a8c7dbb097241005b0423f316bc6ea664be0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 8e3afe5ee62f3c0f415a14f0a23fe043b43abc53
https://github.com/Perl/perl5/commit/8e3afe5ee62f3c0f415a14f0a23fe043b43abc53
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: f15a00aaf35a8ba9ade48e7be2cc3babed0a5331
https://github.com/Perl/perl5/commit/f15a00aaf35a8ba9ade48e7be2cc3babed0a5331
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 1c86588ff731b6f467511e4f8e4ff59b83e5ace8
https://github.com/Perl/perl5/commit/1c86588ff731b6f467511e4f8e4ff59b83e5ace8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: e6db9f3872884f0a6d40eb9a60873ee367e05c07
https://github.com/Perl/perl5/commit/e6db9f3872884f0a6d40eb9a60873ee367e05c07
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 58f85b70457958ac01aad516b7b2b361ad112af3
https://github.com/Perl/perl5/commit/58f85b70457958ac01aad516b7b2b361ad112af3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: f8e5fea5e0d58facc7707bf5e01df97d770f56db
https://github.com/Perl/perl5/commit/f8e5fea5e0d58facc7707bf5e01df97d770f56db
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 1d22d2b7d2f1e0490b3f62715edf78b218400cf8
https://github.com/Perl/perl5/commit/1d22d2b7d2f1e0490b3f62715edf78b218400cf8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 6cb9685cfddd824262a8902d7be8770e48de24f9
https://github.com/Perl/perl5/commit/6cb9685cfddd824262a8902d7be8770e48de24f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 6cd2643d60a52b220537e12212d5a5d9fc357853
https://github.com/Perl/perl5/commit/6cd2643d60a52b220537e12212d5a5d9fc357853
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 8cf755508f35f4df91619594abb18c2ca8e2dced
https://github.com/Perl/perl5/commit/8cf755508f35f4df91619594abb18c2ca8e2dced
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 0d5d748b085aebbefc0faaa438c14b8fa0cfeba8
https://github.com/Perl/perl5/commit/0d5d748b085aebbefc0faaa438c14b8fa0cfeba8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 5b7f9f16960e8adaa4b14907fd70bc0f667cc815
https://github.com/Perl/perl5/commit/5b7f9f16960e8adaa4b14907fd70bc0f667cc815
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 9eb83954975be19b74cd26ff354fbdbeb9751b58
https://github.com/Perl/perl5/commit/9eb83954975be19b74cd26ff354fbdbeb9751b58
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 0f5a919b41484b4b9f9002ee15666cd169ede9a2
https://github.com/Perl/perl5/commit/0f5a919b41484b4b9f9002ee15666cd169ede9a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 03ded8d5cbb429094ee7ffb0391d829b1a9ae868
https://github.com/Perl/perl5/commit/03ded8d5cbb429094ee7ffb0391d829b1a9ae868
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: eb8a87187bcfcb8231f3a54b9d5a24d65d2efb99
https://github.com/Perl/perl5/commit/eb8a87187bcfcb8231f3a54b9d5a24d65d2efb99
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: fe68bc0ed919869d7350164968b2f765c82debc7
https://github.com/Perl/perl5/commit/fe68bc0ed919869d7350164968b2f765c82debc7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: e5c792f462801cd11db8c45f4f0500ad7ff56abe
https://github.com/Perl/perl5/commit/e5c792f462801cd11db8c45f4f0500ad7ff56abe
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 60b43cad59e1356c54c57b8df26fed70eef20664
https://github.com/Perl/perl5/commit/60b43cad59e1356c54c57b8df26fed70eef20664
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 0e9b065fca87ca3c1e56f75cf2b414725e4404d4
https://github.com/Perl/perl5/commit/0e9b065fca87ca3c1e56f75cf2b414725e4404d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: f53d5bf8837183a0041cdfc560537df3ba52370e
https://github.com/Perl/perl5/commit/f53d5bf8837183a0041cdfc560537df3ba52370e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 034ff9613908d733d8db20079d322eed85b9d163
https://github.com/Perl/perl5/commit/034ff9613908d733d8db20079d322eed85b9d163
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: a616e1ec142993852ea16d22f3ede92937939739
https://github.com/Perl/perl5/commit/a616e1ec142993852ea16d22f3ede92937939739
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: 213d7008547bb3fb56ff8cc9052cdd9fe7aed212
https://github.com/Perl/perl5/commit/213d7008547bb3fb56ff8cc9052cdd9fe7aed212
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: 3a64ad057bb7978924b2c04f4879b55c4c1f74a8
https://github.com/Perl/perl5/commit/3a64ad057bb7978924b2c04f4879b55c4c1f74a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 44d27e7c504af13907f851d2128c222464ebdb3c
https://github.com/Perl/perl5/commit/44d27e7c504af13907f851d2128c222464ebdb3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 142f3c320195500d24c23365a7f7230895d4ad3c
https://github.com/Perl/perl5/commit/142f3c320195500d24c23365a7f7230895d4ad3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: d8d24c9bf23009fb20ea4ef26f2c73bf17328a64
https://github.com/Perl/perl5/commit/d8d24c9bf23009fb20ea4ef26f2c73bf17328a64
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: eeb0f36a199db768d7c0d5e1eba5d3f8eba92714
https://github.com/Perl/perl5/commit/eeb0f36a199db768d7c0d5e1eba5d3f8eba92714
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: c9c9d05da8301d57afcc21e30f795c21048b66fd
https://github.com/Perl/perl5/commit/c9c9d05da8301d57afcc21e30f795c21048b66fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 920edee475314cef35eaef37e4b8f7a66dd37328
https://github.com/Perl/perl5/commit/920edee475314cef35eaef37e4b8f7a66dd37328
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: ae9d6c2cc4775414d2f7d022f3d8f95fba3cd07f
https://github.com/Perl/perl5/commit/ae9d6c2cc4775414d2f7d022f3d8f95fba3cd07f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 623c6fbd3c591588f5a52f1b8efb1e130f6b6808
https://github.com/Perl/perl5/commit/623c6fbd3c591588f5a52f1b8efb1e130f6b6808
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: 999cc516fc1bde6f4724418ac66cc7a1be551e34
https://github.com/Perl/perl5/commit/999cc516fc1bde6f4724418ac66cc7a1be551e34
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 2104a947d930ff3e3b2e8a91c8ea09aace76fb23
https://github.com/Perl/perl5/commit/2104a947d930ff3e3b2e8a91c8ea09aace76fb23
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: b740be7a7cf802777cfdcb6f0ec47e960ab9bdab
https://github.com/Perl/perl5/commit/b740be7a7cf802777cfdcb6f0ec47e960ab9bdab
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 739126d5b9b8d0e1fb96902f43ffb42265d24153
https://github.com/Perl/perl5/commit/739126d5b9b8d0e1fb96902f43ffb42265d24153
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: 08d5dcfc4e216caac858a3f92296f55894ef50fb
https://github.com/Perl/perl5/commit/08d5dcfc4e216caac858a3f92296f55894ef50fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: e9ed48cfe6d76a04bac438c6905f461223f2dabb
https://github.com/Perl/perl5/commit/e9ed48cfe6d76a04bac438c6905f461223f2dabb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: ce8b9b0e3a4ccfb03461923d5f59702d9592c672
https://github.com/Perl/perl5/commit/ce8b9b0e3a4ccfb03461923d5f59702d9592c672
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 32d990697210ad259a6b2115beb373156e58bcf6
https://github.com/Perl/perl5/commit/32d990697210ad259a6b2115beb373156e58bcf6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 88ddc8b54352f4d12171b5681daa2476e2349371
https://github.com/Perl/perl5/commit/88ddc8b54352f4d12171b5681daa2476e2349371
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 6b31546971ab196c3b65fd7b863b128361b2f255
https://github.com/Perl/perl5/commit/6b31546971ab196c3b65fd7b863b128361b2f255
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: 10d88bc5e8b02cc75e24ccc675b9adc91e968881
https://github.com/Perl/perl5/commit/10d88bc5e8b02cc75e24ccc675b9adc91e968881
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: d14c600c2f03f3540366603d317ef0eae835efeb
https://github.com/Perl/perl5/commit/d14c600c2f03f3540366603d317ef0eae835efeb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: d1f48cebcf60b7d332b211e432abfa09053cb7ee
https://github.com/Perl/perl5/commit/d1f48cebcf60b7d332b211e432abfa09053cb7ee
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: bdf57a252315be12273f4f6d4e1af428be897dd2
https://github.com/Perl/perl5/commit/bdf57a252315be12273f4f6d4e1af428be897dd2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: af542f7741e1d04f6781d0826530862300bcea72
https://github.com/Perl/perl5/commit/af542f7741e1d04f6781d0826530862300bcea72
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: d89b281d1ba2bdfea6742cb2283c9a466e08f31a
https://github.com/Perl/perl5/commit/d89b281d1ba2bdfea6742cb2283c9a466e08f31a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: d16adc82826a0a961c98ce08bcfddc778ea12eb4
https://github.com/Perl/perl5/commit/d16adc82826a0a961c98ce08bcfddc778ea12eb4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 324f0fb6bb15033d14ace527e45f06174f06330c
https://github.com/Perl/perl5/commit/324f0fb6bb15033d14ace527e45f06174f06330c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 4c47f47d1cef3960ee62c0ae685eee69801731cf
https://github.com/Perl/perl5/commit/4c47f47d1cef3960ee62c0ae685eee69801731cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 5431913b853e6a971f84a8d170f4751034501a6f
https://github.com/Perl/perl5/commit/5431913b853e6a971f84a8d170f4751034501a6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 519d6cba8d65cfc8656525bbd9bd2ba1282c4191
https://github.com/Perl/perl5/commit/519d6cba8d65cfc8656525bbd9bd2ba1282c4191
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: a863e1b470da8fd5faac54c0334aae41018be6a1
https://github.com/Perl/perl5/commit/a863e1b470da8fd5faac54c0334aae41018be6a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 229236b6b138045a16da0a373b93f808bd8c9ea8
https://github.com/Perl/perl5/commit/229236b6b138045a16da0a373b93f808bd8c9ea8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 70cff110463e3c5b7f4f7dff19c178fce49c9797
https://github.com/Perl/perl5/commit/70cff110463e3c5b7f4f7dff19c178fce49c9797
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: b69e136306acd2607406d6fb2a0792cb6734cd1e
https://github.com/Perl/perl5/commit/b69e136306acd2607406d6fb2a0792cb6734cd1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 1c0c2e9055341888073286ab6f02ef871fe2516e
https://github.com/Perl/perl5/commit/1c0c2e9055341888073286ab6f02ef871fe2516e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: d66d7e7ee140fcb8133867e57e1dcbc767665eea
https://github.com/Perl/perl5/commit/d66d7e7ee140fcb8133867e57e1dcbc767665eea
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 665079b364a9599fbb6e1473e1631f75b0937c1f
https://github.com/Perl/perl5/commit/665079b364a9599fbb6e1473e1631f75b0937c1f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 9166bec21e3cf8c72756039bbfba67edf2cf19e0
https://github.com/Perl/perl5/commit/9166bec21e3cf8c72756039bbfba67edf2cf19e0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: a91668112a0a57d1ea9f03b92baacf7e770e00ab
https://github.com/Perl/perl5/commit/a91668112a0a57d1ea9f03b92baacf7e770e00ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: 78593d60f235c47bdc41395459d0c896f96ac145
https://github.com/Perl/perl5/commit/78593d60f235c47bdc41395459d0c896f96ac145
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 236a430c18a0d632cf58bf5c418dc5501d8a9650
https://github.com/Perl/perl5/commit/236a430c18a0d632cf58bf5c418dc5501d8a9650
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 232a86b0c0efaf91f5634d5f53a316559cccd276
https://github.com/Perl/perl5/commit/232a86b0c0efaf91f5634d5f53a316559cccd276
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 3881d6ec1fe35789e7c8883db92c5eb3d4c35392
https://github.com/Perl/perl5/commit/3881d6ec1fe35789e7c8883db92c5eb3d4c35392
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 56c45b308d1a5adb3040383ae77d2d77ae02c968
https://github.com/Perl/perl5/commit/56c45b308d1a5adb3040383ae77d2d77ae02c968
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: f8b3a54d130337305bd0cd598e829a29a96b54ef
https://github.com/Perl/perl5/commit/f8b3a54d130337305bd0cd598e829a29a96b54ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: a31c91a9bfd493754674181904cad0f59b6fd9a9
https://github.com/Perl/perl5/commit/a31c91a9bfd493754674181904cad0f59b6fd9a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: 3fd355b288df03fad9a68202e019941970257ab8
https://github.com/Perl/perl5/commit/3fd355b288df03fad9a68202e019941970257ab8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: f2dbe0f26782ff9d7f8ff555b97181ef483a5c2a
https://github.com/Perl/perl5/commit/f2dbe0f26782ff9d7f8ff555b97181ef483a5c2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: e365b1f12f2875bb0bc2a99b98bc1d3ea558bb38
https://github.com/Perl/perl5/commit/e365b1f12f2875bb0bc2a99b98bc1d3ea558bb38
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 288ed6cb5a3a7cbed2e27c7d94823cfc8b5f1a51
https://github.com/Perl/perl5/commit/288ed6cb5a3a7cbed2e27c7d94823cfc8b5f1a51
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 8d770cdc521e437b219ffc4683f5954934658208
https://github.com/Perl/perl5/commit/8d770cdc521e437b219ffc4683f5954934658208
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
43
Compare: https://github.com/Perl/perl5/compare/fa549dd3869e...8d770cdc521e
