Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: c112aeefff30b65b273cf0d9d87ef28192401be6
https://github.com/Perl/perl5/commit/c112aeefff30b65b273cf0d9d87ef28192401be6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
perlapi: Rmv repeated word
Commit: 39dbb5e5a53003c688cc723dbdfb370f4eb3b820
https://github.com/Perl/perl5/commit/39dbb5e5a53003c688cc723dbdfb370f4eb3b820
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: 4777e01bc06b4c1e24eaf2938e59a818273aa24e
https://github.com/Perl/perl5/commit/4777e01bc06b4c1e24eaf2938e59a818273aa24e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 0966792337d2040e6d9f6231352c62518748961c
https://github.com/Perl/perl5/commit/0966792337d2040e6d9f6231352c62518748961c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 62b18b105ed7896a1d71fb9e8652ba241d1da9ac
https://github.com/Perl/perl5/commit/62b18b105ed7896a1d71fb9e8652ba241d1da9ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: e74f26354f9253c9d8b35ec2e397e0aebd448a4a
https://github.com/Perl/perl5/commit/e74f26354f9253c9d8b35ec2e397e0aebd448a4a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 228588997450bd9800be0a301a9623ffe691a7c1
https://github.com/Perl/perl5/commit/228588997450bd9800be0a301a9623ffe691a7c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: c2cbd8c9bbe69fd43152ff68aa9c170951aaf3b9
https://github.com/Perl/perl5/commit/c2cbd8c9bbe69fd43152ff68aa9c170951aaf3b9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: 13504c966c1d7dde4579931f55fcc4b3d202ac09
https://github.com/Perl/perl5/commit/13504c966c1d7dde4579931f55fcc4b3d202ac09
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: f87e16002fab7eedcc1aa1550100357116bba477
https://github.com/Perl/perl5/commit/f87e16002fab7eedcc1aa1550100357116bba477
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: 356303d3e2213e45f3576cec4aefd6bd047bb3a2
https://github.com/Perl/perl5/commit/356303d3e2213e45f3576cec4aefd6bd047bb3a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 5081de98a764a32025877f06df226bcc9daee40b
https://github.com/Perl/perl5/commit/5081de98a764a32025877f06df226bcc9daee40b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 3b692e96017a26ff67a7bdf7656c1012d10bc181
https://github.com/Perl/perl5/commit/3b692e96017a26ff67a7bdf7656c1012d10bc181
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 35dcde6570ef72e7f367e58dcccd4ec1d1a525b3
https://github.com/Perl/perl5/commit/35dcde6570ef72e7f367e58dcccd4ec1d1a525b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 54085b33da514a7faa96c8e6c4b4cdb8ae41b01b
https://github.com/Perl/perl5/commit/54085b33da514a7faa96c8e6c4b4cdb8ae41b01b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: ee13aca21104db7036b43350b2ad4ac356fb34a1
https://github.com/Perl/perl5/commit/ee13aca21104db7036b43350b2ad4ac356fb34a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 9faa92cab4205302e2bf9575d7e75896ac4e592a
https://github.com/Perl/perl5/commit/9faa92cab4205302e2bf9575d7e75896ac4e592a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: eca127a249934ee2663f7081740c231223288c9e
https://github.com/Perl/perl5/commit/eca127a249934ee2663f7081740c231223288c9e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 3fbacaeb52f3e95fc2d652834c96321e09acf0bf
https://github.com/Perl/perl5/commit/3fbacaeb52f3e95fc2d652834c96321e09acf0bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: 4efd09f5307e72174728739f2df3b39d12b13517
https://github.com/Perl/perl5/commit/4efd09f5307e72174728739f2df3b39d12b13517
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: fc913390365049d661c18b255d6d855da8919aa6
https://github.com/Perl/perl5/commit/fc913390365049d661c18b255d6d855da8919aa6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 4534aae4789206ee6618085b6d15376beb7a2d1c
https://github.com/Perl/perl5/commit/4534aae4789206ee6618085b6d15376beb7a2d1c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: e136fa30708804103f0f3c1bdda83ec5ea3bacb2
https://github.com/Perl/perl5/commit/e136fa30708804103f0f3c1bdda83ec5ea3bacb2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: 9b5e9ee9dc2c84cfa96fbafff62eb5d89af3c207
https://github.com/Perl/perl5/commit/9b5e9ee9dc2c84cfa96fbafff62eb5d89af3c207
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: db2c90cb73f2ae2da0b316ed3c66b5974c86b5f0
https://github.com/Perl/perl5/commit/db2c90cb73f2ae2da0b316ed3c66b5974c86b5f0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: e14ee83ecf916a05b234f3d9266e81f6a15538e9
https://github.com/Perl/perl5/commit/e14ee83ecf916a05b234f3d9266e81f6a15538e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: d1cd594e12a9de09130cb2c0b1f3cd86f0fb7fe8
https://github.com/Perl/perl5/commit/d1cd594e12a9de09130cb2c0b1f3cd86f0fb7fe8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: c786990659d1257e4b88c728832da984c2ee6d2e
https://github.com/Perl/perl5/commit/c786990659d1257e4b88c728832da984c2ee6d2e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: a00c18eda9355588b5a82c7d1a1412f1f5d1adad
https://github.com/Perl/perl5/commit/a00c18eda9355588b5a82c7d1a1412f1f5d1adad
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: dd7b521f14854b65deb07545330039806d4da3bf
https://github.com/Perl/perl5/commit/dd7b521f14854b65deb07545330039806d4da3bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: 300ca5675379e39ebbaa815ae4acf62e57e5c444
https://github.com/Perl/perl5/commit/300ca5675379e39ebbaa815ae4acf62e57e5c444
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: 029b207a398e34e9b8e46670ccbf20755c90a788
https://github.com/Perl/perl5/commit/029b207a398e34e9b8e46670ccbf20755c90a788
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 660246f72a0c5e81e926fcd5fe1a41d9ca738ae7
https://github.com/Perl/perl5/commit/660246f72a0c5e81e926fcd5fe1a41d9ca738ae7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: f9003406537698b70283646cd86e8715993693c8
https://github.com/Perl/perl5/commit/f9003406537698b70283646cd86e8715993693c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: 1444f87dd058883b2d8bae787a35d94669444f30
https://github.com/Perl/perl5/commit/1444f87dd058883b2d8bae787a35d94669444f30
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 9fb234395b9769f85754f69d585c86525e20821a
https://github.com/Perl/perl5/commit/9fb234395b9769f85754f69d585c86525e20821a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: a7e70247178096e0132ef8388cb3e34aaa4ea19a
https://github.com/Perl/perl5/commit/a7e70247178096e0132ef8388cb3e34aaa4ea19a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 659d69fa25f7e85bb72c746ba536fa6a1be8568a
https://github.com/Perl/perl5/commit/659d69fa25f7e85bb72c746ba536fa6a1be8568a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: 3805eb11850ec773366f46558ca3f2a329906303
https://github.com/Perl/perl5/commit/3805eb11850ec773366f46558ca3f2a329906303
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 73c801deaf4f57781b4da596583028e16df77d8d
https://github.com/Perl/perl5/commit/73c801deaf4f57781b4da596583028e16df77d8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: d6b3e7bcc89a671df6eab192d8952a172ac4f206
https://github.com/Perl/perl5/commit/d6b3e7bcc89a671df6eab192d8952a172ac4f206
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: c65c168bd55ef441be86bba377b9f3175a822159
https://github.com/Perl/perl5/commit/c65c168bd55ef441be86bba377b9f3175a822159
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: 8f787fa0e5e292da0557f45df2db218eca5d247b
https://github.com/Perl/perl5/commit/8f787fa0e5e292da0557f45df2db218eca5d247b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: de9ae1da9d575167cff60e8f97bb0730fc1ed966
https://github.com/Perl/perl5/commit/de9ae1da9d575167cff60e8f97bb0730fc1ed966
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: 2297a7e433a4463f095cdf5e213c66816b25b587
https://github.com/Perl/perl5/commit/2297a7e433a4463f095cdf5e213c66816b25b587
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 9f786544c9f368c2afe762e705332ad7a0f1c238
https://github.com/Perl/perl5/commit/9f786544c9f368c2afe762e705332ad7a0f1c238
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 622caf61407fbbdf8d677ba01b35f2f7e75a1c4c
https://github.com/Perl/perl5/commit/622caf61407fbbdf8d677ba01b35f2f7e75a1c4c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: c0d1daab2c0c9a83b655152bf396379a33d75be0
https://github.com/Perl/perl5/commit/c0d1daab2c0c9a83b655152bf396379a33d75be0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 5eefce416db4113c14e77594f61053ff13c5c682
https://github.com/Perl/perl5/commit/5eefce416db4113c14e77594f61053ff13c5c682
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 18dfeedcfed3778505d1600c58b3ed131981fa69
https://github.com/Perl/perl5/commit/18dfeedcfed3778505d1600c58b3ed131981fa69
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: 015ba90a4ebc9e9ae550e69b94b385f4f0dcc3ff
https://github.com/Perl/perl5/commit/015ba90a4ebc9e9ae550e69b94b385f4f0dcc3ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: 84ce715ee86f67516a883061d79187625a348fc3
https://github.com/Perl/perl5/commit/84ce715ee86f67516a883061d79187625a348fc3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 97d51d0eb2027052c47f152768355a64cf431275
https://github.com/Perl/perl5/commit/97d51d0eb2027052c47f152768355a64cf431275
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: f840bdbe5084014ffe54d77101483f4149edb8d2
https://github.com/Perl/perl5/commit/f840bdbe5084014ffe54d77101483f4149edb8d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: bb26a9c703e85460aa783f071977f2caa9c4b608
https://github.com/Perl/perl5/commit/bb26a9c703e85460aa783f071977f2caa9c4b608
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: af05c72e5b432d0db7d96434aa247f4163699972
https://github.com/Perl/perl5/commit/af05c72e5b432d0db7d96434aa247f4163699972
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: 21b5f43756fc985ae1d0b7ec51ab79627a3fccc4
https://github.com/Perl/perl5/commit/21b5f43756fc985ae1d0b7ec51ab79627a3fccc4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 77686478c90788624e4877e64ad444bac807e0bf
https://github.com/Perl/perl5/commit/77686478c90788624e4877e64ad444bac807e0bf
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: a8533824c68021ce1bc74036dc9a709436edbb38
https://github.com/Perl/perl5/commit/a8533824c68021ce1bc74036dc9a709436edbb38
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: 2a5d84c015d244c3cb2bff72b3f09a6532827f5e
https://github.com/Perl/perl5/commit/2a5d84c015d244c3cb2bff72b3f09a6532827f5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 6fcde750c6ea542795b5160ddd4bea7f4b12306f
https://github.com/Perl/perl5/commit/6fcde750c6ea542795b5160ddd4bea7f4b12306f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: ebea65e75ddad384dafc36a6c77d953e57a66863
https://github.com/Perl/perl5/commit/ebea65e75ddad384dafc36a6c77d953e57a66863
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: 3d46c1b1dc18887ab1c952717792b39d79f39d1e
https://github.com/Perl/perl5/commit/3d46c1b1dc18887ab1c952717792b39d79f39d1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: 0b08d36695263d4d5bedab8b916690c0df5a731a
https://github.com/Perl/perl5/commit/0b08d36695263d4d5bedab8b916690c0df5a731a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 19a3750109978fca5099cfeffd73cd22eed74531
https://github.com/Perl/perl5/commit/19a3750109978fca5099cfeffd73cd22eed74531
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: e9bec9de95de4946dcbf0f030738f148f762c931
https://github.com/Perl/perl5/commit/e9bec9de95de4946dcbf0f030738f148f762c931
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: b0e81a53d51dccdb25a947f8c213b4b57c746208
https://github.com/Perl/perl5/commit/b0e81a53d51dccdb25a947f8c213b4b57c746208
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 641b8aa3636da0e08d00d26e6c6d8200b3bbfb59
https://github.com/Perl/perl5/commit/641b8aa3636da0e08d00d26e6c6d8200b3bbfb59
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: a2232f994c38a02295bdb22c280b0300db1949e9
https://github.com/Perl/perl5/commit/a2232f994c38a02295bdb22c280b0300db1949e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: 1d0d2ddf7c2fdad6e52c3fac0d8b95e5108d6307
https://github.com/Perl/perl5/commit/1d0d2ddf7c2fdad6e52c3fac0d8b95e5108d6307
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: b7d6afa202335fa2d4b781d629f63c156082657a
https://github.com/Perl/perl5/commit/b7d6afa202335fa2d4b781d629f63c156082657a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: b8bb7332e17be61cb65dbb74ae3c6178b42394aa
https://github.com/Perl/perl5/commit/b8bb7332e17be61cb65dbb74ae3c6178b42394aa
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: a069ee45ee496932cbb8479729684fe38949f995
https://github.com/Perl/perl5/commit/a069ee45ee496932cbb8479729684fe38949f995
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: cb438576af040ee0b3bcdbffcf7d3eb9150abe25
https://github.com/Perl/perl5/commit/cb438576af040ee0b3bcdbffcf7d3eb9150abe25
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 7561797d94bc67d207a62a8f5d60aad2e36a14df
https://github.com/Perl/perl5/commit/7561797d94bc67d207a62a8f5d60aad2e36a14df
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: c41c17aef0a464235c2956fa1f72619f5ab9ed21
https://github.com/Perl/perl5/commit/c41c17aef0a464235c2956fa1f72619f5ab9ed21
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: eb3834dea5f54e22051bc067a07ca8fdf15d1fec
https://github.com/Perl/perl5/commit/eb3834dea5f54e22051bc067a07ca8fdf15d1fec
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: ba8dbfcd27514a5cc7e3ee9e7cd27af0a2a65b35
https://github.com/Perl/perl5/commit/ba8dbfcd27514a5cc7e3ee9e7cd27af0a2a65b35
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: f5ad2068b2e1e34339c3c8a1c4c4623e509f994f
https://github.com/Perl/perl5/commit/f5ad2068b2e1e34339c3c8a1c4c4623e509f994f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: dbd59b31281003431484a15f2d464baf598786bb
https://github.com/Perl/perl5/commit/dbd59b31281003431484a15f2d464baf598786bb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: d17064040930055e5e8aa4778d9648649b7b6704
https://github.com/Perl/perl5/commit/d17064040930055e5e8aa4778d9648649b7b6704
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: f104ba53876f0a9ca8ad5687e87c9f9d92ba29c5
https://github.com/Perl/perl5/commit/f104ba53876f0a9ca8ad5687e87c9f9d92ba29c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 011b28e14e19d8e6e6192e873f95ee09ea86ff0b
https://github.com/Perl/perl5/commit/011b28e14e19d8e6e6192e873f95ee09ea86ff0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: a44dadacf0f8bb87b2e0c133d18c0c7a5cb3594c
https://github.com/Perl/perl5/commit/a44dadacf0f8bb87b2e0c133d18c0c7a5cb3594c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: e53f014ff3392378163d4534eb29ab7bdce4ea05
https://github.com/Perl/perl5/commit/e53f014ff3392378163d4534eb29ab7bdce4ea05
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: b0979628929a7e7a8fdd624e6d1c7e0a858dd8d2
https://github.com/Perl/perl5/commit/b0979628929a7e7a8fdd624e6d1c7e0a858dd8d2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: f9b10f5b30776b73ea29791e67d81c8fd07a840c
https://github.com/Perl/perl5/commit/f9b10f5b30776b73ea29791e67d81c8fd07a840c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: f9490566bd956fd88830594c9a33a4e9de211e0b
https://github.com/Perl/perl5/commit/f9490566bd956fd88830594c9a33a4e9de211e0b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 01cd9150f7338dcf95cf8347a344282d4bc2c8cf
https://github.com/Perl/perl5/commit/01cd9150f7338dcf95cf8347a344282d4bc2c8cf
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 933765fda1abb30d64ea192c1b1149a00a8b748e
https://github.com/Perl/perl5/commit/933765fda1abb30d64ea192c1b1149a00a8b748e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 09759ff6249fe9ff92e10351bc1e6e9df506d24f
https://github.com/Perl/perl5/commit/09759ff6249fe9ff92e10351bc1e6e9df506d24f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 9e74e14e1abf4ceb41e73754dbcac0a3f5b7450a
https://github.com/Perl/perl5/commit/9e74e14e1abf4ceb41e73754dbcac0a3f5b7450a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 28a0279056a364edfaa6110bc014bfc5e263b5c6
https://github.com/Perl/perl5/commit/28a0279056a364edfaa6110bc014bfc5e263b5c6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 4df4d349aa07a6de1b3175f5faa303f9a183e25f
https://github.com/Perl/perl5/commit/4df4d349aa07a6de1b3175f5faa303f9a183e25f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: 1aaf204b67985fa422cafed6ed4f62cc97ee3a6e
https://github.com/Perl/perl5/commit/1aaf204b67985fa422cafed6ed4f62cc97ee3a6e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: 9c601ee9410c58ac0d36e4ac9b2a50e4487cc796
https://github.com/Perl/perl5/commit/9c601ee9410c58ac0d36e4ac9b2a50e4487cc796
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: dbd8f551e2e8f28056b63586806075ff5b960b14
https://github.com/Perl/perl5/commit/dbd8f551e2e8f28056b63586806075ff5b960b14
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: ad822ecec8556b430b03575ff13d08bff3ec5e41
https://github.com/Perl/perl5/commit/ad822ecec8556b430b03575ff13d08bff3ec5e41
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: f94b980b5c26487ba58f879afc5465c9f096607c
https://github.com/Perl/perl5/commit/f94b980b5c26487ba58f879afc5465c9f096607c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: a239e3893964a7ca6e6a321a4009b977531751fc
https://github.com/Perl/perl5/commit/a239e3893964a7ca6e6a321a4009b977531751fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 6fc7ef0d4878da55a7e92e9bf74d0faff88c4512
https://github.com/Perl/perl5/commit/6fc7ef0d4878da55a7e92e9bf74d0faff88c4512
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: 4154049b0a92cfc1abe30888aecbbbf66ea8081a
https://github.com/Perl/perl5/commit/4154049b0a92cfc1abe30888aecbbbf66ea8081a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 6640a62ea1e3647229a4ae88b75e6979d1f64b95
https://github.com/Perl/perl5/commit/6640a62ea1e3647229a4ae88b75e6979d1f64b95
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 9f2712484aa77125d5aa43298a01ce6a235f6b2a
https://github.com/Perl/perl5/commit/9f2712484aa77125d5aa43298a01ce6a235f6b2a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 1d94ed2a3a973599ff4141634d4474c49baff519
https://github.com/Perl/perl5/commit/1d94ed2a3a973599ff4141634d4474c49baff519
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: 1b99a5cc2fa0e42f2deae1478b4c3e71ac491dc3
https://github.com/Perl/perl5/commit/1b99a5cc2fa0e42f2deae1478b4c3e71ac491dc3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 879983ce850f44fc83aa70af0eabbbebbd42eaca
https://github.com/Perl/perl5/commit/879983ce850f44fc83aa70af0eabbbebbd42eaca
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: 117c9dccd559c2808bb366cfd15e21b2622daede
https://github.com/Perl/perl5/commit/117c9dccd559c2808bb366cfd15e21b2622daede
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: fe693cba6fad9373f31d7b83decb507f71bc54a4
https://github.com/Perl/perl5/commit/fe693cba6fad9373f31d7b83decb507f71bc54a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: f07ec5e9597a2648785a7e7ad96ba2e20e8131b4
https://github.com/Perl/perl5/commit/f07ec5e9597a2648785a7e7ad96ba2e20e8131b4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 12ca2dc84ec8df5b3b9be32eb5b2b56e260affe0
https://github.com/Perl/perl5/commit/12ca2dc84ec8df5b3b9be32eb5b2b56e260affe0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: a087971e22061a9fb55dad48844888530bfdb8e5
https://github.com/Perl/perl5/commit/a087971e22061a9fb55dad48844888530bfdb8e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: 152b594f5f8a85971cbfee6056632664c7f021db
https://github.com/Perl/perl5/commit/152b594f5f8a85971cbfee6056632664c7f021db
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: a877b17892491885996473aeeed607969d885c21
https://github.com/Perl/perl5/commit/a877b17892491885996473aeeed607969d885c21
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: a6ddfed4df6689ce0598283c1cfea4bcd4ce6f3c
https://github.com/Perl/perl5/commit/a6ddfed4df6689ce0598283c1cfea4bcd4ce6f3c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: 5a03586e14da5d01d6aeff5695335118562df990
https://github.com/Perl/perl5/commit/5a03586e14da5d01d6aeff5695335118562df990
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: eb61bc8a3efa8b3d7246104e546c30ba7ef0cc9b
https://github.com/Perl/perl5/commit/eb61bc8a3efa8b3d7246104e546c30ba7ef0cc9b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 4a76c483524e7c35dad697dfd1e591a3ddb0c327
https://github.com/Perl/perl5/commit/4a76c483524e7c35dad697dfd1e591a3ddb0c327
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 1728a3f14c51f6aa8ee9dd964949121d358c4f16
https://github.com/Perl/perl5/commit/1728a3f14c51f6aa8ee9dd964949121d358c4f16
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 0508235725101a679f2c153d543e2f9e8060226a
https://github.com/Perl/perl5/commit/0508235725101a679f2c153d543e2f9e8060226a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: 8325d110314773f38105421f1a9a20ea6c3413ac
https://github.com/Perl/perl5/commit/8325d110314773f38105421f1a9a20ea6c3413ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 18a36e566f86c25503c03e94709687585c4c75ea
https://github.com/Perl/perl5/commit/18a36e566f86c25503c03e94709687585c4c75ea
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: 7adbbf650fc826d25c375ec5adb5c11f048c6638
https://github.com/Perl/perl5/commit/7adbbf650fc826d25c375ec5adb5c11f048c6638
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: ffa20e36735b85769a68c21ad94db9ccff98a10e
https://github.com/Perl/perl5/commit/ffa20e36735b85769a68c21ad94db9ccff98a10e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: ad8f8f0415d2e1f231b1d0a233f0c64c522a52ac
https://github.com/Perl/perl5/commit/ad8f8f0415d2e1f231b1d0a233f0c64c522a52ac
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: 4350f2b722d9aa642b0c34c49b3433cde1c965f8
https://github.com/Perl/perl5/commit/4350f2b722d9aa642b0c34c49b3433cde1c965f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: bd66e1722dd7ac7784798f486ffd0bd8ca90db31
https://github.com/Perl/perl5/commit/bd66e1722dd7ac7784798f486ffd0bd8ca90db31
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: adc8e325e2706913a9422e3c70c36d70b8d0a3d9
https://github.com/Perl/perl5/commit/adc8e325e2706913a9422e3c70c36d70b8d0a3d9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 3186659bbdd701f910048959d8aecd98c22cdc48
https://github.com/Perl/perl5/commit/3186659bbdd701f910048959d8aecd98c22cdc48
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: de7af1b6737f5db9a86b58da56744ddef36ffc9c
https://github.com/Perl/perl5/commit/de7af1b6737f5db9a86b58da56744ddef36ffc9c
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 95a31548e4f4d7814bd929fab9ca7b871ff090cd
https://github.com/Perl/perl5/commit/95a31548e4f4d7814bd929fab9ca7b871ff090cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: 1b950c97b7bb757121c41ccc69a9c3b4b9832684
https://github.com/Perl/perl5/commit/1b950c97b7bb757121c41ccc69a9c3b4b9832684
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: ac3dfbab8a6e519c3c82b7a9c99626c4da25289a
https://github.com/Perl/perl5/commit/ac3dfbab8a6e519c3c82b7a9c99626c4da25289a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 0f7de983130cf3c8d597d03aace6bfcd021ef338
https://github.com/Perl/perl5/commit/0f7de983130cf3c8d597d03aace6bfcd021ef338
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: e89d9d73efc03689775e7a50d9efa9a99634f809
https://github.com/Perl/perl5/commit/e89d9d73efc03689775e7a50d9efa9a99634f809
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: 002b05e420ca5bd78e91eef14b5f782ce24e3a20
https://github.com/Perl/perl5/commit/002b05e420ca5bd78e91eef14b5f782ce24e3a20
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 2f2687f6d0e1ebc22f108590bc005386417785d3
https://github.com/Perl/perl5/commit/2f2687f6d0e1ebc22f108590bc005386417785d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: a8170aab85f1c13754c99ed7878da1fdcfd4d795
https://github.com/Perl/perl5/commit/a8170aab85f1c13754c99ed7878da1fdcfd4d795
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: ab803cfd6f01c377aedb9f74c594950627ecc27e
https://github.com/Perl/perl5/commit/ab803cfd6f01c377aedb9f74c594950627ecc27e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 0e80ad51a3a537842d2f2e9f2b4d81ad056c264a
https://github.com/Perl/perl5/commit/0e80ad51a3a537842d2f2e9f2b4d81ad056c264a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: eea598d447ffdc5236e3634b6504517ab9b30a92
https://github.com/Perl/perl5/commit/eea598d447ffdc5236e3634b6504517ab9b30a92
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 2db8d19f18958b69d643940d684cfa26a5570dbb
https://github.com/Perl/perl5/commit/2db8d19f18958b69d643940d684cfa26a5570dbb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: a9fd7c8d4ddad6ed280dc6e8f7690dc5b633b365
https://github.com/Perl/perl5/commit/a9fd7c8d4ddad6ed280dc6e8f7690dc5b633b365
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 41fc5897da73a428014b1aed1569264f3b4c722a
https://github.com/Perl/perl5/commit/41fc5897da73a428014b1aed1569264f3b4c722a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 36c9125a64ac06a7eea43f415d8768851889e3fe
https://github.com/Perl/perl5/commit/36c9125a64ac06a7eea43f415d8768851889e3fe
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: 0a3240e7ca9eb8243ac8cc8c3767f1c5e7b16f8a
https://github.com/Perl/perl5/commit/0a3240e7ca9eb8243ac8cc8c3767f1c5e7b16f8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 9d5f2654ee659b121b01be804af8757f0e5d0c27
https://github.com/Perl/perl5/commit/9d5f2654ee659b121b01be804af8757f0e5d0c27
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: d744bb9369d2998cd73b0d499574bec324212854
https://github.com/Perl/perl5/commit/d744bb9369d2998cd73b0d499574bec324212854
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: e3733ac6a3162c2697b763a959b42984161836e7
https://github.com/Perl/perl5/commit/e3733ac6a3162c2697b763a959b42984161836e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: 12cd5d3eefb51d379603a6fb15f3a4fafd98435a
https://github.com/Perl/perl5/commit/12cd5d3eefb51d379603a6fb15f3a4fafd98435a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 80628b57df366ceceb044e91ae9ad1453d167085
https://github.com/Perl/perl5/commit/80628b57df366ceceb044e91ae9ad1453d167085
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: ff9e8e5970b809d5fbdecfb12c9b17772fda16e7
https://github.com/Perl/perl5/commit/ff9e8e5970b809d5fbdecfb12c9b17772fda16e7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 650a41bee41fc28809f475dcc7d7983f5f470da8
https://github.com/Perl/perl5/commit/650a41bee41fc28809f475dcc7d7983f5f470da8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: d32e5a24122d79a30c7ba0a92da2a3e39b7c4b2d
https://github.com/Perl/perl5/commit/d32e5a24122d79a30c7ba0a92da2a3e39b7c4b2d
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: d459e3a08dc374dbf38f4be127a848327a80f422
https://github.com/Perl/perl5/commit/d459e3a08dc374dbf38f4be127a848327a80f422
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: b406e7eefa77902baecee58ab248bf8658b18a38
https://github.com/Perl/perl5/commit/b406e7eefa77902baecee58ab248bf8658b18a38
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: a76566da1dee8a3007f85622108dc71d95107957
https://github.com/Perl/perl5/commit/a76566da1dee8a3007f85622108dc71d95107957
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 0af5117551ea17557febb7e6c994713533cadbad
https://github.com/Perl/perl5/commit/0af5117551ea17557febb7e6c994713533cadbad
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 57be731a32124bf88b406a66756b5fe3584955fc
https://github.com/Perl/perl5/commit/57be731a32124bf88b406a66756b5fe3584955fc
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 7530c309058a545b8e9b5007d421607d9852c6b1
https://github.com/Perl/perl5/commit/7530c309058a545b8e9b5007d421607d9852c6b1
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: d02cb6eafd33591963cb2a4ebc3587eff3a09e43
https://github.com/Perl/perl5/commit/d02cb6eafd33591963cb2a4ebc3587eff3a09e43
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: 16934f17fe8689947363df9e0d643040a0f0a980
https://github.com/Perl/perl5/commit/16934f17fe8689947363df9e0d643040a0f0a980
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 309400dbc27a3f069f91753290cf92e10227b678
https://github.com/Perl/perl5/commit/309400dbc27a3f069f91753290cf92e10227b678
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 00ac69fc44e5ff94eca3cd166446b370651883f6
https://github.com/Perl/perl5/commit/00ac69fc44e5ff94eca3cd166446b370651883f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 1bc47185ce7657fb052b179fb0f4ac846831fed7
https://github.com/Perl/perl5/commit/1bc47185ce7657fb052b179fb0f4ac846831fed7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 5591e4a0f514e0f7d11b719fc698f123c231bba8
https://github.com/Perl/perl5/commit/5591e4a0f514e0f7d11b719fc698f123c231bba8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: fca1be65f68351ddef62338a93e6965a6f52edff
https://github.com/Perl/perl5/commit/fca1be65f68351ddef62338a93e6965a6f52edff
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 940bdc67cfc5ae3252e3cc7d5d1e647c2f44b431
https://github.com/Perl/perl5/commit/940bdc67cfc5ae3252e3cc7d5d1e647c2f44b431
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: 112b49495c50264dcf882fc44e0a7fe3da97a1ef
https://github.com/Perl/perl5/commit/112b49495c50264dcf882fc44e0a7fe3da97a1ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: 2eea6b02b2a022541c8b8a004889942dd7ed0ea2
https://github.com/Perl/perl5/commit/2eea6b02b2a022541c8b8a004889942dd7ed0ea2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 433e1abe79aa6b44d962ce17d90253dc8358fb73
https://github.com/Perl/perl5/commit/433e1abe79aa6b44d962ce17d90253dc8358fb73
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 8f11fda921705f74b87f0428e21a6c8fe27a52e6
https://github.com/Perl/perl5/commit/8f11fda921705f74b87f0428e21a6c8fe27a52e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: c11078c367bc9d4abc0706624ad28aae0e855d62
https://github.com/Perl/perl5/commit/c11078c367bc9d4abc0706624ad28aae0e855d62
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: 0494f434389a3c49b8516fedef38429a661115a9
https://github.com/Perl/perl5/commit/0494f434389a3c49b8516fedef38429a661115a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: 04ed1c753def2eabb2e2cc7f651665f543afb71a
https://github.com/Perl/perl5/commit/04ed1c753def2eabb2e2cc7f651665f543afb71a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: c015a523895e2dd0cd4bf97c8c395fd7871e9ca9
https://github.com/Perl/perl5/commit/c015a523895e2dd0cd4bf97c8c395fd7871e9ca9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: ca0aadd58745c6152a93a84ac43b5dada30e68a4
https://github.com/Perl/perl5/commit/ca0aadd58745c6152a93a84ac43b5dada30e68a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: 2d1c897d94a97f7c05c6f75308f50171f4d1e028
https://github.com/Perl/perl5/commit/2d1c897d94a97f7c05c6f75308f50171f4d1e028
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 2e70cfea20fe4e0e0077d3f48d87c54d5a7cebf7
https://github.com/Perl/perl5/commit/2e70cfea20fe4e0e0077d3f48d87c54d5a7cebf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: ba2fec8046bb4770d55c692f7c5eb9bc28e1e606
https://github.com/Perl/perl5/commit/ba2fec8046bb4770d55c692f7c5eb9bc28e1e606
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: ef4bbef245b293ea738d6c5bb0fc62effde21712
https://github.com/Perl/perl5/commit/ef4bbef245b293ea738d6c5bb0fc62effde21712
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: f17583bb641dff0ecff346c444d8502e81840a37
https://github.com/Perl/perl5/commit/f17583bb641dff0ecff346c444d8502e81840a37
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: 0f3fb747b98ccf40df4b30ee11f7a8bee4359ad2
https://github.com/Perl/perl5/commit/0f3fb747b98ccf40df4b30ee11f7a8bee4359ad2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: e8fe9e69b7da3a1929a336bd0b2d0c90ac47f5bc
https://github.com/Perl/perl5/commit/e8fe9e69b7da3a1929a336bd0b2d0c90ac47f5bc
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 8e818b539edeba47d7a38daf42a1b7898f207d8f
https://github.com/Perl/perl5/commit/8e818b539edeba47d7a38daf42a1b7898f207d8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 99609b13cd51be34ef5be4e3b13f19513cb3d8b6
https://github.com/Perl/perl5/commit/99609b13cd51be34ef5be4e3b13f19513cb3d8b6
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 08a636f5ad8127b08daef60c1f27c580e7ec3300
https://github.com/Perl/perl5/commit/08a636f5ad8127b08daef60c1f27c580e7ec3300
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 16738dc34dc329a71296b2ee5b6124209f22cf1e
https://github.com/Perl/perl5/commit/16738dc34dc329a71296b2ee5b6124209f22cf1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 5e606b960d91174d43f6a1e2a725c1bca44ee5f2
https://github.com/Perl/perl5/commit/5e606b960d91174d43f6a1e2a725c1bca44ee5f2
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 74f8ca679857a5ba7c7c79e981d722e1a19286c5
https://github.com/Perl/perl5/commit/74f8ca679857a5ba7c7c79e981d722e1a19286c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 1f0a19d0cd4afd591e7dfc490b7bc8fe56a0a663
https://github.com/Perl/perl5/commit/1f0a19d0cd4afd591e7dfc490b7bc8fe56a0a663
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 948dca0949225eb103b514903847807d571fc0d0
https://github.com/Perl/perl5/commit/948dca0949225eb103b514903847807d571fc0d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: d090bef8ef1450d26cdce7f926abb3aa16de82eb
https://github.com/Perl/perl5/commit/d090bef8ef1450d26cdce7f926abb3aa16de82eb
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: 2e3156e1804b639bda8799d691b84a9c0df7d447
https://github.com/Perl/perl5/commit/2e3156e1804b639bda8799d691b84a9c0df7d447
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 622c824f21bcbf8fc906b1f638886917925e303a
https://github.com/Perl/perl5/commit/622c824f21bcbf8fc906b1f638886917925e303a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: 93e0aa4a38620918d917b46c00b38ff752b5984b
https://github.com/Perl/perl5/commit/93e0aa4a38620918d917b46c00b38ff752b5984b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: 9faae4ee540628b10bfc0af21c4b14eb1bcc7e18
https://github.com/Perl/perl5/commit/9faae4ee540628b10bfc0af21c4b14eb1bcc7e18
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 6601b6fcd5618d135281636191e82d3950d23c32
https://github.com/Perl/perl5/commit/6601b6fcd5618d135281636191e82d3950d23c32
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: 731cf09bf6e09fc3ecb5747db1374a2d0b2c88ab
https://github.com/Perl/perl5/commit/731cf09bf6e09fc3ecb5747db1374a2d0b2c88ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: c1196d5bc22149c32820569ba89094746fd406d7
https://github.com/Perl/perl5/commit/c1196d5bc22149c32820569ba89094746fd406d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: c679348841c8c90f5c7fb06ee6efed7fd8a9ba3b
https://github.com/Perl/perl5/commit/c679348841c8c90f5c7fb06ee6efed7fd8a9ba3b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: d7db52d829fac2c233c722aa7cd4ed7ede4518d7
https://github.com/Perl/perl5/commit/d7db52d829fac2c233c722aa7cd4ed7ede4518d7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 2ecb84a9b572bf28e1bc51d6b98fa71faa5b2db5
https://github.com/Perl/perl5/commit/2ecb84a9b572bf28e1bc51d6b98fa71faa5b2db5
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 95a307d369ef044135caa12960bed4de1c88f208
https://github.com/Perl/perl5/commit/95a307d369ef044135caa12960bed4de1c88f208
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: d6d35b0e11e5283277883994e3967d7d5e53b6cc
https://github.com/Perl/perl5/commit/d6d35b0e11e5283277883994e3967d7d5e53b6cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: df47740a38afcac4f74c6e859a1dc0be726e4b0e
https://github.com/Perl/perl5/commit/df47740a38afcac4f74c6e859a1dc0be726e4b0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: e70b8f3de4e797e01cbf1fcb4a4cef998fcca351
https://github.com/Perl/perl5/commit/e70b8f3de4e797e01cbf1fcb4a4cef998fcca351
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: e9405188a5093b1d210305a6a5f7c36edd222e04
https://github.com/Perl/perl5/commit/e9405188a5093b1d210305a6a5f7c36edd222e04
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 76783ca1e083f9a79a2745773465f77a8756dede
https://github.com/Perl/perl5/commit/76783ca1e083f9a79a2745773465f77a8756dede
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: ce7a04219acdf46965f12def4f51f2b2e63cfe25
https://github.com/Perl/perl5/commit/ce7a04219acdf46965f12def4f51f2b2e63cfe25
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 9a39ba4075e3c081a76199b225cf9d9d212300a3
https://github.com/Perl/perl5/commit/9a39ba4075e3c081a76199b225cf9d9d212300a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 0c666a8be1c6ed3676124f548ba31d5f248a5372
https://github.com/Perl/perl5/commit/0c666a8be1c6ed3676124f548ba31d5f248a5372
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 02ec2326c92e51398780c1fa617f13c4868b3c08
https://github.com/Perl/perl5/commit/02ec2326c92e51398780c1fa617f13c4868b3c08
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: edb3a835f41590c81cc2ce39be3075da8dca38d0
https://github.com/Perl/perl5/commit/edb3a835f41590c81cc2ce39be3075da8dca38d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: f859ca5f87149599c3065d34fea15075c7a3a582
https://github.com/Perl/perl5/commit/f859ca5f87149599c3065d34fea15075c7a3a582
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: e8d7480e91a7c90afa4cbf318177716172068b38
https://github.com/Perl/perl5/commit/e8d7480e91a7c90afa4cbf318177716172068b38
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: 7050ffcfad50a2f141b64986cc0154dd7e7b9da1
https://github.com/Perl/perl5/commit/7050ffcfad50a2f141b64986cc0154dd7e7b9da1
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: 49fce85e3d760ca76e52880c276ed4fb00cce8a8
https://github.com/Perl/perl5/commit/49fce85e3d760ca76e52880c276ed4fb00cce8a8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: c9a5b2144ac84c8795c0e602017f6cdc3ce0609b
https://github.com/Perl/perl5/commit/c9a5b2144ac84c8795c0e602017f6cdc3ce0609b
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: cd4c7fc9e60d61d9f988ae72aa09f2c2f48c3e8e
https://github.com/Perl/perl5/commit/cd4c7fc9e60d61d9f988ae72aa09f2c2f48c3e8e
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: e7bf303431d1f73505a6a870f63caed4a76475d3
https://github.com/Perl/perl5/commit/e7bf303431d1f73505a6a870f63caed4a76475d3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 6bab53879f7315b9596500c4c104ccbe23286119
https://github.com/Perl/perl5/commit/6bab53879f7315b9596500c4c104ccbe23286119
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: 6146772e93afeb74b17317e7055c5e137c6a21b3
https://github.com/Perl/perl5/commit/6146772e93afeb74b17317e7055c5e137c6a21b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 75320a4a9bcf22d23c94ca508951ae7d9768ec28
https://github.com/Perl/perl5/commit/75320a4a9bcf22d23c94ca508951ae7d9768ec28
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: 00d65868b8f0b96fe464c49c1edf6f8a5fd3b1ff
https://github.com/Perl/perl5/commit/00d65868b8f0b96fe464c49c1edf6f8a5fd3b1ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: e1d15734439e2c80e607cb4a20b4d4ef475b5152
https://github.com/Perl/perl5/commit/e1d15734439e2c80e607cb4a20b4d4ef475b5152
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 626afc5aea550e2afa8298945e55804998678ee5
https://github.com/Perl/perl5/commit/626afc5aea550e2afa8298945e55804998678ee5
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: d95553716f00286e0d3b262294681c3eb9020fa8
https://github.com/Perl/perl5/commit/d95553716f00286e0d3b262294681c3eb9020fa8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: 01c65e651958c0c99a113439078a747412fb8c35
https://github.com/Perl/perl5/commit/01c65e651958c0c99a113439078a747412fb8c35
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: 7c726f93bea2883c08a0af4c4299dfc95d7ee7ba
https://github.com/Perl/perl5/commit/7c726f93bea2883c08a0af4c4299dfc95d7ee7ba
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: 6cacf81837156aa7cb1f3034a7860fa53c4a0978
https://github.com/Perl/perl5/commit/6cacf81837156aa7cb1f3034a7860fa53c4a0978
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: afdd712a720579d830fa6ea8c04168e0ad8160b7
https://github.com/Perl/perl5/commit/afdd712a720579d830fa6ea8c04168e0ad8160b7
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: af9c36be9cb263ac699ca088c65cde367b2d7433
https://github.com/Perl/perl5/commit/af9c36be9cb263ac699ca088c65cde367b2d7433
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: 31b7d166052e6274e76b1c6ff7483a4c7ef73697
https://github.com/Perl/perl5/commit/31b7d166052e6274e76b1c6ff7483a4c7ef73697
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 84a928f2d3db312c02b9fd72840a6d006a8b0d77
https://github.com/Perl/perl5/commit/84a928f2d3db312c02b9fd72840a6d006a8b0d77
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: 7422924a9019a5e058a0ac542f58f1869e3f3da0
https://github.com/Perl/perl5/commit/7422924a9019a5e058a0ac542f58f1869e3f3da0
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 088287dcb4b86985691836785aaf7d67473b800f
https://github.com/Perl/perl5/commit/088287dcb4b86985691836785aaf7d67473b800f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 4f38f54533abad0611734b60e2ad5594fcf4d087
https://github.com/Perl/perl5/commit/4f38f54533abad0611734b60e2ad5594fcf4d087
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 97d26195507d7e032c1d9b556f46f4f5672bfebd
https://github.com/Perl/perl5/commit/97d26195507d7e032c1d9b556f46f4f5672bfebd
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: e5930786a39095d18c74f8632acedd32b497a949
https://github.com/Perl/perl5/commit/e5930786a39095d18c74f8632acedd32b497a949
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: 1074492fbcdc8b893e036a151cc876c8c0b08098
https://github.com/Perl/perl5/commit/1074492fbcdc8b893e036a151cc876c8c0b08098
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 8999966ff7e76e47baf725251e28615fd717a827
https://github.com/Perl/perl5/commit/8999966ff7e76e47baf725251e28615fd717a827
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: 81b083ed29ddb3d84df699e897a3cdb4f5df541a
https://github.com/Perl/perl5/commit/81b083ed29ddb3d84df699e897a3cdb4f5df541a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: e7b83216eda558ed18faecab96480c0e9d99c1a9
https://github.com/Perl/perl5/commit/e7b83216eda558ed18faecab96480c0e9d99c1a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: b673be8ffcc12239f20c7b59757651896146462f
https://github.com/Perl/perl5/commit/b673be8ffcc12239f20c7b59757651896146462f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: ced125bc056834df64894b2d1c364abbf8b000ff
https://github.com/Perl/perl5/commit/ced125bc056834df64894b2d1c364abbf8b000ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: 05a55f54b7cf24eda57778f5aed268679e876999
https://github.com/Perl/perl5/commit/05a55f54b7cf24eda57778f5aed268679e876999
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 8af932831e421cffc2a05600c0ceedf180fea3c8
https://github.com/Perl/perl5/commit/8af932831e421cffc2a05600c0ceedf180fea3c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: 6f7fb067193b12389166ef8289576d817b18f76a
https://github.com/Perl/perl5/commit/6f7fb067193b12389166ef8289576d817b18f76a
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 69ef1ebe8bee1ff1a06173b13f6fa5029e9b278f
https://github.com/Perl/perl5/commit/69ef1ebe8bee1ff1a06173b13f6fa5029e9b278f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: 90afe66d6e8fe6ed6133d37198249fd5e19fd5a9
https://github.com/Perl/perl5/commit/90afe66d6e8fe6ed6133d37198249fd5e19fd5a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: c4662f218a5759c49f9b1bbf85c8d67fc5397b31
https://github.com/Perl/perl5/commit/c4662f218a5759c49f9b1bbf85c8d67fc5397b31
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: 1cc1869fd5794c32394c299578415f25fa60738f
https://github.com/Perl/perl5/commit/1cc1869fd5794c32394c299578415f25fa60738f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: 28df002091e17b3ffb3f5277af1eefd85ce62bd4
https://github.com/Perl/perl5/commit/28df002091e17b3ffb3f5277af1eefd85ce62bd4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: af25d8b6c38295294172f34a074cdcc7e28d2ce4
https://github.com/Perl/perl5/commit/af25d8b6c38295294172f34a074cdcc7e28d2ce4
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 13824aa4fec5ca32f170651228064fb8a73d515f
https://github.com/Perl/perl5/commit/13824aa4fec5ca32f170651228064fb8a73d515f
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 0132659f5fd9053f43612d7d394f093c9fa1f6ae
https://github.com/Perl/perl5/commit/0132659f5fd9053f43612d7d394f093c9fa1f6ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-28 (Wed, 28 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M proto.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
44
Compare: https://github.com/Perl/perl5/compare/8d770cdc521e...0132659f5fd9
