Branch: refs/heads/smoke-me/khw-locale
Home: https://github.com/Perl/perl5
Commit: a42f903ba7680d1312c0074e9be4b8d6f01c6885
https://github.com/Perl/perl5/commit/a42f903ba7680d1312c0074e9be4b8d6f01c6885
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
perlapi: Rmv repeated word
Commit: 0b66b44086b3c2cc1c3c680a560bb5bfc67bb3be
https://github.com/Perl/perl5/commit/0b66b44086b3c2cc1c3c680a560bb5bfc67bb3be
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M dosish.h
M unixish.h
Log Message:
-----------
XXX craig Unixish.h, doshish.h: Reorder terminations; simplify
The IO and memory terminations need to be after other things. Add a
comment so that future maintainers won't make the mistakes I did.
Also refactor to that amiga os doesn't have a separate list to get out
of sync
I suspect that the amiga termination should be moved to earlier in
the sequence, but absent any evidence; I'm leaving it unchanged.
Commit: e3abc372024702d07873a8534edca7d52891bcd3
https://github.com/Perl/perl5/commit/e3abc372024702d07873a8534edca7d52891bcd3
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Win32: Don't check folds validity
This code will check, when warnings are on, that the libc functions
return valid values. But Windows platforms will always fail because
they have multiple divergences from the Posix standard. The macros that
implement the case changing/folding in handy.h take extra steps to bring
Windows code more into alignment with Posix. Those are too complicated
to easily duplicate the logic here. The result of these checks is
looked at by our test suite, which has long, without anyone noticing,
skipped portions on Windows, even though handy.h should correct for
this. So simply, don't do the checking under Windows, and find out what
handy.h has failed to fully correct for.
Commit: 855845478f1db5671690babf27930f4e0bd9cc5b
https://github.com/Perl/perl5/commit/855845478f1db5671690babf27930f4e0bd9cc5b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
DEBUG_L now also looks at environment variable
Because locale initialization happens before command line processing,
one can't pass a -DL argument to enable debugging of locale
initialization. Instead, an environment variable is read then, and is
used to enable debugging or not. In the past, code specifically had to
test for this being set. This commit changes that so that debugging can
automatically be enabled without having to write special code. Future
commits will strip out those special checks.
Commit: 7bfd005749a131cca5b15ef5d28feda2c9891f3f
https://github.com/Perl/perl5/commit/7bfd005749a131cca5b15ef5d28feda2c9891f3f
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Replace most #ifdef DEBUGGING lines
THe previous commit enhanced the DEBUG macros so that they contain the
logic that previously had to be done with conditional compilation
statements. Removing them makes the code easier to read.
Commit: c05900b45bde27900492c64bdd58b73a6066af3a
https://github.com/Perl/perl5/commit/c05900b45bde27900492c64bdd58b73a6066af3a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
M numeric.c
M regcomp.c
M regexec.c
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are most of the ones in handy.h that have few uses
outside it.
Commit: 34d1ef762e5614165ba38185ff32f1f8bf09be10
https://github.com/Perl/perl5/commit/34d1ef762e5614165ba38185ff32f1f8bf09be10
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Remove only 2 calls to an internal macro
Replace isIDFIRST_LC and isWORD_CHAR_LC isIDFIRST_LC with slightly
faster implementations.
Commit: 774701292f3a66af33164d5c91464f33a1a6240e
https://github.com/Perl/perl5/commit/774701292f3a66af33164d5c91464f33a1a6240e
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some #ifdef's for commonality
This changes these compilation conditionals so that things in common
between Windows and other platforms are only defined once.
It changes the isIDFIRST_LC and isWORDCHAR_LC definitions for
non-Windows to match that platform superficially, though expanding to
what it previously did to.
Commit: e5c3021bfb86745c2f9510b0b4c031e3ea9fdf8f
https://github.com/Perl/perl5/commit/e5c3021bfb86745c2f9510b0b4c031e3ea9fdf8f
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add some branch predictions
Commit: 10cbca54423c758393e211b13b1da45a14ab18a3
https://github.com/Perl/perl5/commit/10cbca54423c758393e211b13b1da45a14ab18a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: White-space, comment only
Commit: d7bb3228160d57978875aafc27e668c16d17f3e4
https://github.com/Perl/perl5/commit/d7bb3228160d57978875aafc27e668c16d17f3e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Don't use char class if no LC_CTYPE
It is possible to compile perl to not pay attention to LC_CTYPE. This
was testing for no locales at all; whereas the stricter requirement
should be used.
Commit: 766d9784d4ca949d9b88b444e4483a5dbc69ded5
https://github.com/Perl/perl5/commit/766d9784d4ca949d9b88b444e4483a5dbc69ded5
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M charclass_invlists.h
M handy.h
M l1_char_class_tab.h
M lib/unicore/uni_keywords.pl
M perl.c
M perl.h
M regcomp.c
M regcomp.h
M regen/mk_PL_charclass.pl
M regexec.c
M sv.c
M uni_keywords.h
M utfebcdic.h
Log Message:
-----------
Change handy.h macro names to be C standard conformant
C reserves symbols beginning with underscores for its own use. This
commit moves the underscore so it is trailing, which is legal. The
symbols changed here are many of the ones in handy.h that have
significant uses outside it.
Commit: 15cf8d902989de774a05dc49d892487d395cb5de
https://github.com/Perl/perl5/commit/15cf8d902989de774a05dc49d892487d395cb5de
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv internal macro
LC_CAST_ was my attempt at generality, but I didn't realize that the
POSIX standard specifies the type that this was meant to generalize, so
there isn't any need for it.
Commit: 412b34e6ffa770f04e02ff56505fe66e62e8dcb1
https://github.com/Perl/perl5/commit/412b34e6ffa770f04e02ff56505fe66e62e8dcb1
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Refactor some internal macros
This changes the parameters etc, in preparation for further changes
Commit: 5622bed43bd3da4869d1605c04c7a8fbebc1d77a
https://github.com/Perl/perl5/commit/5622bed43bd3da4869d1605c04c7a8fbebc1d77a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Rmv unnecessary parameter to internal macros
The cast is required to be U8 by the POSIX standard. There is no need
to have this added generality.
Commit: f4448417cf90735423f53e053143646318ed6318
https://github.com/Perl/perl5/commit/f4448417cf90735423f53e053143646318ed6318
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: #define one macro in terms of another
These two macros are equivalent as folding and lowercasing are the same
for this input domain. Better to say so rather than to replicate the
definitions.
Commit: 1d7a16010270e0288d877e162a4c4a563a697929
https://github.com/Perl/perl5/commit/1d7a16010270e0288d877e162a4c4a563a697929
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
No locales => don't use isspace(), toLower() etc.
This commit changes what happens on platforms without locale handling to
use our precomputed definitions of what the various character class
definitions and case changing operations are. Previously, it just
called the libc locale-dependent functions and made sure the result was
ASCII. I think this is a holdover from before we had the precomputed
definitions
Commit: a264f60c5bc0dd1cb7f6f7f9ec5d74fe7f43a895
https://github.com/Perl/perl5/commit/a264f60c5bc0dd1cb7f6f7f9ec5d74fe7f43a895
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse two sets of macros
By redefining a wrapper macro used in one set based on compile-time
info; the other set can be defined in terms of it, and the separate
entries removed.
Commit: 8e9dc65d0e50261b669ea88da0e84e8d2f1aa730
https://github.com/Perl/perl5/commit/8e9dc65d0e50261b669ea88da0e84e8d2f1aa730
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Move some macro defns around
This is to make the difference listing in future commits smaller.
This change includes some comment changes, and some extra parens around
some subexpressions
Commit: a5ddb10b28dfc1ad07c5b2aa3649dda7abcb8eb3
https://github.com/Perl/perl5/commit/a5ddb10b28dfc1ad07c5b2aa3649dda7abcb8eb3
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Collapse some macros
These 3 sets of macros can be collapsed trivially into 3 macros.
Commit: 0f0f421e3aff3acc4dd4ce54efd739852fcfe92c
https://github.com/Perl/perl5/commit/0f0f421e3aff3acc4dd4ce54efd739852fcfe92c
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add wrapper layer macros for isalnum() ...
This adds a new set of macros, forming a lower layer to what is currently
there to wrap the character classification libc functions, isdigit()
etc, and case changing ones, tolower(), toupper().
On most platforms these expand simply to the libc function call. But on
windows, they expand to something more complex, to bring the Windows
calls into POSIX compliance. Previously that was achieved at the higher
level, with the result that lower level calls were broken. This
resulted in parts of the test suite being skipped on Windows.
The current level is rewritten to use the new lower layer, with the
result that it is simpler, as the complexity is now done further down.
I thought about calling these macros is_porcelain_isalnum or something
similar to emphaisze that they are close to the bare libc version, but
thought isU8_alnum() is shorter and conveys another truth, that being
the input is assumed to be a byte, without checking.
Commit: 536108f50041468b601476e0980932964a221aab
https://github.com/Perl/perl5/commit/536108f50041468b601476e0980932964a221aab
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M vms/vms.c
Log Message:
-----------
locale.c: Use new macros from the prev commit
This should result in Windows boxes now passing the locale sanity
checks. Previously that failure would cause the test suite tests to be
skipped, and warnings generated to Windows users that actually were
invalid, as the flaws were actually compensated for in other code.
Commit: 6754f0d9ce51351055d43a456a5cae6da5622315
https://github.com/Perl/perl5/commit/6754f0d9ce51351055d43a456a5cae6da5622315
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX SEE IF WORKS handy.h: Change Windows macros
Commit: b067ae4d53835eef734b7c4122534385a09df795
https://github.com/Perl/perl5/commit/b067ae4d53835eef734b7c4122534385a09df795
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add isCASED_LC
As a convenience to other code.
Commit: c13bf65edee51c1252e407f8cad69cb7de2f2ee0
https://github.com/Perl/perl5/commit/c13bf65edee51c1252e407f8cad69cb7de2f2ee0
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Improve code
These case statements in a switch all had the same prelude for checking
if the locale is UTF-8 and handling that case separately. A few commits
ago created macros closer to the base level. This commit factors out
the common UTF-8 handling, and then puts the lower lever things in the
switch(). Perhaps the C optimizer will be smart enough to do this too,
but we might as well do it ourselves, now that it is convenient.
Commit: 0b0df4d713f04578fbc1c2b520c7567910070af9
https://github.com/Perl/perl5/commit/0b0df4d713f04578fbc1c2b520c7567910070af9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M regexec.c
Log Message:
-----------
regexec.c: Refactor switch default()
It seems clearer to me to have the panic at the end of the routine
instead of as the default: of a switch().
Commit: 7c7c92f0a65def021084f0097d495e2f65c456ab
https://github.com/Perl/perl5/commit/7c7c92f0a65def021084f0097d495e2f65c456ab
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Declare three static arrays to be so.
Commit: 6838530f3b7f39ff7bc4975148fa22b2893ba32b
https://github.com/Perl/perl5/commit/6838530f3b7f39ff7bc4975148fa22b2893ba32b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Move some locale.c #defines to perl.h
This is in preparation for them to be used in macros from outside
locale.c
Commit: 1dd41ba867ef159ba81fbda19aaad8dfa6db697d
https://github.com/Perl/perl5/commit/1dd41ba867ef159ba81fbda19aaad8dfa6db697d
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Mark newly moved symbols as private
The previous commit made certain symbols that previously were local to
locale.c now available everywhere. Add a trailing underscore to their
names to mark them as private.
Commit: 78dfbdb062e85079b7727c7bb9401d06c6d7b831
https://github.com/Perl/perl5/commit/78dfbdb062e85079b7727c7bb9401d06c6d7b831
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M makedef.pl
M perl.h
Log Message:
-----------
Add USE_LOCALE_THREADS #define
This is in preparation for supporting configurations where there threads
are available, but the locale handling code should ignore that fact.
This stems from the unusual locale handling of z/OS, where any attempt
is ignored to change locales after the first thread is created.
Commit: c295a0777048fff95249120fd1a64105ae27ee84
https://github.com/Perl/perl5/commit/c295a0777048fff95249120fd1a64105ae27ee84
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pm
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
Regularize HAS_POSIX_2008_LOCALE, USE_POSIX_2008_LOCALE
A platform shouldn't be required to use the Posix 2008 locale handling
functions if they are present. Perhaps they are buggy. So, a separate
define for using them was introduced, USE_POSIX_2008_LOCALE. But until
this commit there were cases that were looking at the underlying
availability of the functions, not if the Configuration called for their
use.
Commit: b0d0bcc841fa330c2f879854ebdc94ad766e28c7
https://github.com/Perl/perl5/commit/b0d0bcc841fa330c2f879854ebdc94ad766e28c7
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change macro name
Adopt the git convention of 'porcelain' meaning without special
handling. This makes it clear that porcelain_setlocale() is the base
level.
Commit: 426b306804b04fad6332ff650386ba8a9757a0d8
https://github.com/Perl/perl5/commit/426b306804b04fad6332ff650386ba8a9757a0d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Cast return of setlocale() to const
If they had it to do over again, the libc makers would have made the
return of this function 'const char *'. We can cast it that way
internally to catch erroneous uses at compile time.
Commit: 9e6edaad6059f2c4c7d436324deca6e8d9f25c2b
https://github.com/Perl/perl5/commit/9e6edaad6059f2c4c7d436324deca6e8d9f25c2b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Create S_get_category_index()
libc locale categories, like LC_NUMERIC, are opaque integers. This
makes it inconvenient to have table-driven code. Instead, we have
tables that are indexed by small positive integers, which are a
compile-time mapping from the libc values.
This commit creates a run-time function to also do that mapping. It
will first be used in the next commit.
The function does a loop through the available categories, looking for a
match. It could be replaced by some sort of quick hash lookup, but the
largest arrays in the field have a max of 12 elements, with almost all
searches finding their quarry in the first 6. It doesn't seem
worthwhile to me to replace a linear search of 6 elements by something
more complicated. The design intent is this search will be used only at
the edges of the locale-handling code; once found the index is used in
future bits of the current operation.
Commit: ff30b566aa77bf69d8ac15b058ee64efd870d5b8
https://github.com/Perl/perl5/commit/ff30b566aa77bf69d8ac15b058ee64efd870d5b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use get_category_index()
This creates the first uses of the function added in the previous commit.
It changes the name of a function that now takes an index to have the
suffix _i to indicate its calling parameter is a category index rather
than a category. This will become a common paradigm in this file in
later commits.
Two macros are also created to call that function; they have suffixes _c
(to indicate the parameter is a category known at compile time, and _r
(to indicate it needs to be computed at runtime). This is in keeping
with the already existing paradigm in this file.
Commit: 75d20d5aa95dc8fe0662eb096a6ac663cc597bb5
https://github.com/Perl/perl5/commit/75d20d5aa95dc8fe0662eb096a6ac663cc597bb5
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change S_emulate_setlocale name and sig
It turns out this function is called only from places where we have the
category index already computed; so change the signature to use the
index and remove the re-calculation.
It renames it to emulate_setlocale_i() to indicate that the category
parameter is an index.
This also means, that it's very unlikely that it will be called with an
out-of-bounds value. Remove the debugging statement for that case (but
retain the error return value).
Commit: fe7e05c28b478cc5d35f7c600f0948ba9d447492
https://github.com/Perl/perl5/commit/fe7e05c28b478cc5d35f7c600f0948ba9d447492
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M pod/perldelta.pod
M pod/perldiag.pod
Log Message:
-----------
locale.c: Simplify S_category_name
We can use the new function S_get_category_index() to simplify this.
Also, when I wrote it I didn't know about Perl_form(), and had
reimplemented a portion of it here; which is yanked as well.
Commit: 0f5af375a2f90690e3b023051728af554f9d0fcf
https://github.com/Perl/perl5/commit/0f5af375a2f90690e3b023051728af554f9d0fcf
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move unreachable code
It turns out this code, setting errno, is unreachable. Move it to the
place where it would do some good, removing an extraneous, unreachable
return;
Commit: fb4ff0ea6fb4bdf0bf1fa2a9861999b863484ca3
https://github.com/Perl/perl5/commit/fb4ff0ea6fb4bdf0bf1fa2a9861999b863484ca3
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Comment clarifications, white space
Some of these are to make future difference listings shorter
Some of the changes look like incorrect indentation here, but anticipate
future commits.
Commit: 964714dfdfb800ca3b664a620143d2bf77582283
https://github.com/Perl/perl5/commit/964714dfdfb800ca3b664a620143d2bf77582283
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move fcn within file
This is for later commits which will change it to rely on new defines
that won't occur until later in the file than its current position
Commit: b713887fea9fe2e834db13b839fb0e6d86f560ff
https://github.com/Perl/perl5/commit/b713887fea9fe2e834db13b839fb0e6d86f560ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Separate query part of emulate_setlocale()
This splits a large function so that it is easier to comprehend, and is
in preparation for them to be separately callable.
Commit: 8df3a916ca1763a8d0f8c763d01349d692ece8a5
https://github.com/Perl/perl5/commit/8df3a916ca1763a8d0f8c763d01349d692ece8a5
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Outdent previous commit
The previous commit kept the indentation level the same as it moved code
to a new function, even though an outer block was stripped off in the
process. This was to minimize diff output. This commit is white space
only.
Commit: c828468409b73eba06a4774b1bb13ca6a597b14d
https://github.com/Perl/perl5/commit/c828468409b73eba06a4774b1bb13ca6a597b14d
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove spaces around a '##' preprocessor directive
It turns out that at least my gcc preprocessor gets confused in some
contexts if spaces surround the ##. CAT2() doesn't work for these.
It is working in this context, but future commits will introduce ones
where it won't, so this commit will help make things consistent within
this file
What seems to fail is #define f(x) (..., g(x ## y), ...) where 'x' is a
an already #defined symbol. I want 'xy', but instead, for example if
'x' has been defined to be 1, I get '1y'
Commit: c680e6219ee16973b2e92494e8808784565241c0
https://github.com/Perl/perl5/commit/c680e6219ee16973b2e92494e8808784565241c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: #define some macros in terms of a base one
This is so changes to the lowest level automatically propagate to the
others
Commit: fd6980fbfb9e127ed65e220e1ccf79e540c2fa1e
https://github.com/Perl/perl5/commit/fd6980fbfb9e127ed65e220e1ccf79e540c2fa1e
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Create new macros for just querying locale
There are two sets of names, which immediately indicate if the result
can be relied on to be thread level or must be assumed to be global to
the whole process. At the moment they all expand to the same thing,
since on a threadless perl, it's a don't care; and on a threaded perl,
they are all already thread-level, in the Configurations we support.
Future commits will cause the macros to diverge, and comments will be
added then.
For POSIX 2008, this commit causes queries to go directly to the query
function, avoiding S_emulate_setlocale_i() completely.
Commit: 887acb64fbae9807333f2416060353b97100b88d
https://github.com/Perl/perl5/commit/887acb64fbae9807333f2416060353b97100b88d
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Generalize certain Win32 calls
The old versions were windows-specific; the changes use a more generic
macro that currently expands to the same thing, but future commits will
change that.
Commit: 66d34ac4a20c8f53531899e9ff22ae4a6d2f2981
https://github.com/Perl/perl5/commit/66d34ac4a20c8f53531899e9ff22ae4a6d2f2981
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add a convenience #define
This makes it clear if we are using an array that currently only happens
on non-querylocale systems, but that will change in future commits.
Commit: 1822c82e9c1d0f5bc1d140c6695f0cd67dd76fed
https://github.com/Perl/perl5/commit/1822c82e9c1d0f5bc1d140c6695f0cd67dd76fed
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add setlocale() return context macros
Future commits will benefit from knowing if the return value of
setlocale is to be ignored, just checked for if it worked, or the full
value is needed and can be relied on (or not) to be per-thread.
Commit: 0f33c58c402e8658d160dc8ddb82b57715c43e73
https://github.com/Perl/perl5/commit/0f33c58c402e8658d160dc8ddb82b57715c43e73
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add panic check/message
This panic is done when a setlocale unexpectedly fails.
Commit: 4f5d4c6a2d0a3b8f47a270f31f4aaff4ecaea392
https://github.com/Perl/perl5/commit/4f5d4c6a2d0a3b8f47a270f31f4aaff4ecaea392
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Use a function table to simplify code
Some locale categories require extra steps when they are changed. This
moves that logic to a table, which gets rid of some code
Commit: cc3e501858a78e0bd78469eb160aa40ba36b6a82
https://github.com/Perl/perl5/commit/cc3e501858a78e0bd78469eb160aa40ba36b6a82
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Perl_setlocale(): Same code for all param2 == NULL
Calling Perl_setlocale() with a NULL 2nd parameter returns the current
locale, rather than changing it. Previously LC_NUMERIC and LC_ALL were
treated specially; other categories were lumped in with the code that
changes the locale.
Changing some categories involves a non-trivial amount of work. This
commit avoids that by moving all queries to the same 'if' branch.
LC_NUMERIC and LC_ALL still have to be treated specially, but now it's
all within the same outer 'if', and the unnecessarily executing code
for when the locale changes is avoided.
Commit: bed6adff4ebcaf5fbeb9f9f7b5b93c8b4b66aff8
https://github.com/Perl/perl5/commit/bed6adff4ebcaf5fbeb9f9f7b5b93c8b4b66aff8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use low level macros at low level
Implementing Perl_setlocale, we can safely use the internal macros that
the public ones expand to call, without the overhead those public macros
impose (which they do to be more immune from improper calls from outside
code).
Commit: 2803317db35aeb25a58c466df7b83af607b21b6f
https://github.com/Perl/perl5/commit/2803317db35aeb25a58c466df7b83af607b21b6f
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Remove exploratory code
This code was to find out, in debugging builds, if an undocumented glibc
feature worked. There were no reports that it didn't, and so, after,
several releases, it has served its purpose. A future commit will allow
enabling this feature as a Configuration option.
Commit: bed635efcdfdf69f69670109a9da0d7e76414527
https://github.com/Perl/perl5/commit/bed635efcdfdf69f69670109a9da0d7e76414527
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Expand scope of cpp conditional
This just doesn't bother with checking some locale-related stuff if not
paying attention to locales.
Commit: ba031487723befb8147e9315c69eea1a97893a36
https://github.com/Perl/perl5/commit/ba031487723befb8147e9315c69eea1a97893a36
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
locale.c: Create new convenience macro
glibc doesn't have the querylocale() function, available on some other
platforms, such as Darwin and *BSD. However, it instead has the
equivalent functionality available through an undocumented feature.
This commit allows someone in the know to compile perl to use that
feature, and wraps its API with a macro so that the calling code doesn't
have to be aware of the different APIs of the two methods.
That macro's definition is now done in perl.h, as future commits will
use it in other files.
Since this is an undocumented feature, I am not currently documenting
this wrapper availability. However, it has been used in the field
without complaint for a couple of releases, as follows: A more
cumbersome substitute method continues to be used to get what it does.
But in the past both methods were tried and the program died if they
yielded different results. Since no one has complained, I'm fairly
confident it works. But sill I'm deferring its more general use.
Commit: ce5092c00aa57e85c623883a19fa290b8387c124
https://github.com/Perl/perl5/commit/ce5092c00aa57e85c623883a19fa290b8387c124
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: querylocale() doesn't work on LC_ALL
I had misread the man pages. This bug has been in the field for several
releases now, but most likely hasn't shown up because it's almost always
the case that the locale categories will be set to the same locale. And
so most implementations of querylocale() would return the correct
result.
This commit works by splitting the calculation of the value of LC_ALL
from S_emulate_setlocale_i() into a separate function, and extending it
to work on querylocale() systems. This has the added benefit of
removing tangential code from the main line, making
S_emulate_setlocale_i easier to read.
calculate_LC_ALL() is the new function, and is now called from two
places. As part of this commit, constness is added to PL_curlocales[]
Part of this change is to keep our records of LC_ALL on non-querylocale
systems always up-to-date, which is better practice
And part of this change is temporary, marked as such, to be removed a
few commits later.
Commit: d77ba713464babcb2e3f66cd07b0fbc22e46938f
https://github.com/Perl/perl5/commit/d77ba713464babcb2e3f66cd07b0fbc22e46938f
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M intrpvar.h
M locale.c
M proto.h
Log Message:
-----------
Make three locale PL_ strings const char*
This adds some compile safety to these.
Commit: 85950ce3ecd75118073f9f3e030ab0e838324df9
https://github.com/Perl/perl5/commit/85950ce3ecd75118073f9f3e030ab0e838324df9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c Make a char * variable const
A future commit will want this
Commit: 61224fcc0fd568fb36641872ca821ef61e82d85e
https://github.com/Perl/perl5/commit/61224fcc0fd568fb36641872ca821ef61e82d85e
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Generalize stdize_locale()
This function is rewritten to handle LC_ALL, and to make it easier to
add new checks.
There is also a change, which I think is an improvement, in that everything
starting with a \n is trimmed, instead of just a trailing \n being
A couple of calls to stdize_locale() are removed, as they are redundant,
because they are called only as a result of Perl_setlocale() being
called, and that ends up calling stdize_locale always, early on.
The call to savepv() is also moved in a couple cases to after the result
is known to not be NULL
I originally had such a new check in mind, but it turned out that doing
it here didn't solve the problem, so this commit has been amended
(before ever being pushed) to not include that.
chomped.
Commit: b84965fee8c88e5bd8386231edd85ecc3de21917
https://github.com/Perl/perl5/commit/b84965fee8c88e5bd8386231edd85ecc3de21917
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX drop stdize_locale: #if 0, enabled even for emulate
Commit: 5f424ffab383c79753ec05a045df3f0acc2e049a
https://github.com/Perl/perl5/commit/5f424ffab383c79753ec05a045df3f0acc2e049a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor some derived #defines
The _c suffix is supposed to mean the category is known at compile time.
In some configurations this does not matter, and so I had named things
carelessly, so this might be confusing. This commit fixes that.
Commit: 6a2ebc04dc22de50e3ff87d9cc102a6594c83749
https://github.com/Perl/perl5/commit/6a2ebc04dc22de50e3ff87d9cc102a6594c83749
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use setlocale() for init, not P2008
We have found bugs in the POSIX 2008 libc implementations on various
platforms. This code, which does the initialization of locale handling
has always been very conservative, expecting possible failures due to
bugs in it our the libc implementations, and backing out if necessary to
a crippled, but workable state, if something goes wrong.
I think we should use the oldest, most stable locale implementation in
these circumstances
Commit: e33c073eda14dea67a47c8e9d5151401f68c2e24
https://github.com/Perl/perl5/commit/e33c073eda14dea67a47c8e9d5151401f68c2e24
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split aggregate LC_ALL from emulate_setlocale
This splits into a separate function the code necessary in some
Configurations to calculate LC_ALL from a potentially disparate
aggregate of categories having different locales.
This is being done just for readability, as this extensive code in the
middle of something else distracts from the main point.
A goto is hence replaced by a recursive call.
Commit: ed56581ce221d786b79eeadb2b5916e5976cdab6
https://github.com/Perl/perl5/commit/ed56581ce221d786b79eeadb2b5916e5976cdab6
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Change internal variable name
The new name better reflects its purpose, so is less confusing
Commit: 48a807008f25f8dbe43ad99fe9e39953dc065995
https://github.com/Perl/perl5/commit/48a807008f25f8dbe43ad99fe9e39953dc065995
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up handling of a glibc bug
This commit moves all mention of this bug to just the code that requires
it, and inlines a macro, making it easier to comprehend
Commit: 33224646d4f52e6f285af556cd93961f3783c5d0
https://github.com/Perl/perl5/commit/33224646d4f52e6f285af556cd93961f3783c5d0
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Split ancillary from S_emulate_setlocale
This takes the code to update LC_ALL, used only in some Configurations,
out of the main line, making the main line more readable.
It also allows the removal of temporary code added a few commits back
Commit: 6d8afb4453a0c79d9391f68910e1f29f656d8ee6
https://github.com/Perl/perl5/commit/6d8afb4453a0c79d9391f68910e1f29f656d8ee6
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: locale "" can be disparate
Setting a locale "" means to get the value from environment variables.
These can set locale categories to different locales, and this needs to
be handled. The logic before this commit only handled the disparate
case when the locale wasn't ""; but this was compensated for elsewhere.
A future commit will remove that compensation.
Commit: 61d3ab001cf3021388aadbaf8cfc1c36689dacaf
https://github.com/Perl/perl5/commit/61d3ab001cf3021388aadbaf8cfc1c36689dacaf
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Split off setting locale to "" from S_emulate_setlocale
This is done for readability, to move the special casing of setting a
locale to the empty string (hence getting it from the environment) out
of the main line code.
Commit: 617c62515d746ab42805841a6beba5af1fdb2d8d
https://github.com/Perl/perl5/commit/617c62515d746ab42805841a6beba5af1fdb2d8d
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Duplicate more variables during cloning
These locale-related ones should be getting initialized in the new
thread, but be certain.
Commit: a9e6786b883881ec85c8cc0d316d9771f5738885
https://github.com/Perl/perl5/commit/a9e6786b883881ec85c8cc0d316d9771f5738885
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Add fcn to hide edge case undefined behavior
The POSIX 2008 API has an edge case in that the result of most of the
functions when called with a global (as opposed to a per-thread) locale
is undefined.
The duplocale() function is the exception which will create a per-thread
locale containing the values copied from the global one.
This commit just calls duplocale, if needed, and the caller need not
concern itself with this possibility
Commit: bc9bc60e68045f4c571a90aa8b703b76b277a42f
https://github.com/Perl/perl5/commit/bc9bc60e68045f4c571a90aa8b703b76b277a42f
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add DEBUGGING information
These functions are called as expansions of macros. It may be useful to
know where in the file the macro occurred.
Commit: 896610ff236013965b044da42949794fdf4f5875
https://github.com/Perl/perl5/commit/896610ff236013965b044da42949794fdf4f5875
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Separate out two Win fcns from a larger one
This makes the larger one easier to understand, and prepares for
possible independent calls to the two, which are potentially useful on
their own.
Commit: a42f3e849a7e3a5b102a4816e49462f4e776f4ae
https://github.com/Perl/perl5/commit/a42f3e849a7e3a5b102a4816e49462f4e776f4ae
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
f XXX make fcns accessible to cygwin
Commit: 2ffdc96284f175dd4c0a729c1e96e7feaf0ee2c3
https://github.com/Perl/perl5/commit/2ffdc96284f175dd4c0a729c1e96e7feaf0ee2c3
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: Use macro to reduce complexity
This #defines a macro and uses it to populate a structure, so that
strings don't have to be typed twice.
Commit: 72562015c5038a993d9d24d46d73c7ab1875e466
https://github.com/Perl/perl5/commit/72562015c5038a993d9d24d46d73c7ab1875e466
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs: White-space only
Properly indent some nested preprocessor directives
Commit: dcf60501d190f935d7b039c785af604d525c6fac
https://github.com/Perl/perl5/commit/dcf60501d190f935d7b039c785af604d525c6fac
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
Move code from POSIX.xs to locale.c
This avoids duplicated logic.
Commit: 062275fcc8bb0ecfbf319b84709917f66f22c548
https://github.com/Perl/perl5/commit/062275fcc8bb0ecfbf319b84709917f66f22c548
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder cases in a switch
This moves handling the CODESET to the end, as future commits will make
its handling more complicated. The cases are now ordered so the
simplest (based on the direction of future commits) are first
Commit: e34a032f3a273703f51ce0f1d2a8eb89647a8e45
https://github.com/Perl/perl5/commit/e34a032f3a273703f51ce0f1d2a8eb89647a8e45
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Make statics of repeated string constants
These strings are (or soon will be) used in multiple places; so have
just one definition for them.
Commit: 2547436736254f92a812749d5414084dc45454c8
https://github.com/Perl/perl5/commit/2547436736254f92a812749d5414084dc45454c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add two #defines
This makes sure that we handle having any variant of nl_langinfo() or
localeconv().
Commit: 1725da375e630b9ad2b89dea821cbbae6d5b0173
https://github.com/Perl/perl5/commit/1725da375e630b9ad2b89dea821cbbae6d5b0173
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Return defaults for uncomputable langinfo items
Return the values from the C locale for nl_langinfo() items that aren't
computable on this platform. If the platform has nl_langinfo(), then
all of them are computable, but if not, some can't be computed, and
others can be, but only if there are alternative methods available on
the platform.
As part of this commit, S_my_nl_langinfo() and S_save_to_buffer() are no
longer used when USE_LOCALE is not defined, so don't compile them.
Commit: b99cb6cc47822e92365b2e5443e0ec0c919bce40
https://github.com/Perl/perl5/commit/b99cb6cc47822e92365b2e5443e0ec0c919bce40
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv reimplementation of my_strftime()
Prior to this commit, there was a near duplicate copy of the code from
util.c that implements my_strftime(). This was done because the util.c
version zaps the wday field, which made it incompatible.
But it dawned on me that if the arbitrary date we use to do our
calculations were such that it was for a year in which January 1 falls
on a Sunday, then the util.c version automatically works.
Commit: 46634c8cb24fcd90c41af9fff24bde3ab101799a
https://github.com/Perl/perl5/commit/46634c8cb24fcd90c41af9fff24bde3ab101799a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Shorten static function name
The extra syllable(s) are unnecessary noise
Commit: 0247813ed0cd89e9ae10fdd549b98cc3882185a3
https://github.com/Perl/perl5/commit/0247813ed0cd89e9ae10fdd549b98cc3882185a3
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Extend a static function
This will allow it to be used in situations where the buffer it controls
is single use, and we don't need to keep track of the size for future
calls.
Commit: 850d3490e6e582fab3ebcee1fa412687543f640b
https://github.com/Perl/perl5/commit/850d3490e6e582fab3ebcee1fa412687543f640b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use typedef to simplify
This allows some preprocessor conditionals to be removed
Commit: b9d4eb29df1b46043e56b98a07b931b100a616c0
https://github.com/Perl/perl5/commit/b9d4eb29df1b46043e56b98a07b931b100a616c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv redundant cBOOL()
strEQ and && already return booleans
Commit: 6a3dfb8d980a43b6635140a6fcca4654daf5f710
https://github.com/Perl/perl5/commit/6a3dfb8d980a43b6635140a6fcca4654daf5f710
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix currency symbol derivation
On platforms without nl_langinfo(), we derive the currency symbol from
localeconv(). The symbol must be tweaked to conform to nl_langinfo()
standards. Prior to this commit, it guessed at how to tweak a rare
circumstance. I found evidence this guess was wrong, so looked around,
and copied the way cygwin does it.
This also no longer returns just an empty string in certain cases.
nl_langinfo() itself doesn't, so conform to that.
Commit: a9c6d51c011e5fa3838ec383fb25612dd2879a4f
https://github.com/Perl/perl5/commit/a9c6d51c011e5fa3838ec383fb25612dd2879a4f
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't add CP to Windows code page names
The actual name appears to be just the number for purposes of
nl_langinfo()-ish things.
Commit: 180769e16efd406aad48c49bfc19924d77544c38
https://github.com/Perl/perl5/commit/180769e16efd406aad48c49bfc19924d77544c38
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Don't ask a static fcn to be inlined
It's too complicated to really be inlined, and the compiler can figure
things out itself given it is a static function
Commit: 895b759e0332d01f38997e8fb0c6a19dad226f7d
https://github.com/Perl/perl5/commit/895b759e0332d01f38997e8fb0c6a19dad226f7d
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv no longer used param from static fnc
Previous commits have gotten rid of this parameter to S_save_to_buffer
Commit: 4f6802bb1ff5b2e0e17bdb6ade053cc42f4381cb
https://github.com/Perl/perl5/commit/4f6802bb1ff5b2e0e17bdb6ade053cc42f4381cb
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't change locale if already there
Changing the locale is cheap for some categories, but expensive for
others. Changing LC_COLLATE is most expensive, requiring recalculation
of the collation transformation mapping.
This commit checks that we aren't already in the desired locale before
changing locales. and does nothing if no change is needed.
Commit: 3242a2b6245eb6cc565d84fda30d24a373383b08
https://github.com/Perl/perl5/commit/3242a2b6245eb6cc565d84fda30d24a373383b08
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use a scratch buf; instead of reusing old
This is in preparation for the next commit
Commit: 6a690e881388f18a72c2797646c21990374543ef
https://github.com/Perl/perl5/commit/6a690e881388f18a72c2797646c21990374543ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Make static fcn reentrant
This makes my_langinfo() reentrant by adding parameters specifying where
to store the result.
This prepares for future commits, and fixes some minor bugs for XS
writers, in that the claim was that the buffer in calling
Perl_langinfo() was safe from getting zapped until the next call to it
in the same thread. It turns out there were cases where, because of
internal calls, the buffer did get zapped.
Commit: 5051c0aa14944c9fe07fd0e30f6ffd104b299eea
https://github.com/Perl/perl5/commit/5051c0aa14944c9fe07fd0e30f6ffd104b299eea
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: langinfo: Use Windows fcn to find CODESET
There is a Windows function, available for quite a long time, that will
return the current code page. Use this for the nl_langinfo() CODESET,
as that libc function isn't implemented on Windows.
Commit: 7dc14724b9ec9a74de1e218da195a11ceb713e57
https://github.com/Perl/perl5/commit/7dc14724b9ec9a74de1e218da195a11ceb713e57
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add static fcn to analyze locale codeset
It determines if the name indicates it is UTF-8 or not. There are
several variant spellings in use, and this hides that from the the
callers.
It won't be actually used until the next commit
Commit: aa2f2e16d64a1444261fa4f42b3ad1e4d7a06066
https://github.com/Perl/perl5/commit/aa2f2e16d64a1444261fa4f42b3ad1e4d7a06066
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M ext/I18N-Langinfo/Langinfo.pm
M locale.c
Log Message:
-----------
locale.c: Improve non-nl_langinfo() CODESET calc
Prior to this commit, on non-Windows platforms that don't have a
nl_langinfo() libc function, the code completely punted computation of
the CODESET item. I have not been able to figure out how to do this,
even going to the locale definition files on disk (which may vary
anyway), but we can do a lot better than punting.
This commit adds three checks:
1) If the locale name is C or POSIX, we know the codeset
2) We can detect if a locale is UTF-8. If it is, that is the codeset.
Many modern locales are of this ilk.
3) Failing that, some locales have the codeset appear in the name,
following a dot.
It isn't perfect, but it's a lot better than completely punting.
Commit: e305bf653ab19fe3fab87f59d1a7b98711ddfd03
https://github.com/Perl/perl5/commit/e305bf653ab19fe3fab87f59d1a7b98711ddfd03
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add toggle_locale() fcns
These are designed to temporarily switch the locale for a cateogry
around some operation that needs it to be different than the current
one. They will be used in the next commit.
These will eventually replace the more unwieldy
_is_cur_LC_category_utf8() function, which toggles as a side effect
Commit: f53a79e7577b442bdc97132b0c517382cdb33234
https://github.com/Perl/perl5/commit/f53a79e7577b442bdc97132b0c517382cdb33234
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
New signature for static fcn my_langinfo()
This commit changes the calling sequence for my_langinfo to add the
desired locale (or a sentinel to indicate to use the current locale),
and the locale category of the desired item.
This allows the function to be able to return the desired value for any
locale, avoiding some locale changes that would happen until this
commit, and hiding the need for locale changes from outside functions,
though a couple continue to do so to avoid potential multiple changes.
Commit: 2d493eb8ea7e1548c584a3806c116be4db710b60
https://github.com/Perl/perl5/commit/2d493eb8ea7e1548c584a3806c116be4db710b60
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add is_locale_utf8()
Previous commits have added the infrastructure to be able to determine
if a locale is UTF-8. This will prove useful, and this commit adds
a function to encapsulate this information, and uses it in a couple of
places, with more to come in future commits.
This uses as a final fallback, mbtowc(), which some sources view was a
late adder to C89, and others as not really being available until C99.
Future commits will add heuristics when that function isn't available.
Commit: 515794e49622e38ecf33a49020092fd5e2f18ce2
https://github.com/Perl/perl5/commit/515794e49622e38ecf33a49020092fd5e2f18ce2
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add fcn for UTF8ness determination
get_locale_string_utf8ness_i() will determine if the string it is passed
in the locale it is passed is to be treated as UTF-8, or not.
Commit: d20caccc00e64bcac88d4bc22158f3bd913f93e3
https://github.com/Perl/perl5/commit/d20caccc00e64bcac88d4bc22158f3bd913f93e3
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXX perldelta Move POSIX::localeconv() logic to locale.c
The code currently in POSIX.xs is moved to locale.c, and reworked some
to fit in that scheme, and the logic for the workaround for the Windows
broken localeconv() is made more robust.
This is in preparation for the next commit which will use this logic
instead of (imperfectly) duplicating it.
This also creates Perl_localeconv() for direct XS calls of this
functionality.
Commit: 165c47953f1ba8882890c147c9656b659d77ae16
https://github.com/Perl/perl5/commit/165c47953f1ba8882890c147c9656b659d77ae16
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: localeconv() unconditional NUMERIC toggle
It is possible to lockout changing the LC_NUMERIC locale. This is done
in some printf cases where a recursive call could get the radix
character wrong. But localeconv(), which could be called during this
recursion on some platforms, toggles the locale briefly, without
affecting the surrounding calls; so it can do the toggle
unconditionally.
The previous commit merely moved the functionality of localeconv() from
POSIX.xs to locale.c. This commit expands upon that.
Commit: 95a5a2f7f37b362ecdc01bf10a761ad0d72d64a2
https://github.com/Perl/perl5/commit/95a5a2f7f37b362ecdc01bf10a761ad0d72d64a2
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Collapse duplicate logic into one instance
The previous commit move the logic for localeconv() into locale.c. This
commit takes advantage of that to use it instead of repeating the logic.
On Windows, there is alternative way of finding the radix character for
systems that have a localeconv() that could cause a race. Prior to this
commit, if that failed to find something that looked like the radix, it
returned a '?'. Now it will drop down to using this new code, as the
likelihood of the race is small.
Notably, this commit removes the inconsistent duplicate logic that had
been used to deal with the Windows broken localeconv() bug.
Commit: 258bb276bb5700ea822d76d1db28e50758e54524
https://github.com/Perl/perl5/commit/258bb276bb5700ea822d76d1db28e50758e54524
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Fix windows bug with broken localeconv()
localeconv() was broken on Windows until VS 2015. As a workaround, this
was using my_snprintf() to find what the decimal point character is,
trying to avoid our workaround for localeconv(), which has a (slight)
chance of a race condition.
The problem is that my_snprintf() might not end up calling snprintf at
all; I didn't trace all possibilities in Windows. So it doesn't make
for a reliable sentinel.
This commit now specifically uses libc snprintf(), and if it fails, drops
down to try localeconv().
Commit: 94e6fd8b6e48b4fc4bd5665dc18275b34be96bb3
https://github.com/Perl/perl5/commit/94e6fd8b6e48b4fc4bd5665dc18275b34be96bb3
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M ext/POSIX/POSIX.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add my_strftime8()
This is like plain my_strftime(), but additionally returns an indication
of the UTF-8ness of the returned string
Commit: 774cbb722fcc2f61e5052ceaccc8dcb7b6a55692
https://github.com/Perl/perl5/commit/774cbb722fcc2f61e5052ceaccc8dcb7b6a55692
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add utf8ness return param to static fcn
my_langinfo_i() now will additionally return the UTF-8ness of the
returned string.
Commit: b73917cd12043868eef6b2a50a44f060d6e58abb
https://github.com/Perl/perl5/commit/b73917cd12043868eef6b2a50a44f060d6e58abb
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/Langinfo.xs
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Add Perl_langinfo8()
This is like Perl_langinfo() but additionally returns information about
the UTF-8ness of the returned string.
Commit: 3d1fbb8a469fcbcce512023a59372b7b50a36259
https://github.com/Perl/perl5/commit/3d1fbb8a469fcbcce512023a59372b7b50a36259
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add fallbacks if no mbtowc()
This add heuristics that work well for non-English locales to determine
if a locale is UTF-8 or not when mbtowc() isn't available. It would be
a very rare compiler that didn't have that these days, but this covers
that case as best as I have been able to figure out.
Commit: cde11a350fed8bda94680bd2522e8c4eb26e7148
https://github.com/Perl/perl5/commit/cde11a350fed8bda94680bd2522e8c4eb26e7148
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use Strerror(), not strerror()
Commit: f1f2661a442b89a5dbb2317b04b029292e4d22e6
https://github.com/Perl/perl5/commit/f1f2661a442b89a5dbb2317b04b029292e4d22e6
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor #ifdef's for clarity
The my_strerror() function has effectively 5 different implementations
depending on the capabilities of the platform. Only a few lines are
common to all, the set-up and the return. The #ifdefs obscure the
underlying logic. So this commit separates them out into 5 different
functions, with the result that it's clear what is going on in each.
Commit: 59786f865e68d495c305fc9bbe655cf96eb42830
https://github.com/Perl/perl5/commit/59786f865e68d495c305fc9bbe655cf96eb42830
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Avoid mojibake in "$!"
In stress testing, I discovered that the LC_CTYPE and LC_MESSAGES
locales need to be the same locale, or strerror() can return
question marks or mojibake instead of the proper message.
This commit refactors the handling of stringifying "$!" to make the
locales of both categories the same during the stringification.
Actually, I suspect it isn't the locale, but the codeset of the locale
that needs to be the same. I suspect that if the categories were both
in different UTF-8 locales, or both in single-byte locales, that things
would work fine. But it's cheaper to find the locale rather than the
locale's codeset, so that is what is done.
Commit: 130f7103237cfbdca93e628addf6d0ffcb8b8134
https://github.com/Perl/perl5/commit/130f7103237cfbdca93e628addf6d0ffcb8b8134
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M makedef.pl
M mg.c
M proto.h
Log Message:
-----------
Move utf8ness calc for $! into locale.c from mg.c
locale.c has the infrastructure to handle this, so remove repeated
logic.
The removed code tried to discern better based on using script runs, but
this actually doesn't help, so is removed.
Commit: 57c920e9292e33b891d672388addc31c0163d0fb
https://github.com/Perl/perl5/commit/57c920e9292e33b891d672388addc31c0163d0fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M mg.c
Log Message:
-----------
mg.c: White-space only
Indent newly formed block from the previous commit.
Commit: fb9b387be2f34c88ff8a87fbb4612aa4231573a1
https://github.com/Perl/perl5/commit/fb9b387be2f34c88ff8a87fbb4612aa4231573a1
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
locale.c: Rmv no longer used code; UTF8ness cache
What these functions do has been subsumed by code introduced in previous
commits, and in a more straight forward manner.
Also removed in this commit is the cache of the knowing what locales are
UTF-8 or not. This data is now cheaper to calculate when needed, and
there is now a single entry cache, so I don't think the complexity
warrants keeping it.
It could be added back if necessary, split off from the remainder of
this commit.
Commit: 623c01c5d126fb941b03e175f44ad33964284935
https://github.com/Perl/perl5/commit/623c01c5d126fb941b03e175f44ad33964284935
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
Don't discard locale info in starting P2008
The program is started in the global locale, and then is converted to
the POSIX 2008 per-thread locale API. Prior to this commit the startup
locale was discarded. It really should be the foundation for the 2008
locales. I don't know of any current paths through the code that this
makes a difference for, but it is a potential hole that is easy to plug.
Commit: 78d46cd415e52bc4839a3d597aad531b9f3a6c11
https://github.com/Perl/perl5/commit/78d46cd415e52bc4839a3d597aad531b9f3a6c11
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M perl.h
M proto.h
Log Message:
-----------
Add a common locale panic macro and functions
This will make sure that all the necessary clean up gets done.
Commit: b0c863b739bd105d5a43159895b99e8c13dab341
https://github.com/Perl/perl5/commit/b0c863b739bd105d5a43159895b99e8c13dab341
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Clean up thread_locale_init()
We can use internal functions to this file instead of the API ones here.
This commit also calls sync_locale() to avoid repeated logic.
Commit: 455f647b2e1dc0b5bf2e871dec9c5c9a1fb75412
https://github.com/Perl/perl5/commit/455f647b2e1dc0b5bf2e871dec9c5c9a1fb75412
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Omit an extra copy
In this case in Perl_setlocale(), we can just return the plain result
from setlocale(), as, if something further needs to be done that would
destroy it, that is taken care of already at the time.
On per-thread locale platforms, the result already is in a per-category
buffer.
Commit: 76f7ece241662745fe21514879c3cc8350687b22
https://github.com/Perl/perl5/commit/76f7ece241662745fe21514879c3cc8350687b22
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M sv.c
Log Message:
-----------
locale.c: Cache the current LC_CTYPE locale name
This is now used as a cache of length 1 to avoid having to lookup up the
UTF-8ness as often.
There was a complicated cache previously, but changes to the logic
caused that to be much less necessary, and it is no longer actually
used, and will be removed in a later commit.
But it's pretty easy to keep this single value around to cut further
down the new scheme's need to look it up
This commit also skips doing S_newctype() if the new boss is the same as
the old
Commit: 1b23653326bad25a12d014103ee71032916292f9
https://github.com/Perl/perl5/commit/1b23653326bad25a12d014103ee71032916292f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Initialize a variable
I don't believe there is a bug with this PL_numeric_name being
uninitialized, but this is an easy precaution.
Commit: 4624d86c27f93c6c370882f0653346883b4b2d5e
https://github.com/Perl/perl5/commit/4624d86c27f93c6c370882f0653346883b4b2d5e
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
Swap the ordering of two locale category indices
Perl internally uses a mapping of locale category values into a
consecutive sequence of indices starting at 0. These are used as
indexes into arrays. The reason is that the category numbers are
opaque, vary by platform, aren't necessarily sequential, and hence are
hard to make table driven code for.
This commit makes the LC_CTYPE index 0, and LC_NUMERIC equal to 1;
swapping them. The reason is to cause LC_CTYPE to get done first in the
many loops through the categories. The UTF8ness of categories is an
often needed value, and most of the time the categories will have the
same locale. LC_CTYPE is needed to calculate the UTF8ness, and by doing
it first and caching the result, the other categories likely
automatically will use the same value, without having to recalculate.
Commit: b90c01da388e28d45dfb79fac6266fb21fb0c990
https://github.com/Perl/perl5/commit/b90c01da388e28d45dfb79fac6266fb21fb0c990
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use new mechanism to save/restore errno
Instead of explicitly saving the errno around debugging statements, the
new more general mechanism is used.
Commit: 4fc63301a48bd0cbc85ed8da1c7abc11a3121615
https://github.com/Perl/perl5/commit/4fc63301a48bd0cbc85ed8da1c7abc11a3121615
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move DEBUG location info
This commit takes advantage of the new mechanism to add common DEBUGGING
code to print the __FILE__ and __LINE__ of every debugging statement.
This allows those to be removed from each statement, and have them
implicitly added.
This make things consistent, and easier to read and add new statements.
Commit: fcbda8cfbadaf92af5f20dddbab6b419ce390ea1
https://github.com/Perl/perl5/commit/fcbda8cfbadaf92af5f20dddbab6b419ce390ea1
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add some asserts
Commit: c9d68e6bea7f3b3a742c9016a7272c6568edb2ff
https://github.com/Perl/perl5/commit/c9d68e6bea7f3b3a742c9016a7272c6568edb2ff
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder code, rmv unneeded conditional
Previous commits have made the conditional about being able to find the
radix character unnecessary. The called function my_langinfo_c()
handles the case properly.
This commit also makes the trivial case first in a conditional, as that
is easier to comprehend.
Commit: 9995291acc5ad9d1bb70a6c9e2e8f7dbcfc3583d
https://github.com/Perl/perl5/commit/9995291acc5ad9d1bb70a6c9e2e8f7dbcfc3583d
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Reorder 'if' branches
It's better for understandability to have positive tests than negative
ones
Commit: db2d9332d82723cf91291c2b9602c15aeb52e32a
https://github.com/Perl/perl5/commit/db2d9332d82723cf91291c2b9602c15aeb52e32a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Refactor a static function
S_new_numeric() is called after the LC_NUMERIC category is changed, to
update various ancillary information Perl keeps.
This reorders the function so that on POSIX 2008 platforms, the numeric
object is created earlier. This allows for fewer operations on those
platforms, as we already have the correct value in place for querying
what the radix and thousands separator characters are.
Explanatory comments are also added.
Commit: 6040fa4583b39a3f576e1c1099152023d5c46dc0
https://github.com/Perl/perl5/commit/6040fa4583b39a3f576e1c1099152023d5c46dc0
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M locale.c
M proto.h
Log Message:
-----------
locale.c: Rmv unused code
The code to handle changing LC_NUMERIC and LC_COLLATION handled the
possibility of being passed a NULL locale name. But we're not changing
things unless we have a new locale, and know its name, so a name is
always passed
Commit: e9c0d6c6d2f84eab4e661988951c45f895898dca
https://github.com/Perl/perl5/commit/e9c0d6c6d2f84eab4e661988951c45f895898dca
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv unnecessary savepv()
This moves the savepv() down in the function, after we know we need it.
Commit: 86f57e3297f6b669dc0f79fba3d99a1bf3d5b69b
https://github.com/Perl/perl5/commit/86f57e3297f6b669dc0f79fba3d99a1bf3d5b69b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Mv line of code later in fcn
This avoids setting this until needed.
Commit: 273f1ff36051760afb70f26d291b2b4c6743d203
https://github.com/Perl/perl5/commit/273f1ff36051760afb70f26d291b2b4c6743d203
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Skip code if will be a no-op
The previous commits have fixed things up so that at this point in the
code nothing has changed, and if nothing will change, we can just return
Commit: 5fe95c625d23d82e23a8b568e3a92195e8b668fb
https://github.com/Perl/perl5/commit/5fe95c625d23d82e23a8b568e3a92195e8b668fb
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Specially handle the trivial case
When setting the numeric radix character, and the locale is C or POSIX,
we know it's going to be a dot without having to look further. All the
ancillary info is also known. So save time and just set these all and
return.
Commit: b4b1b28238408793efcfa73acf822dc811226524
https://github.com/Perl/perl5/commit/b4b1b28238408793efcfa73acf822dc811226524
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M intrpvar.h
M numeric.c
Log Message:
-----------
numeric.c, intrpvar.h: Rmv outdated condition, comment
It hasn't been true for some releases that the SV was removed when the
radix was a dot. Instead the SV contains the correct decimal point
character at all times.
Commit: 3b78459f70e0a16ea392b4fc973e1dd05382073a
https://github.com/Perl/perl5/commit/3b78459f70e0a16ea392b4fc973e1dd05382073a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Swap setting related variables
It is clearer to use the variable more directly related to what is being
set; then set the more distantly related onve, than vice versa
Commit: 343c5eafcb2f873dc1f3bd13f2564d43fbc8552e
https://github.com/Perl/perl5/commit/343c5eafcb2f873dc1f3bd13f2564d43fbc8552e
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Rmv special case
At this point in the code, we know we are already switched into the
underlying numeric locale; there's no need to further check to see if
switching is necessary.
Commit: 875c46afb8478afd41ee5718b88dcdcb7b905ad9
https://github.com/Perl/perl5/commit/875c46afb8478afd41ee5718b88dcdcb7b905ad9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M perl.c
M sv.c
Log Message:
-----------
locale.c: Save underlying radix character
When changing locales the new decimal point needs to be calculated.
This commit creates a new per-interpreter variable to save that
calculation, so it only has to be done when a new locale is set; prior
to this commit it was recalculated each time it was needed.
The calculation is still performed twice when the new locale is switched
into. But the redundant calculation will be removed in a couple of
commits hence.
Commit: 90517a91dbb50b1ae1af5f86bcd5c6b4b064956c
https://github.com/Perl/perl5/commit/90517a91dbb50b1ae1af5f86bcd5c6b4b064956c
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move debug stmt to earlier in fcn
Commit: 04f27ea8e3b0784a3b7903240d2de04bdeb83355
https://github.com/Perl/perl5/commit/04f27ea8e3b0784a3b7903240d2de04bdeb83355
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
Log Message:
-----------
locale.c: Rmv S_set_numeric_radix()
Previous commits have made this function much smaller, and its branches
can be easily absorbed into the callers, with clearer code, and in fact
removal of a redundant calculation of the locale's radix character,
promised in a previous commit's message
Commit: b9a7283adc9564e7125e849d851c0eb2a847e347
https://github.com/Perl/perl5/commit/b9a7283adc9564e7125e849d851c0eb2a847e347
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXXfinish commit msg locale.c: Rmv some special cases
The previous commits have allowed the removal of special casing of
making sure the
Commit: 9ae365fd0b14298322e0e4eb7c1173af0c7025e9
https://github.com/Perl/perl5/commit/9ae365fd0b14298322e0e4eb7c1173af0c7025e9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change assert() into STATIC_ASSERT()
Commit: 06bba136148a6c56a869f0a5bd06999c4f6cced7
https://github.com/Perl/perl5/commit/06bba136148a6c56a869f0a5bd06999c4f6cced7
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use standard fold table for C locale
Copy the standard compiled-in ASCII fold table when the locale is C or
POSIX, instead of looping through all 256 characters and computing them.
This saves some time as well as ensures that any platform bugs become
irrelevant.
Commit: 85454e3435a440422a7b83c1854cbd3e83ca7c02
https://github.com/Perl/perl5/commit/85454e3435a440422a7b83c1854cbd3e83ca7c02
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add check that strxfrm didn't fail
The code failed to take into account that strxfrm() can fail for reasons
besides buffer length. It does not return errors, and the only way to
check is to set errno to 0 beforehand, and check that it is still 0
afterwards.
Commit: 97ee1a51cb041fa666a586ed88a0dae353302aad
https://github.com/Perl/perl5/commit/97ee1a51cb041fa666a586ed88a0dae353302aad
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Don't assume LC_CTYPE, LC_COLLATE are same
This code is using isCNTRL_LC which depends on LC_CTYPE to verify that
something in the LC_COLLATE locale is a control. That only works
properly if the two locales are the same. This commit adds code to
ensure they are.
Commit: 861b7f254c1f8925973d73fe512b9f0563bd1096
https://github.com/Perl/perl5/commit/861b7f254c1f8925973d73fe512b9f0563bd1096
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: strxfrm() requires LC_CTYPE eq LC_COLLATE
The libc functions strxfrm() on some platforms requires the LC_CTYPE
locale to be the same as the LC_COLLATE locale (or rather, probably that
they have the same code set, but checking for locale is cheaper).
Otherwise mojibake would result, or more likely the function will fail,
setting errno.
This commit brings the locales into alignment if necessary
Commit: 8a96cf1c02df0fb895b99f9fa3f91906844e4736
https://github.com/Perl/perl5/commit/8a96cf1c02df0fb895b99f9fa3f91906844e4736
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M Configure
M Cross/config.sh-arm-linux
M Cross/config.sh-arm-linux-n770
M NetWare/config.wc
M Porting/config.sh
M config_h.SH
M configure.com
M metaconfig.h
M plan9/config_sh.sample
M uconfig.h
M uconfig.sh
M uconfig64.sh
M win32/config.gc
M win32/config.vc
Log Message:
-----------
Configure: strxfrm_l
Commit: 43aded080a08a33c9962d1b5176f4abd41653ecb
https://github.com/Perl/perl5/commit/43aded080a08a33c9962d1b5176f4abd41653ecb
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
XXX temp: lib/locale.t: debug
Commit: e4b3cb4e5a3b370ba618cf0a93991a9de72bd08e
https://github.com/Perl/perl5/commit/e4b3cb4e5a3b370ba618cf0a93991a9de72bd08e
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Use strxfrm_l() if available
This more modern version of the function doesn't require us to change
locales.
Commit: 7b47fc36b9f58bcc738dffb6c8ca3aef3772fc8a
https://github.com/Perl/perl5/commit/7b47fc36b9f58bcc738dffb6c8ca3aef3772fc8a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M mathoms.c
M proto.h
M sv.c
Log Message:
-----------
Change name of internal function
This is in preparation for working on it; the new name, mem_collxfrm_ is
in compliance with the C Standard; the old was not.
Commit: 6979a749c14e912a89c509401b7c66de65fd9913
https://github.com/Perl/perl5/commit/6979a749c14e912a89c509401b7c66de65fd9913
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M ext/POSIX/POSIX.xs
M ext/POSIX/lib/POSIX.pod
M locale.c
M proto.h
Log Message:
-----------
XXXdelta Fix POSIX::strxfrm()
This function takes an SV containing a PV. The encoding of that PV is
based on the locale of the LC_CTYPE locale. It really doesn't make
sense to collate based off of the sequencing of a different locale, which
prior to this commit it would do if the LC_COLLATION locale were
different.
Commit: 5fe5f5be5ff0401bf2c440dadeffa7bb66ecd890
https://github.com/Perl/perl5/commit/5fe5f5be5ff0401bf2c440dadeffa7bb66ecd890
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Improve debugging for mem_collxfrm()
This prints out more information, better organized.
It also moves up the info from -DLv to plain -DL
Commit: d7a8a83a480abe160ac22408c6e1a401f75e1deb
https://github.com/Perl/perl5/commit/d7a8a83a480abe160ac22408c6e1a401f75e1deb
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debug statement for collation failure
Perhaps this should be a warning to the user that we couldn't calculate
collation info for the locale, but at least there should be a way to
get that info from a DEBUG statement
Commit: 64d6f4518beaf0156ccbf46ecdc5c742fabdb2b8
https://github.com/Perl/perl5/commit/64d6f4518beaf0156ccbf46ecdc5c742fabdb2b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Print code point in hex, not decimal
Hex is the more familiar form
Commit: 7164572499a6f13f72873f3c63a78405024cc933
https://github.com/Perl/perl5/commit/7164572499a6f13f72873f3c63a78405024cc933
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
Mark certain mutex lock macros as private
mbtowc() mblen(), and wctomb() should not be directly used by XS
writers; instead use the POSIX versions. Don't encourage the direct use
by having public macros to aid in their use.
Commit: 874b3394c0c36cddccb8c159ad9403f204d35a63
https://github.com/Perl/perl5/commit/874b3394c0c36cddccb8c159ad9403f204d35a63
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some code around
This is purely to make future commits have smaller real difference
listings, and involves a temporary (complemented) copy of a preprocessor
conditional.
Commit: 1b569e4694f5526ce435059fa403d5c983be2414
https://github.com/Perl/perl5/commit/1b569e4694f5526ce435059fa403d5c983be2414
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Reorder cpp branches
Disposing of the trivial case first makes things easier to read.
Commit: a57b4e3bba8a1bda4fec322344b4724f13fc85ef
https://github.com/Perl/perl5/commit/a57b4e3bba8a1bda4fec322344b4724f13fc85ef
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M makedef.pl
M perl.h
M sv.c
Log Message:
-----------
Make the locale mutex a general semaphore
Future commits will use this new capability, and in Configurations where
no locale locking is currently necessary.
Commit: 336e52579406c81459e5cd9d78ff4cc7d379b8af
https://github.com/Perl/perl5/commit/336e52579406c81459e5cd9d78ff4cc7d379b8af
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M makedef.pl
M perl.h
M perlvars.h
M sv.c
Log Message:
-----------
Use general locale mutex for numeric operations
This commit removes the separate mutex for locking locale-related
numeric operations on threaded perls; instead using the general locale
one. The previous commit made that a general semaphore, so now suitable
for use for this purpose as well.
This means that the locale can be locked for the duration of some
sprintf operations, longer than before this commit. But on most modern
platforms, thread-safe locales cause this lock to expand just to a
no-op; so there is no effect on these. And on the impacted platforms,
one is not supposed to be using locales and threads in combination, as
races can occur. This lock is used on those perls to keep Perl's
manipulation of LC_NUMERIC thread-safe. And for those there is also no
effect, as they already lock around those sprintf's.
Commit: 0587e4aeef95804e17333a0c2b678ace234f630b
https://github.com/Perl/perl5/commit/0587e4aeef95804e17333a0c2b678ace234f630b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Add locale macro to wrap static-space-using fncs
Some functions return a result in a global-to-the-program buffer, or
they have an internal global buffer. Other threads must be kept from
simultaneously using that function. This macro is to be used for all
such ones dealing with locales. Ideally, there would be a separate mutex
for each such buffer space. But these functions also have to lock the
locale from changing during their execution, and there aren't that many
such functions, and they actually are rarely executed. So a single lock
will do.
This will allow future commits to have more targeted locking for
functions that don't affect the global locale.
Commit: 8f276909f40a42928957826c18333d8d1c492f17
https://github.com/Perl/perl5/commit/8f276909f40a42928957826c18333d8d1c492f17
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
Redefine the POSIX.xs locale macros using prev commit
This commit uses the new macro introduced in the previous commit to
define the internal locale mutex macros in POSIX.xs
Commit: 0c9e36e0d58ccb16cfe3354de66645ff7b92e515
https://github.com/Perl/perl5/commit/0c9e36e0d58ccb16cfe3354de66645ff7b92e515
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove NL_LANGINFO_LOCK
This is needed in precisely one place in the code, so move it to there.
Commit: 85fc7817f41a6eb8ae595f97f684ad2b883e59d5
https://github.com/Perl/perl5/commit/85fc7817f41a6eb8ae595f97f684ad2b883e59d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
perl.h: Remove LOCALECONV_LOCK
This is needed in just one function, in locale.c, so more it there.
Commit: 50ba688d3422c7dc8490c3cce166236132936f9f
https://github.com/Perl/perl5/commit/50ba688d3422c7dc8490c3cce166236132936f9f
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M perl.h
Log Message:
-----------
XXX perlembed Add PORCELAIN_SETLOCALE_LOCK/UNLOCK
This macro is used to surround raw setlocale() calls so that the return
value in a global static buffer can be saved without interference with
other threads.
There are a few very rarely occurring instances in locale.c that are
converted to use this. These previously could have been races.
The raw setlocales in the initialization function are not guarded, as
these happen early in the Perl process initialization, before threading
is enabled.
This is buggy if there are multiple embedded perls. It can't be helped.
perlembed is being updated to indicate this.
Commit: f1d07ec7b7cbb2c8662dc2c732463395008eb87c
https://github.com/Perl/perl5/commit/f1d07ec7b7cbb2c8662dc2c732463395008eb87c
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move #defining SETLOCALE_LOCK
This simplifies slightly, and will allow further simplification
Commit: 4f03c8ca83684e465b683d26b7b12594465b059b
https://github.com/Perl/perl5/commit/4f03c8ca83684e465b683d26b7b12594465b059b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move LOCALE_READ_LOCK #definition
To enable future simplifications
Commit: 99da01ceb473e71aa6abe2fd63d0ced4e21903c8
https://github.com/Perl/perl5/commit/99da01ceb473e71aa6abe2fd63d0ced4e21903c8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
M makedef.pl
M perl.c
M perl.h
M sv.c
Log Message:
-----------
locale.c: Move #define to perl.h; use it elsewhere
Rather than recalculate this combined conditional, do it once in
perl.h.
Commit: 18ea850bffd2eaf47961f25510c7875437bce55b
https://github.com/Perl/perl5/commit/18ea850bffd2eaf47961f25510c7875437bce55b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Mitigate unsafe threaded locales
This a new set of macros and functions to do locale changing and
querying for platforms where perl is compiled with threads, but the
platform doesn't have thread-safe locale handling.
All it does is:
1) The return of setlocale() is always safely saved in a per-thread
buffer, and
2) setlocale() is protected by a mutex from other threads which are
using perl's locale functions.
This isn't much, but it might be enough to get some programs to work on
such platforms which rarely change or query the locale.
Commit: 3d2e244190c500c5fd499ab7bb547d5d3b442562
https://github.com/Perl/perl5/commit/3d2e244190c500c5fd499ab7bb547d5d3b442562
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX make sure comments get moved appropriately perl.h: Remove now empty block
Previous commits have left this empty except for comments.
Commit: e5cdfc1ccd6ea76cca80b48caf13d03759d0f34d
https://github.com/Perl/perl5/commit/e5cdfc1ccd6ea76cca80b48caf13d03759d0f34d
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M pp.c
Log Message:
-----------
XXX pp.c: do %g print under mutex,
Commit: 5007173c6273523a12e463bdf4ec9944a2ec8816
https://github.com/Perl/perl5/commit/5007173c6273523a12e463bdf4ec9944a2ec8816
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M ebcdic_tables.h
M embedvar.h
M globvar.sym
M inline.h
M intrpvar.h
M perl.h
M regen/ebcdic.pl
M sv.c
Log Message:
-----------
Make fc(), /i thread-safe on participating platforms
A long standing bug in Perl that has gone undetected is that the array
is global that is created when changing locales and tells fc() and qr//i
matching what the folds are in the new locale.
What this means is that any program only has one set of fold definitions
that apply to all threads within it, even if we claim that the locales
are thread-safe on the given platform. One possibility for this going
undetected so long is that no one is using locales on multi-threaded
systems much. Another possibility is that modern UTF-8 locales have the
same set of folds as any other one.
It is a simple matter to make the fold array per-thread instead of
per-process, and that solves the problem transparently to other code.
I discovered this stress-testing locale handling under threads. That
test will be added in a future commit.
Commit: a37b98b6e31d84021bcf48cb03efd315f67190a9
https://github.com/Perl/perl5/commit/a37b98b6e31d84021bcf48cb03efd315f67190a9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M inline.h
M locale.c
Log Message:
-----------
locale.c/inline.h: Add fold calc debug statements
Under verbose debugging, this shows non-standard folds
Commit: faab94930c61b37a1e3c0bca12c068dbccbed2cc
https://github.com/Perl/perl5/commit/faab94930c61b37a1e3c0bca12c068dbccbed2cc
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c comments
Commit: 5852a61e9c303f70f3b9e867faca0acc78067cc8
https://github.com/Perl/perl5/commit/5852a61e9c303f70f3b9e867faca0acc78067cc8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX prob drop; done before anything so no races
Commit: 6651820000a8122d8edf68cfd5f8dfefe8507822
https://github.com/Perl/perl5/commit/6651820000a8122d8edf68cfd5f8dfefe8507822
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Add #define for gwENVr_LOCALEr_UNLOCK
This is for functions that read the locale and environment and write to
some global space.
Commit: 9e9abe8c36ada61f6363af709364273ccff7ee42
https://github.com/Perl/perl5/commit/9e9abe8c36ada61f6363af709364273ccff7ee42
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
M time64.c
Log Message:
-----------
Remove ENV_LOCALE_LOCK/UNLOCK macros
These are subsumed by gwENVr_LOCALEr_LOCK created in the previous
commit.
Commit: b3d3069479f32afb18ad441463c7bebe7abf3cb8
https://github.com/Perl/perl5/commit/b3d3069479f32afb18ad441463c7bebe7abf3cb8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
M time64.c
M util.c
Log Message:
-----------
Change ENV/LOCALE locking read macro names
The old name was confusing.
Commit: bf92704f989bad35a676f56491f93ca2f753010a
https://github.com/Perl/perl5/commit/bf92704f989bad35a676f56491f93ca2f753010a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Move some statements
So they are closer to related statements
Commit: c7ec92516bcbbfa824a6f61b77176fbe4c17bdd8
https://github.com/Perl/perl5/commit/c7ec92516bcbbfa824a6f61b77176fbe4c17bdd8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
M util.c
Log Message:
-----------
perl.h: Finish implementing combo ENV/LOCALE mutexes
There are cases where an executing function is vulnerable to either the
locale or environment being changed by another thread. This commit
implements macros that use mutexes to protect these critical sections.
There are two cases that exist: one where the functions only read; and
one where they can also need exclusive control so that a competing
thread can't overwrite the returned static buffer before it is safely
copied.
5.32 had a placeholder for these, but didn't actually implement it.
Instead it locked just the ENV portion. On modern platforms with
thread-safe locales, the locale portion is a no-op anyway, so things
worked on them.
This new commit extends that safety to other platforms. This has long
been a vulnerability in Perl.
Commit: 5e73f6d6f3dccc70913609acdd105eb8a5854034
https://github.com/Perl/perl5/commit/5e73f6d6f3dccc70913609acdd105eb8a5854034
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M time64.c
Log Message:
-----------
time64.c: Remove no longer needed code
This code defined some macros; those are now defined by perl.h
Commit: fd3b275d25ca0b60e87d3d15caeeba0350763426
https://github.com/Perl/perl5/commit/fd3b275d25ca0b60e87d3d15caeeba0350763426
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M pp_sys.c
Log Message:
-----------
XXX need to StructCopy pp_sys mutexes
Commit: 937ea891f1984a1d6b54c9793e7f7037ceee902d
https://github.com/Perl/perl5/commit/937ea891f1984a1d6b54c9793e7f7037ceee902d
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M win32/win32.c
Log Message:
-----------
win32.c: Add mutexes around some calls
These could have races.
Commit: 9ff6655e4125afc9a4f8ea31f976157db349d7ce
https://github.com/Perl/perl5/commit/9ff6655e4125afc9a4f8ea31f976157db349d7ce
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
Log Message:
-----------
POSIX.xs env locks, check file for more
Commit: ef655e5a6706b907237c8510945af0fc93fb440b
https://github.com/Perl/perl5/commit/ef655e5a6706b907237c8510945af0fc93fb440b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: mktime needs to run under a mutex
per the Posix standard
Commit: 12ad67e137915fc689e2cccf2b88586e7c81e9e5
https://github.com/Perl/perl5/commit/12ad67e137915fc689e2cccf2b88586e7c81e9e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M util.c
Log Message:
-----------
util.c: Add locks around strftime() calls
Commit: db6e06af8c95d6d20398ae55972b8d3b92179d26
https://github.com/Perl/perl5/commit/db6e06af8c95d6d20398ae55972b8d3b92179d26
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M os2/os2.c
Log Message:
-----------
os2: Use many reader lock instead of exclusive
This is just reading the environment, not changing it, so a many readers
can be accessing it at the same time.
Commit: ae4263907e3f54cd9473c9885dea6647a4197504
https://github.com/Perl/perl5/commit/ae4263907e3f54cd9473c9885dea6647a4197504
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.pm
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
XXX cpan PR Time-Piece: Add locks
This add mutex locking around some unsafe thread operations to make this
module thread-safe.
Commit: 13e78fc89a2eddb2d6c707478be145d86054f98f
https://github.com/Perl/perl5/commit/13e78fc89a2eddb2d6c707478be145d86054f98f
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use foldEQ_locale() if available
This supported core function is thread-safe and knows about Perl
internals, so is preferable to the similar libc function, which is now
used only as a fallback. This commit also bomb proofs the code by
adding an additional fallback, specified in C89, which isn't a great
substituted, but far better than nothing.
Commit: 884a96333f7de8eee6b38768deb427cd4f5fd3fd
https://github.com/Perl/perl5/commit/884a96333f7de8eee6b38768deb427cd4f5fd3fd
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isSPACE, not isspace
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isSPACE_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 9c2f9817dd7c52e5151f38578ae059a0a92074d5
https://github.com/Perl/perl5/commit/9c2f9817dd7c52e5151f38578ae059a0a92074d5
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isDIGIT, not isdigit
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isDIGIT_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 42c3b4eceaf5b137143a174406e4ecf1ca943164
https://github.com/Perl/perl5/commit/42c3b4eceaf5b137143a174406e4ecf1ca943164
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
Log Message:
-----------
Time-Piece: Use isUPPER, not isupper
The latter gives results that are dependent on the program's underlying
locale, and so may be inconsistent.
If locale dependence is actually desired, isUPPER_LC should be used, as
it knows about various things the module writer shouldn't have to
concern themselves with. It is supported since 5.004
Commit: 817c60214c18698595a02d5ef512befea0b8a9c9
https://github.com/Perl/perl5/commit/817c60214c18698595a02d5ef512befea0b8a9c9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M pod/perlhacktips.pod
Log Message:
-----------
XXX incomplete perlhacktips:
Commit: 6e71efdf4c6a65269699e938820f56ea2ec5614c
https://github.com/Perl/perl5/commit/6e71efdf4c6a65269699e938820f56ea2ec5614c
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M dist/IO/IO.pm
M dist/IO/IO.xs
Log Message:
-----------
XXX check if using ppport IO.xs: Remove fallback code furnished by ppport
Commit: 02c3647dd66e720afed368f4829ab39af2926927
https://github.com/Perl/perl5/commit/02c3647dd66e720afed368f4829ab39af2926927
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M hints/freebsd.sh
Log Message:
-----------
XXX check with freebsd: hints/freebsd.sh
Commit: 95cdd806b082ae548b6b89b5fabdb6cce71ad050
https://github.com/Perl/perl5/commit/95cdd806b082ae548b6b89b5fabdb6cce71ad050
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
thread.h: White-space, braces only
Commit: 50296769c54587dd095fc88fa3dd3050fcaefc40
https://github.com/Perl/perl5/commit/50296769c54587dd095fc88fa3dd3050fcaefc40
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M thread.h
Log Message:
-----------
XXX thread.h Save errno around lock/unlock
Commit: feda54027396008bcce7370441e9d43f4a5fd0e4
https://github.com/Perl/perl5/commit/feda54027396008bcce7370441e9d43f4a5fd0e4
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging mutex lock'
Commit: 24d8c1ddd6f7ca70e4339945559a01acda2e7f01
https://github.com/Perl/perl5/commit/24d8c1ddd6f7ca70e4339945559a01acda2e7f01
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M ext/POSIX/POSIX.xs
M locale.c
M perl.h
Log Message:
-----------
locks
Commit: bf662e3c6d12381806e073f2254333bc79787390
https://github.com/Perl/perl5/commit/bf662e3c6d12381806e073f2254333bc79787390
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
XXX locale.c: Kludge because C obj getting destroyed
Commit: a820222b3deb1bc3b9f49e156dd3d5f3c3fbf36e
https://github.com/Perl/perl5/commit/a820222b3deb1bc3b9f49e156dd3d5f3c3fbf36e
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M .github/workflows/testsuite.yml
Log Message:
-----------
Make DEBUGGING the default on CI
Commit: 83a192f614a589c40f769439471d38799f9fdba9
https://github.com/Perl/perl5/commit/83a192f614a589c40f769439471d38799f9fdba9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
t/run/locale.t: Move init stmt
This makes it easier to add a line to turn on debugging temporarily
Commit: cfcfb44cd6b35228ef790e7cb284c5abd95a48b8
https://github.com/Perl/perl5/commit/cfcfb44cd6b35228ef790e7cb284c5abd95a48b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/run/locale.t
Log Message:
-----------
XXX run/locale.t temp debug
Commit: 90e175013495560e5ff00079c69ec7ae57065cf9
https://github.com/Perl/perl5/commit/90e175013495560e5ff00079c69ec7ae57065cf9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Clean up white space
Change tabs to blanks; Fix indentation; chomp trailing white space
Remove some blank lines that don't contribute to readability
Commit: 4cd923fc3d63f94c6b2df259c6e515131c9d90d4
https://github.com/Perl/perl5/commit/4cd923fc3d63f94c6b2df259c6e515131c9d90d4
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/porting/customized.dat
M vutil.c
Log Message:
-----------
vutil.c: Simplify locale handling
I read the code over and realized that there was a much simpler way to
do things.
Commit: 06ed7a1ad9c18d42f45035563334dd245852f25c
https://github.com/Perl/perl5/commit/06ed7a1ad9c18d42f45035563334dd245852f25c
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Change a branch into an assert
This code should no longer be necessary; but verify
Commit: 55d9de4ee3ebf32d9f268ff3f7742e5cdb541833
https://github.com/Perl/perl5/commit/55d9de4ee3ebf32d9f268ff3f7742e5cdb541833
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
Add pTHX to locale_thread_init()
Commit: 4f7d824de421b7287b9573dc5073b9764b2036d8
https://github.com/Perl/perl5/commit/4f7d824de421b7287b9573dc5073b9764b2036d8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: e64a26d40027b51520dd229051ebdc226b236be9
https://github.com/Perl/perl5/commit/e64a26d40027b51520dd229051ebdc226b236be9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
PLcurlocales
Commit: bc3d7426189feecdc394ce082b7dd8e272ba216a
https://github.com/Perl/perl5/commit/bc3d7426189feecdc394ce082b7dd8e272ba216a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embedvar.h
M intrpvar.h
M locale.c
M sv.c
Log Message:
-----------
Revert "PLcurlocales"
This reverts commit cd1fd76eac05b9ca866bb6f1dae6151767aa3d76.
Commit: b753f186dcf00f148ec9348b2a46be67f8a069f8
https://github.com/Perl/perl5/commit/b753f186dcf00f148ec9348b2a46be67f8a069f8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t FILE debug
Commit: 9d2b4a12163a8746ff95c15df4c09f67e2fae10b
https://github.com/Perl/perl5/commit/9d2b4a12163a8746ff95c15df4c09f67e2fae10b
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: windows DEBUG stmts
Commit: 277e16688db0a07f09261568e8a4dd5572df5405
https://github.com/Perl/perl5/commit/277e16688db0a07f09261568e8a4dd5572df5405
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M proto.h
Log Message:
-----------
f save_to_buffer ignore return
Commit: bee8c05e2737a1dc1b606ee11f85e6b7a6aa163e
https://github.com/Perl/perl5/commit/bee8c05e2737a1dc1b606ee11f85e6b7a6aa163e
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
handy.h: Add layer for char classification/case change
This layer currently expands to just the layer below it, but that will
be changed in a future commit.
Commit: 2dbb11c6320aee81d910b3db2788914b2162c5f6
https://github.com/Perl/perl5/commit/2dbb11c6320aee81d910b3db2788914b2162c5f6
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M t/porting/known_pod_issues.dat
Log Message:
-----------
perlxs
Commit: 8433b26a27f921778f9d1020e5199bfbc8924e8c
https://github.com/Perl/perl5/commit/8433b26a27f921778f9d1020e5199bfbc8924e8c
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Temp dont use querylocale()
Commit: 6de445902b936c800507543f0986bd8e8dfecc0a
https://github.com/Perl/perl5/commit/6de445902b936c800507543f0986bd8e8dfecc0a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
l
Commit: 8c77fe01f1be5f82429ce8bae34635138dcd5709
https://github.com/Perl/perl5/commit/8c77fe01f1be5f82429ce8bae34635138dcd5709
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Swap position of two defns; add comment
Commit: 5a104aed2b810356819cfc92f28181932a6c7074
https://github.com/Perl/perl5/commit/5a104aed2b810356819cfc92f28181932a6c7074
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M intrpvar.h
M locale.c
Log Message:
-----------
locale.c: Add 'Lazy' location changing
When comparing two strings for order under 'use locale', one can call
strcoll() which creates hidden modified versions of the strings based on
the locale's collation ordering, does the comparison, and then throws
away the modified versions.
Or one can call strxfrm() to create a non-hidden modified version of
each string, and then do a straight comparison. The advantage here is
that you are in control of when to discard the modified version, and the
(expensive) transformation is done just once, no matter how many times a
comparison is done.
Perl assumes that a string will be compared multiple times, so the first
time it happens under 'use locale', strxfrm() is called, and the
modified string is attached via magic to the SV. The modified string is
discarded if the string changes, or is recomputed if the locale has
changed since the computation was done.
The transformation generally occupies some multiple of size of the
original string. Memory must be allocated to hold it. For any given
locale, the amount is predictable for all strings, roughly via a linear
equation "mx+b", where x is the size of the original string. By
computing 'm' and 'b' once, Perl can allocate enough memory to hold the
transformation, but not too much. (m and b are adjusted up as necessary
as more strings get transformed.) This minimizes mallocs.
But the calculation of m and b is somewhat expensive, and only necessary
if the program actually does a string compare under 'use locale'.
This commit defers the calculation until needed. It does the bare
minimum of changes accomplish this. The next commit will rearrange
things.
Commit: f5a26baa08ba203c1ad2b0e6fd600b704644f526
https://github.com/Perl/perl5/commit/f5a26baa08ba203c1ad2b0e6fd600b704644f526
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Move code, white-space, comment only
This moves the function created in the previous commit to a more logical
place in the file; just before its only call. It also removes nested
blocks that are no longer necessary.
Commit: be8d7eb6c38b23c0b7045ada650e4075f75f189a
https://github.com/Perl/perl5/commit/be8d7eb6c38b23c0b7045ada650e4075f75f189a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M util.c
Log Message:
-----------
XXX Configure strftime() is C89
We can assume it exists
Commit: d7f9e27cb2feb59fa7e542920a4722a4a5b9a824
https://github.com/Perl/perl5/commit/d7f9e27cb2feb59fa7e542920a4722a4a5b9a824
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
M sv.c
Log Message:
-----------
perl.h: Change macro name to be C conformant
Leading underscores in names are undefined
Commit: 55e5bc24da40185e29aa072b3893278d63a0af49
https://github.com/Perl/perl5/commit/55e5bc24da40185e29aa072b3893278d63a0af49
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
patchlevel.h: White-space only: properly indent
Commit: c4f875e4c9a64c941c2a17d99e31d9cf3c092a07
https://github.com/Perl/perl5/commit/c4f875e4c9a64c941c2a17d99e31d9cf3c092a07
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Comments white-space only
Commit: f4e65db7e4ee0764637e9e921a377f27701ce6f7
https://github.com/Perl/perl5/commit/f4e65db7e4ee0764637e9e921a377f27701ce6f7
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M makedef.pl
Log Message:
-----------
makedef.pl: Rmv obsolete symbol
This routine is now a static function, so needn't be in makedef.pl
Commit: 97d234f8e5f5a97063a5f1696b6fbc4e94f1f84c
https://github.com/Perl/perl5/commit/97d234f8e5f5a97063a5f1696b6fbc4e94f1f84c
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Refactor internal debugging function
setlocale_debug_string() variants now use Perl_form, a function I
didn't know existed when I originally wrote this code.
Commit: eadc7432e3c1b3b8ee1e9bdfbc986351b340c498
https://github.com/Perl/perl5/commit/eadc7432e3c1b3b8ee1e9bdfbc986351b340c498
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M locale.c
M proto.h
Log Message:
-----------
locale.c: Add a fcn to display LC_ALL
This is trivial on a platform that has LC_ALL, but requires extra work
on platforms that don't.
Commit: 87753070dd721e27aa09272c1285b98bf07edb0e
https://github.com/Perl/perl5/commit/87753070dd721e27aa09272c1285b98bf07edb0e
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Add debugging check
If we run across the REPLACEMENT CHARACTER, its likely a mismatch
between LC_CTYPE and another category. This panics on debugging builds.
Commit: a03a80587fcc2f3eb879fb802c91fd4dfe6cc3cd
https://github.com/Perl/perl5/commit/a03a80587fcc2f3eb879fb802c91fd4dfe6cc3cd
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize variables to avoid runtime check
Initializing them means we no longer have to tess that they are non-NULL
each time they are accessed.
Commit: ac0e126cf61498f9d5320168950cce1cc2500c47
https://github.com/Perl/perl5/commit/ac0e126cf61498f9d5320168950cce1cc2500c47
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
Log Message:
-----------
locale.c: Initialize PL_underlying_numeric_obj
This probably doesn't matter, but it's better form to initialize it to a
sane value.
Commit: 9714f3e6ee028a21976eeb1ffed2d4614a85a16a
https://github.com/Perl/perl5/commit/9714f3e6ee028a21976eeb1ffed2d4614a85a16a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Print better failing test numbers
This test module is 'required' from other perl test files. If it
encounters an error, it doesn't know how to report it. What it does is
call fail() if available, and a home-grown one otherwise. Prior to this
commit the home-grown version just made all tests number 0. This commit
changes that to make them sequentially numbered from a very high
starting one, so as not to interfere with the outer calls.
Commit: cd26881254112303538d1619285320e5ee1e8c73
https://github.com/Perl/perl5/commit/cd26881254112303538d1619285320e5ee1e8c73
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin
Commit: bbf3d4a356cdb6e890854d11e8c3e35d438102a7
https://github.com/Perl/perl5/commit/bbf3d4a356cdb6e890854d11e8c3e35d438102a7
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M patchlevel.h
Log Message:
-----------
Kludge to get cygwin to compile
Commit: c59fd11fa9d9ad514bd036b0d4f3fc3e641c2343
https://github.com/Perl/perl5/commit/c59fd11fa9d9ad514bd036b0d4f3fc3e641c2343
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
cygwin use fcns
Commit: af87c0fbc296fe58768d901b29bdb632a52767c0
https://github.com/Perl/perl5/commit/af87c0fbc296fe58768d901b29bdb632a52767c0
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M cygwin/cygwin.c
Log Message:
-----------
Revert "cygwin use fcns"
This reverts commit 24fbf2ccd8777c4af31eb9f8038d4cff7073b0c4.
Commit: ee5478d31604818f50be82ac394290cbd374b604
https://github.com/Perl/perl5/commit/ee5478d31604818f50be82ac394290cbd374b604
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Refactor _trylocale()
This function is used to see if a locale actually works on the current
platform. I was not fully aware of the glitches if a category is in one
locale, and LC_CTYPE is in another. This makes sure they are both the
same; and this results in some simplification.
Commit: 3462724ffba026375efa81f225a8196630489122
https://github.com/Perl/perl5/commit/3462724ffba026375efa81f225a8196630489122
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Fail earlier
Move the code that returns failure into the loop, so won't keep
iterating if failure is going to happen anyway.
Commit: ae96cd1d5638a9d95984f421d93c7c1ebc87b1dc
https://github.com/Perl/perl5/commit/ae96cd1d5638a9d95984f421d93c7c1ebc87b1dc
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Add checks
This verifies that we can restore a locale that we were previously in,
and makes sure that we don't stay in a locale that doesn't work well.
Doing so has led to crashes.
Commit: 2f69a022b4846e2424cd837f5c9af3eb70ca0da4
https://github.com/Perl/perl5/commit/2f69a022b4846e2424cd837f5c9af3eb70ca0da4
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Don't allow commas in locale names
This was a problem in some buggy Windows versions. This addition keeps
locales with this bug from being tested.
Commit: c804f4a34b2b946248045cf2fc2198e589729d45
https://github.com/Perl/perl5/commit/c804f4a34b2b946248045cf2fc2198e589729d45
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Check for unsupported locales
This commit causes us not to view unsupported locales as legitimate for
testing. Core dumps occurred on some platforms without this.
It looks for a diagnostic that the next commit in this series will
generate.
Commit: 707f4c87753d42defb6cd0cd3b2d73529e9e5c5f
https://github.com/Perl/perl5/commit/707f4c87753d42defb6cd0cd3b2d73529e9e5c5f
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M locale.c
M pod/perldiag.pod
Log Message:
-----------
XXXdelta Add locale unsupported test
Perl only suppots multi-byte locales that are UTF-8. It turns out that
the others are worse than I thought, and if someone switches to one, the
program can crash.
This commit generates a default-on diagnostic when switching into such a
locale, and doesn't take the steps to add its data to the LC_CTYPE
database.
The check has been done in various releases for some time, but this
elevates its severity and tries to avoid actually using its data.
The previous commit caused the test suite to view such a locale as
unacceptable.
Commit: 2737a6df47fac34868c4d78a7c5251006a5a33b3
https://github.com/Perl/perl5/commit/2737a6df47fac34868c4d78a7c5251006a5a33b3
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: White-space only
Commit: 4639946867ddbdf3e13d19514c1dcbefcaccd5f9
https://github.com/Perl/perl5/commit/4639946867ddbdf3e13d19514c1dcbefcaccd5f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
XXX t/loc_tools.pl: Temp debug
Commit: 7af41e342c8298701d38e3c19d7e8e204d89ea80
https://github.com/Perl/perl5/commit/7af41e342c8298701d38e3c19d7e8e204d89ea80
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M t/loc_tools.pl
Log Message:
-----------
t/loc_tools.pl: Swap lines
It doesn't matter much, but some warnings might be output by doing the
'use locale' before turning off warnings.
Commit: d8738a8dd1510689cf525e6bb90e523e429f80b8
https://github.com/Perl/perl5/commit/d8738a8dd1510689cf525e6bb90e523e429f80b8
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads
Commit: 789c70a576927b18b3c9770d38dbc2257fbcf898
https://github.com/Perl/perl5/commit/789c70a576927b18b3c9770d38dbc2257fbcf898
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M lib/locale_threads.t
Log Message:
-----------
XXX locale_threads debugging
Commit: e788b303e941b5832aead02dd536e2cac8ac5a54
https://github.com/Perl/perl5/commit/e788b303e941b5832aead02dd536e2cac8ac5a54
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: White space only
Commit: 030a5412d2f2c11150823b194abbe9673a7d8c21
https://github.com/Perl/perl5/commit/030a5412d2f2c11150823b194abbe9673a7d8c21
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M intrpvar.h
Log Message:
-----------
intrpvar.h: Move some defns into appropriate #ifdefs
Commit: de08d42d73d5946704e2797056268dc5ef0dd205
https://github.com/Perl/perl5/commit/de08d42d73d5946704e2797056268dc5ef0dd205
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M embed.h
M embedvar.h
M intrpvar.h
M locale.c
M proto.h
M sv.c
Log Message:
-----------
XXX finish msg,thread_init Revamp sync_locale, switch_to_global_locale
f
Commit: 5b87b106d171a6422002311c33817f0ad2069628
https://github.com/Perl/perl5/commit/5b87b106d171a6422002311c33817f0ad2069628
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv duplicate clones
These variables are already cloned when creating a thread
Commit: c8aa47cf2cf7127afdadf965435177bbe1b5b9c1
https://github.com/Perl/perl5/commit/c8aa47cf2cf7127afdadf965435177bbe1b5b9c1
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: Rmv redundant clause
If threaded locales are being used, basic locales are too. No need to
check both
Commit: 8fad3a3c088e2b7110a4add607c5285b06a0c94a
https://github.com/Perl/perl5/commit/8fad3a3c088e2b7110a4add607c5285b06a0c94a
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
M lib/locale.t
Log Message:
-----------
Fix isspace() handling on AIX
This box incorrectly thinks the NBSP is a graphic on many locales.
Overriding that makes these locales behave like proper POSIX ones.
Commit: b9e3cd4c2b117a7f04e1ca9665a704bd598777c5
https://github.com/Perl/perl5/commit/b9e3cd4c2b117a7f04e1ca9665a704bd598777c5
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M sv.c
Log Message:
-----------
sv.c: White-space only
Replace leading tabs with spaces
Commit: 70338ae0e34c46a74cc088175ed630b47e136dbd
https://github.com/Perl/perl5/commit/70338ae0e34c46a74cc088175ed630b47e136dbd
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M hints/cygwin.sh
Log Message:
-----------
XXX check if really necessary after everything: Don't use POSIX 2008 locale
This has been found to be buggy leading to dying inside the newlocale()
in S_emulate_setlocale_i()
Commit: deeeb5be6be591883c1903146da214e8c3f7baa6
https://github.com/Perl/perl5/commit/deeeb5be6be591883c1903146da214e8c3f7baa6
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M lib/locale.t
Log Message:
-----------
lib/locale.t: Use I18N::Langinfo, not POSIX::localeconv()
Now that Langinfo is ported to every box, it requires less work than
localeconv(), and offers more choices. This commit changes to use it,
and for more info when debugging, gets some additional info from it.
Commit: 7daae9c4f91182d71fb555c05975beece7164ace
https://github.com/Perl/perl5/commit/7daae9c4f91182d71fb555c05975beece7164ace
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M handy.h
Log Message:
-----------
XXX cygwin debugging small macro buf
Commit: 01f9a5016cc96c88f1dbf17e3a96f929cbbdeaf7
https://github.com/Perl/perl5/commit/01f9a5016cc96c88f1dbf17e3a96f929cbbdeaf7
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
perl.h: Avoid unnecessary calls to set_numeric_standard()
Prior to this commit, set_numeric_standard() was called unconditionally,
and it could decide if it should do anything or not. But the variable
that indicates this is available to the caller, so by testing it, it can
avoid the call, which is most likely the case.
Commit: bac60f08d0db0b8c9be68873d37db9e00e6f90a4
https://github.com/Perl/perl5/commit/bac60f08d0db0b8c9be68873d37db9e00e6f90a4
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX perl.h: Debugging trace across all files
Commit: 98e63356b4875a97431402d1c7c4a9b998c279e5
https://github.com/Perl/perl5/commit/98e63356b4875a97431402d1c7c4a9b998c279e5
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M perl.h
Log Message:
-----------
XXX Use internal querylocale on Linux
XXX Need to bisect to see where this goes bad
XXX Is effectively a no-op due to other debugging code
Commit: 903fd28b2351593bac896e0d9410cc32baf93db9
https://github.com/Perl/perl5/commit/903fd28b2351593bac896e0d9410cc32baf93db9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M cpan/Time-Piece/Piece.xs
M dist/ExtUtils-ParseXS/lib/perlxs.pod
M handy.h
M iperlsys.h
M locale.c
M perl.h
M pod/perllocale.pod
M regen/reentr.pl
M regexec.c
M util.c
Log Message:
-----------
Notes
Commit: 728919c2c69cdfb49e0386ed1c1f0c3a62d5b7f9
https://github.com/Perl/perl5/commit/728919c2c69cdfb49e0386ed1c1f0c3a62d5b7f9
Author: Karl Williamson <[email protected]>
Date: 2021-04-29 (Thu, 29 Apr 2021)
Changed paths:
M embed.fnc
M ext/I18N-Langinfo/t/Langinfo.t
M ext/POSIX/POSIX.xs
M intrpvar.h
M lib/locale.t
M lib/locale_threads.t
M locale.c
M perl.h
M proto.h
M regexec.c
M t/loc_tools.pl
M t/run/locale.t
Log Message:
-----------
45
Compare: https://github.com/Perl/perl5/compare/0132659f5fd9...728919c2c69c
