On Thu, Jul 14, 2005 at 07:01:58PM -0700, Michael G Schwern wrote: > On Thu, Jul 14, 2005 at 08:14:26PM -0400, Rick Delaney wrote: > > > > I am almost convinced by this argument. > > What are your reservations?
I just don't like exceptions. And since the case we're talking about is pretty unlikely to come up in Real Life, I'm not particulary motivated to change the patch. But I have no objection to some committer tweaking it before submitting if they feel it is important to retain the warning. > I'd add to the argument that: > > package Foo; > our $x = 42; > > package Bar; > my $x = 23; > > has been warning since 5.6.x and I can't recall anyone complaining. I'm sure very few people have ever seen that warning for that scenario. As I write I'm feeling more like it's correct to warn in this case even if it is unlikely to happen. The feeling may start to bug me enough to change the patch but don't hold your breath. -- Rick Delaney [EMAIL PROTECTED]
