# New Ticket Created by Andy Dougherty
# Please include the string: [perl #31849]
# in the subject line of all future correspondence about this issue.
# <URL: http://rt.perl.org:80/rt3/Ticket/Display.html?id=31849 >
The following patch makes compilation both slightly quieter and also
slightly more informative.
Or, with less "spin", it fixes bad advice I gave previously. Specifically,
I had previously noted that it's generally helpful if the Makefile prints
out the commands it is trying to execute so that it's easier to track down
problems when they fail. When I suggested that the '@' be removed from
the .pbc.imc rule, I suggested at the same time that the '@' also be
removed from the compilation step above it.
Alas, that wasn't quite the right place to do it. What's ultimately of
interest is the command that actually gets called. Accordingly, this
patch puts the '@' back in front of the invocation
of tools/dev/cc_flags.pl, but changes the print statement in
tools/dev/cc_flags.pl to show the actual compilation command being issued.
Again, I have found that information to be useful on numerous
occasions. Also, considering how noisy the whole ICU build is, I
think the extra clutter for parrot's sources is not a significant
additional burden.
diff -r -u parrot-current/config/gen/makefiles/root.in
parrot-andy/config/gen/makefiles/root.in
--- parrot-current/config/gen/makefiles/root.in Mon Oct 4 08:39:29 2004
+++ parrot-andy/config/gen/makefiles/root.in Tue Oct 5 10:46:06 2004
@@ -441,7 +441,7 @@
# arguments (etc) injected in the middle.
# There is probably a better way to do this, but I can't work it out right now.
.c$(O) :
- $(PERL) tools/dev/cc_flags.pl ./CFLAGS $(CC) "" $(CFLAGS) -I$(@D)
${cc_o_out}$@ -c $<
+ @$(PERL) tools/dev/cc_flags.pl ./CFLAGS $(CC) "" $(CFLAGS) -I$(@D)
${cc_o_out}$@ -c $<
%.pbc:%.imc
.${slash}$(TEST_PROG) -o $@ $<
diff -r -u parrot-current/tools/dev/cc_flags.pl parrot-andy/tools/dev/cc_flags.pl
--- parrot-current/tools/dev/cc_flags.pl Sun Jul 11 19:00:17 2004
+++ parrot-andy/tools/dev/cc_flags.pl Tue Oct 5 10:46:20 2004
@@ -107,6 +107,6 @@
}
}
-#print "@ARGV\n";
-print "$cfile\n";
+print "@ARGV\n";
+# print "$cfile\n";
exit system(@ARGV)/256;
--
Andy Dougherty [EMAIL PROTECTED]
