I forgot to Cc: the list.  Also, I've taken this ticket and will apply
NotFound's patch in a day or so if we don't hear objections.

Pm

On Mon May 12 10:08:19 2008, pmichaud wrote:
> On Mon May 12 09:23:49 2008, [EMAIL PROTECTED] wrote:
> > The easier solution is to redefine string_bool to allow a NULL
> > argument and return false in that case. Many places in the code does
> > that check before the call, so this change will simplify it.
> 
> +1 from me.  I'd even give this +2 if I could.
> 
> Notably, many of the functions in src/string.c check for NULL values
> prior to performing a function (e.g., string_equal, string_concat, etc.)
> so it makes very good sense to me for string_bool to do the same.
> 
> Pm



Reply via email to