On Tue Oct 09 23:36:40 2007, ptc wrote:
> Hi,
>
> This patch fixes t/codingstd/c_parens.t failures on darwin (which I
> don't have access to, hence the patch).
>
> Files affected:
>
> config/gen/platform/darwin/dl.c
> config/gen/platform/darwin/memalign.c
After an 'svn up' and after running 'make' -- but before applying your
patch -- I got the following error message when running:
prove -v t/codingstd/c_parens.t
[parrot] 510 $ prove -v t/codingstd/c_parens.t
t/codingstd/c_parens....1..3
# Failed test (t/codingstd/c_parens.t at line 80)
# incorrect spacing between C keyword and following open parenthesis
found in 1 files:
# /Users/jimk/work/parrot/src/ops/pmc.ops: register(
# Failed test (t/codingstd/c_parens.t at line 86)
# incorrect spacing between function name and following open parenthesis
found in 49 files:
# /Users/jimk/work/parrot/src/packfile.c: opcode_t (
# /Users/jimk/work/parrot/src/builtin.c: N_BUILTINS (
# /Users/jimk/work/parrot/src/gc/register.c: ALIGNED_CTX_SIZE (
# /Users/jimk/work/parrot/src/objects.c: TBL_SIZE (
# /Users/jimk/work/parrot/src/pic.c: endif
# (
# /Users/jimk/work/parrot/src/runops_cores.c: code_end (
# /Users/jimk/work/parrot/include/parrot/smallobject.h: GC_GMS_STORE_SIZE (
# /Users/jimk/work/parrot/include/parrot/stacks.h: STACK_CLEANUP_NULL (
# /Users/jimk/work/parrot/include/parrot/string.h: UINTVAL (
# /Users/jimk/work/parrot/include/parrot/sub.h: NEED_CONTINUATION (
# /Users/jimk/work/parrot/compilers/imcc/symreg.h: VTREGISTER (
# /Users/jimk/work/parrot/include/parrot/charset.h: INTVAL (
# /Users/jimk/work/parrot/include/parrot/dod.h: DOD_trace_stack_FLAG (
# /Users/jimk/work/parrot/include/parrot/encoding.h: UINTVAL (
# /Users/jimk/work/parrot/include/parrot/hash.h: INITBucketIndex (
# /Users/jimk/work/parrot/include/parrot/headers.h: BUFFER_ALIGN_1 (
# /Users/jimk/work/parrot/include/parrot/interpreter.h: PMCNULL (
# /Users/jimk/work/parrot/include/parrot/io.h: PIO_BUFSIZE (
# /Users/jimk/work/parrot/include/parrot/list.h: MAX_MASK (
# /Users/jimk/work/parrot/include/parrot/mmd.h: INTVAL (
# /Users/jimk/work/parrot/include/parrot/packfile.h: size_t (
# /Users/jimk/work/parrot/include/parrot/parrot.h: NULLfunc (
# /Users/jimk/work/parrot/include/parrot/pmc_freeze.h: INTVAL (
# /Users/jimk/work/parrot/include/parrot/pobj.h: Buffer_alloc_offset (
# /Users/jimk/work/parrot/include/parrot/register.h: _SIZEOF_INTS (
# /Users/jimk/work/parrot/languages/cola/cola.h: MOD_PUBLIC (
# /Users/jimk/work/parrot/src/io/io_private.h: PIO_UNBOUND (
# /Users/jimk/work/parrot/src/jit/i386/jit_emit.h: emit_Index_None (
# /Users/jimk/work/parrot/src/jit/ia64/jit_emit.h: NATIVE_PTR (
# /Users/jimk/work/parrot/src/jit/ppc/jit_emit.h: _BYES (
# /Users/jimk/work/parrot/languages/cardinal/src/pmc/rubyfloat.pmc:
RUBY_NUMBER_FMT (
# /Users/jimk/work/parrot/languages/lua/pmc/luastring.pmc:
set_integer_native (
# /Users/jimk/work/parrot/languages/lua/pmc/luatable.pmc: MAX_INT (
# /Users/jimk/work/parrot/src/ops/bit.ops: by (
# /Users/jimk/work/parrot/src/ops/cmp.ops: Copyright (
# /Users/jimk/work/parrot/src/ops/core.ops: detection (
# /Users/jimk/work/parrot/src/ops/experimental.ops: 5 (
# /Users/jimk/work/parrot/src/ops/io.ops: each
# (
# /Users/jimk/work/parrot/src/ops/math.ops: truncated (
# /Users/jimk/work/parrot/src/ops/object.ops: Copyright (
# /Users/jimk/work/parrot/src/ops/obscure.ops: coversine (
# /Users/jimk/work/parrot/src/ops/pic.ops: PIC (
# /Users/jimk/work/parrot/src/ops/pmc.ops: the (
# /Users/jimk/work/parrot/src/ops/set.ops: Copyright (
# /Users/jimk/work/parrot/src/ops/stack.ops: the (
# /Users/jimk/work/parrot/src/ops/string.ops: length (
# /Users/jimk/work/parrot/src/ops/sys.ops: time (
# /Users/jimk/work/parrot/src/ops/var.ops: Copyright (
# /Users/jimk/work/parrot/languages/dotnet/ops/dotnet.ops: MIN_INT4 (
# Failed test (t/codingstd/c_parens.t at line 92)
# incorrect spacing between parentheses found in 5 files:
# /Users/jimk/work/parrot/config/gen/platform/darwin/dl.c: ( f
# /Users/jimk/work/parrot/config/gen/platform/darwin/memalign.c: ( e
# /Users/jimk/work/parrot/config/gen/platform/win32/env.c: e )
# /Users/jimk/work/parrot/config/gen/platform/win32/exec.c: ( c
# /Users/jimk/work/parrot/config/gen/platform/win32/misc.h: ( d
# Looks like you failed 3 tests of 3.
not ok 1 - Spacing between C keyword and following open parenthesis
not ok 2 - Spacing between function name and following open parethesis
not ok 3 - Spacing between parentheses
dubious
Test returned status 3 (wstat 768, 0x300)
DIED. FAILED tests 1-3
Failed 3/3 tests, 0.00% okay
Failed Test Stat Wstat Total Fail List of Failed
-------------------------------------------------------------------------------
t/codingstd/c_parens.t 3 768 3 3 1-3
Failed 1/1 test scripts. 3/3 subtests failed.
Files=1, Tests=3, 25 wallclock secs (13.35 cusr + 0.72 csys = 14.07 CPU)
Failed 1/1 test programs. 3/3 subtests failed.
Does indicate that even more files than you noted suffer from this problem?
kid51
