On 10/10/2007, James Keenan via RT <[EMAIL PROTECTED]> wrote: > On Tue Oct 09 23:36:40 2007, ptc wrote: > > Hi, > > > > This patch fixes t/codingstd/c_parens.t failures on darwin (which I > > don't have access to, hence the patch). > > > > Files affected: > > > > config/gen/platform/darwin/dl.c > > config/gen/platform/darwin/memalign.c > > > After an 'svn up' and after running 'make' -- but before applying your > patch -- I got the following error message when running: > > prove -v t/codingstd/c_parens.t > > [parrot] 510 $ prove -v t/codingstd/c_parens.t > t/codingstd/c_parens....1..3 <snip>
> > Does indicate that even more files than you noted suffer from this problem? Short answer: yes and no. This actually means that the test itself has problems. Some of these "errors" are coming from #define statements, others are coming from comments within pod. However, the patch corrects actual "problems" detected by the test which apply to darwin. A large number of the failures aren't problems, although some of them could be, hence my cryptic short answer ;-) I'm going to fix the test as soon as I can, nevertheless it'd be nice to have a couple less files failing. Thanks for looking into this so closely :-) Paul
