On Fri, Sep 21, 2012 at 9:55 AM, Barry Smith <bsmith at mcs.anl.gov> wrote:
> I understand why you are doing this (since xmumps_c appears in > multiple places in the code and you don't want the ugly #ifdef at each of > those places) but essentially you are doing what the mumps people should > have done, providing a polymorphic interface to their solver. By doing this > you are making the PETSc--mumps interface less transparent and introducing > the complexity of additional macros. I think it would be better to use the > old style we had (where the #ifdef appear each time as needed in the code). I have mixed feelings about his. We use the top-level macros in the UMFPACK, CHOLMOD, and even BLAS/Lapack. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20120921/253804f5/attachment.html>
