Jed, I had added -pc_reuse specifically for use with fieldsplit since I wanted only a part of the preconditioner to be built only once, for e.g. -fieldsplit_0_pc_reuse. This would build the preconditioner for fieldsplit 0 only once. I had not added any API for it since it was meant to be experimental feature. If this feature is useful then I can add an API for it otherwise I can take it out.
Shri On Mar 23, 2013, at 11:25 AM, Jed Brown wrote: > > On Fri, Mar 22, 2013 at 10:14 AM, Mark F. Adams <mark.adams at columbia.edu> > wrote: > I thought the primary mission of options_left was to catch spelling mistakes. > >> (This is also useful if a PC logically ought to pay attention to this >> option, but isn't.) What about making PCSetUseAmat() use PetscTryMethod() >> and move the check of "-pc_use_amat" into each implementation? >> > > I agree with Barry that it should be high level and make it there for any PC > to use if they want. > >> Do we really want to leave the confusing option in place for all the PCs >> that don't have inner solvers? > > It just doesn't seem that bad to me. > > Okay, okay, I'll stick with the simple thing. > > What about "-pc_reuse"? It is only referenced in > src/ksp/pc/impls/factor/lu/lu.c and it doesn't have an API. Can it be removed > entirely? I thought we were using SAME_PRECONDITIONER for this sort of thing. -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.mcs.anl.gov/pipermail/petsc-dev/attachments/20130323/f93ec9cf/attachment.html>
