Thanks! As Matt says, some people here prefer pull requests. If you prefer to email patches, please use "git send-email" so that they form a chain of emails rather than a single email with lots of attachments.
Harshad Sahasrabudhe <[email protected]> writes: > Hi, > > I have attached my code for the MAGMA solver in the 2 patch files. Also > attached is an example/test code for testing the solver. > > Thanks, > Harshad > From 0acefb8391f04b59bf9f43c179b927ffd34936f7 Mon Sep 17 00:00:00 2001 > From: Harshad Sahasrabudhe <[email protected]> > Date: Tue, 8 Oct 2013 14:33:01 -0500 > Subject: [PATCH 1/2] Added MAGMA solver for dense matrices. Currently, it > only does LU and Cholesky factorization. > > --- > config/PETSc/packages/magma.py | 131 > +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 131 insertions(+) > create mode 100644 config/PETSc/packages/magma.py This is just the Python file so the commit message above should not claim other capability. Either update the commit message to say that it provides --download-magma or fold it into the other patch. > From 4ddb100f646a04646f7eb071894dfafd6a103b68 Mon Sep 17 00:00:00 2001 > From: Harshad Sahasrabudhe <[email protected]> > Date: Tue, 8 Oct 2013 14:35:00 -0500 > Subject: [PATCH 2/2] Added LU and Cholesky factorization through MAGMA mat > solver package for dense matrices. > > --- > include/petscmat.h | 1 + > src/mat/impls/dense/seq/dense.c | 162 > ++++++++++++++++++++++++++++++++++++++- > src/mat/impls/dense/seq/makefile | 3 +- I'm not wild about inserting this into the dense.c. Could you make a sub-directory and put the MAGMA stuff in src/mat/impls/dense/seq/magma/seqmagma.c? Then mark the enclosing makefile with #requirespackage 'PETSC_HAVE_MAGMA'. > static char help[] = "Testing LU factorization of SeqDense matrices using > MAGMA.\n"; Please commit this just like any other test and add your test runs to the makefile and expected output in output/ex123.out. Your first commit (adding magma.py) can also add a testexamples_MAGMA stub to conf/test.
pgpv0ZHPJ6IfC.pgp
Description: PGP signature
