Okay. So here is the pull request. I hope I'm doing it right. The following changes since commit 7a7ac0eac458f6238540aa1700a36a7023132564:
Merge branch 'maint' (2013-10-07 20:21:45 -0500) are available in the git repository at: https://github.com/hsahasra/petsc-magma-dense-mat.git magma-dense-mat for you to fetch changes up to 89daa3cb11978d4eb57075b15ca2b3276d12d6b2: Added LU and Cholesky factorization through MAGMA mat solver package for dense matrices. (2013-10-08 14:53:39 -0500) ---------------------------------------------------------------- Harshad Sahasrabudhe (2): Added MAGMA solver for dense matrices. Currently, it only does LU and Cholesky factorization. Added LU and Cholesky factorization through MAGMA mat solver package for dense matrices. config/PETSc/packages/magma.py | 131 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ include/petscmat.h | 1 + src/mat/impls/dense/seq/dense.c | 162 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- src/mat/impls/dense/seq/makefile | 3 +-- 4 files changed, 294 insertions(+), 3 deletions(-) create mode 100644 config/PETSc/packages/magma.py ----- Original Message ----- From: "Jed Brown" <[email protected]> To: "Harshad Sahasrabudhe" <[email protected]>, "petsc-dev" <[email protected]> Sent: Tuesday, October 8, 2013 5:22:27 PM Subject: Re: [petsc-dev] Code for MAGMA solver Thanks! As Matt says, some people here prefer pull requests. If you prefer to email patches, please use "git send-email" so that they form a chain of emails rather than a single email with lots of attachments. Harshad Sahasrabudhe <[email protected]> writes: > Hi, > > I have attached my code for the MAGMA solver in the 2 patch files. Also > attached is an example/test code for testing the solver. > > Thanks, > Harshad > From 0acefb8391f04b59bf9f43c179b927ffd34936f7 Mon Sep 17 00:00:00 2001 > From: Harshad Sahasrabudhe <[email protected]> > Date: Tue, 8 Oct 2013 14:33:01 -0500 > Subject: [PATCH 1/2] Added MAGMA solver for dense matrices. Currently, it > only does LU and Cholesky factorization. > > --- > config/PETSc/packages/magma.py | 131 > +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 131 insertions(+) > create mode 100644 config/PETSc/packages/magma.py This is just the Python file so the commit message above should not claim other capability. Either update the commit message to say that it provides --download-magma or fold it into the other patch. > From 4ddb100f646a04646f7eb071894dfafd6a103b68 Mon Sep 17 00:00:00 2001 > From: Harshad Sahasrabudhe <[email protected]> > Date: Tue, 8 Oct 2013 14:35:00 -0500 > Subject: [PATCH 2/2] Added LU and Cholesky factorization through MAGMA mat > solver package for dense matrices. > > --- > include/petscmat.h | 1 + > src/mat/impls/dense/seq/dense.c | 162 > ++++++++++++++++++++++++++++++++++++++- > src/mat/impls/dense/seq/makefile | 3 +- I'm not wild about inserting this into the dense.c. Could you make a sub-directory and put the MAGMA stuff in src/mat/impls/dense/seq/magma/seqmagma.c? Then mark the enclosing makefile with #requirespackage 'PETSC_HAVE_MAGMA'. > static char help[] = "Testing LU factorization of SeqDense matrices using > MAGMA.\n"; Please commit this just like any other test and add your test runs to the makefile and expected output in output/ex123.out. Your first commit (adding magma.py) can also add a testexamples_MAGMA stub to conf/test.
