On 4 November 2013 16:44, Jed Brown <[email protected]> wrote: > Lisandro Dalcin <[email protected]> writes: > >> Do you like moving the execution of dsymutil from >> $PETSC_DIR/conf/rules to $PETSC_DIR/gmakefile shared lib targets? The >> rationale is to not run dsymutil with the shared libs are up to date. >> >> diff --git a/conf/rules b/conf/rules >> index 1ac6fe0..6bf2421 100644 >> --- a/conf/rules >> +++ b/conf/rules >> @@ -105,9 +105,6 @@ gnumake: chk_makej >> @echo "Building PETSc using GNU Make with ${MAKE_NP} build threads" >> @echo "==========================================" >> @cd ${PETSC_DIR} && ${OMAKE_PRINTDIR} -f gmakefile -j ${MAKE_NP} >> V=${V} >> - @if [ "${BUILDSHAREDLIB}" = "yes" -a "${DSYMUTIL}" != "true" ]; then >> \ >> - echo "Running ${DSYMUTIL} on ${SHLIBS}";\ >> - for LIBNAME in ${SHLIBS}; do ${DSYMUTIL} >> ${INSTALL_LIB_DIR}/$$LIBNAME.${SL_LINKER_SUFFIX}; done; fi > > Looks like you pasted into gmail, ruining the formatting.
My intention was to show what I was talking about, not to submit a patch. It does not render so bad in my gmail. > I like > running it per library rather than as a separate step. OK, I'll push this change to master. PS: Do you have any intention to continue supporting CMake builds? We could do something similar for this case. -- Lisandro Dalcin --------------- CIMEC (UNL/CONICET) Predio CONICET-Santa Fe Colectora RN 168 Km 472, Paraje El Pozo 3000 Santa Fe, Argentina Tel: +54-342-4511594 (ext 1016) Tel/Fax: +54-342-4511169
