I added it.

"Balay, Satish" <ba...@mcs.anl.gov> writes:

> Ah good to know.
>
> I've tried adding back 'Team' with 'petsc/developers' listed - but
> 'petsc/developers' keeps disappearing from it. Not sure whats
> happening..
>
>
> thanks,
> Satish
>
> On Thu, 12 Sep 2019, Scott Kruger wrote:
>
>> 
>> 
>> Here's what I did:
>> 
>> Settings -> Notifications -> developers + Participate
>> 
>> The default is "Global".  "Participate" is what I'm using now.
>> 
>> There is a "Custom", but it confuses me since it says you can
>> use it to match "Participate", but you can't do something like:
>> Email all new issues, but only show me the MR's I am mentioned
>> in or own.
>> 
>> Scott
>> 
>> 
>> On 9/12/19 7:39 AM, Balay, Satish via petsc-dev wrote:
>> > On Thu, 12 Sep 2019, Jed Brown via petsc-dev wrote:
>> > 
>> >> Matthew Knepley via petsc-dev <petsc-dev@mcs.anl.gov> writes:
>> >>
>> >>> On Thu, Sep 12, 2019 at 9:05 AM Balay, Satish via petsc-dev <
>> >>> petsc-dev@mcs.anl.gov> wrote:
>> >>>
>> >>>> When a new MR is created, approval rules default to 'Integration' and
>> >>>> 'Team'
>> >>>>
>> >>>> So everyone in the team probably receives emails on all MRs. Now that
>> >>>> we have CODEOWNERS setup - perhaps the Team should be removed?
>> >>>>
>> >>>
>> >>> Can you explain CODEOWNERS to me? I cannot find it on the GItlab site. I
>> >>> want to see every MR.
>> >>
>> >> https://docs.gitlab.com/ee/user/project/code_owners.html
>> >>
>> >> We currently require approval from Integration (of which you are a
>> >> member) and a code owner (as specified in the file).
>> >>
>> >> We used to have optional approvals from any other developer, but Satish
>> >> just removed that due to this notification thing, which I guess means
>> >> that any other developer (non-integrator, non-owner) should just comment
>> >> their approval if they find time to review.
>> > 
>> > Ah - forgot the primary purpose of having 'Team' in the 'approve' list.
>> > Is there a way to disable notifications for team  - unless they 
>> > participate?
>> > 
>> > Satish
>> > 
>> 
>> 

Reply via email to