Hi On Tue, Dec 19, 2017 at 2:17 PM, Murtuza Zabuawala <murtuza.zabuawala@ enterprisedb.com> wrote:
> > > On Tue, Dec 19, 2017 at 7:24 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Hi >> >> Interesting. A few thoughts: >> >> - The pulsating icon is very off-putting. I think we need to make it only >> flash a couple of times when we actually need to attract the attention of >> the user. >> > As per my discussion with Chethana, In his opinion user tends to notice > things that way more quickly. > Are you sure you wish to flash only couple of times on error? > We already show and alert and switch to the messages tab if there's an error right? Either way, it's very off-putting. > >> - We shouldn't really use tooltips like this, as it may confuse folks >> with screen readers. Should we make the icon clickable (which should have a >> visual hint)? Maybe a drop-down status panel. >> >> >> > Sure let me check. > > >> >> - Do we need to poll separately for the status? Instead, why not update >> it whenever polling for results, or executing something? >> > Then user won't be able to know the current connection status prior to > query execution, the purpose of the feature is to make user aware of > current connection status even if there is no query running, As most user > tends to leave open their query tool window after their work it will be > useful when flask session gets expired and connection to server gets closed > after that. > Ah, OK. I see. Where is the polling frequency? I can't find it in the Preferences. I'm really not too sure about polling this often. If i've got 5 query tool windows open, that's 10 queries a second, with the dashboard as well. That's why I was suggesting piggy-backing the status updates on other queries. Sidenote: I've seen the status indicator go from green to orange and back again numerous times, for no obvious reason when connected to a local server. > >> Thanks! >> >> On Tue, Dec 19, 2017 at 11:42 AM, Murtuza Zabuawala < >> murtuza.zabuaw...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> PFA patch to add the connection status >>> <http://initd.org/psycopg/docs/extensions.html#transaction-status-constants> >>> in query tool, this feature will allow user to check the database >>> connection status in query tool itself, it will also provide the detailed >>> status as a tooltip when user hovers on it, the most benefit of the feature >>> will be when user open query tool in new Browser Tab where Browser tree is >>> not visible to user, user can also configure the status polling time using >>> preference dialog. >>> RM#2475 >>> >>> Apart from that I have also removed the ..sqleditor/static/css/sqledit >>> or.css reference from ../datagrid/templates/datagrid/index.html file >>> because we are already bundling the "sqleditor.css" file in main >>> "style.css" file. >>> >>> >>> Thanks to Chethana for his UI related inputs and to Surinder for helping >>> me on html alignment issues. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
