On Fri, Jan 5, 2018 at 2:57 PM, Dave Page <dp...@pgadmin.org> wrote: > > > On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < > murtuza.zabuaw...@enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch, >> >> >> On Wed, Jan 3, 2018 at 10:44 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> Hi >>> >>> On Thu, Dec 28, 2017 at 9:38 AM, Murtuza Zabuawala < >>> murtuza.zabuaw...@enterprisedb.com> wrote: >>> >>>> Hi, >>>> >>>> PFA updated patch based on new design suggested by Chethana. >>>> The patch also includes some misc fixes related to object validation. >>>> RM#2475 >>>> >>> >>> This seems much nicer, but I still think there are some tweaks to make: >>> >>> 1) If I open a query tool, and then stop the application server, the >>> icon is updated to show the broken connection. However, unless I execute a >>> query in the query tool before the server is shut down, the connection >>> status won't recover when the server is restarted. If I do run a query >>> first (SELECT 1; will do), then the connection status will recover. >>> >> >> I have logged >> >> https://redmine.postgresql.org/issues/2983 >> > > I'm not sure that's the same issue is it? > Yes, it's the same issue due to which pgAdmin is not able to restore connection.
> > >> >> >>> 2) I think the "connected" icon should be in $primary-blue (#2c76b4). >>> The green is ugly and not overly easy to read. It's also distracting as it >>> catches the eye, which the default, non-error state should not do. >>> >> Fixed >> >> >> >>> 3) I'm not overly happy with the the status text popover. After some >>> thought, I think it's because there are no visual clues that you should >>> click on the icon to see it - and Karen seems to be of a similar opinion. >>> Can we put a small marker there, perhaps a triangle on the bottom-right, >>> like you get on a spreadsheet cell if you add a comment/note? We should >>> also have a hotkey and I guess a tooltip, e.g. "Connection status >>> Ctrl+Alt+S" or similar. >>> >> Fixed >> , added accesskey *'T'* for TX status tooltip shortcut as 'S' is already >> taken for Save file option >> >> >>> Thanks! >>> >>> >>>> >>>> Please review. >>>> >>>> -- >>>> Regards, >>>> Murtuza Zabuawala >>>> EnterpriseDB: http://www.enterprisedb.com >>>> The Enterprise PostgreSQL Company >>>> >>>> >>>> On Fri, Dec 22, 2017 at 11:53 AM, Chethana Kumar < >>>> chethana.ku...@enterprisedb.com> wrote: >>>> >>>>> Yes Dave. >>>>> >>>>> Now it is clearly differentiated, please check and confirm. >>>>> >>>>> Thanks, >>>>> Chethana kumar >>>>> >>>>> On Fri, Dec 22, 2017 at 12:08 AM, Dave Page <dp...@pgadmin.org> wrote: >>>>> >>>>>> Hi >>>>>> >>>>>> There are 2 icons that look the same except for colour. That’s not >>>>>> going to work for some users with colour blindness. >>>>>> >>>>>> -- >>>>>> Dave Page >>>>>> Blog: http://pgsnake.blogspot.com >>>>>> Twitter: @pgsnake >>>>>> >>>>>> EnterpriseDB UK:http://www.enterprisedb.com >>>>>> The Enterprise PostgreSQL Company >>>>>> >>>>>> On 21 Dec 2017, at 15:32, Chethana Kumar < >>>>>> chethana.ku...@enterprisedb.com> wrote: >>>>>> >>>>>> Hi Team, >>>>>> >>>>>> I have refined the icon once again for database connection status in >>>>>> query tool itself. >>>>>> >>>>>> Below are the 5 different status that I have attached as screenshot - >>>>>> >>>>>> 1_busy >>>>>> 2_error_in_transaction >>>>>> 3_valid_transaction_in_idle >>>>>> 4_database_connected >>>>>> 5_database_disconnected >>>>>> >>>>>> Please provide your inputs. >>>>>> >>>>>> Regards, >>>>>> Chethana kumar >>>>>> >>>>>> >>>>>> On Tue, Dec 19, 2017 at 5:12 PM, Murtuza Zabuawala < >>>>>> murtuza.zabuaw...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> PFA patch to add the connection status >>>>>>> <http://initd.org/psycopg/docs/extensions.html#transaction-status-constants> >>>>>>> in query tool, this feature will allow user to check the database >>>>>>> connection status in query tool itself, it will also provide the >>>>>>> detailed >>>>>>> status as a tooltip when user hovers on it, the most benefit of the >>>>>>> feature >>>>>>> will be when user open query tool in new Browser Tab where Browser tree >>>>>>> is >>>>>>> not visible to user, user can also configure the status polling time >>>>>>> using >>>>>>> preference dialog. >>>>>>> RM#2475 >>>>>>> >>>>>>> Apart from that I have also removed the >>>>>>> ..sqleditor/static/css/sqleditor.css reference from >>>>>>> ../datagrid/templates/datagrid/index.html file because we are >>>>>>> already bundling the "sqleditor.css" file in main "style.css" file. >>>>>>> >>>>>>> >>>>>>> Thanks to Chethana for his UI related inputs and to Surinder for >>>>>>> helping me on html alignment issues. >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Regards, >>>>>>> Murtuza Zabuawala >>>>>>> EnterpriseDB: http://www.enterprisedb.com >>>>>>> The Enterprise PostgreSQL Company >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Chethana Kumar >>>>>> Principal UI/UX Designer >>>>>> EnterpriseDB Corporation >>>>>> >>>>>> >>>>>> The Postgres Database Company >>>>>> >>>>>> P: +91 86981 57146 <+91%2086981%2057146> >>>>>> www.enterprisedb.com >>>>>> >>>>>> <1_busy.jpg> >>>>>> >>>>>> <2_error_in_transaction.jpg> >>>>>> >>>>>> <3_valid_transaction_in_idle.jpg> >>>>>> >>>>>> <4_database_connected.jpg> >>>>>> >>>>>> <5_database_disconnected.jpg> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Chethana Kumar >>>>> Principal UI/UX Designer >>>>> EnterpriseDB Corporation >>>>> >>>>> >>>>> The Postgres Database Company >>>>> >>>>> P: +91 86981 57146 <+91%2086981%2057146> >>>>> www.enterprisedb.com >>>>> >>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company >
