Joao, are you looking at this? On Tue, Apr 3, 2018 at 2:03 PM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote:
> > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > On Tue, Apr 3, 2018 at 6:10 PM, Dave Page <dp...@pgadmin.org> wrote: > >> Argh, managed to send before I finished typing... >> >> On Tue, Apr 3, 2018 at 1:38 PM, Dave Page <dp...@pgadmin.org> wrote: >> >>> Hi >>> >>> On Thu, Mar 29, 2018 at 4:29 PM, Joao De Almeida Pereira < >>> jdealmeidapere...@pivotal.io> wrote: >>> >>>> Hi Dave, >>>> That looks like in the surrounding area of the change. We run our >>>> pipeline and everything was green. >>>> Can you provide more details, which python version are you using? OS? >>>> >>> >>> That was on my travel laptop, which is macOS Sierra with the Apple >>> supplied Python 2.7. >>> >>> Interestingly, I'm on my dev laptop today (same OS and Python) and it's >>> working just fine. The difference is that the travel machine is a 12" >>> Macbook, whilst the dev machine is >>> >> >> a 15" MacBook Pro with 2 24" external monitors. That makes me wonder if >> the small screen size is causing a problem with this test, something we >> have seen before. >> >> > > Yes, screen size does cause problem. Slick grid does not render all > columns if viewport is not wide enough (like it does for rows). > Remaining columns would render when user scrolls right. > > To avoid similar problem in datatype feature test (commit: > 88bcd3b5129db88975421e26c1bf188daf4892f9 > <https://git.postgresql.org/gitweb/?p=pgadmin4.git;a=commitdiff;h=88bcd3b5129db88975421e26c1bf188daf4892f9>) > I have executed > queries in batch to limit number of columns in single query result. > > > >> >>> >>>> >>>> Thanks >>>> Joao >>>> >>>> On Thu, Mar 29, 2018 at 9:03 AM Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> Hi >>>>> >>>>> On Wed, Mar 28, 2018 at 7:06 PM, Joao De Almeida Pereira < >>>>> jdealmeidapere...@pivotal.io> wrote: >>>>> >>>>>> Hey Akshay and Neethu >>>>>> >>>>>> We refactored the patch to add tests for the resize feature. We were >>>>>> able to write test cases for the drag event by using spies and setting >>>>>> the >>>>>> rect dimensions. In cases like this, we can just test some components in >>>>>> order to have enough confidence in the code. So we isolated the function >>>>>> that implements the behavior of this feature and tested that it was >>>>>> performing as expected. >>>>>> >>>>>> We ran the patch through the pipelines and all of the tests passed. >>>>>> >>>>> >>>>> I'm consistently seeing the feature test failure below with this patch >>>>> applied: >>>>> >>>>> ====================================================================== >>>>> FAIL: runTest (pgadmin.feature_tests.view_da >>>>> ta_dml_queries.CheckForViewDataTest) >>>>> Validate Insert, Update operations in View/Edit data with given test >>>>> data >>>>> ---------------------------------------------------------------------- >>>>> Traceback (most recent call last): >>>>> File >>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>>>> line 125, in runTest >>>>> self._verify_row_data(True) >>>>> File >>>>> "/Users/dpage/git/pgadmin4/web/pgadmin/feature_tests/view_data_dml_queries.py", >>>>> line 325, in _verify_row_data >>>>> self.assertEquals(cells[idx], config_data[str(idx)][1]) >>>>> AssertionError: u'[null]' != u'1' >>>>> - [null] >>>>> + 1 >>>>> >>>>> >>>>> -- >>>>> Dave Page >>>>> Blog: http://pgsnake.blogspot.com >>>>> Twitter: @pgsnake >>>>> >>>>> EnterpriseDB UK: http://www.enterprisedb.com >>>>> The Enterprise PostgreSQL Company >>>>> >>>> >>> >>> >>> -- >>> Dave Page >>> Blog: http://pgsnake.blogspot.com >>> Twitter: @pgsnake >>> >>> EnterpriseDB UK: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
