On Fri, Jun 15, 2018 at 6:32 AM, Khushboo Vashi < [email protected]> wrote:
> Hi Shubham, > > On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal < > [email protected]> wrote: > >> Hi Team, >> >> I have modified following two functions in pgadmin_page.py :- >> >> 1. click_tab() -> Added wait till element is clickable, test cases are >> failing since the function attempts to click the tab which is not yet in >> the state to be clicked. >> >> 2. add_server() -> Replaced the sleep statement with wait till element to >> be clickable. >> >> Please find the attached patch. >> >> We should start using CSS selectors instead of xpath, otherwise the patch > works fine and also changes look good to me. > Yes, and we should update files as and when we touch them as part of our ongoing refactoring. Shubham; please go through the files your patch touches, and replace any xpath selectors with CSS selectors. Aside from that, the patch looked to me too, and Pivotal's patch-bot seems happy with it. Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
