Hi Khushboo, Yes i agree, currently we are not changing the functions that are already written but will use css selectors in all the upcoming new test cases.
Thanks and regards, Shubham Agarwal On Fri, Jun 15, 2018 at 11:02 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Shubham, > > On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal < > shubham.agar...@enterprisedb.com> wrote: > >> Hi Team, >> >> I have modified following two functions in pgadmin_page.py :- >> >> 1. click_tab() -> Added wait till element is clickable, test cases are >> failing since the function attempts to click the tab which is not yet in >> the state to be clicked. >> >> 2. add_server() -> Replaced the sleep statement with wait till element to >> be clickable. >> >> Please find the attached patch. >> >> We should start using CSS selectors instead of xpath, otherwise the patch > works fine and also changes look good to me. > >> -- >> Thanks & Regards, >> Shubham Agarwal >> EnterpriseDB Corporation >> >> The Postgres Database Company >> > > -- Thanks & Regards, Shubham Agarwal EnterpriseDB Corporation The Postgres Database Company
