If content hashing is enabled on webpack, cache time can even be 10 years as the file names will update and effectively invalidate the old caches. If content hashing or some other cache busting mechanism is not enabled, it might be a problem.
In my experience, it is good to have one year, browsers usually re-download resources marked for 30 days quite often On Thu., 29 Aug. 2019, 10:59 am Ashesh Vashi, <ashesh.va...@enterprisedb.com> wrote: > On Wed, Aug 28, 2019 at 1:32 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to increase cache control max age (in http header) >> for static files to improve performance over longer run. >> By default it is 43200 seconds (12 hrs), which means that the static >> files like vendor.js, etc. will be fetched again from server after 12hrs. >> This is not required as these files won't change. >> >> Kindly review. >> > I have done the review, it looks good to me. > I have only concern about - with this change the caching will be done for > at least 1 year. I am still kind of confused, what should be the caching > time? > > But - we can go ahead with this change. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com/> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi> > > > >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> >
