Hi Nikhil The review comments are below:
- Reduce some space from source selection and target selection. - Inside the select control, make the server group label bold. - There is currently a search icon instead of a filter icon. On the button, change the cursor pointer to none. - Add a help button near the 'Filter' button. - The spinner and comparison status string should be bolded or larger. - The distance between the 'Generate Script' and 'Filter' buttons should be the same, it should not change on resizing of the browser. or open schema diff in a new tab. - The label (Identical: 20, Different: 10, etc.) should change based on the selection of the Filter. It shows all by default and does not change. - Overall font size in react data grid should be increased. The header should be in bold. - Two vertical scroll bars are visible. Remove if possible. - The components should be aligned properly after deselecting all the filters. Take a look at the existing behavior. - Check the resize behavior against the existing one. Try to make it the same. - In the DDL comparison panel, no DDL statement is displayed when the 'Identical' node is selected. - On selection, remove the border of the cell if we are showing the selected row in a different color. Also, remove the border from the header node selection. On Mon, Sep 5, 2022 at 4:09 PM Nikhil Mohite <nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached the patch for RM-6133 > <https://redmine.postgresql.org/issues/6133> : [React] Port schema diff > to React. > This patch also included the changes for removing SlickGrid from pgAdmin. > > -- > *Thanks & Regards,* > *Nikhil Mohite* > *Senior Software Engineer.* > *EDB Postgres* <https://www.enterprisedb.com/> > *Mob.No: +91-7798364578.* > -- <http://www.enterprisedb.com> Akshay Joshi Principal Software Architect +91 9767888246 www.enterprisedb.com <https://www.linkedin.com/company/edbpostgres> <https://twitter.com/edbpostgres?lang=en> <https://www.facebook.com/EDBpostgres> <https://www.instagram.com/EDBpostgres/>
