Hi Akshay, On Tue, Sep 13, 2022 at 3:09 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote:
> Hi Akshay, > > PFA patch for resolving the following issues reported in testing: > > 1. When some option from filter is selected, that particular type > should be completely removed from top level result instead of showing > identical:0 > 2. Copy button is missing for Difference SQL > 3. Throw error when source & target server versions selected are > different > 4. In High contrast - Font color for identical turns same as > background. > 5. In High contrast - Checkbox box column turns same color of row > resulting unable to distingiush about selection of item. > > Please ignore the previous patch, PFA updated patch included security fixes. Please ignore the previous patch, PFA updated patch included security fixes. > On Thu, Sep 8, 2022 at 3:32 PM Akshay Joshi <akshay.jo...@enterprisedb.com> > wrote: > >> Thanks, the patch applied. >> >> On Thu, Sep 8, 2022 at 1:57 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> PFA patch to resolve following issues. >>> Details: >>> 1. Resolved resize window issue for DDL result panel. >>> 2. Updated the Screenshots. >>> 3. Updated server group title to bold. >>> >>> On Wed, Sep 7, 2022 at 7:25 PM Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> Thanks, the patch applied. >>>> >>>> Please send another patch with updated screenshots and the issues you >>>> have mentioned. >>>> >>>> On Wed, Sep 7, 2022 at 6:58 PM Nikhil Mohite < >>>> nikhil.moh...@enterprisedb.com> wrote: >>>> >>>>> Hi Akshay, >>>>> >>>>> PFA updated patch, I have resolved the review comments, there is one >>>>> issue with resize window I will send another patch for it. >>>>> >>>>> On Mon, Sep 5, 2022 at 6:34 PM Akshay Joshi < >>>>> akshay.jo...@enterprisedb.com> wrote: >>>>> >>>>>> Hi Nikhil >>>>>> >>>>>> The review comments are below: >>>>>> >>>>>> - Reduce some space from source selection and target selection. >>>>>> - Inside the select control, make the server group label bold. >>>>>> >>>>>> Only this review comment is remaining, I will try to add it with a >>>>> resize window patch. >>>>> >>>>>> >>>>>> - There is currently a search icon instead of a filter icon. On >>>>>> the button, change the cursor pointer to none. >>>>>> - Add a help button near the 'Filter' button. >>>>>> - The spinner and comparison status string should be bolded or >>>>>> larger. >>>>>> - The distance between the 'Generate Script' and 'Filter' buttons >>>>>> should be the same, it should not change on resizing of the browser. >>>>>> or >>>>>> open schema diff in a new tab. >>>>>> - The label (Identical: 20, Different: 10, etc.) should change >>>>>> based on the selection of the Filter. It shows all by default and >>>>>> does not >>>>>> change. >>>>>> - Overall font size in react data grid should be increased. The >>>>>> header should be in bold. >>>>>> - Two vertical scroll bars are visible. Remove if possible. >>>>>> - The components should be aligned properly after deselecting all >>>>>> the filters. Take a look at the existing behavior. >>>>>> - Check the resize behavior against the existing one. Try to make >>>>>> it the same. >>>>>> - In the DDL comparison panel, no DDL statement is displayed when >>>>>> the 'Identical' node is selected. >>>>>> - On selection, remove the border of the cell if we are showing >>>>>> the selected row in a different color. Also, remove the border from >>>>>> the >>>>>> header node selection. >>>>>> >>>>>> >>>>>> On Mon, Sep 5, 2022 at 4:09 PM Nikhil Mohite < >>>>>> nikhil.moh...@enterprisedb.com> wrote: >>>>>> >>>>>>> Hi Hackers, >>>>>>> >>>>>>> Please find attached the patch for RM-6133 >>>>>>> <https://redmine.postgresql.org/issues/6133> : [React] Port schema >>>>>>> diff to React. >>>>>>> This patch also included the changes for removing SlickGrid from >>>>>>> pgAdmin. >>>>>>> >>>>>>> -- >>>>>>> *Thanks & Regards,* >>>>>>> *Nikhil Mohite* >>>>>>> *Senior Software Engineer.* >>>>>>> *EDB Postgres* <https://www.enterprisedb.com/> >>>>>>> *Mob.No: +91-7798364578.* >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> <http://www.enterprisedb.com> >>>>>> >>>>>> Akshay Joshi >>>>>> >>>>>> Principal Software Architect >>>>>> >>>>>> +91 9767888246 >>>>>> >>>>>> www.enterprisedb.com >>>>>> >>>>>> <https://www.linkedin.com/company/edbpostgres> >>>>>> <https://twitter.com/edbpostgres?lang=en> >>>>>> <https://www.facebook.com/EDBpostgres> >>>>>> <https://www.instagram.com/EDBpostgres/> >>>>>> >>>>> >>>>> Regards, >>>>> Nikhil Mohite >>>>> >>>> >>>> >>>> -- >>>> >>>> <http://www.enterprisedb.com> >>>> >>>> Akshay Joshi >>>> >>>> Principal Software Architect >>>> >>>> +91 9767888246 >>>> >>>> www.enterprisedb.com >>>> >>>> <https://www.linkedin.com/company/edbpostgres> >>>> <https://twitter.com/edbpostgres?lang=en> >>>> <https://www.facebook.com/EDBpostgres> >>>> <https://www.instagram.com/EDBpostgres/> >>>> >>> Regards, >>> Nikhil Mohite >>> >> >> >> -- >> >> <http://www.enterprisedb.com> >> >> Akshay Joshi >> >> Principal Software Architect >> >> +91 9767888246 >> >> www.enterprisedb.com >> >> <https://www.linkedin.com/company/edbpostgres> >> <https://twitter.com/edbpostgres?lang=en> >> <https://www.facebook.com/EDBpostgres> >> <https://www.instagram.com/EDBpostgres/> >> > > Regards, > Nikhil Mohite > > Regards, Nikhil Mohite
RM-6133_v4.patch
Description: Binary data
