Hi Guillaume,

the delete problem is following:
deleting rows has got the shortcut 'del'. Disabeling row deletion disables 'del'.
Even the key event WXK_DELETE is not fired.
So the solution of this problem which should been there since 'del' is the shortcut for row delete is to change the shortcut to eg. 'ctrl-del', to get the default behavior of the del key.
Could you please comment this.

Working on this I located other issues in the edit context:
_Select some text use context menu an try to perform an action.
Nothing happens, because as I assume selection and focus is lost while opening the conext menu. _Select a numeric value and use context menu. A totally different context menu occurs (system context menu includeing unicode input features, icons etc.),
which I know from situations in which no menu was defined.

For the shortcut issue I attach a patch.
The new rest will take some time, because for newbie eyes this looks not trivial.

Regards Steffen

On 03.09.2010 17:12, Guillaume Lelarge wrote:
Le 03/09/2010 17:08, Steffen Kuhn a écrit :
  Okay I'll do my best. ;-)

Thanks. That gives me more time for the GSoC. I really appreciate that.

Did I get you right to just perform a delete for to current text
selection or the letter after the cursor
Yes.

and not enabling menu and toolbar (commented with 'Delete selected
rows.') ?

The icon on the toolbar is not at fault here. It's a delete row button,
and it should stay that way.

The Delete item in the Edit menu should be enabled when an editor is
open. And disabled otherwise.



diff --git a/pgadmin/frm/frmEditGrid.cpp b/pgadmin/frm/frmEditGrid.cpp
index 9ee4555..67c0b9d 100644
--- a/pgadmin/frm/frmEditGrid.cpp
+++ b/pgadmin/frm/frmEditGrid.cpp
@@ -170,7 +170,7 @@ frmEditGrid::frmEditGrid(frmMain *form, const wxString& _title, pgConn *_conn, p
     editMenu->AppendSeparator();
     editMenu->Append(MNU_COPY, _("&Copy\tCtrl-C"),_("Copy selected cells to clipboard."));
     editMenu->Append(MNU_PASTE, _("&Paste\tCtrl-V"),_("Paste data from the clipboard."));
-    editMenu->Append(MNU_DELETE, _("&Delete\tDel"),_("Delete selected rows."));
+    editMenu->Append(MNU_DELETE, _("&Delete\tCtrl-Del"),_("Delete selected rows."));
     editMenu->Enable(MNU_UNDO, false);
     editMenu->Enable(MNU_DELETE, false);
 
@@ -220,7 +220,7 @@ frmEditGrid::frmEditGrid(frmMain *form, const wxString& _title, pgConn *_conn, p
     entries[3].Set(wxACCEL_NORMAL,              WXK_F1,        MNU_HELP);
     entries[4].Set(wxACCEL_CTRL,                (int)'C',      MNU_COPY);
     entries[5].Set(wxACCEL_CTRL,                (int)'V',      MNU_PASTE);
-    entries[6].Set(wxACCEL_NORMAL,              WXK_DELETE,    MNU_DELETE);
+    entries[6].Set(wxACCEL_CTRL,                WXK_DELETE,    MNU_DELETE);
     
     wxAcceleratorTable accel(7, entries);
     SetAcceleratorTable(accel);
-- 
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

Reply via email to