Hi Dave, this was the way I tried to solve the issue. Do not change the enabled/disabled state of the button but getting the back 'del' function. As I see the only and minor invasive way is to change the current delete row shortcut to 'ctrl-del'. BTW this did not break the german translation.
Regards Steffen On 06.09.2010 09:39 "Dave Page" <dp...@pgadmin.org> wrote: > On Fri, Sep 3, 2010 at 11:39 PM, Guillaume Lelarge > <guilla...@lelarge.info> wrote: > > Le 03/09/2010 23:07, Dave Page a écrit : > >> On Fri, Sep 3, 2010 at 9:24 PM, Steffen Kuhn <p...@kuhnsteffen.de> > >> wrote: > >>> Hi Guillaume, > >>> > >>> the delete problem is following: > >>> deleting rows has got the shortcut 'del'. Disabeling row deletion > >>> disables > >>> 'del'. > >>> Even the key event WXK_DELETE is not fired. > >>> So the solution of this problem which should been there since > >>> 'del' is the > >>> shortcut for row delete > >>> is to change the shortcut to eg. 'ctrl-del', to get the default > >>> behavior of > >>> the del key. > >>> Could you please comment this. > >> > >> Del on its own is the correct key. It should be able to do the > >> "right > >> thing" based on whether or not a cell is in edit mode. > >> > > > > Yeah, I agree. See patch attached (not yet commited). > > Hmm, that seems to be setting up the button to handle deletion of > text, which is not really consistent with anything else. Can we leave > the button to be enabled/disabled as it currently is, and ensure the > right thing is done in edit more? That would also avoid breaking a > translation... > -- Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgadmin-hackers