Hi, New language patch is working fine. Ashesh - Can you please review it ? If it looks good then can you please commit ?
Thank you, Harshal -- *Harshal Dhumal* *Software Engineer * EenterpriseDB <http://www.enterprisedb.com> On Thu, Feb 11, 2016 at 4:01 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote: > Hi All > > Attached is the modified patch, please review it. > > On Thu, Feb 11, 2016 at 2:06 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find the review comments below for Language node. >> >> - On postgres9.1 language node failed with below error when clicked on >> properties or sql tab. >> >> * function expression in FROM cannot refer to other relations of same >> query level LINE 15: aclexplode(lanacl) d ^* >> > > Fixed. > >> >> *- *Error when tried to update language name, owner, comment. >> >> File "/home/edb/PRJ/pgadmin4/web/pgadmin/browser/utils.py", line 277, in >> dispatch_request >> return method(*args, **kwargs) >> File >> "/home/edb/PRJ/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/languages/__init__.py", >> line 139, in wrap >> return f(*args, **kwargs) >> File >> "/home/edb/PRJ/pgadmin4/web/pgadmin/browser/server_groups/servers/databases/languages/__init__.py", >> line 224, in update >> sql = self.get_sql(gid, sid, data, did, lid) >> TypeError: get_sql() takes from 2 to 3 positional arguments but 6 were >> given >> > > Fixed. > >> >> >> *- *In pgadmin3 it shows drop down for language name while in pgadmin4 >> in edit mode it shows input text >> *.* >> Need some clarification whether user is allowed to enter any language >> name or can only select from predefined language names. >> > > User can give any language name. In pgAdmin3 it shows drop down but in > disabled state user can't see any predefine value, so its better to have > input control instead of drop down. > >> >> Regards, >> ~Harshal >> >> >> >> >> -- >> *Harshal Dhumal* >> *Software Engineer * >> >> >> >> EenterpriseDB <http://www.enterprisedb.com> >> >> On Mon, Feb 8, 2016 at 6:17 PM, Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi All >>> >>> Attached is the patch for the Language Module. Please review it and if >>> it looks good then please commit it. >>> >>> -- >>> *Akshay Joshi* >>> *Principal Software Engineer * >>> >>> >>> >>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >>> >>> >>> -- >>> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) >>> To make changes to your subscription: >>> http://www.postgresql.org/mailpref/pgadmin-hackers >>> >>> >> > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517Mobile: +91 976-788-8246* >
