Thanks - committed. On Mon, Feb 22, 2016 at 1:23 PM, Akshay Joshi <akshay.jo...@enterprisedb.com > wrote:
> Hi All > > Attached is the modified patch with support of Dependents and Dependencies > tabs. Please review it. > > On Mon, Feb 22, 2016 at 5:29 PM, Dave Page <dp...@pgadmin.org> wrote: > >> >> >> On Mon, Feb 22, 2016 at 10:53 AM, Dave Page <dp...@pgadmin.org> wrote: >> >>> >>> >>> On Fri, Feb 19, 2016 at 10:48 AM, Akshay Joshi < >>> akshay.jo...@enterprisedb.com> wrote: >>> >>>> Hi All >>>> >>>> On Mon, Feb 15, 2016 at 3:47 PM, Dave Page <dp...@pgadmin.org> wrote: >>>> >>>>> >>>>> >>>>> On Mon, Feb 15, 2016 at 7:29 AM, Akshay Joshi < >>>>> akshay.jo...@enterprisedb.com> wrote: >>>>> >>>>>> Hi All >>>>>> >>>>>> Attached is the new patch after fixing review comments given by Dave. >>>>>> >>>>>> On Fri, Feb 12, 2016 at 10:04 PM, Dave Page <dp...@pgadmin.org> >>>>>> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Fri, Feb 12, 2016 at 11:21 AM, Harshal Dhumal < >>>>>>> harshal.dhu...@enterprisedb.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> New language patch is working fine. >>>>>>>> Ashesh - Can you please review it ? >>>>>>>> If it looks good then can you please commit ? >>>>>>>> >>>>>>>> Thank you, >>>>>>>> Harshal >>>>>>>> >>>>>>> >>>>>>> A few comments: >>>>>>> >>>>>>> - We omitted CREATE LANGUAGE, as most are now extensions. Shouldn't >>>>>>> we also therefore omit DROP LANGUAGE? >>>>>>> >>>>>> Fixed. >>>>>> >>>>>>> - Please leave a blank line between the file header and python code >>>>>>> in python files. >>>>>>> >>>>>> Fixed. >>>>>> >>>>>>> - The pydoc module description is missing from __init__.py >>>>>>> >>>>>> Fixed. >>>>>> >>>>>>> - What about the Dependents and Dependencies tabs? >>>>>>> >>>>>> Infrastructure is not ready, so not implemented yet. >>>>>> >>>>> >>>>> The first person that needs it should be working on it! I don't want >>>>> to be committing partially completed features, otherwise we'll have to >>>>> come >>>>> back and revisit them all when the infrastructure is done. >>>>> >>>>> Having done it before for pgAdmin 3, I don't imagine it's hard. It's >>>>> really just the same as the Statistics view. Please take a look at it >>>>> (assuming noone else is already). >>>>> >>>> >>>> Fixed. Attached is the modified patch with support of Dependents and >>>> Dependencies tabs. Please review it. >>>> >>> >>> Committed, with a couple of additional minor changes: >>> >>> - s/resourcegroups/resource_groups (for consistency with server_groups) >>> >>> - Added a PyDoc module description to __init__.py >>> >> >> Oops, wrong thread. Please ignore. >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >> EnterpriseDB UK: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> > > > > -- > *Akshay Joshi* > *Principal Software Engineer * > > > > *Phone: +91 20-3058-9517 <%2B91%2020-3058-9517>Mobile: +91 976-788-8246* > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
