Hi Surinder, Can you please move all genereic logic & sql at schema level so that we can use it in table node as well? Currently it’s materialized view node centric only.
Regards, Murtuza > On 23-Mar-2016, at 9:34 pm, Surinder Kumar <surinder.ku...@enterprisedb.com> > wrote: > > Hi, > > > On Fri, Mar 18, 2016 at 8:58 PM, Dave Page <dp...@pgadmin.org > <mailto:dp...@pgadmin.org>> wrote: > On Fri, Mar 18, 2016 at 10:37 AM, Surinder Kumar > <surinder.ku...@enterprisedb.com <mailto:surinder.ku...@enterprisedb.com>> > wrote: > > Hi, > > > > PFA control for displaying auto vacuum fields into grid. This control is > > common for > > Materialized View Node and Table Node. > > > > Usage: > > > > { > > id: 'vacuum_table', label: '{{ _("Vacuum Table") }}', > > model: VacuumTableModel, editable: false, type: 'collection', > > canEdit: true, group: '{{ _("Table") }}', > > mode: ['edit', 'create'], url: 'get_vacuum_defaults', > > control: Backform.VacuumCollectionControl.extend({ > > grid_columns :[ > > { > > name: 'label', label: '{{ _("Label") }}', > > cell: 'string', editable: false > > }, > > { > > name: 'value', label: '{{ _("Value") }}', > > cellFunction: cellFunction, editable: function(m) { > > if(m.handler.has('autovacuum_enabled')) { > > return m.handler.get('autovacuum_enabled'); > > } > > return !m.handler.isNew(); > > } > > }, > > { > > name: 'setting', label: '{{ _("Default value") }}', > > cellFunction: cellFunction, editable: false > > } > > ] > > }), > > > > > > When using this control, provide following parameters in schema: > > 1. model > > 2. url - to fetch default values for auto vacuum fields. > > 3. grid columns - Name of the columns to display in the grid. > > > > > > Please review the patch. > > It's hard to review this without being able to test. Do you have a > simple test case? > > I have submitted patch for materialized view which is using this control. so > you can test it in materialized view. > > -- > Dave Page > Blog: http://pgsnake.blogspot.com <http://pgsnake.blogspot.com/> > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com <http://www.enterprisedb.com/> > The Enterprise PostgreSQL Company >
